davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1951336964
> thanks @davsclaus , apologies I was unable to finish this. perhaps I (or
someone else) can try picking it up again in the future.
Absolutely no problem, you got 99% there. We
kahboom commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1951332368
thanks @davsclaus , apologies I was unable to finish this. perhaps I (or
someone else) can try picking it up again in the future.
--
This is an automated message from the Apache Git
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1951143578
closing this PR as JIRA has a link to it from
https://issues.apache.org/jira/browse/CAMEL-20395
--
This is an automated message from the Apache Git Service.
To respond to the
davsclaus closed pull request #12769: [CAMEL-19620] - upgrade
californium-scandium
URL: https://github.com/apache/camel/pull/12769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1933716187
Thanks @boaks and @kahboom for the help. We have upgraded to 3.x but
disabled that particular test failure.
Created a ticket to look into this in the future
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1931994183
Trying this PR from a fresh start at
https://github.com/apache/camel/pull/13039
Want to make the CI able to build and test so we can better finish this work
--
This is an
boaks commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1913517747
> The test routes:
kahboom commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1913114275
@davsclaus is it fine now? I rebased, ran `mvn clean verify` and then
regenerated with `mvn org.apache.camel:camel-package-maven-plugin:generate`
--
This is an automated message from
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1913098863
There are again changed files in catalog/camel-catalog that are not in this
PR so the CI cannot run the tests
--
This is an automated message from the Apache Git Service.
To respond
kahboom commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1912633539
Sorry about that @boaks :
```
[ERROR] Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
10.83 s <<< FAILURE! -- in org.apache.camel.coap.CoAPComponentTCPTLSTest
boaks commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1912413578
> So now I'm down to two
I still didn't clone and test it on my own locally. Therefore, if possible,
may be someone can provide the logs or some details about the last two left
kahboom commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1912339970
I found there was a duplicated `advancedPsk` URL param trailing at the end
of the test route, which resolves another one of the errors.
So now I'm down to two, which seem to be the
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1910532606
Welcome to the Camel github community, - your first PR is certainly not an
easy one, so anyone of us would have trouble getting this done without help.
You are welcome to reach
kahboom commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1910394976
>Since 3.0 null is replaced by `Bytes.EMPTY`. The method will now always
return an byte array, which may be empty.
@boaks thanks for the tip, I've changed it from
kahboom commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1466421491
##
components/camel-coap/src/test/java/org/apache/camel/coap/CoAPComponentTLSTestBase.java:
##
@@ -419,9 +432,10 @@ private void registerTLSConfiguration(CamelContext
apupier commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1464911682
##
components/camel-coap/src/test/java/org/apache/camel/coap/CoAPComponentTLSTestBase.java:
##
@@ -419,9 +432,10 @@ private void registerTLSConfiguration(CamelContext
apupier commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1464910997
##
components/camel-coap/src/test/java/org/apache/camel/coap/CoAPComponentTLSTestBase.java:
##
@@ -399,14 +405,21 @@ private void registerTLSConfiguration(CamelContext
apupier commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1464910761
##
components/camel-coap/src/test/java/org/apache/camel/coap/CoAPComponentTLSTestBase.java:
##
@@ -399,14 +405,21 @@ private void registerTLSConfiguration(CamelContext
apupier commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1464910082
##
components/camel-coap/src/test/java/org/apache/camel/coap/CoAPComponentTLSTestBase.java:
##
@@ -207,9 +208,9 @@ public void configure() {
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1907767256
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.033 s <<< FAILURE! -- in org.apache.camel.coap.CoAPMethodRestrictTest
[ERROR]
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1907764970
There is also some system out printlin that should either be removed or
changed into a logger
[INFO] Running org.apache.camel.coap.CoAPComponentTLSTest
There are configured
davsclaus commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1907760875
These changed files needs to be in this PR
modified:
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/coap+tcp.json
modified:
kahboom commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1461906689
##
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##
@@ -44,16 +44,16 @@
"bridgeErrorHandler": { "index": 4, "kind":
kahboom commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1461906689
##
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##
@@ -44,16 +44,16 @@
"bridgeErrorHandler": { "index": 4, "kind":
apupier commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1903446940
uncommitted changes are in `came-catalog`, this code is generated. Need to
regenerate it. i think it can be done via
`org.apache.camel:camel-package-maven-plugin:generate`.
I
oscerd commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1900865705
There are uncommitted changes. The branch needs to be rebuilt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
boaks commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1900827606
I simply don't see in the logs, what's failing.
Does someone have more insights?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
oscerd commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1900804131
/componet-test coap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kahboom commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1900315974
Wow thank you @boaks , that's very helpful. Working through your feedback
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
boaks commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1898684217
Lets see, if the the comments help to reduce the failures ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457592940
##
components/camel-coap/src/main/java/org/apache/camel/coap/CoAPEndpoint.java:
##
@@ -500,18 +531,14 @@ public CoapClient createCoapClient(URI uri) throws
IOException,
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457582490
##
components/camel-coap/src/main/java/org/apache/camel/coap/CoAPEndpoint.java:
##
@@ -460,31 +482,40 @@ public DTLSConnector
createDTLSConnector(InetSocketAddress
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457576943
##
components/camel-coap/src/main/java/org/apache/camel/coap/CoAPEndpoint.java:
##
@@ -460,31 +482,40 @@ public DTLSConnector
createDTLSConnector(InetSocketAddress
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457569548
##
components/camel-coap/src/main/java/org/apache/camel/coap/CoAPEndpoint.java:
##
@@ -405,19 +420,20 @@ public static boolean enableTCP(URI uri) {
public
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457569548
##
components/camel-coap/src/main/java/org/apache/camel/coap/CoAPEndpoint.java:
##
@@ -405,19 +420,20 @@ public static boolean enableTCP(URI uri) {
public
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457549644
##
components/camel-coap/src/main/java/org/apache/camel/coap/CoAPComponent.java:
##
@@ -68,34 +70,30 @@ public synchronized CoapServer getServer(int port,
CoAPEndpoint
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457543363
##
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##
@@ -44,16 +44,16 @@
"bridgeErrorHandler": { "index": 4, "kind":
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457542849
##
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##
@@ -44,16 +44,16 @@
"bridgeErrorHandler": { "index": 4, "kind":
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457538343
##
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##
@@ -44,16 +44,16 @@
"bridgeErrorHandler": { "index": 4, "kind":
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457534984
##
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##
@@ -44,16 +44,16 @@
"bridgeErrorHandler": { "index": 4, "kind":
boaks commented on code in PR #12769:
URL: https://github.com/apache/camel/pull/12769#discussion_r1457534286
##
components/camel-coap/src/generated/resources/org/apache/camel/coap/coap+tcp.json:
##
@@ -44,16 +44,16 @@
"bridgeErrorHandler": { "index": 4, "kind":
kahboom commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1898565456
Hi @boaks - Yes it's ok to comment here, thank you for your help.
Locally you first build with `mvn clean install -Dquickly` though I think
that's not even necessary for this PR
boaks commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1898217193
Hi @kahboom,
I answered your e-mail on the
[cf-dev-mailing-list](https://www.eclipse.org/lists/cf-dev/msg01795.html).
Is it OK to comment here?
Is it possible to run the test
github-actions[bot] commented on PR #12769:
URL: https://github.com/apache/camel/pull/12769#issuecomment-1887785103
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel
kahboom opened a new pull request, #12769:
URL: https://github.com/apache/camel/pull/12769
# Description
This PR intends to upgrade Californium-Scandium from `2.8.0` to `3.10.0`,
which also seems to require upgrading Californium to `3.10.0`. Part of this was
following the [migration
45 matches
Mail list logo
