davsclaus merged PR #11930:
URL: https://github.com/apache/camel/pull/11930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
brunoriemenschneider commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1385278441
##
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConsumer.java:
##
@@ -109,7 +110,8 @@ private SMPPSession createSession()
brunoriemenschneider commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1385273477
##
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##
@@ -120,6 +120,8 @@ public class SmppConfiguration
brunoriemenschneider commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1385007841
##
pull_request_CAMEL-20061.md:
##
@@ -0,0 +1,40 @@
+# Description
Review Comment:
deleted the file
--
This is an automated message from the
brunoriemenschneider commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1385006037
##
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##
@@ -120,6 +120,8 @@ public class SmppConfiguration
davsclaus commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1384980130
##
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##
@@ -120,6 +120,8 @@ public class SmppConfiguration implements
oscerd commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1384977868
##
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##
@@ -733,6 +735,26 @@ public void setSingleDLR(boolean singleDLR) {
brunoriemenschneider commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1384939826
##
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##
@@ -733,6 +735,26 @@ public void setSingleDLR(boolean
oscerd commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1384877000
##
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##
@@ -733,6 +735,26 @@ public void setSingleDLR(boolean singleDLR) {
oscerd commented on code in PR #11930:
URL: https://github.com/apache/camel/pull/11930#discussion_r1384874950
##
pull_request_CAMEL-20061.md:
##
@@ -0,0 +1,40 @@
+# Description
Review Comment:
Thanks but this should be removed. You should add some information in
github-actions[bot] commented on PR #11930:
URL: https://github.com/apache/camel/pull/11930#issuecomment-1798425462
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel
brunoriemenschneider opened a new pull request, #11930:
URL: https://github.com/apache/camel/pull/11930
Interface Version functionality as supported by jSMPP is adopted with
@UriParam configuration parameter. The default value (interface version 3.4)
remains unchanged.
The
12 matches
Mail list logo
