[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-14 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214205#comment-17214205 ] Jordan West commented on CASSANDRA-16148: - Committed. Thanks.  > Test failures caused by

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-14 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214075#comment-17214075 ] David Capwell commented on CASSANDRA-16148: --- +1 from me > Test failures caused by merging

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-14 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214074#comment-17214074 ] David Capwell commented on CASSANDRA-16148: --- I feel that

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-13 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213458#comment-17213458 ] Jordan West commented on CASSANDRA-16148: - Builds: -

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-02 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206372#comment-17206372 ] Jordan West commented on CASSANDRA-16148: - Hehe this is why I wanted to split them up

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-02 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206371#comment-17206371 ] David Capwell commented on CASSANDRA-16148: --- Overall the patch LGTM, one thing I would

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-01 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205950#comment-17205950 ] Jordan West commented on CASSANDRA-16148: - Added the memoization changes as well and pushed.

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-01 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205909#comment-17205909 ] Jordan West commented on CASSANDRA-16148: - {quote} This logic isn't correct as you need the

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-01 Thread Jira
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205774#comment-17205774 ] Andres de la Peña commented on CASSANDRA-16148: --- bq. I'd move

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-01 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205713#comment-17205713 ] Caleb Rackliffe commented on CASSANDRA-16148: - bq. It would be great if we could get a

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-10-01 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205708#comment-17205708 ] Caleb Rackliffe commented on CASSANDRA-16148: - bq. This logic isn't correct as you need

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-09-30 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205126#comment-17205126 ] David Capwell commented on CASSANDRA-16148: --- bq. Can you say more about what you mean by

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-09-30 Thread Jordan West (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205090#comment-17205090 ] Jordan West commented on CASSANDRA-16148: - [~dcapwell] good catch re: volatile. I had that

[jira] [Commented] (CASSANDRA-16148) Test failures caused by merging CASSANDRA-15833

2020-09-30 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205069#comment-17205069 ] David Capwell commented on CASSANDRA-16148: --- The change to Gossiper isn't thread safe.