[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249911#comment-17249911 ] David Capwell commented on CASSANDRA-16213: --- Starting commit CI Results (pending):

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249805#comment-17249805 ] Sam Tunnicliffe commented on CASSANDRA-16213: - +1 to keeping the flag and defaulting it

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249435#comment-17249435 ] David Capwell commented on CASSANDRA-16213: --- Thanks for the review [~paulo]. bq. I think

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249377#comment-17249377 ] Paulo Motta commented on CASSANDRA-16213: - Sorry for the delay. Approved PR with one minor

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245983#comment-17245983 ] Paulo Motta commented on CASSANDRA-16213: - Just a heads up that I'll take a final look at

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245464#comment-17245464 ] David Capwell commented on CASSANDRA-16213: --- Thanks [~samt]! Will wait for [~paulo] to

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245458#comment-17245458 ] Sam Tunnicliffe commented on CASSANDRA-16213: - +1 from me too, thanks for incorporating

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244295#comment-17244295 ] David Capwell commented on CASSANDRA-16213: --- Thanks for the review [~brandon.williams] and

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244284#comment-17244284 ] Brandon Williams commented on CASSANDRA-16213: -- Finally got this all straight in my

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244160#comment-17244160 ] Jon Meredith commented on CASSANDRA-16213: -- Thanks for addressing nits.  +1 from me. >

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243602#comment-17243602 ] Jon Meredith commented on CASSANDRA-16213: -- Posted a review. I'm chasing down a second 

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243453#comment-17243453 ] David Capwell commented on CASSANDRA-16213: --- rebased to trunk, which fixed some of the

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241860#comment-17241860 ] David Capwell commented on CASSANDRA-16213: --- To keep history clear for review, I split

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241853#comment-17241853 ] David Capwell commented on CASSANDRA-16213: --- [~samt] pushed changes based off your

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241760#comment-17241760 ] David Capwell commented on CASSANDRA-16213: --- booo... rebased and now getting {code}

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241059#comment-17241059 ] David Capwell commented on CASSANDRA-16213: --- I left comments on the commit

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240979#comment-17240979 ] David Capwell commented on CASSANDRA-16213: --- Thanks sam for the review, ill try to look

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240385#comment-17240385 ] Paulo Motta commented on CASSANDRA-16213: - I really like the alternative implementation and

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238836#comment-17238836 ] Sam Tunnicliffe commented on CASSANDRA-16213: - Sorry I'm a bit late to the party here.

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233571#comment-17233571 ] Paulo Motta commented on CASSANDRA-16213: - Thanks! I'll take another look this week. >

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233070#comment-17233070 ] David Capwell commented on CASSANDRA-16213: --- [~brandon.williams] [~paulo] [~samt] the

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231934#comment-17231934 ] David Capwell commented on CASSANDRA-16213: --- Finished assassinate and made sure to flesh

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231832#comment-17231832 ] David Capwell commented on CASSANDRA-16213: --- [~paulo] added the test and rebased to latest

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231767#comment-17231767 ] David Capwell commented on CASSANDRA-16213: --- I plan to fix the schema wait logic in

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231736#comment-17231736 ] David Capwell commented on CASSANDRA-16213: --- Found the issue, it was caused by

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231097#comment-17231097 ] David Capwell commented on CASSANDRA-16213: --- I have been working on the test but its

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228747#comment-17228747 ] David Capwell commented on CASSANDRA-16213: --- Thanks for the feedback bq. not required as

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228291#comment-17228291 ] Paulo Motta commented on CASSANDRA-16213: - Thanks for the update [~dcapwell]. I think 5) is

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225842#comment-17225842 ] Ekaterina Dimitrova commented on CASSANDRA-16213: - I left a few small

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225015#comment-17225015 ] David Capwell commented on CASSANDRA-16213: --- [~paulo] and I chatted in GH and slack,

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224346#comment-17224346 ] Paulo Motta commented on CASSANDRA-16213: - Thanks, added some comments to the commit. Please

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223916#comment-17223916 ] David Capwell commented on CASSANDRA-16213: --- I made the changes pass in

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223882#comment-17223882 ] David Capwell commented on CASSANDRA-16213: --- Started down the path of only modifying

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220881#comment-17220881 ] David Capwell commented on CASSANDRA-16213: --- Thanks for the review [~paulo] bq. I would

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220413#comment-17220413 ] Paulo Motta commented on CASSANDRA-16213: - Overall I like the proposed approach, I would

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214972#comment-17214972 ] David Capwell commented on CASSANDRA-16213: --- [~paulo]. Brandon told me in slack you would

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214966#comment-17214966 ] David Capwell commented on CASSANDRA-16213: --- Sorry, I misspoke, on startup we do add it

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214963#comment-17214963 ] David Capwell commented on CASSANDRA-16213: --- Thanks for the replay [~brandon.williams]!

[jira] [Commented] (CASSANDRA-16213) Cannot replace_address /X because it doesn't exist in gossip

[ https://issues.apache.org/jira/browse/CASSANDRA-16213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214935#comment-17214935 ] Brandon Williams commented on CASSANDRA-16213: -- This affects all versions since the