[cloudstack] 01/01: Merge branch '4.11'

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 7e39961f22ab3157994fc075325287ecaf365d11 Merge: 86b0dd8 2ca264c Author: Rohit Yadav AuthorDate: Mon Jan 22 09:04:24 2

[cloudstack] branch master updated (86b0dd8 -> 7e39961)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 86b0dd8 Merge branch '4.11' add 2ca264c CLOUDSTACK-10244: Cache whether to migrate storage (#2416) new

[GitHub] rhtyd commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

rhtyd commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162867659 ## File path: scripts/vm/network/security_group.py ## @@ -951,16 +951,15 @@ def parse_n

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359351470 I've an outstanding question, other LGTM pending test results. @blueorangutan package -

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359351549 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on a change in pull request #2417: Fix errors that appeared after #2283

rhtyd commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162868103 ## File path: plugins/hypervisors/ovm3/pom.xml ## @@ -1,72 +1,80 @@ - +http://maven.apache.org/POM/4.0.0"; xml

[GitHub] rhtyd commented on a change in pull request #2417: Fix errors that appeared after #2283

rhtyd commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162868253 ## File path: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/objects/OvmObject.java ## @@ -1

[GitHub] rhtyd commented on a change in pull request #2417: Fix errors that appeared after #2283

rhtyd commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162868253 ## File path: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/objects/OvmObject.java ## @@ -1

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359356443 Packaging result: ?centos6 ?centos7 ?debian. JID-1665

[GitHub] rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

rhtyd commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359358231 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359358351 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] marcaurele commented on issue #2417: Fix errors that appeared after #2283

marcaurele commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359359212 Yes, that's possible that some `git mv` commands weren't done correctly. I just ver surprised that the compilation and packaging worked with t

[GitHub] wido commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

wido commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162882114 ## File path: scripts/vm/network/security_group.py ## @@ -951,16 +951,15 @@ def parse_ne

[GitHub] rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283

rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162896259 ## File path: plugins/hypervisors/ovm3/pom.xml ## @@ -1,72 +1,80 @@ - +http://maven.apache.org/POM/

[GitHub] rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283

rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162896571 ## File path: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/objects/OvmObject.java #

[GitHub] rhtyd commented on issue #2417: Fix errors that appeared after #2283

rhtyd commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359382454 @blueorangutan package This is an automated message from the Apache Git Service. T

[GitHub] blueorangutan commented on issue #2417: Fix errors that appeared after #2283

blueorangutan commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359382489 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359382791 @marcaurele I was surprised as well. Not just the compilation that passed, but the tests that were executed. And it was not just about

[GitHub] rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283

rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162896571 ## File path: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/objects/OvmObject.java #

[GitHub] DaanHoogland commented on a change in pull request #2417: Fix errors that appeared after #2283

DaanHoogland commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162897727 ## File path: engine/storage/integration-test/src/test/java/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java ###

[GitHub] DaanHoogland commented on issue #2417: Fix errors that appeared after #2283

DaanHoogland commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359384414 @rafaelweingartner what's your $ mvn --version? Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=800m; support was

[GitHub] rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283

rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162898993 ## File path: engine/storage/integration-test/src/test/java/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359385351 @DaanHoogland, I have tested running these in two different systems: System one: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09

[GitHub] blueorangutan commented on issue #2417: Fix errors that appeared after #2283

blueorangutan commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359389138 Packaging result: ?centos6 ?centos7 ?debian. JID-1666 This is an automated

[GitHub] DaanHoogland commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

DaanHoogland commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162903882 ## File path: scripts/vm/network/security_group.py ## @@ -951,16 +951,15 @@ def

[GitHub] DaanHoogland commented on issue #2417: Fix errors that appeared after #2283

DaanHoogland commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359390372 no, it doesn't but still, mine compiles This is an automated message from t

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359391244 What can I tell you then? Can you open the class `engine/storage/integration-test/src/test/java/com/cloud/vm/snapshot/dao/VmSnapshot

[GitHub] rhtyd commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

rhtyd commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162907480 ## File path: scripts/vm/network/security_group.py ## @@ -951,16 +951,15 @@ def parse_n

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359391244 What can I tell you then? Can you open the class `engine/storage/integration-test/src/test/java/com/cloud/vm/snapshot/dao/VmSnapshot

[GitHub] marcaurele commented on a change in pull request #2417: Fix errors that appeared after #2283

marcaurele commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162911223 ## File path: engine/storage/integration-test/src/test/java/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java #

[GitHub] rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283

rafaelweingartner commented on a change in pull request #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#discussion_r162911651 ## File path: engine/storage/integration-test/src/test/java/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java

[GitHub] DaanHoogland commented on issue #2417: Fix errors that appeared after #2283

DaanHoogland commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359398213 I see your point @rafaelweingartner It passing without havcing compiled those files is a lack of feature. Your changes LGTM ---

[GitHub] blueorangutan commented on issue #2417: Fix errors that appeared after #2283

blueorangutan commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359399239 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] rhtyd commented on issue #2417: Fix errors that appeared after #2283

rhtyd commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359399168 @blueorangutan test This is an automated message from the Apache Git Service. To r

[GitHub] DaanHoogland commented on issue #2417: Fix errors that appeared after #2283

DaanHoogland commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359398213 I see your point @rafaelweingartner It passing without having compiled those files is a lack of feature. Your changes LGTM

[GitHub] wido commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

wido commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359403878 I agree with you @DaanHoogland that's it not very elegant. But the way we pass rules to the Python file isn't my favorite e

[GitHub] wido commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

wido commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359403878 I agree with you @DaanHoogland that's it not very elegant. But the way we pass rules to the Python file isn't my favorite e

[GitHub] marcaurele commented on issue #2417: Fix errors that appeared after #2283

marcaurele commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359419122 @rafaelweingartner I'll send you a PR against your branch with other changes -

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359419386 Sure, no problem. Is there something else missing? This is an autom

[GitHub] marcaurele commented on issue #2417: Fix errors that appeared after #2283

marcaurele commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359424310 New checkstyle validation: http://checkstyle.sourceforge.net/config_coding.html#PackageDeclaration --

[GitHub] fmaximus opened a new pull request #2419: CLOUDSTACK-10245: Fix password server

fmaximus opened a new pull request #2419: CLOUDSTACK-10245: Fix password server URL: https://github.com/apache/cloudstack/pull/2419 In case of isolated networks where VR is not the gateway, both self.config.is_vpc() and self.config.is_router() are false, but self.config.is_dhcp() is true

[GitHub] nvazquez opened a new pull request #2420: CLOUDSTACK-10247: L2 network not shared on projects

nvazquez opened a new pull request #2420: CLOUDSTACK-10247: L2 network not shared on projects URL: https://github.com/apache/cloudstack/pull/2420 When trying to deploy a vm providing a project id and a L2 network id, this error is logged: 2018-01-18 09:04:31,749 INFO [c.c.a

[GitHub] rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283

rafaelweingartner commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359489817 just to make it clear here. @marcaurele is not going to open a PR to this branch. His changes will be introduced in a specific PR to en

[GitHub] blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

blueorangutan commented on issue #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group URL: https://github.com/apache/cloudstack/pull/2418#issuecomment-359508413 Trillian test result (tid-2178) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total t

[GitHub] wido opened a new pull request #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

wido opened a new pull request #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421 This might (and does block) in certain situations on the VR as also explained in the Python documentation: https://docs.python.org/2/l

[GitHub] wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess

wido commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python subprocess URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-359534358 @rhtyd My colleagues told me that they didn?t see this happen with 4.9 and now see it in 4.10. This file has not changed

[GitHub] blueorangutan commented on issue #2417: Fix errors that appeared after #2283

blueorangutan commented on issue #2417: Fix errors that appeared after #2283 URL: https://github.com/apache/cloudstack/pull/2417#issuecomment-359544728 Trillian test result (tid-2179) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29594 seconds

[GitHub] khos2ow commented on a change in pull request #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

khos2ow commented on a change in pull request #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#discussion_r163055953 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resou

[GitHub] mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359587811 The managed-storage test for 4.11 RC1 that failed and led to the creation of the JIRA ticket that this PR a

[GitHub] mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359588567 I have also tested the other failed use case that led to this PR: Take a volume snapshot of a volume. Delet

[GitHub] mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359588825 The code LGTM. Also, as noted above, I tested both failed use cases that led to this PR and they both work

[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command

rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359613929 @rhtyd I noticed that you changed the base branch for this PR, from master to 4.11. Do you want me to op

[GitHub] marcaurele opened a new pull request #2422: checkstyle: add package name declaration validation

marcaurele opened a new pull request #2422: checkstyle: add package name declaration validation URL: https://github.com/apache/cloudstack/pull/2422 - add a new checkstyle directive (http://checkstyle.sourceforge.net/config_coding.html#PackageDeclaration) - force the use of latest checks