[GitHub] [cloudstack] blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume

2019-06-13 Thread GitBox
blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-501579687 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] borisstoyanov commented on issue #3218: vmware: don't use redundant worker VM to extract volume

2019-06-13 Thread GitBox
borisstoyanov commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-501579569 @blueorangutan package This is an automated message fr

[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-13 Thread GitBox
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501583954 > @ustcweizhou yes, you added tags to vm ? @matheusdaluz yes. I added tags, no change in virtual routers. then s

[GitHub] [cloudstack] blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume

2019-06-13 Thread GitBox
blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-501586088 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2886

[GitHub] [cloudstack] NicoWohlfarth opened a new pull request #3403: Fix quick view tooltip title on multiselect list views

2019-06-13 Thread GitBox
NicoWohlfarth opened a new pull request #3403: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403 ## Description Fixed an issue, where the quick view tooltip title would not have been displayed properly on list views with a mul

[GitHub] [cloudstack] svenvogel commented on issue #3403: Fix quick view tooltip title on multiselect list views

2019-06-13 Thread GitBox
svenvogel commented on issue #3403: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403#issuecomment-501595950 @shwstppr @anuragaw can you take a look? :) This is an auto

[GitHub] [cloudstack] anuragaw commented on issue #3385: UI Translate code removes same-level content

2019-06-13 Thread GitBox
anuragaw commented on issue #3385: UI Translate code removes same-level content URL: https://github.com/apache/cloudstack/issues/3385#issuecomment-501597123 This should be fixed on latest master @richardlawley https://github.com/apache/cloudstack/pull/3326 CC/ @rhtyd , @rafaelweingar

[GitHub] [cloudstack] svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD

2019-06-13 Thread GitBox
svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401#issuecomment-501597825 @darkfiberiru thanks for the issue. i think there is no plan to integrate it. @andrijapanic is this correct?

[GitHub] [cloudstack] richardlawley commented on issue #3385: UI Translate code removes same-level content

2019-06-13 Thread GitBox
richardlawley commented on issue #3385: UI Translate code removes same-level content URL: https://github.com/apache/cloudstack/issues/3385#issuecomment-501601114 @anuragaw #3326 only fixes the Dashboard instance - there were about 10 occurrences of the same problem which I fixed in #3386.

[cloudstack] branch DaanHoogland-patch-2 updated (b39d3c4 -> 2fcbb13)

2019-06-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b39d3c4 Update test_tags.py add 2fcbb13 make resourceId be used as projectId if the latter is

[GitHub] [cloudstack] ustcweizhou commented on issue #3390: Add more info for creating volume snapshots

2019-06-13 Thread GitBox
ustcweizhou commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-501604687 code LGTM, did not test it. @anuragaw could you squash the commits ? -

[GitHub] [cloudstack] richardlawley commented on issue #3386: Fix labels broken by translation code

2019-06-13 Thread GitBox
richardlawley commented on issue #3386: Fix labels broken by translation code URL: https://github.com/apache/cloudstack/pull/3386#issuecomment-501618967 Updated this to remove the fix to the dashboard already fixed in #3326, and changed to keep translate tag self-closing, just wrapped in .

[cloudstack] branch DaanHoogland-patch-2 updated (2fcbb13 -> 8462fce)

2019-06-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 2fcbb13 make resourceId be used as projectId if the latter is missing add 8462fce space No ne

[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3378: project id added in test

2019-06-13 Thread GitBox
ustcweizhou commented on a change in pull request #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#discussion_r293287184 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -646,7 +646,9 @@ Ternar

[GitHub] [cloudstack] shwstppr commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot

2019-06-13 Thread GitBox
shwstppr commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-501633220 @blueorangutan package This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot

2019-06-13 Thread GitBox
blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-501633406 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make pro

[GitHub] [cloudstack] anuragaw commented on issue #3403: ui: Fix quick view tooltip title on multiselect list views

2019-06-13 Thread GitBox
anuragaw commented on issue #3403: ui: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403#issuecomment-501633549 Tested fine locally too > Based on PR Description and reading style in CSS LGTM. > Will do a quick test locally

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs

2019-06-13 Thread GitBox
DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#discussion_r293295533 ## File path: api/src/main/java/org/apache/cloudstack/api/command/ad

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs

2019-06-13 Thread GitBox
DaanHoogland commented on a change in pull request #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#discussion_r293294473 ## File path: api/src/main/java/org/apache/cloudstack/api/command/ad

[GitHub] [cloudstack] anuragaw commented on issue #3390: Add more info for creating volume snapshots

2019-06-13 Thread GitBox
anuragaw commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-501637065 @ustcweizhou - can we directly do a squash and merge into master? Seems redundant given all PRs are merged into master after a squash. Ca

[GitHub] [cloudstack] blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot

2019-06-13 Thread GitBox
blueorangutan commented on issue #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-501640055 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2887 ---

[GitHub] [cloudstack] DaanHoogland commented on issue #3232: Cadf events

2019-06-13 Thread GitBox
DaanHoogland commented on issue #3232: Cadf events URL: https://github.com/apache/cloudstack/pull/3232#issuecomment-501640444 @ndalezios , when thesis delivered, can you look at the conflict? This is an automated message from

[GitHub] [cloudstack] DaanHoogland commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined

2019-06-13 Thread GitBox
DaanHoogland commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined URL: https://github.com/apache/cloudstack/issues/3388#issuecomment-501639800 @gildegoma I wonder if using the browser time offset is really what you want as a lot of multitimezone implemen

[GitHub] [cloudstack] rhtyd closed issue #3327: Volume name for failed and successful snapshots

2019-06-13 Thread GitBox
rhtyd closed issue #3327: Volume name for failed and successful snapshots URL: https://github.com/apache/cloudstack/issues/3327 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack] rhtyd merged pull request #3390: Add more info for creating volume snapshots

2019-06-13 Thread GitBox
rhtyd merged pull request #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390 This is an automated message from the Apache Git Service. To respond to the message, please log

[cloudstack] branch master updated (8f9f526 -> 1c963ba)

2019-06-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8f9f526 ui: alignment fixes (#3395) add 1c963ba ui: Add more info for creating volume snapshots (#3390) No

[GitHub] [cloudstack] rhtyd closed issue #3385: UI Translate code removes same-level content

2019-06-13 Thread GitBox
rhtyd closed issue #3385: UI Translate code removes same-level content URL: https://github.com/apache/cloudstack/issues/3385 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [cloudstack] rhtyd merged pull request #3386: Fix labels broken by translation code

2019-06-13 Thread GitBox
rhtyd merged pull request #3386: Fix labels broken by translation code URL: https://github.com/apache/cloudstack/pull/3386 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[cloudstack] branch master updated (1c963ba -> 873f1f2)

2019-06-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 1c963ba ui: Add more info for creating volume snapshots (#3390) add 873f1f2 ui: Fix labels broken by transl

[GitHub] [cloudstack] rhtyd merged pull request #3403: ui: Fix quick view tooltip title on multiselect list views

2019-06-13 Thread GitBox
rhtyd merged pull request #3403: ui: Fix quick view tooltip title on multiselect list views URL: https://github.com/apache/cloudstack/pull/3403 This is an automated message from the Apache Git Service. To respond to the mess

[cloudstack] branch master updated: ui: Fix quick view tooltip title on multiselect list views (#3403)

2019-06-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 29125be ui: Fix quick view tooltip title on

[GitHub] [cloudstack] rhtyd opened a new issue #3404: Improve volume migration without using secondary storage if possible

2019-06-13 Thread GitBox
rhtyd opened a new issue #3404: Improve volume migration without using secondary storage if possible URL: https://github.com/apache/cloudstack/issues/3404 Currently, a volume migration from one primary storage to another primary storage pool happens via the secondary storage (or a caching

[cloudstack] branch DaanHoogland-patch-2 updated (8462fce -> b47ae14)

2019-06-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch DaanHoogland-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8462fce space add b47ae14 Update QueryManagerImpl.java No new revisions were added by this up

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3365: KVM: DPDK live migrations

2019-06-13 Thread GitBox
DaanHoogland commented on a change in pull request #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#discussion_r293326526 ## File path: api/src/main/java/com/cloud/agent/api/to/DPDKTO.java ## @@ -0,0 +1,45 @@ +// Licensed to the Apache S

[GitHub] [cloudstack] rhtyd opened a new pull request #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
rhtyd opened a new pull request #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405 This fixes the qemu hooks `mkdir` race condition which can happen when too many VMs may launch on a KVM host executing the hooks script that tries to `mkdir` for

[GitHub] [cloudstack] rhtyd commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
rhtyd commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501668831 @blueorangutan package This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] rhtyd commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
rhtyd commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501671949 @DaanHoogland we currently have no way to detect and tell the user/admin that VM died due to the hooks race condition. @blueorangutan package

[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501672015 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
DaanHoogland commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501677511 @rhtyd my question is/was: Do we need to send an alarm if the directory doesn't exist? ---

[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501678235 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2888 This is an automated me

[GitHub] [cloudstack] rhtyd commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
rhtyd commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501679229 @blueorangutan test This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501679434 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] [cloudstack] rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable

2019-06-13 Thread GitBox
rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable URL: https://github.com/apache/cloudstack/issues/3400#issuecomment-501682742 I've not tested it, if it's not a valid bug, we can close it after reproduction. -

[GitHub] [cloudstack] ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

2019-06-13 Thread GitBox
ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501699613 @svenvogel I tested in my testing environment. it can be fixed by ``` root@s

[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3378: project id added in test

2019-06-13 Thread GitBox
ustcweizhou commented on a change in pull request #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#discussion_r293378598 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -646,7 +646,12 @@ Terna

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3378: project id added in test

2019-06-13 Thread GitBox
DaanHoogland commented on a change in pull request #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#discussion_r293387009 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -646,7 +646,12 @@ Tern

[GitHub] [cloudstack] matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-13 Thread GitBox
matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318 @ustcweizhou sorry, i use a modified cloudstack that save the tags in virtual router, it is a good feature to acs or n

[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-13 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318 @ustcweizhou sorry, i use a modified cloudstack that save the tags in virtual router, it is a new feature for y

[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-13 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318 @ustcweizhou sorry, i use a modified cloudstack that save the tags in virtual router, it is a good new feature

[GitHub] [cloudstack] gildegoma commented on issue #3272: VR DHCP lease file not persistent

2019-06-13 Thread GitBox
gildegoma commented on issue #3272: VR DHCP lease file not persistent URL: https://github.com/apache/cloudstack/issues/3272#issuecomment-501763348 FYI: I did some validation tests against CloudStack 4.11.3.0-RC1, and can confirm that this issue is now elegantly resolved :+1: :heart:

[GitHub] [cloudstack] gildegoma commented on issue #3354: Upon VM removal, VM records not removed from /etc/hosts

2019-06-13 Thread GitBox
gildegoma commented on issue #3354: Upon VM removal, VM records not removed from /etc/hosts URL: https://github.com/apache/cloudstack/issues/3354#issuecomment-501763541 FYI: I did some validation tests against CloudStack 4.11.3.0-RC1, and can confirm that this issue is now elegantly resolv

[GitHub] [cloudstack] darkfiberiru commented on issue #3401: Support for bhyve hypervisor on FreeBSD

2019-06-13 Thread GitBox
darkfiberiru commented on issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401#issuecomment-501826415 Any help understanding the scope of work for a third party wanting to contribute the integration would be helpful. I can go reread thro

[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-13 Thread GitBox
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501836649 @matheusdaluz it might be useful for some other users. so if you want to merge it into master, it would be better

[GitHub] [cloudstack] blueorangutan commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
blueorangutan commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501849151 Trillian test result (tid-3692) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24461 seconds

[GitHub] [cloudstack] gildegoma commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined

2019-06-13 Thread GitBox
gildegoma commented on issue #3388: User timezone is forced to UTC when user.timezone is undefined URL: https://github.com/apache/cloudstack/issues/3388#issuecomment-501876149 @DaanHoogland I have no preference for one solution over the other one, but I wanted to report and address the fol

[GitHub] [cloudstack] svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD

2019-06-13 Thread GitBox
svenvogel commented on issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401#issuecomment-501892441 @darkfiberiru why do you need this hypervisor? there are different ... like kvm, esxi or xen? is it because you want only use bsd and not

[GitHub] [cloudstack] rhtyd merged pull request #3391: ui: fix for disk offering quickview details, actions

2019-06-13 Thread GitBox
rhtyd merged pull request #3391: ui: fix for disk offering quickview details, actions URL: https://github.com/apache/cloudstack/pull/3391 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [cloudstack] rhtyd closed issue #2741: QuickView on DiskOfferings not showing actions

2019-06-13 Thread GitBox
rhtyd closed issue #2741: QuickView on DiskOfferings not showing actions URL: https://github.com/apache/cloudstack/issues/2741 This is an automated message from the Apache Git Service. To respond to the message, please log on

[cloudstack] branch master updated: ui: fix for disk offering quickview details, actions (#3391)

2019-06-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 02cf680 ui: fix for disk offering quickview

[GitHub] [cloudstack] ustcweizhou commented on issue #3405: kvm: fix qemu hook race condition

2019-06-13 Thread GitBox
ustcweizhou commented on issue #3405: kvm: fix qemu hook race condition URL: https://github.com/apache/cloudstack/pull/3405#issuecomment-501992112 code LGTM This is an automated message from the Apache Git Service. To respond