Re: [PR] Ensure marvin package version is PEP440 compliant [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud merged PR #9230: URL: https://github.com/apache/cloudstack/pull/9230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-06-12 Thread via GitHub
rp- commented on PR #9138: URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2164499737 > > @sureshanaparti , do you dare to merge? > > Hi @rp- Code looks good, but I'm not able to check UI with Linstor plugin, possible to share any screenshot showing resource group

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2164494566 > [SF] Trillian test result (tid-10417) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44990 seconds Marvin logs:

Re: [PR] add to cpu speed parameter a description of the cgroup2 case [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on code in PR #9191: URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637586046 ## api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java: ## @@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd

Re: [PR] add to cpu speed parameter a description of the cgroup2 case [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on code in PR #9191: URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637011378 ## api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java: ## @@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd

(cloudstack) branch main updated: Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups (#8835)

2024-06-12 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 525c2c6fe93 Show in which primary storage volumes

Re: [PR] Show in which primary storage volumes are allocated in instance details page and volume migration pop-ups [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland merged PR #8835: URL: https://github.com/apache/cloudstack/pull/8835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#issuecomment-2164431267 Yes @BryanMLima but our lab is reserved for 4.19 work this week. main will have to wait. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on code in PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#discussion_r1637551428 ## api/src/main/java/org/apache/cloudstack/api/command/admin/config/UpdateHypervisorCapabilitiesCmd.java: ## @@ -45,6 +45,12 @@ public class

Re: [PR] vxlan: do not create duplicated network for private gateway [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9232: URL: https://github.com/apache/cloudstack/pull/9232#issuecomment-2164332795 [SF] Trillian test result (tid-10423) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44939 seconds Marvin logs:

Re: [PR] saml: introduce saml2.check.signature [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9219: URL: https://github.com/apache/cloudstack/pull/9219#issuecomment-2164044849 [SF] Trillian test result (tid-10420) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42783 seconds Marvin logs:

Re: [PR] Ensure marvin package version is PEP440 compliant [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9230: URL: https://github.com/apache/cloudstack/pull/9230#issuecomment-2164023360 [SF] Trillian test result (tid-10418) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42973 seconds Marvin logs:

Re: [PR] engine-storage: Set SecretConsumerDetail for VM live migration with storage on shared NFS [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9222: URL: https://github.com/apache/cloudstack/pull/9222#issuecomment-2163994633 @abh1sar a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] engine-storage: Set SecretConsumerDetail for VM live migration with storage on shared NFS [cloudstack]

2024-06-12 Thread via GitHub
abh1sar commented on PR #9222: URL: https://github.com/apache/cloudstack/pull/9222#issuecomment-2163993197 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2163989083 [SF] Trillian test result (tid-10417) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44990 seconds Marvin logs:

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
vladimirpetrov commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2163945294 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on code in PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#discussion_r1637060650 ## engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java: ## @@ -61,6 +61,11 @@ public interface ResourceManager extends

Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2163861065 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9910 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2163861071 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9909 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Handle public IP race conditions [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9234: URL: https://github.com/apache/cloudstack/pull/9234#issuecomment-2163861066 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9911 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] add to cpu speed parameter a description of the cgroup2 case [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on code in PR #9191: URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637011378 ## api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java: ## @@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd

Re: [PR] add to cpu speed parameter a description of the cgroup2 case [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on code in PR #9191: URL: https://github.com/apache/cloudstack/pull/9191#discussion_r1637011378 ## api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java: ## @@ -56,7 +56,7 @@ public class CreateServiceOfferingCmd

Re: [PR] GUI whitelabel runtime system [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #8942: URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-2163774144 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163772637 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9908 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] cks: fix events [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2163767853 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] cks: fix events [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2163765706 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Handle public IP race conditions [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9234: URL: https://github.com/apache/cloudstack/pull/9234#issuecomment-2163762061 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Handle public IP race conditions [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on PR #9234: URL: https://github.com/apache/cloudstack/pull/9234#issuecomment-2163761110 > @weizhouapache, could you take a look at this one? Will do @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] cks: fix events [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2163750396 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9907 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2163750397 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9906 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2163750013 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2163749967 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2163748728 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2163747452 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(cloudstack) branch dummy updated (8ab259bee22 -> f854aea8225)

2024-06-12 Thread sureshanaparti
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 8ab259bee22 donot merge add 371ce12abef Normalize dates in Usage and Quota APIs (#8243) add

(cloudstack) branch 4.19-dummy updated (c32f8ef7daf -> 0f8799a45fe)

2024-06-12 Thread sureshanaparti
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch 4.19-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard c32f8ef7daf do not merge add 4bd0b1c24f1 ui: refactor global createmenu (#9139) add

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2163740396 @DaanHoogland, my bad, I did not see the comment at https://github.com/apache/cloudstack/pull/8878#issuecomment-2162594804, you can ignore my other comments. -- This is an

[PR] Improve logs in primary storage removal process [cloudstack]

2024-06-12 Thread via GitHub
hsato03 opened a new pull request, #8649: URL: https://github.com/apache/cloudstack/pull/8649 ### Description While listing volumes from a primary storage, volumes from system VMs are not listed, making the primary storage removal process difficult as an exception is thrown if the

Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima closed pull request #8649: Improve logs in primary storage removal process URL: https://github.com/apache/cloudstack/pull/8649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#issuecomment-2163734772 @weizhouapache, are your concerns met? @DaanHoogland, could you trigger the CI one last time? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Handle public IP race conditions [cloudstack]

2024-06-12 Thread via GitHub
GutoVeronezi commented on PR #9234: URL: https://github.com/apache/cloudstack/pull/9234#issuecomment-2163716520 @weizhouapache, could you take a look at this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636927477 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -378,7 +378,7 @@ public

Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-06-12 Thread via GitHub
hsato03 commented on issue #8967: URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2163679437 @bragonznx @vdombrovski We also discovered that the public IP can be duplicated when different VRs have the same control IP. Could you check the database to see if there

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
codecov[bot] commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163662662 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8934?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #8557: URL: https://github.com/apache/cloudstack/pull/8557#issuecomment-2163653326 @DaanHoogland @sureshanaparti, could you trigger the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163652888 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2163650795 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
GaOrtiga opened a new pull request, #8934: URL: https://github.com/apache/cloudstack/pull/8934 ### Description The configuration `SystemVMDefaultHypervisor` is not dynamic, it is necessary to restart the management server after each alteration to its value. Besides, its input is a

Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima closed pull request #8934: Refactor configuration SystemVMDefaultHypervisor URL: https://github.com/apache/cloudstack/pull/8934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#issuecomment-2163646878 @DaanHoogland, can we run the CI one last time here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] xenserver: attach regular iso with configdrive [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9216: URL: https://github.com/apache/cloudstack/pull/9216#issuecomment-2163636801 @shwstppr a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2163636740 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] orchestration,hypervisor: allow custom manufacturer, product for vm metadata [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #9163: URL: https://github.com/apache/cloudstack/pull/9163#issuecomment-2163635744 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] xenserver: attach regular iso with configdrive [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #9216: URL: https://github.com/apache/cloudstack/pull/9216#issuecomment-2163634079 @blueorangutan test rocky8 xcpng82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] cks: fix events [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2163633534 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] cks: fix events [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2163632022 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2163630337 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2163628305 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-06-12 Thread via GitHub
BryanMLima closed pull request #8372: [Quota] Add API to list preset variables URL: https://github.com/apache/cloudstack/pull/8372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-06-12 Thread via GitHub
hsato03 commented on issue #8967: URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2163616158 Hello @bragonznx @vdombrovski We reproduced the issue using the script you provided in this discussion and also discovered that this situation also happens when creating a

Re: [I] Certificate error when downloading ISO [cloudstack]

2024-06-12 Thread via GitHub
Dimonyga commented on issue #9086: URL: https://github.com/apache/cloudstack/issues/9086#issuecomment-2163559052 After June 6, downloading images from sources with certificates issued by letsencrypt stopped working. https://letsencrypt.org/2024/04/12/changes-to-issuance-chains --

Re: [PR] Handle public IP race conditions [cloudstack]

2024-06-12 Thread via GitHub
codecov[bot] commented on PR #9234: URL: https://github.com/apache/cloudstack/pull/9234#issuecomment-2163543495 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9234?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] Handle public IP race conditions [cloudstack]

2024-06-12 Thread via GitHub
hsato03 opened a new pull request, #9234: URL: https://github.com/apache/cloudstack/pull/9234 ### Description When executing many operations simultaneously with a public IP, some inconsistencies are being implemented in the environment, such as the duplicate public IP (#8967).

Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on code in PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#discussion_r1636813437 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -5068,31 +5068,66 @@ public Pair, Integer> listHypervisorCapab return new

Re: [PR] Remove duplicate network state checks before shutdown network [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8462: URL: https://github.com/apache/cloudstack/pull/8462#issuecomment-2163511024 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9905 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[I] Dashboard items are shown even when permission set to Deny [cloudstack]

2024-06-12 Thread via GitHub
scottsignal opened a new issue, #9233: URL: https://github.com/apache/cloudstack/issues/9233 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0.1 ~~~ # CONFIGURATION

Re: [I] migrateVolume does not copy the template [cloudstack]

2024-06-12 Thread via GitHub
gpordeus closed issue #5759: migrateVolume does not copy the template URL: https://github.com/apache/cloudstack/issues/5759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] api: listVM API improvement followup, change returning of stats detail [cloudstack]

2024-06-12 Thread via GitHub
GutoVeronezi commented on PR #9177: URL: https://github.com/apache/cloudstack/pull/9177#issuecomment-2163430400 @rohityadavcloud, I did not judge your change of opinion. If you read it carefully, you will see that what I am doing is pointing out that there was no consensus on the change of

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
GaOrtiga commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636740222 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -379,8 +380,8 @@ public VMTemplateVO

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
GaOrtiga commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636740222 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -379,8 +380,8 @@ public VMTemplateVO

Re: [PR] Remove duplicate network state checks before shutdown network [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8462: URL: https://github.com/apache/cloudstack/pull/8462#issuecomment-2163380950 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Remove duplicate network state checks before shutdown network [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #8462: URL: https://github.com/apache/cloudstack/pull/8462#issuecomment-2163379242 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Remove duplicate network state checks before shutdown network [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8462: URL: https://github.com/apache/cloudstack/pull/8462#issuecomment-2163375271 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9904 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2163375272 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9903 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2163374158 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9902 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Remove duplicate network state checks before shutdown network [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8462: URL: https://github.com/apache/cloudstack/pull/8462#issuecomment-2163318815 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Remove duplicate network state checks before shutdown network [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #8462: URL: https://github.com/apache/cloudstack/pull/8462#issuecomment-2163315291 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] vxlan: do not create duplicated network for private gateway [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9232: URL: https://github.com/apache/cloudstack/pull/9232#issuecomment-2163291706 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] vxlan: do not create duplicated network for private gateway [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on PR #9232: URL: https://github.com/apache/cloudstack/pull/9232#issuecomment-2163288351 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Start VM (with considerlasthost=true) failed with NPE when last host removed [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on issue #9033: URL: https://github.com/apache/cloudstack/issues/9033#issuecomment-2163277131 fixed by #9037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Start VM (with considerlasthost=true) failed with NPE when last host removed [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland closed issue #9033: Start VM (with considerlasthost=true) failed with NPE when last host removed URL: https://github.com/apache/cloudstack/issues/9033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(cloudstack) branch main updated: While starting VM with 'considerlasthost' enabled, don't load host tags/details for the last host when it doesn't exist [main] (#9063)

2024-06-12 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 6fda757936b While starting VM with

Re: [PR] While starting VM with 'considerlasthost' enabled, don't load host tags/details for the last host when it doesn't exist [main] [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland merged PR #9063: URL: https://github.com/apache/cloudstack/pull/9063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on code in PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#discussion_r1636636454 ## engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java: ## @@ -90,49 +90,54 @@ public String concatenateUserData(String

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2163215354 > > @vishesh92 @DaanHoogland I agree that if we are to have a configuration for each table it would be too much. However, the configuration that @vishesh92 proposed to use

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2163185942 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2163185832 @vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2163181584 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
vladimirpetrov commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2163183209 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2163125571 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636554494 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -379,8 +380,8 @@ public

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2163119952 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636548382 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java: ## @@ -105,6 +105,7 @@

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
codecov[bot] commented on PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#issuecomment-2163113513 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9223?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1636534341 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java: ## @@ -1127,14 +1127,14 @@ private void

Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #9138: URL: https://github.com/apache/cloudstack/pull/9138#issuecomment-2163092802 > @sureshanaparti , do you dare to merge? Hi @rp- Code looks good, but I'm not able to check UI with Linstor plugin, possible to share any screenshot showing resource

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache merged PR #9212: URL: https://github.com/apache/cloudstack/pull/9212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Wrong mountpoint generated on secondary storage for ISO on live migration [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache closed issue #8901: Wrong mountpoint generated on secondary storage for ISO on live migration URL: https://github.com/apache/cloudstack/issues/8901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Wrong mountpoint generated on secondary storage for ISO on live migration [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on issue #8901: URL: https://github.com/apache/cloudstack/issues/8901#issuecomment-2163090387 fixed by #9212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2163089437 > LGTM based on manual testing. I cannot reproduce the problem after this patch. thanks @vladimirpetrov ! merging -- This is an automated message from the Apache

  1   2   3   4   >