onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519170384
`VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(Long vmId, Long
vmSnapshotId, Boolean quiescevm)` is used in two places:
- `VMSnapshotM
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519171822
I suspect that `orchestrateDeleteVMSnapshot(VmWorkDeleteVMSnapshot work)`
and `orchestrateDeleteAllVMSnapshots(VmWorkDeleteAllVMSnapshots wor
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519174665
Sorry, scratch that last remark. These function only get a boolean return
value. No risk of an NPE there.
--
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519389917
What do you think, @rhtyd ? Would a null value check in
`VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(VmWorkCreateVMSnapshot
work)` be
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519829463
The problem here is that this fairly difficult, as I don't have a reliable
way to trigger throwing an exception, in a real life scenario.
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519870665
There are other sources for exceptions, not just the part that did `return
null`, so I would assume that there is already some sort of error
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-520497337
@DaanHoogland Setting the snapshot state to "Error" would involve something
like this:
```java
try {
VMS
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-520857458
So, after some more digging, I came to the conclusion that there are two
major code paths how the snapshot creation can be reached:
-
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-563126673
@rhtyd is this only going into 4.14? No backport to 4.13?
This is an automat
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-564003226
All right, will do.
This is an automated message from the Apache Git Service
10 matches
Mail list logo
