[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #12033: Return 400 when SQL query cannot be planned

abhishekagarwal87 commented on a change in pull request #12033: URL: https://github.com/apache/druid/pull/12033#discussion_r764614500 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java ## @@ -3122,23 +3121,8 @@ public void testInnerJoinOnTw

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #12033: Return 400 when SQL query cannot be planned

abhishekagarwal87 commented on a change in pull request #12033: URL: https://github.com/apache/druid/pull/12033#discussion_r764614328 ## File path: sql/src/main/java/org/apache/druid/sql/http/SqlResource.java ## @@ -205,22 +205,20 @@ public Response doPost( throw (Forbid

[GitHub] [druid] clintropolis commented on a change in pull request #12033: Return 400 when SQL query cannot be planned

clintropolis commented on a change in pull request #12033: URL: https://github.com/apache/druid/pull/12033#discussion_r764601254 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java ## @@ -3122,23 +3121,8 @@ public void testInnerJoinOnTwoInli

[GitHub] [druid] vogievetsky opened a new pull request #12037: Web console: use query actions in query view

vogievetsky opened a new pull request #12037: URL: https://github.com/apache/druid/pull/12037 Right now there is a bug that can lead to parts of queries typed into the query view being lost: To repro: 1. Run some query e.g: ```sql SELECT channel, COUNT(*) A

[druid] branch master updated (150902b -> 0565f0e)

This is an automated email from the ASF dual-hosted git repository. xvrl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 150902b clean up the balancing code around the batched vs deprecated way of sampling segments to balance (#11960)

[GitHub] [druid] xvrl merged pull request #12034: fix build warnings for forbidden-apis

xvrl merged pull request #12034: URL: https://github.com/apache/druid/pull/12034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [druid] kfaraz opened a new pull request #12036: Docs: Fix column name in ingestion rollup doc

kfaraz opened a new pull request #12036: URL: https://github.com/apache/druid/pull/12036 ### Description Fix the referred column from "count" to "cnt". --- This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/

[GitHub] [druid] clintropolis commented on a change in pull request #11961: Add parse error list API for stream supervisors, use structured object for parse exceptions, simplify parse exception messag

clintropolis commented on a change in pull request #11961: URL: https://github.com/apache/druid/pull/11961#discussion_r764479194 ## File path: extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/FileBasedProtobufBytesDecoder.java ## @@ -98,35

[GitHub] [druid] jon-wei commented on pull request #11961: Add parse error list API for stream supervisors, use structured object for parse exceptions, simplify parse exception message

jon-wei commented on pull request #11961: URL: https://github.com/apache/druid/pull/11961#issuecomment-988381383 @abhishekagarwal87 Thanks for the review! I addressed your comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [druid] jon-wei commented on a change in pull request #11961: Add parse error list API for stream supervisors, use structured object for parse exceptions, simplify parse exception message

jon-wei commented on a change in pull request #11961: URL: https://github.com/apache/druid/pull/11961#discussion_r764465182 ## File path: processing/src/main/java/org/apache/druid/segment/incremental/ParseExceptionReport.java ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache

[GitHub] [druid] jon-wei commented on a change in pull request #11961: Add parse error list API for stream supervisors, use structured object for parse exceptions, simplify parse exception message

jon-wei commented on a change in pull request #11961: URL: https://github.com/apache/druid/pull/11961#discussion_r764464756 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskClient.java ## @@ -224,6 +231,31 @@ public D

[GitHub] [druid] jon-wei commented on a change in pull request #11961: Add parse error list API for stream supervisors, use structured object for parse exceptions, simplify parse exception message

jon-wei commented on a change in pull request #11961: URL: https://github.com/apache/druid/pull/11961#discussion_r764464482 ## File path: core/src/main/java/org/apache/druid/java/util/common/parsers/ParseException.java ## @@ -38,26 +40,43 @@ public class ParseException extend

[GitHub] [druid] wjhypo commented on a change in pull request #11309: Optionally load segment index files into page cache on bootstrap and new segment download

wjhypo commented on a change in pull request #11309: URL: https://github.com/apache/druid/pull/11309#discussion_r764462889 ## File path: server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java ## @@ -369,7 +392,7 @@ private void addSegments(Collec

[GitHub] [druid] shallada opened a new pull request #12035: clarify time format for intervals

shallada opened a new pull request #12035: URL: https://github.com/apache/druid/pull/12035 Clarifies the time format for intervals in the granularitySpec and adds an example. CC: @techdocsmith @sthetland This PR has: - [X] been self-reviewed. - [ ] using the [concurrency

[GitHub] [druid] jihoonson commented on a change in pull request #12025: fix issues with multi-value string constant expressions

jihoonson commented on a change in pull request #12025: URL: https://github.com/apache/druid/pull/12025#discussion_r764436410 ## File path: processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java ## @@ -201,6 +201,9 @@ public static DimensionSelector

[druid] branch master updated (a8815f6 -> 150902b)

This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from a8815f6 Fix druid client timeout zero (#12023) add 150902b clean up the balancing code around the batched vs

[GitHub] [druid] jihoonson merged pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

jihoonson merged pull request #11960: URL: https://github.com/apache/druid/pull/11960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [druid] jihoonson commented on pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

jihoonson commented on pull request #11960: URL: https://github.com/apache/druid/pull/11960#issuecomment-988316724 The "docs' CI passed. Merging this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [druid] lgtm-com[bot] commented on pull request #12032: Migrade Druid HttpClient from Netty 3 to 4

lgtm-com[bot] commented on pull request #12032: URL: https://github.com/apache/druid/pull/12032#issuecomment-988295089 This pull request **introduces 3 alerts** when merging 1d38c3a0b06750b0400d74be55f797fe41a9c84a into 1d3c8c187b9c07ee1adc6a6669f756421ec9f324 - [view on LGTM.com](https:/

[GitHub] [druid] xvrl opened a new pull request #12034: fix build warnings for forbidden-apis

xvrl opened a new pull request #12034: URL: https://github.com/apache/druid/pull/12034 * replace deprecated forbidden-apis config failOnUnresolvableSignatures with ignoreSignaturesOfMissingClasses which avoids warnings for classes not present in a particular sub-module * fix inc

[GitHub] [druid] clintropolis commented on a change in pull request #11888: add 'TypeStrategy' to types

clintropolis commented on a change in pull request #11888: URL: https://github.com/apache/druid/pull/11888#discussion_r764348554 ## File path: core/src/main/java/org/apache/druid/segment/column/TypeStrategy.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [druid] clintropolis commented on a change in pull request #11888: add 'TypeStrategy' to types

clintropolis commented on a change in pull request #11888: URL: https://github.com/apache/druid/pull/11888#discussion_r764348431 ## File path: core/src/main/java/org/apache/druid/segment/column/TypeStrategy.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [druid] clintropolis commented on a change in pull request #11888: add 'TypeStrategy' to types

clintropolis commented on a change in pull request #11888: URL: https://github.com/apache/druid/pull/11888#discussion_r764347282 ## File path: core/src/main/java/org/apache/druid/segment/column/TypeStrategy.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [druid] clintropolis commented on a change in pull request #11888: add 'TypeStrategy' to types

clintropolis commented on a change in pull request #11888: URL: https://github.com/apache/druid/pull/11888#discussion_r764346431 ## File path: core/src/main/java/org/apache/druid/segment/column/TypeStrategy.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [druid] clintropolis merged pull request #12023: Fix druid client timeout zero

clintropolis merged pull request #12023: URL: https://github.com/apache/druid/pull/12023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [druid] jihoonson commented on pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

jihoonson commented on pull request #11960: URL: https://github.com/apache/druid/pull/11960#issuecomment-988206282 @capistrant thank you for updating docs. Feel free to merge once the "docs" CI passes. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [druid] lgtm-com[bot] commented on pull request #12032: Migrade Druid HttpClient from Netty 3 to 4

lgtm-com[bot] commented on pull request #12032: URL: https://github.com/apache/druid/pull/12032#issuecomment-988201547 This pull request **introduces 3 alerts** when merging f2794fdeac57763a8967109ed731a34d1f0aa3f2 into 0b3f0bbbd81cc3ec33e1a4716ee33b149d1a2940 - [view on LGTM.com](https:/

[GitHub] [druid] clintropolis merged pull request #12031: Web console: query view improvements and other fixes

clintropolis merged pull request #12031: URL: https://github.com/apache/druid/pull/12031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [druid] jihoonson commented on a change in pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

jihoonson commented on a change in pull request #11960: URL: https://github.com/apache/druid/pull/11960#discussion_r764238416 ## File path: web-console/src/druid-models/coordinator-dynamic-config.tsx ## @@ -213,14 +213,16 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: Fiel

[GitHub] [druid] clintropolis commented on a change in pull request #12025: fix issues with multi-value string constant expressions

clintropolis commented on a change in pull request #12025: URL: https://github.com/apache/druid/pull/12025#discussion_r764237349 ## File path: processing/src/main/java/org/apache/druid/segment/DimensionSelector.java ## @@ -164,6 +166,27 @@ static DimensionSelector constant(@Nu

[GitHub] [druid] capistrant commented on a change in pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

capistrant commented on a change in pull request #11960: URL: https://github.com/apache/druid/pull/11960#discussion_r764235666 ## File path: web-console/src/druid-models/coordinator-dynamic-config.tsx ## @@ -213,14 +213,16 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: Fie

[GitHub] [druid] techdocsmith merged pull request #11481: Docs - Metrics docs layout and info about query/bytes

techdocsmith merged pull request #11481: URL: https://github.com/apache/druid/pull/11481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [druid] gianm commented on a change in pull request #12032: Migrade Druid HttpClient from Netty 3 to 4

gianm commented on a change in pull request #12032: URL: https://github.com/apache/druid/pull/12032#discussion_r764228382 ## File path: core/src/main/java/org/apache/druid/java/util/http/client/response/SequenceInputStreamResponseHandler.java ## @@ -102,14 +100,14 @@ public In

[GitHub] [druid] petermarshallio commented on a change in pull request #11490: Docs - S3 masking and nav update to S3 page

petermarshallio commented on a change in pull request #11490: URL: https://github.com/apache/druid/pull/11490#discussion_r738338327 ## File path: docs/ingestion/native-batch.md ## @@ -837,16 +837,53 @@ Only the native Parallel task and Simple task support the input source.

[GitHub] [druid] jihoonson commented on a change in pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

jihoonson commented on a change in pull request #11960: URL: https://github.com/apache/druid/pull/11960#discussion_r764219324 ## File path: web-console/src/druid-models/coordinator-dynamic-config.tsx ## @@ -213,14 +213,16 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: Fiel

[GitHub] [druid] abhishekagarwal87 closed pull request #12001: Intern RowSignature in DruidSchema to reduce its memory footprint

abhishekagarwal87 closed pull request #12001: URL: https://github.com/apache/druid/pull/12001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [druid] techdocsmith merged pull request #11677: Docs - roll-up tip

techdocsmith merged pull request #11677: URL: https://github.com/apache/druid/pull/11677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[druid] branch master updated (65cadbe -> d7463c9)

This is an automated email from the ASF dual-hosted git repository. techdocsmith pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 65cadbe Fix bad lookup config fails task (#12021) add d7463c9 Docs - Task ref logs correction (#11746) N

[GitHub] [druid] techdocsmith merged pull request #11746: Docs - Task ref logs correction

techdocsmith merged pull request #11746: URL: https://github.com/apache/druid/pull/11746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [druid] abhishekagarwal87 commented on pull request #12033: Return 400 when SQL query cannot be planned

abhishekagarwal87 commented on pull request #12033: URL: https://github.com/apache/druid/pull/12033#issuecomment-988113099 no worries @capistrant. Thank you for thumbs up :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [druid] xvrl commented on a change in pull request #12032: Migrade Druid HttpClient from Netty 3 to 4

xvrl commented on a change in pull request #12032: URL: https://github.com/apache/druid/pull/12032#discussion_r764193588 ## File path: core/src/main/java/org/apache/druid/java/util/http/client/response/SequenceInputStreamResponseHandler.java ## @@ -102,14 +100,14 @@ public Inp

[GitHub] [druid] FrankChen021 commented on pull request #10147: Support rolling log files

FrankChen021 commented on pull request #10147: URL: https://github.com/apache/druid/pull/10147#issuecomment-988070408 @clintropolis Thank you for your information. Let me take a look later this week. If you think this might be a blocker or something that is not mature, it's OK to revert it

[GitHub] [druid] FrankChen021 commented on pull request #12026: Fix vulnerabilities in some HTTP endpoints

FrankChen021 commented on pull request #12026: URL: https://github.com/apache/druid/pull/12026#issuecomment-988067555 @kfaraz My opinion is that we should use exception-thrown style instead of returning statement. The reason I keep a `toResponse` function to return a `Response` object is t

[GitHub] [druid] capistrant commented on pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

capistrant commented on pull request #11960: URL: https://github.com/apache/druid/pull/11960#issuecomment-988037607 @a2l007 @yuanlihan thank you both for reviewing! I synced up with master and plan on merging once CI is green. -- This is an automated message from the Apache Git Service.

[GitHub] [druid] yogrj commented on issue #9781: Request failed with status code 500

yogrj commented on issue #9781: URL: https://github.com/apache/druid/issues/9781#issuecomment-987932392 Hello , I am also facing same issue - request failed with status 500. Can anyone suggest what's going wrong in config -- This is an automated message from the Apache Git Service

[GitHub] [druid] abhishekagarwal87 opened a new pull request #12033: Return 400 when SQL query cannot be planned

abhishekagarwal87 opened a new pull request #12033: URL: https://github.com/apache/druid/pull/12033 This is a follow-up to https://github.com/apache/druid/pull/11911. In this PR, we will now return 400 instead of 500 when SQL query cannot be planned. I also fixed a bug where error messa

[GitHub] [druid] LakshSingla commented on a change in pull request #12001: Intern RowSignature in DruidSchema to reduce its memory footprint

LakshSingla commented on a change in pull request #12001: URL: https://github.com/apache/druid/pull/12001#discussion_r763855107 ## File path: benchmarks/src/test/java/org/apache/druid/benchmark/DruidSchemaInternRowSignatureBenchmark.java ## @@ -0,0 +1,219 @@ +/* + * Licensed t

[GitHub] [druid] LakshSingla commented on a change in pull request #12001: Intern RowSignature in DruidSchema to reduce its memory footprint

LakshSingla commented on a change in pull request #12001: URL: https://github.com/apache/druid/pull/12001#discussion_r763854409 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java ## @@ -791,7 +795,7 @@ DruidTable buildDruidTable(final String d

[GitHub] [druid] lgtm-com[bot] commented on pull request #12032: Migrade Druid HttpClient from Netty 3 to 4

lgtm-com[bot] commented on pull request #12032: URL: https://github.com/apache/druid/pull/12032#issuecomment-987685656 This pull request **introduces 1 alert** when merging 5c704e6e962e72691a3a7791439591fcff33e10d into 65cadbe42a23fc4dca0d1f703b755293f54f15c4 - [view on LGTM.com](https://