[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1047148112 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1045871843 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -1485,7 +1486,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041911963 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -358,7 +324,7 @@ private void validate() { } -private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041911174 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientDomainServiceImpl.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041379158 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -463,7 +459,7 @@ public boolean isWithdrawn() { return

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040895441 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040894809 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040894541 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040893967 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040891345 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040889924 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +61,7 @@ public interface

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040888121 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepositoryWrapper.java: ## @@ -86,8 +87,21 @@ public Client

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040886870 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +750,18 @@ public boolean isStaff() { return

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040886420 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -463,7 +459,7 @@ public boolean isWithdrawn() { return

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040885753 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -224,12 +227,11 @@ public class Client extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040851100 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040850809 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040850456 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040850214 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040849840 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040847505 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040847320 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040846935 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040845861 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -415,25 +300,302 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040842842 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/AbstractWorkbookPopulator.java: ## @@ -130,7 +130,7 @@ protected void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039811298 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -24,92 +24,96 @@ import java.util.List; import java.util.Set;

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039804761 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -555,6 +523,7 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039802744 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247,16 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039800321 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -479,10 +476,10 @@ public Map update(final JsonCommand command) {

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039796013 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -229,7 +232,7 @@ public static Client createNew(final AppUser

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039793683 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -379,7 +383,7 @@ public static ClientData clientIdentifier(final

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039793234 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -293,7 +297,7 @@ public static ClientData template(final Long

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039791113 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientPersonImportHandler.java: ## @@ -95,7 +97,7 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039786406 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7 +143,7 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039786406 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7 +143,7 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039302792 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039293985 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039293985 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039292804 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247,15 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039288976 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +60,7 @@ public interface

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039287520 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientRepository extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039287147 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientRepository extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039285495 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +757,18 @@ public boolean isStaff() { return

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039284331 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -34,82 +36,83 @@ import

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039275106 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private GetClientsGroups() {}

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039275106 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private GetClientsGroups() {}

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039270839 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -436,4 +352,251 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039264757 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -91,6 +84,29

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039265325 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java: ## @@ -489,4 +491,11 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039264757 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -91,6 +84,29