[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046644809 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046644809 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046080521 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeSpecificDueDateTest.java: ## @@ -110,7 +110,60 @@ public void

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046064916 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/common/loans/LoanTransactionHelper.java: ## @@ -1563,6 +1563,14 @@ public

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046060125 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -213,6

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2797: FINERACT-1785: Allow to add charge (penalty) with same disbursement date

2022-12-12 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2797: URL: https://github.com/apache/fineract/pull/2797#discussion_r1046058356 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeSpecificDueDateTest.java: ## @@ -110,7 +110,60 @@ public void