Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
chaokunyang merged PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
LiangliangSui commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537739565 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Seriali

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
LiangliangSui commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537176291 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Seriali

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
chaokunyang commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537174200 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serialize

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
LiangliangSui commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537144622 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Seriali

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
chaokunyang commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537136635 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serialize

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
chaokunyang commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537135649 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serialize

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-25 Thread via GitHub
LiangliangSui commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537126328 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Seriali

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-24 Thread via GitHub
chaokunyang commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537120046 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serialize

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-24 Thread via GitHub
chaokunyang commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537119871 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serialize

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-24 Thread via GitHub
LiangliangSui commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537103987 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Seriali

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-24 Thread via GitHub
chaokunyang commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537038289 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serialize

Re: [PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-24 Thread via GitHub
chaokunyang commented on code in PR #1424: URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537038165 ## java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java: ## @@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serialize

[PR] refactor(java): remove registerWithCheck function [incubator-fury]

2024-03-24 Thread via GitHub
LiangliangSui opened a new pull request, #1424: URL: https://github.com/apache/incubator-fury/pull/1424 Remove `registerWithCheck` function and register function enables duplicate registration check by default. When Class is repeatedly registered, an `IllegalArgumentException` is thrown.