Re: [I] [VL] Umbrella tracker for data mismatch issues [incubator-gluten]

2024-03-11 Thread via GitHub
kecookier commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-1990694124 https://github.com/apache/incubator-gluten/issues/4930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [VL] Umbrella tracker for data mismatch issues [incubator-gluten]

2024-03-11 Thread via GitHub
kecookier commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-1990691680 https://github.com/apache/incubator-gluten/issues/4928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[I] [VL] Results are mismatch with vanilla Spark, it maybe caused by cast(string as bigint) [incubator-gluten]

2024-03-11 Thread via GitHub
kecookier opened a new issue, #4930: URL: https://github.com/apache/incubator-gluten/issues/4930 ### Backend VL (Velox) ### Bug description The following SQL might lead to wrong results, but it's not yet certain if there are other factors involved. I will try to

Re: [PR] [Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4708: URL: https://github.com/apache/incubator-gluten/pull/4708#issuecomment-1990640490 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… [incubator-gluten]

2024-03-11 Thread via GitHub
binmahone commented on PR #4708: URL: https://github.com/apache/incubator-gluten/pull/4708#issuecomment-1990639191 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Fix wrong plan equality due to case class inheritance [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1990623631 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-1990589034 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [Gluten-4912][CH]Support Specifying columns in clickhouse tables to b… [incubator-gluten]

2024-03-11 Thread via GitHub
zzcclp commented on PR #4925: URL: https://github.com/apache/incubator-gluten/pull/4925#issuecomment-1990517955 LGTM if ci passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Fix wrong plan equality due to case class inheritance [incubator-gluten]

2024-03-11 Thread via GitHub
zzcclp commented on code in PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#discussion_r1520863275 ## gluten-ut/spark33/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala: ## @@ -339,6 +339,10 @@ class ClickHouseTestSettings

Re: [PR] [VL]Bucket join support for Iceberg tables [incubator-gluten]

2024-03-11 Thread via GitHub
yma11 commented on code in PR #4859: URL: https://github.com/apache/incubator-gluten/pull/4859#discussion_r1520855069 ## gluten-iceberg/src/test/scala/io/glutenproject/execution/VeloxIcebergSuite.scala: ## @@ -56,44 +71,246 @@ class VeloxIcebergSuite extends

Re: [PR] [VL] Fix wrong plan equality due to case class inheritance [incubator-gluten]

2024-03-11 Thread via GitHub
zhztheplayer commented on code in PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#discussion_r1520852289 ## gluten-ut/spark33/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala: ## @@ -339,6 +339,10 @@ class ClickHouseTestSettings

Re: [PR] [VL] Fix wrong plan equality due to case class inheritance [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1990413871 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support posexplode function and code refactoring on GenerateExecTransformer [incubator-gluten]

2024-03-11 Thread via GitHub
zhouyuan commented on code in PR #4901: URL: https://github.com/apache/incubator-gluten/pull/4901#discussion_r1520844750 ## backends-velox/src/main/scala/io/glutenproject/execution/GenerateExecTransformer.scala: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

Re: [PR] [VL] Support posexplode function and code refactoring on GenerateExecTransformer [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4901: URL: https://github.com/apache/incubator-gluten/pull/4901#issuecomment-1990272456 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [VL] Results are mismatch with vanilla Spark, it could be get_json_object() causing the issue. [incubator-gluten]

2024-03-11 Thread via GitHub
kecookier opened a new issue, #4928: URL: https://github.com/apache/incubator-gluten/issues/4928 ### Backend VL (Velox) ### Bug description The following SQL might lead to wrong results, but it's not yet certain if there are other factors involved. I will try to

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-1990169436 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4745][CH] support Sort Merge Join [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4812: URL: https://github.com/apache/incubator-gluten/pull/4812#issuecomment-1990154902 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4796][VL] Add orc char type validation [incubator-gluten]

2024-03-11 Thread via GitHub
kerwin-zk commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1990149858 @zhouyuan cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [VL] Results are mismatch with the vanilla Spark when cast(sum(decmial(20,4)), float) [incubator-gluten]

2024-03-11 Thread via GitHub
kecookier commented on issue #4891: URL: https://github.com/apache/incubator-gluten/issues/4891#issuecomment-1990135583 I've identified the error code, and I will submit a velox PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-4745][CH] support Sort Merge Join [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4812: URL: https://github.com/apache/incubator-gluten/pull/4812#issuecomment-1990121047 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] parquet file metadata columns support in velox [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3870: URL: https://github.com/apache/incubator-gluten/pull/3870#issuecomment-1990046048 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] parquet file metadata columns support in velox [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3870: URL: https://github.com/apache/incubator-gluten/pull/3870#issuecomment-1990049174 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4926][CELEBORN] `CelebornShuffleManager` should remove `shuffleId` from `columnarShuffleIds` after unregistering shuffle [incubator-gluten]

2024-03-11 Thread via GitHub
ulysses-you commented on PR #4927: URL: https://github.com/apache/incubator-gluten/pull/4927#issuecomment-1990018161 lgtm if tests pass cc @kerwin-zk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4903][CELEBORN][WIP] Support multiple versions of Celeborn [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1989979983 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4926][CELEBORN] `CelebornShuffleManager` should remove `shuffleId` from `columnarShuffleIds` after unregistering shuffle [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4927: URL: https://github.com/apache/incubator-gluten/pull/4927#issuecomment-1989977981 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4926][CELEBORN] `CelebornShuffleManager` should remove `shuffleId` from `columnarShuffleIds` after unregistering shuffle [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4927: URL: https://github.com/apache/incubator-gluten/pull/4927#issuecomment-1989977158 https://github.com/apache/incubator-gluten/issues/4926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4926][CELEBORN] `CelebornShuffleManager` should remove `shuffleId` from `columnarShuffleIds` after unregistering shuffle [incubator-gluten]

2024-03-11 Thread via GitHub
SteNicholas opened a new pull request, #4927: URL: https://github.com/apache/incubator-gluten/pull/4927 ## What changes were proposed in this pull request? `CelebornShuffleManager` removes `shuffleId` from `columnarShuffleIds` after unregistering shuffle. Fixes: #4926

Re: [PR] [GLUTEN-4903][CELEBORN][WIP] Support multiple versions of Celeborn [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1989968373 https://github.com/apache/incubator-gluten/issues/4903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] CelebornShuffleManager should remove shuffleId from columnarShuffleIds after unregistering shuffle [incubator-gluten]

2024-03-11 Thread via GitHub
SteNicholas opened a new issue, #4926: URL: https://github.com/apache/incubator-gluten/issues/4926 ### Backend VL (Velox) ### Bug description `CelebornShuffleManager` should remove `shuffleId` from `columnarShuffleIds` after unregistering shuffle to avoid unnecessary

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-1989951371 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten-site) branch main updated: change publish to main (#3)

2024-03-11 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new ba15580 change publish to main

Re: [PR] change publish to main [incubator-gluten-site]

2024-03-11 Thread via GitHub
weiting-chen merged PR #3: URL: https://github.com/apache/incubator-gluten-site/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] change publish to main [incubator-gluten-site]

2024-03-11 Thread via GitHub
weiting-chen opened a new pull request, #3: URL: https://github.com/apache/incubator-gluten-site/pull/3 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Gluten-4912][CH]Support Specifying columns in clickhouse tables to b… [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4925: URL: https://github.com/apache/incubator-gluten/pull/4925#issuecomment-1989917287 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [Gluten-4912][CH]Support Specifying columns in clickhouse tables to b… [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4925: URL: https://github.com/apache/incubator-gluten/pull/4925#issuecomment-1989918008 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… [incubator-gluten]

2024-03-11 Thread via GitHub
binmahone commented on PR #4708: URL: https://github.com/apache/incubator-gluten/pull/4708#issuecomment-1989890144 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4708: URL: https://github.com/apache/incubator-gluten/pull/4708#issuecomment-1989889873 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten-site) branch main updated: add github page setting (#2)

2024-03-11 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new 8247e18 add github page

Re: [PR] add github page setting [incubator-gluten-site]

2024-03-11 Thread via GitHub
weiting-chen merged PR #2: URL: https://github.com/apache/incubator-gluten-site/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] add github page setting [incubator-gluten-site]

2024-03-11 Thread via GitHub
weiting-chen opened a new pull request, #2: URL: https://github.com/apache/incubator-gluten-site/pull/2 Add github page setting in .asf.yaml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#issuecomment-1989850599 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten-site) 01/01: Merge pull request #1 from weiting-chen/update_for_apache

2024-03-11 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git commit 0633718a2275072bba670c4715673c574c4785f2 Merge: a2f1263 6fcb17e Author: Wei-Ting Chen AuthorDate: Tue

(incubator-gluten-site) branch main updated (a2f1263 -> 0633718)

2024-03-11 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git from a2f1263 update docs add 6fcb17e Update NOTICE and modify yaml for apache new 0633718

Re: [PR] Update NOTICE and modify yaml for apache [incubator-gluten-site]

2024-03-11 Thread via GitHub
weiting-chen merged PR #1: URL: https://github.com/apache/incubator-gluten-site/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update NOTICE and modify yaml for apache [incubator-gluten-site]

2024-03-11 Thread via GitHub
weiting-chen opened a new pull request, #1: URL: https://github.com/apache/incubator-gluten-site/pull/1 Update NOTICE and Modify YAML File for Apache website setup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-11 Thread via GitHub
kerwin-zk commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1989803372 > Is it possible to use one module to be compatible with multi-version celeborn ? It is hard to maintain if we always create new module for new coming celeborn version.

Re: [I] SPARK 3.4.1 master --yarn on EMR fails with java.lang.ClassNotFoundException: org.apache.spark.shuffle.sort.ColumnarShuffleManager [incubator-gluten]

2024-03-11 Thread via GitHub
sagarlakshmipathy commented on issue #4924: URL: https://github.com/apache/incubator-gluten/issues/4924#issuecomment-1989783821 Just to add, Spark 3.2 (both v1.1.1 and v1.1.0) fails as well. ` ./spark-3.2.4-bin-hadoop3.2/bin/spark-shell --master yarn --deploy-mode client

Re: [PR] [GLUTEN-4796][VL] Add orc char type validation [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1989782070 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix wrong plan equality due to case class inheritance [incubator-gluten]

2024-03-11 Thread via GitHub
zhztheplayer commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1989773812 > Thank you @zhztheplayer for the improvement. I'm wondering why we need to make our transformer plan inherit spark operator. Is there any history reason ? Yes it

Re: [I] Website not accessible? [incubator-gluten]

2024-03-11 Thread via GitHub
weiting-chen commented on issue #4921: URL: https://github.com/apache/incubator-gluten/issues/4921#issuecomment-1989773247 I am working on the new website setup, will fix it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CH][DOC] update shell script of Part-'clone Kyligence/ClickHouse repo' & … [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #4353: [CH][DOC] update shell script of Part-'clone Kyligence/ClickHouse repo' & … URL: https://github.com/apache/incubator-gluten/pull/4353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [CH][DOC] update shell script of Part-'clone Kyligence/ClickHouse repo' & … [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4353: URL: https://github.com/apache/incubator-gluten/pull/4353#issuecomment-1989763051 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240116) [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4408: URL: https://github.com/apache/incubator-gluten/pull/4408#issuecomment-1989763033 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240116) [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #4408: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240116) URL: https://github.com/apache/incubator-gluten/pull/4408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240117) [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #4423: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240117) URL: https://github.com/apache/incubator-gluten/pull/4423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240117) [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4423: URL: https://github.com/apache/incubator-gluten/pull/4423#issuecomment-1989762997 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-11 Thread via GitHub
ulysses-you commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1989759258 Is it possible to use one module to be compatible with multi-version celeborn ? It is hard to maintain if we always create new module for new coming celeborn version.

Re: [PR] [VL] Fix wrong plan equality due to case class inheritance [incubator-gluten]

2024-03-11 Thread via GitHub
ulysses-you commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1989741712 Thank you @zhztheplayer for the improvement. I'm wondering why we need to make our transformer plan inherit spark operator. Is there any history reason ? Is it

Re: [I] Website not accessible? [incubator-gluten]

2024-03-11 Thread via GitHub
PHILO-HE commented on issue #4921: URL: https://github.com/apache/incubator-gluten/issues/4921#issuecomment-1989740499 Thanks for your feedback! @weiting-chen, could you help fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [CH] support CTAS for clickhouse table [incubator-gluten]

2024-03-11 Thread via GitHub
zzcclp closed issue #4918: [CH] support CTAS for clickhouse table URL: https://github.com/apache/incubator-gluten/issues/4918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Gluten-4918][CH]support CTAS for clickhouse table [incubator-gluten]

2024-03-11 Thread via GitHub
zzcclp merged PR #4919: URL: https://github.com/apache/incubator-gluten/pull/4919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4484] [CH] support native write csv file [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4846: URL: https://github.com/apache/incubator-gluten/pull/4846#issuecomment-1989726817 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… [incubator-gluten]

2024-03-11 Thread via GitHub
zzcclp commented on code in PR #4708: URL: https://github.com/apache/incubator-gluten/pull/4708#discussion_r1520657117 ## backends-clickhouse/src/main/scala/io/glutenproject/execution/CHHashAggregateExecTransformer.scala: ## @@ -428,15 +434,20 @@ case class

Re: [PR] [VL] Fix wrong plan equality due to case class inheritance [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1989723857 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… [incubator-gluten]

2024-03-11 Thread via GitHub
zzcclp commented on code in PR #4708: URL: https://github.com/apache/incubator-gluten/pull/4708#discussion_r1520656005 ## backends-clickhouse/src/main/scala/io/glutenproject/execution/CHHashAggregateExecTransformer.scala: ## @@ -428,15 +434,20 @@ case class

[I] SPARK 3.4.1 master --yarn on EMR fails with java.lang.ClassNotFoundException: org.apache.spark.shuffle.sort.ColumnarShuffleManager [incubator-gluten]

2024-03-11 Thread via GitHub
sagarlakshmipathy opened a new issue, #4924: URL: https://github.com/apache/incubator-gluten/issues/4924 ### Backend VL (Velox) ### Bug description [Expected behavior]: spark-shell to successfully start [actual behavior]: java.lang.ClassNotFoundException:

Re: [PR] [VL] Fix protobuf configure arguments in get_velox.sh [incubator-gluten]

2024-03-11 Thread via GitHub
GlutenPerfBot commented on PR #4920: URL: https://github.com/apache/incubator-gluten/pull/4920#issuecomment-1989679375 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] Can't start the spark-shell with Gluten/Velox [incubator-gluten]

2024-03-11 Thread via GitHub
zhouyuan commented on issue #4909: URL: https://github.com/apache/incubator-gluten/issues/4909#issuecomment-1989675740 @sagarlakshmipathy great to know, feel free to circle back if there are any other issues. thanks, -yuan -- This is an automated message from the Apache Git

Re: [PR] [VL]Bucket join support for Iceberg tables [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4859: URL: https://github.com/apache/incubator-gluten/pull/4859#issuecomment-1989673061 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_12) [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4923: URL: https://github.com/apache/incubator-gluten/pull/4923#issuecomment-1989671925 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_03_12) [incubator-gluten]

2024-03-11 Thread via GitHub
GlutenPerfBot opened a new pull request, #4923: URL: https://github.com/apache/incubator-gluten/pull/4923 Velox Upstream New Commits: ```txt af49aa528 by Krishna Pai, Add better messaging for bad dates in DateTimeFormatter (8923) 17f0ed844 by joey.ljy, Add skewness Spark agg

Re: [PR] [VL]Bucket join support for Iceberg tables [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4859: URL: https://github.com/apache/incubator-gluten/pull/4859#issuecomment-1989614546 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240312) [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4922: URL: https://github.com/apache/incubator-gluten/pull/4922#issuecomment-1989610431 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240312) [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4922: URL: https://github.com/apache/incubator-gluten/pull/4922#issuecomment-1989610125 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240312) [incubator-gluten]

2024-03-11 Thread via GitHub
lwz9103 opened a new pull request, #4922: URL: https://github.com/apache/incubator-gluten/pull/4922 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Can't start the spark-shell with Gluten/Velox [incubator-gluten]

2024-03-11 Thread via GitHub
sagarlakshmipathy closed issue #4909: Can't start the spark-shell with Gluten/Velox URL: https://github.com/apache/incubator-gluten/issues/4909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Can't start the spark-shell with Gluten/Velox [incubator-gluten]

2024-03-11 Thread via GitHub
sagarlakshmipathy commented on issue #4909: URL: https://github.com/apache/incubator-gluten/issues/4909#issuecomment-1989484397 thanks @zhouyuan Can confirm this worked on ubuntu 22.04 ``` $SPARK_HOME/bin/spark-shell --jars

Re: [PR] [VL]Bucket join support for Iceberg tables [incubator-gluten]

2024-03-11 Thread via GitHub
SinghAsDev commented on PR #4859: URL: https://github.com/apache/incubator-gluten/pull/4859#issuecomment-1989449985 > Actually, we have made support for Spark3.5 even w/o UTs added. Can you also help apply the shim layer change against this version? Hi @yma11 is it ok if I handle

Re: [PR] [VL]Bucket join support for Iceberg tables [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4859: URL: https://github.com/apache/incubator-gluten/pull/4859#issuecomment-1989447960 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL]Bucket join support for Iceberg tables [incubator-gluten]

2024-03-11 Thread via GitHub
SinghAsDev commented on code in PR #4859: URL: https://github.com/apache/incubator-gluten/pull/4859#discussion_r1520432612 ## shims/spark34/src/main/scala/io/glutenproject/sql/shims/spark34/Spark34Shims.scala: ## @@ -252,4 +254,45 @@ class Spark34Shims extends SparkShims {

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1989078326 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4796][VL] Add orc char type validation [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1989078003 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1989050788 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4796][VL] Add orc char type validation [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1989047443 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] parquet file metadata columns support in velox [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3870: URL: https://github.com/apache/incubator-gluten/pull/3870#issuecomment-1988949586 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] parquet file metadata columns support in velox [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3870: URL: https://github.com/apache/incubator-gluten/pull/3870#issuecomment-1988851240 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] parquet file metadata columns support in velox [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3870: URL: https://github.com/apache/incubator-gluten/pull/3870#issuecomment-1988664197 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] parquet file metadata columns support in velox [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3870: URL: https://github.com/apache/incubator-gluten/pull/3870#issuecomment-1988662251 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support lead window function [incubator-gluten]

2024-03-11 Thread via GitHub
GlutenPerfBot commented on PR #4902: URL: https://github.com/apache/incubator-gluten/pull/4902#issuecomment-1988616995 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1988610440 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Gluten-4706] [CH][CORE] Add a mode to execute count distinct directly instead o… [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4708: URL: https://github.com/apache/incubator-gluten/pull/4708#issuecomment-1988606038 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support posexplode function and code refactoring on GenerateExecTransformer [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4901: URL: https://github.com/apache/incubator-gluten/pull/4901#issuecomment-1988556688 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated (92ca76d22 -> 5d923bf29)

2024-03-11 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 92ca76d22 [VL] Support lead window function (#4902) add 5d923bf29 [VL] Fix protobuf configure arguments

Re: [PR] [VL] Fix protobuf configure arguments in get_velox.sh [incubator-gluten]

2024-03-11 Thread via GitHub
PHILO-HE merged PR #4920: URL: https://github.com/apache/incubator-gluten/pull/4920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#issuecomment-1988492947 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix protobuf configure arguments in get_velox.sh [incubator-gluten]

2024-03-11 Thread via GitHub
liujiayi771 commented on PR #4920: URL: https://github.com/apache/incubator-gluten/pull/4920#issuecomment-1988490423 cc @PHILO-HE, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [DOC] Update release & configuration doc [incubator-gluten]

2024-03-11 Thread via GitHub
GlutenPerfBot commented on PR #4910: URL: https://github.com/apache/incubator-gluten/pull/4910#issuecomment-1988488592 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] parquet file metadata columns support in velox [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #3870: URL: https://github.com/apache/incubator-gluten/pull/3870#issuecomment-1988477007 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix protobuf configure arguments in get_velox.sh [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4920: URL: https://github.com/apache/incubator-gluten/pull/4920#issuecomment-1988422187 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix protobuf configure arguments in get_velox.sh [incubator-gluten]

2024-03-11 Thread via GitHub
liujiayi771 opened a new pull request, #4920: URL: https://github.com/apache/incubator-gluten/pull/4920 ## What changes were proposed in this pull request? Velox already has install_protobuf in

  1   2   >