Re: [PR] [GLUTEN-5041][CH] Fix primary not used when query with filter [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5045: URL: https://github.com/apache/incubator-gluten/pull/5045#issuecomment-2008706140 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5041][CH] Fix primary not used when query with filter [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5045: URL: https://github.com/apache/incubator-gluten/pull/5045#issuecomment-2008704310 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5041][CH] Fix primary not used when query with filter [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5045: URL: https://github.com/apache/incubator-gluten/pull/5045#issuecomment-2008704127 https://github.com/apache/incubator-gluten/issues/5041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5041][CH] Fix primary not used when query with filter [incubator-gluten]

2024-03-19 Thread via GitHub
loneylee opened a new pull request, #5045: URL: https://github.com/apache/incubator-gluten/pull/5045 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) (Fixes: \#5041) ## How was this patch tested? Test by ut --

Re: [PR] [CORE] Catch more specific exceptions in Gluten plan validation [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE commented on PR #5036: URL: https://github.com/apache/incubator-gluten/pull/5036#issuecomment-2008703728 @rui-mo, do you have any comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531532126 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [CORE] Catch more specific exceptions in Gluten plan validation [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE commented on code in PR #5036: URL: https://github.com/apache/incubator-gluten/pull/5036#discussion_r1531531449 ## gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala: ## @@ -83,6 +83,9 @@ object ExpressionConverter extends SQLConfHelper

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531529571 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

[I] [VL] [incubator-gluten]

2024-03-19 Thread via GitHub
xumingming opened a new issue, #5044: URL: https://github.com/apache/incubator-gluten/issues/5044 ### Backend VL (Velox) ### Bug description ```scala scala> var df = spark.read.csv("/tmp/test.csv"); E20240320 13:21:15.767925 16464018 Exceptions.h:69] Line:

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008652742 @WangGuangxin Perhaps we could create an issue in the upstream Velox community to remove this verification. -- This is an automated message from the Apache Git Service.

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [GLUTEN-4999] Fix ColumnarUnionExec to get PartitionerAwareUnionRDD used if child RDDs share same partitioner [incubator-gluten]

2024-03-19 Thread via GitHub
Yohahaha merged PR #5021: URL: https://github.com/apache/incubator-gluten/pull/5021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] In ColumnarUnionExec, it would be better to be transformed to PartitionerAwareUnionRDD than UnionRDD when they has same partitioner. [incubator-gluten]

2024-03-19 Thread via GitHub
Yohahaha closed issue #4999: In ColumnarUnionExec, it would be better to be transformed to PartitionerAwareUnionRDD than UnionRDD when they has same partitioner. URL: https://github.com/apache/incubator-gluten/issues/4999 -- This is an automated message from the Apache Git Service. To

(incubator-gluten) branch main updated: [GLUTEN-4999] Fix ColumnarUnionExec to get PartitionerAwareUnionRDD used if child RDDs share same partitioner (#5021)

2024-03-19 Thread yangzy
This is an automated email from the ASF dual-hosted git repository. yangzy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new c85db55d5 [GLUTEN-4999] Fix

Re: [PR] [CH][WIP] Refactor: Remove headers [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5043: URL: https://github.com/apache/incubator-gluten/pull/5043#issuecomment-2008639617 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH][WIP] Refactor: Remove headers [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5043: URL: https://github.com/apache/incubator-gluten/pull/5043#issuecomment-2008639473 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
zhztheplayer commented on code in PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#discussion_r1531488552 ## backends-velox/src/test/scala/io/glutenproject/execution/TestOperator.scala: ## @@ -1233,4 +1233,12 @@ class TestOperator extends

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2008631878 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2008631686 https://github.com/apache/incubator-gluten/issues/5016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-19 Thread via GitHub
lwz9103 opened a new pull request, #5042: URL: https://github.com/apache/incubator-gluten/pull/5042 ## What changes were proposed in this pull request? (Fixes: \#5016) ## How was this patch tested? unit tests -- This is an automated message from the Apache Git

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531484022 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531484022 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531482873 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531479331 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
zhztheplayer commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008617781 Thank you in advance! > I believe the change on Gluten side is ready now. Did that mean this PR can be merged prior to merging Velox changes? -- This is an

[I] [CH] Mergetree primary not used when query with filter [incubator-gluten]

2024-03-19 Thread via GitHub
loneylee opened a new issue, #5041: URL: https://github.com/apache/incubator-gluten/issues/5041 ### Backend CH (ClickHouse) ### Bug description Function `markRangesFromPKRange` will not filter with primary key. ### Spark version None ### Spark

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#issuecomment-2008612122 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] UnsupportedOperationException is abused [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE closed issue #2535: UnsupportedOperationException is abused URL: https://github.com/apache/incubator-gluten/issues/2535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5012: URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2008611432 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] UnsupportedOperationException is abused [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE commented on issue #2535: URL: https://github.com/apache/incubator-gluten/issues/2535#issuecomment-2008611386 Fixed by https://github.com/apache/incubator-gluten/pull/4996. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
taiyang-li commented on code in PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#discussion_r1531473966 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala: ## @@ -318,8 +318,9 @@ object BackendSettings extends

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#issuecomment-2008608607 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5040: URL: https://github.com/apache/incubator-gluten/pull/5040#issuecomment-2008605014 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5040: URL: https://github.com/apache/incubator-gluten/pull/5040#issuecomment-2008604863 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) [incubator-gluten]

2024-03-19 Thread via GitHub
lwz9103 opened a new pull request, #5040: URL: https://github.com/apache/incubator-gluten/pull/5040 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) [incubator-gluten]

2024-03-19 Thread via GitHub
lwz9103 closed pull request #5029: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) URL: https://github.com/apache/incubator-gluten/pull/5029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) [incubator-gluten]

2024-03-19 Thread via GitHub
lwz9103 commented on PR #5029: URL: https://github.com/apache/incubator-gluten/pull/5029#issuecomment-2008601121 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2008595501 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
rui-mo commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531463499 ## gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala: ## @@ -199,6 +199,10 @@ trait SparkPlanExecApi { throw new

(incubator-gluten) branch main updated: [CH][Build][Minor] Fix Build Due to Clickhouse refactor (#5034)

2024-03-19 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new d9a555dc3 [CH][Build][Minor] Fix Build

Re: [PR] [CH][Build][Minor] Fix Build Due to Clickhouse refactor [incubator-gluten]

2024-03-19 Thread via GitHub
baibaichen merged PR #5034: URL: https://github.com/apache/incubator-gluten/pull/5034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
zhli1142015 commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531459439 ## gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala: ## @@ -199,6 +199,10 @@ trait SparkPlanExecApi { throw new

[I] [VL] Support using AppleClang to build [incubator-gluten]

2024-03-19 Thread via GitHub
xumingming opened a new issue, #5039: URL: https://github.com/apache/incubator-gluten/issues/5039 ### Problem description Build command: ``` ./dev/buildbundle-veloxbe.sh --build_type=RelWithDebInfo ``` Error message: ``` CMake Error at CMakeLists.txt:106

Re: [PR] [GLUTEN-4899][VL]Fix 3.5 build issue with -Pspark-ut [incubator-gluten]

2024-03-19 Thread via GitHub
GlutenPerfBot commented on PR #4975: URL: https://github.com/apache/incubator-gluten/pull/4975#issuecomment-2008585412 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4956][CH] Fix parsing string with blank prefix/suffix to number [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5022: URL: https://github.com/apache/incubator-gluten/pull/5022#issuecomment-2008585247 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_20) [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5038: URL: https://github.com/apache/incubator-gluten/pull/5038#issuecomment-2008582595 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_03_20) [incubator-gluten]

2024-03-19 Thread via GitHub
yma11 opened a new pull request, #5038: URL: https://github.com/apache/incubator-gluten/pull/5038 Velox Upstream New Commits: ``` 0b4b6e84a by wypb, Add more test cases for cast(string as float) (#9148) 9c7eb6c17 by Masha Basmanova, Add support for DECIMAL types to Simple Function

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-03-19 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2008580619 > @FelixYBW Has this issue not been fixed by #4443 ? No, it's tested from main branch. A new issue -- This is an automated message from the Apache Git

Re: [PR] [VL] Fix regexp_replace function [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE commented on PR #4411: URL: https://github.com/apache/incubator-gluten/pull/4411#issuecomment-2008579251 As https://github.com/facebookincubator/velox/pull/8387 has been merged, we can land this pr. @marin-ma, do you have any other comment? Thanks! -- This is an automated

Re: [PR] [VL][MINOR] Refactor operator/function tests [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5037: URL: https://github.com/apache/incubator-gluten/pull/5037#issuecomment-2008576256 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][MINOR] Refactor operator/function tests [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE opened a new pull request, #5037: URL: https://github.com/apache/incubator-gluten/pull/5037 ## What changes were proposed in this pull request? ## How was this patch tested? Existing tests. -- This is an automated message from the Apache Git Service.

Re: [PR] [GLUTEN-5001][CORE] Support HiveGenericUDF when mapping to native function [incubator-gluten]

2024-03-19 Thread via GitHub
taiyang-li commented on PR #5002: URL: https://github.com/apache/incubator-gluten/pull/5002#issuecomment-2008575509 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Fix regexp_replace function [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #4411: URL: https://github.com/apache/incubator-gluten/pull/4411#issuecomment-2008574290 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4999]In ColumnarUnionExec, it would be better to be transformed to PartitionerAwareUnionRDD than UnionRDD when they has same partitioner [incubator-gluten]

2024-03-19 Thread via GitHub
Yohahaha commented on PR #5021: URL: https://github.com/apache/incubator-gluten/pull/5021#issuecomment-2008574020 thank you for this fix, I have verified Gluten's union rdd is same as Spark's after this pr. Spark

Re: [PR] [VL] Support lead/lag window function with negative input offset [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5026: URL: https://github.com/apache/incubator-gluten/pull/5026#issuecomment-2008573362 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-03-19 Thread via GitHub
ulysses-you commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2008571424 > 2. distinct hash agg + spill returned duplicated keys. @FelixYBW Has this issue not been fixed by https://github.com/apache/incubator-gluten/pull/4443 ? --

Re: [PR] [VL] Support lead/lag window function with negative input offset [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5026: URL: https://github.com/apache/incubator-gluten/pull/5026#issuecomment-2008571227 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Umbrella tracker for data mismatch issues [incubator-gluten]

2024-03-19 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2008565662 3 issues we met: 1. parquet scan + filter pushdown wrongly return "", should return null. Fixed by https://github.com/facebookincubator/velox/pull/9129 2.

Re: [PR] [GLUTEN-5001][CORE] Support HiveGenericUDF when mapping to native function [incubator-gluten]

2024-03-19 Thread via GitHub
WangGuangxin commented on code in PR #5002: URL: https://github.com/apache/incubator-gluten/pull/5002#discussion_r1531443419 ## gluten-core/src/main/scala/org/apache/spark/sql/hive/HiveUDFTransformer.scala: ## @@ -22,34 +22,37 @@ import

Re: [PR] [GLUTEN-5001][CORE] Support HiveGenericUDF when mapping to native function [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5002: URL: https://github.com/apache/incubator-gluten/pull/5002#issuecomment-2008564476 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5012: URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2008562573 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Is develop & build supported on MacOS(Apple Silicon)? [incubator-gluten]

2024-03-19 Thread via GitHub
xumingming commented on issue #5006: URL: https://github.com/apache/incubator-gluten/issues/5006#issuecomment-2008558976 @ulysses-you @PHILO-HE Thanks for the information. I have tried to build with `--enable_vcpkg=OFF`, and found a couple of issues, I will use this issue as the umbrella

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
WangGuangxin commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008557794 I believe the change on Gluten side is ready now. But the `ApproxPercentileAggregate` implements in velox has to make some minor modification, becasue when add

(incubator-gluten) branch main updated: [GLUTEN-4899][VL] Fix 3.5 build issue with -Pspark-ut (#4975)

2024-03-19 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 6514392ad [GLUTEN-4899][VL] Fix 3.5

Re: [PR] [VL] Update clang-format version to v4.11.0 for Velox backend [incubator-gluten]

2024-03-19 Thread via GitHub
GlutenPerfBot commented on PR #5035: URL: https://github.com/apache/incubator-gluten/pull/5035#issuecomment-2008554431 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Known issues against Gluten + Spark 3.5 [incubator-gluten]

2024-03-19 Thread via GitHub
ulysses-you closed issue #4899: [VL] Known issues against Gluten + Spark 3.5 URL: https://github.com/apache/incubator-gluten/issues/4899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-4899][VL]Fix 3.5 build issue with -Pspark-ut [incubator-gluten]

2024-03-19 Thread via GitHub
ulysses-you merged PR #4975: URL: https://github.com/apache/incubator-gluten/pull/4975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Fix regexp_replace function [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #4411: URL: https://github.com/apache/incubator-gluten/pull/4411#issuecomment-2008554006 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4917][VL] Refactor CI to build spark.test.home when running UTs [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-2008553757 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5001][CORE] Support HiveGenericUDF when mapping to native function [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE commented on code in PR #5002: URL: https://github.com/apache/incubator-gluten/pull/5002#discussion_r1531434409 ## gluten-core/src/main/scala/org/apache/spark/sql/hive/HiveUDFTransformer.scala: ## @@ -22,34 +22,37 @@ import org.apache.spark.sql.catalyst.expressions._

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
ulysses-you commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531433566 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531430562 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +662,81 @@ class SparkPlanExecApiImpl extends

(incubator-gluten) branch main updated: [GLUTEN-5009][CH] Fix TPCDS q9 failed with debug build (#5015)

2024-03-19 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 8dbca6cfe [GLUTEN-5009][CH] Fix TPCDS

Re: [I] [CH][UT] TPCDS q9 failed with Debug Build [incubator-gluten]

2024-03-19 Thread via GitHub
baibaichen closed issue #5009: [CH][UT] TPCDS q9 failed with Debug Build URL: https://github.com/apache/incubator-gluten/issues/5009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5009][CH] Fix TPCDS q9 failed with debug build [incubator-gluten]

2024-03-19 Thread via GitHub
baibaichen merged PR #5015: URL: https://github.com/apache/incubator-gluten/pull/5015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531426021 ## backends-clickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala: ## @@ -750,4 +750,8 @@ class CHSparkPlanExecApi

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
marin-ma commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531422585 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-19 Thread via GitHub
rui-mo commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531417665 ## gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala: ## @@ -199,6 +199,10 @@ trait SparkPlanExecApi { throw new

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

2024-03-19 Thread via GitHub
zhouyuan commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2008478357 CC: @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-19 Thread via GitHub
ulysses-you commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531399817 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

Re: [PR] [CORE] Catch more specific exceptions in Gluten plan validation [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5036: URL: https://github.com/apache/incubator-gluten/pull/5036#issuecomment-2008476283 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Catch more specific exceptions in Gluten plan validation [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5036: URL: https://github.com/apache/incubator-gluten/pull/5036#issuecomment-2008476152 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Catch more specific exceptions in Gluten plan validation [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE opened a new pull request, #5036: URL: https://github.com/apache/incubator-gluten/pull/5036 ## What changes were proposed in this pull request? This is a follow-up to throw/catch GlutenNotSupportException in plan validation. ## How was this patch tested?

(incubator-gluten) branch main updated: [VL] Update clang-format version to v4.11.0 for Velox backend (#5035)

2024-03-19 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 01cce51dd [VL] Update clang-format

Re: [PR] [VL] Update clang-format version to v4.11.0 for Velox backend [incubator-gluten]

2024-03-19 Thread via GitHub
zhouyuan merged PR #5035: URL: https://github.com/apache/incubator-gluten/pull/5035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5029: URL: https://github.com/apache/incubator-gluten/pull/5029#issuecomment-2008436853 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH][Build][Minor] Fix Build Due to Clickhouse refactor [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5034: URL: https://github.com/apache/incubator-gluten/pull/5034#issuecomment-2008429778 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Update clang-format version to v4.11.0 for Velox backend [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5035: URL: https://github.com/apache/incubator-gluten/pull/5035#issuecomment-2008414459 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [CH]Improve parquet reader performacne [incubator-gluten]

2024-03-19 Thread via GitHub
baibaichen closed issue #3582: [CH]Improve parquet reader performacne URL: https://github.com/apache/incubator-gluten/issues/3582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-3582] Support PageIndex [incubator-gluten]

2024-03-19 Thread via GitHub
baibaichen merged PR #4634: URL: https://github.com/apache/incubator-gluten/pull/4634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-3582] Support PageIndex [incubator-gluten]

2024-03-19 Thread via GitHub
baibaichen commented on PR #4634: URL: https://github.com/apache/incubator-gluten/pull/4634#issuecomment-2008404671 Let's Merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-3582] Support PageIndex [incubator-gluten]

2024-03-19 Thread via GitHub
baibaichen commented on PR #4634: URL: https://github.com/apache/incubator-gluten/pull/4634#issuecomment-2008404192 | | GlutenWithCHStandard tpch-data-sf100-bucket | | | -- | | With 4634| [mean-total 60332,

Re: [PR] [GLUTEN-3582] Support PageIndex [incubator-gluten]

2024-03-19 Thread via GitHub
lgbo-ustc commented on PR #4634: URL: https://github.com/apache/incubator-gluten/pull/4634#issuecomment-2008397664 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Update clang-format version to v4.11.0 for Velox backend [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5035: URL: https://github.com/apache/incubator-gluten/pull/5035#issuecomment-2008396473 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Update clang-format version to v4.11.0 for Velox backend [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5035: URL: https://github.com/apache/incubator-gluten/pull/5035#issuecomment-2008396292 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Update clang-format version to v4.11.0 for Velox backend [incubator-gluten]

2024-03-19 Thread via GitHub
yma11 opened a new pull request, #5035: URL: https://github.com/apache/incubator-gluten/pull/5035 ## What changes were proposed in this pull request? jidicula/clang-format-action@v3.5.1 doesn't meet Apache criteria and will cause following error. So we upgrade to v4.11.0 which is

Re: [PR] [CH][Build]Fix Build Due to Clickhouse refactor [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5034: URL: https://github.com/apache/incubator-gluten/pull/5034#issuecomment-2008392507 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH][Build]Fix Build Due to Clickhouse refactor [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #5034: URL: https://github.com/apache/incubator-gluten/pull/5034#issuecomment-2008392206 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

  1   2   3   >