Re: [PR] [GLUTEN-4933][VL] Update iceberg version to 1.4.3 for Spark 3.4 and above [incubator-gluten]

2024-03-20 Thread via GitHub
zhouyuan merged PR #4967: URL: https://github.com/apache/incubator-gluten/pull/4967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-20 Thread via GitHub
WangGuangxin commented on code in PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#discussion_r1533084012 ## cpp/velox/substrait/VeloxSubstraitSignature.cc: ## @@ -159,16 +151,43 @@ TypePtr VeloxSubstraitSignature::fromSubstraitSignature(const std::string&

Re: [I] [CORE] Enhancement: Gluten Advanced Cost-based Query Optimization (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on issue #5057: URL: https://github.com/apache/incubator-gluten/issues/5057#issuecomment-2010952605 There is a runnable PoC for this. Will submit a PR ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4933][VL] Update iceberg version to 1.4.3 for Spark 3.4 and above [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4967: URL: https://github.com/apache/incubator-gluten/pull/4967#issuecomment-2010949742 https://github.com/apache/incubator-gluten/issues/4933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] Enhancement: Gluten Advanced Cost-based Query Optimization (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer opened a new issue, #5057: URL: https://github.com/apache/incubator-gluten/issues/5057 ### Description # Enhancement: Gluten Advanced Cost-based Query Optimization (Advanced CBO) ## Background Many of developers may already noticed that Apache Spark's

(incubator-gluten) branch main updated: [GLUTEN-5027][VL] Fail fast for unsupported compiler (#5030)

2024-03-20 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new cbaa49591 [GLUTEN-5027][VL] Fail fast

Re: [I] [VL] clang: error: the clang compiler does not support '-march=native' [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW closed issue #5027: [VL] clang: error: the clang compiler does not support '-march=native' URL: https://github.com/apache/incubator-gluten/issues/5027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5027][VL] Fail fast for unsupported compilers [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW merged PR #5030: URL: https://github.com/apache/incubator-gluten/pull/5030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [WIP] Upload build library [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5056: URL: https://github.com/apache/incubator-gluten/pull/5056#issuecomment-2010943665 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010942825 @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010942586 Thank you. It's something we just planed. Since build_velox is always needed, can you add one flag like -Dfetch_velox=ON/OFF which can fetch velox or not before build? by

Re: [PR] [WIP] Upload build library [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5056: URL: https://github.com/apache/incubator-gluten/pull/5056#issuecomment-2010918065 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Upload build library [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5056: URL: https://github.com/apache/incubator-gluten/pull/5056#issuecomment-2010917908 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2010912174 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] check ci apache jenkins [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2010883756 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240321) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5055: URL: https://github.com/apache/incubator-gluten/pull/5055#issuecomment-2010856058 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240321) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5055: URL: https://github.com/apache/incubator-gluten/pull/5055#issuecomment-2010856578 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240321) [incubator-gluten]

2024-03-20 Thread via GitHub
lwz9103 opened a new pull request, #5055: URL: https://github.com/apache/incubator-gluten/pull/5055 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [GLUTEN-5027][VL] Fail fast for unsupported compilers [incubator-gluten]

2024-03-20 Thread via GitHub
xumingming commented on PR #5030: URL: https://github.com/apache/incubator-gluten/pull/5030#issuecomment-2010853337 @FelixYBW Would you take a look at this one? Very simple but useful one I think. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-20 Thread via GitHub
xumingming commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010850789 @FelixYBW Would you take a look at this one? I think it saves time for build's debuging. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-5039][VL] Add support for AppleClang compiler [incubator-gluten]

2024-03-20 Thread via GitHub
xumingming commented on PR #5053: URL: https://github.com/apache/incubator-gluten/pull/5053#issuecomment-2010838877 @FelixYBW Velox support AppleClang at least, I think many Velox developers using macOS to develop Velox(including myself), it builds without issue. There are many macOS

Re: [I] [Doc] Fix typos in https://gluten.apache.org/developers/HowTo.html [incubator-gluten]

2024-03-20 Thread via GitHub
xumingming commented on issue #5051: URL: https://github.com/apache/incubator-gluten/issues/5051#issuecomment-2010828308 Closing it as https://github.com/apache/incubator-gluten/pull/5052 is merged. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [Doc] Fix typos in https://gluten.apache.org/developers/HowTo.html [incubator-gluten]

2024-03-20 Thread via GitHub
xumingming closed issue #5051: [Doc] Fix typos in https://gluten.apache.org/developers/HowTo.html URL: https://github.com/apache/incubator-gluten/issues/5051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]

2024-03-20 Thread via GitHub
GlutenPerfBot commented on PR #5012: URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2010672427 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2010595886 Can you also help to add input_file_name() function? It's very useful for debug purpose. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-5039][VL] Add support for AppleClang compiler [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW commented on PR #5053: URL: https://github.com/apache/incubator-gluten/pull/5053#issuecomment-2010593497 does velox support clang compiler? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [GLUTEN-5051][Core] Optimize document: HowTo.md [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW commented on PR #5052: URL: https://github.com/apache/incubator-gluten/pull/5052#issuecomment-2010592064 Good to update! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(incubator-gluten) branch main updated (e1f0c01a7 -> 1eac8be32)

2024-03-20 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from e1f0c01a7 [GLUTEN-4989][CH] Support function timestamp_add (#5012) add 1eac8be32 [GLUTEN-5051][Core]

Re: [PR] [GLUTEN-5051][Core] Optimize document: HowTo.md [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW merged PR #5052: URL: https://github.com/apache/incubator-gluten/pull/5052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Fix bug where session config is lost when benchmark is enabled [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5054: URL: https://github.com/apache/incubator-gluten/pull/5054#issuecomment-2010588944 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix bug where session config is lost when benchmark is enabled [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW opened a new pull request, #5054: URL: https://github.com/apache/incubator-gluten/pull/5054 It's a quick bug fix. unordered_map::merge removes the duplicated items from source. https://en.cppreference.com/w/cpp/container/unordered_map/merge -- This is an automated

Re: [I] [GLUTEN-4263][VL] Compression type 2 not supported [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW commented on issue #4263: URL: https://github.com/apache/incubator-gluten/issues/4263#issuecomment-2010577564 The root cause is that folly can't find lz4 library for some reason, but lz4 does be built in vcpkg and can be used by shuffle. You may bypass the issue using snappy/zstd

Re: [PR] [GLUTEN-5039][VL] Add support for AppleClang compiler [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5053: URL: https://github.com/apache/incubator-gluten/pull/5053#issuecomment-2009715036 https://github.com/apache/incubator-gluten/issues/5039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5051][Core] Optimize document: HowTo.md [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5052: URL: https://github.com/apache/incubator-gluten/pull/5052#issuecomment-2009704712 https://github.com/apache/incubator-gluten/issues/5051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5051][Core] Optimize document: HowTo.md [incubator-gluten]

2024-03-20 Thread via GitHub
xumingming opened a new pull request, #5052: URL: https://github.com/apache/incubator-gluten/pull/5052 1. Fixed some typos. 2. Changed `gluten_home` to `${GLUTEN_HOME}`, so the code in this doc is actually executable. 3. Some other polishing. -- This is an automated message from

Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]

2024-03-20 Thread via GitHub
zhli1142015 commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2009700175 Acked, let me check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] [Doc] Fix typos in https://gluten.apache.org/developers/HowTo.html [incubator-gluten]

2024-03-20 Thread via GitHub
xumingming opened a new issue, #5051: URL: https://github.com/apache/incubator-gluten/issues/5051 ### Description I was reading https://gluten.apache.org/developers/HowTo.html , I find there are some typos in it, would be great to fix them. -- This is an automated message from the

Re: [PR] [DNM][VL] check ci apache jenkins [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2009618119 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4956][CH] Fix parsing string with blank prefix/suffix to number [incubator-gluten]

2024-03-20 Thread via GitHub
taiyang-li commented on PR #5022: URL: https://github.com/apache/incubator-gluten/pull/5022#issuecomment-2009612231 @exmy could you help review it, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-4956][CH] Fix parsing string with blank prefix/suffix to number [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5022: URL: https://github.com/apache/incubator-gluten/pull/5022#issuecomment-2009610323 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] check ci apache jenkins [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2009608821 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] check ci apache jenkins [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2009590802 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#issuecomment-2009585811 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-20 Thread via GitHub
taiyang-li commented on PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#issuecomment-2009582338 velox build failed cc @rui-mo ![image](https://github.com/apache/incubator-gluten/assets/8181003/c7df63a1-0ae3-4928-bf46-5e304dda3b52) -- This is an automated

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
marin-ma commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2009516887 @liujiayi771 @ulysses-you Could you help to review again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2009516553 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2009497149 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-20 Thread via GitHub
summaryzb commented on code in PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#discussion_r1532020728 ## .github/workflows/velox_be.yml: ## @@ -441,7 +442,37 @@ jobs: run: | $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/exec.sh '

Re: [PR] [GLUTEN-5049][CH] Clean code in substring function parser and fix s3 building issue [incubator-gluten]

2024-03-20 Thread via GitHub
taiyang-li commented on PR #5050: URL: https://github.com/apache/incubator-gluten/pull/5050#issuecomment-2009433275 @KevinyhZou could you help review, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] [CH] Remove useless codes in substring function parser and fix s3 building issue [incubator-gluten]

2024-03-20 Thread via GitHub
taiyang-li opened a new issue, #5049: URL: https://github.com/apache/incubator-gluten/issues/5049 ### Description s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on code in PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#discussion_r1531988230 ## .github/workflows/velox_be.yml: ## @@ -441,7 +442,37 @@ jobs: run: | $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/exec.sh '

Re: [PR] [GLUTEN-5049][CH] Remove useless codes in substring function parser and fix s3 building issue [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5050: URL: https://github.com/apache/incubator-gluten/pull/5050#issuecomment-2009403511 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated (d762deb9b -> e1f0c01a7)

2024-03-20 Thread mahongbin
This is an automated email from the ASF dual-hosted git repository. mahongbin pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from d762deb9b [GLUTEN-5041][CH] Fix primary not used when query with filter (#5045) add e1f0c01a7

[PR] [GLUTEN-5049][CH] Remove useless codes in substring function parser and fix s3 building issue [incubator-gluten]

2024-03-20 Thread via GitHub
taiyang-li opened a new pull request, #5050: URL: https://github.com/apache/incubator-gluten/pull/5050 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) (Fixes: \#5049) -- This is an automated message from the Apache

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on code in PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#discussion_r1531988230 ## .github/workflows/velox_be.yml: ## @@ -441,7 +442,37 @@ jobs: run: | $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/exec.sh '

Re: [I] [CH] Support timestampadd on CH backend [incubator-gluten]

2024-03-20 Thread via GitHub
binmahone closed issue #4989: [CH] Support timestampadd on CH backend URL: https://github.com/apache/incubator-gluten/issues/4989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]

2024-03-20 Thread via GitHub
binmahone merged PR #5012: URL: https://github.com/apache/incubator-gluten/pull/5012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5049][CH] Remove useless codes in substring function parser and fix s3 building issue [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5050: URL: https://github.com/apache/incubator-gluten/pull/5050#issuecomment-2009403068 https://github.com/apache/incubator-gluten/issues/5049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4989][CH] Support function timestamp_add [incubator-gluten]

2024-03-20 Thread via GitHub
binmahone commented on PR #5012: URL: https://github.com/apache/incubator-gluten/pull/5012#issuecomment-2009442820 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2009319762 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-20 Thread via GitHub
taiyang-li commented on code in PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#discussion_r1531965401 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala: ## @@ -318,8 +318,9 @@ object BackendSettings extends

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2009415207 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#issuecomment-2009410210 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL ] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]

2024-03-20 Thread via GitHub
gaoyangxiaozhu commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2009403778 @zhli1142015 current `monotonically_increasing_id` implement causes inconsistent behavior vs vinalla spark. looks in velox we always use one function instance when

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
lwz9103 commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2009316145 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(incubator-gluten) branch main updated: [GLUTEN-5041][CH] Fix primary not used when query with filter (#5045)

2024-03-20 Thread zhangzc
This is an automated email from the ASF dual-hosted git repository. zhangzc pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new d762deb9b [GLUTEN-5041][CH] Fix primary

Re: [PR] [GLUTEN-4993][CH] Support mergetree on object storage [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4992: URL: https://github.com/apache/incubator-gluten/pull/4992#issuecomment-2009215723 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_20) [incubator-gluten]

2024-03-20 Thread via GitHub
GlutenPerfBot commented on PR #5038: URL: https://github.com/apache/incubator-gluten/pull/5038#issuecomment-2009257840 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5020][VL] Add sudo for macOS related commands [incubator-gluten]

2024-03-20 Thread via GitHub
GlutenPerfBot commented on PR #5031: URL: https://github.com/apache/incubator-gluten/pull/5031#issuecomment-2009155077 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Enable url_decode function for spark 3.4+ [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on issue #3411: URL: https://github.com/apache/incubator-gluten/issues/3411#issuecomment-2009118891 No one is doing it. Yes, you can pick this work. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [GLUTEN-5041][CH] Fix primary not used when query with filter [incubator-gluten]

2024-03-20 Thread via GitHub
zzcclp merged PR #5045: URL: https://github.com/apache/incubator-gluten/pull/5045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2009198447 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [CH] Mergetree primary not used when query with filter [incubator-gluten]

2024-03-20 Thread via GitHub
zzcclp closed issue #5041: [CH] Mergetree primary not used when query with filter URL: https://github.com/apache/incubator-gluten/issues/5041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2009122140 I'll have a check to see if we can solve the issue without reverting. The change was important somehow. Thanks. -- This is an automated message from the Apache Git

Re: [I] [VL] Enable url_decode function for spark 3.4+ [incubator-gluten]

2024-03-20 Thread via GitHub
gaoyangxiaozhu commented on issue #3411: URL: https://github.com/apache/incubator-gluten/issues/3411#issuecomment-2009107293 @PHILO-HE any one pick this work ,if not i will do ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2009094966 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-20 Thread via GitHub
rui-mo commented on code in PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#discussion_r1531725452 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala: ## @@ -318,8 +318,9 @@ object BackendSettings extends

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_03_20) (#5038)

2024-03-20 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 7ad6b3fb3 [VL] Daily Update Velox Version

Re: [PR] [VL] Daily Update Velox Version (2024_03_20) [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE merged PR #5038: URL: https://github.com/apache/incubator-gluten/pull/5038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-20 Thread via GitHub
zhli1142015 commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531700862 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -129,6 +129,13 @@ class SparkPlanExecApiImpl extends

Re: [I] [VL] INSTALL xsimd: Permission denied [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE closed issue #5020: [VL] INSTALL xsimd: Permission denied URL: https://github.com/apache/incubator-gluten/issues/5020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(incubator-gluten) branch main updated: [GLUTEN-5020][VL] Add sudo for macOS related commands (#5031)

2024-03-20 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 044f46aab [GLUTEN-5020][VL] Add sudo for

Re: [PR] [GLUTEN-5020][VL] Add sudo for macOS related commands [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE merged PR #5031: URL: https://github.com/apache/incubator-gluten/pull/5031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2009058696 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5041][CH] Fix primary not used when query with filter [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5045: URL: https://github.com/apache/incubator-gluten/pull/5045#issuecomment-2009054774 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5041][CH] Fix primary not used when query with filter [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5045: URL: https://github.com/apache/incubator-gluten/pull/5045#issuecomment-2009039446 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] support uuid function [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on code in PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#discussion_r1531682348 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -129,6 +129,13 @@ class SparkPlanExecApiImpl extends

(incubator-gluten) branch main updated: [VL] Support lead/lag window function with negative input offset (#5026)

2024-03-20 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 70ceb5075 [VL] Support lead/lag window

Re: [PR] [VL] Support lead/lag window function with negative input offset [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE merged PR #5026: URL: https://github.com/apache/incubator-gluten/pull/5026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2009013231 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2009012977 https://github.com/apache/incubator-gluten/issues/4946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
loudongfeng opened a new pull request, #5048: URL: https://github.com/apache/incubator-gluten/pull/5048 ## What changes were proposed in this pull request? cast avg input type to double when type is integer types: bigint/int/short... Fixes: \#4946 ## How was this patch

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531653906 ## gluten-core/src/main/scala/io/glutenproject/utils/PullOutProjectHelper.scala: ## @@ -57,12 +57,13 @@ trait PullOutProjectHelper { protected def

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
liujiayi771 commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531653906 ## gluten-core/src/main/scala/io/glutenproject/utils/PullOutProjectHelper.scala: ## @@ -57,12 +57,13 @@ trait PullOutProjectHelper { protected def

Re: [PR] [VL] Support regexp_replace function with position argument [incubator-gluten]

2024-03-20 Thread via GitHub
GlutenPerfBot commented on PR #4411: URL: https://github.com/apache/incubator-gluten/pull/4411#issuecomment-2008995604 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Row Index Metadata Column support for Parquet Scan [incubator-gluten]

2024-03-20 Thread via GitHub
gaoyangxiaozhu commented on issue #5047: URL: https://github.com/apache/incubator-gluten/issues/5047#issuecomment-2008987418 I would send PR to address -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [VL] Row Index Metadata Column support for Parquet Scan [incubator-gluten]

2024-03-20 Thread via GitHub
gaoyangxiaozhu opened a new issue, #5047: URL: https://github.com/apache/incubator-gluten/issues/5047 ### Description this issue use to track support row index metadata column support for parquet scan in velox backend. The dependency issue in Velox is

Re: [PR] [VL ] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2008984659 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-4993][CH] Support mergetree on object storage [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4992: URL: https://github.com/apache/incubator-gluten/pull/4992#issuecomment-2008976800 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
ulysses-you commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1531615518 ## gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformerBase.scala: ## @@ -26,11 +26,28 @@ import

<    1   2   3   >