[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client

2020-02-23 Thread GitBox
yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383117457 ## File path: hudi-client/src/test/java/org/apache/hudi/client/TestHoodieClientBase.java

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client

2020-02-23 Thread GitBox
yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383116984 ## File path: hudi-client/src/test/java/org/apache/hudi/TestUpdateSchemaEvolution.java ##

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client

2020-02-23 Thread GitBox
yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383115191 ## File path: hudi-client/src/main/java/org/apache/hudi/table/rollback/RollbackExecutor.java

[GitHub] [incubator-hudi] apoorva007 commented on issue #143: Tracking ticket for folks to be added to slack group

2020-02-23 Thread GitBox
apoorva007 commented on issue #143: Tracking ticket for folks to be added to slack group URL: https://github.com/apache/incubator-hudi/issues/143#issuecomment-590172680 Please add me : apoorva.aggar...@grofers.com This is an

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #198

2020-02-23 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.25 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/boot: plexus-classworlds-2.5.2.jar

[jira] [Updated] (HUDI-581) NOTICE need more work as it missing content form included 3rd party ALv2 licensed NOTICE files

2020-02-23 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated HUDI-581: -- Priority: Blocker (was: Major) > NOTICE need more work as it missing content form included 3rd party ALv2 >

[jira] [Updated] (HUDI-289) Implement a test suite to support long running test for Hudi writing and querying end-end

2020-02-23 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated HUDI-289: -- Fix Version/s: (was: 0.5.2) 0.6.0 > Implement a test suite to support long running test

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo

2020-02-23 Thread GitBox
lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590142768 This is a great start.  IMO, because we already set InstantiatorStrategy, so we needn't

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1342: [SUPPORT] do cow tables need to be converted when changing from hoodie to hudi?

2020-02-23 Thread GitBox
lamber-ken edited a comment on issue #1342: [SUPPORT] do cow tables need to be converted when changing from hoodie to hudi? URL: https://github.com/apache/incubator-hudi/issues/1342#issuecomment-588567557 hi @tooptoop4, I test it in my local env. No need to run any convert utility.

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo

2020-02-23 Thread GitBox
lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590142768 This is a great start.  IMO, because we already set InstantiatorStrategy, so we needn't

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043117#comment-17043117 ] lamber-ken edited comment on HUDI-625 at 2/24/20 2:01 AM: -- The key issue is

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043117#comment-17043117 ] lamber-ken edited comment on HUDI-625 at 2/24/20 1:58 AM: -- The key issue is

[jira] [Comment Edited] (HUDI-603) HoodieDeltaStreamer should periodically fetch table schema update

2020-02-23 Thread Yixue (Andrew) Zhu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043016#comment-17043016 ] Yixue (Andrew) Zhu edited comment on HUDI-603 at 2/24/20 1:40 AM: -- I am

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo

2020-02-23 Thread GitBox
lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590142768 This is a great start. IMO, because we already set InstantiatorStrategy, so we needn't

[GitHub] [incubator-hudi] lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo

2020-02-23 Thread GitBox
lamber-ken commented on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590142768 Because we already set InstantiatorStrategy, so we needn't register class agian.

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043117#comment-17043117 ] lamber-ken edited comment on HUDI-625 at 2/24/20 1:32 AM: -- The key issue is

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043117#comment-17043117 ] lamber-ken edited comment on HUDI-625 at 2/24/20 1:29 AM: -- The key issue is

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043117#comment-17043117 ] lamber-ken edited comment on HUDI-625 at 2/24/20 1:24 AM: -- The key issue is

[jira] [Commented] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043117#comment-17043117 ] lamber-ken commented on HUDI-625: - The key issue is

[jira] [Commented] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043115#comment-17043115 ] Vinoth Chandar commented on HUDI-625: - I fixed that in my PR as well .. Do you want to drive the kryo

[GitHub] [incubator-hudi] satishkotha commented on issue #1341: [HUDI-626] Add exportToTable option to CLI

2020-02-23 Thread GitBox
satishkotha commented on issue #1341: [HUDI-626] Add exportToTable option to CLI URL: https://github.com/apache/incubator-hudi/pull/1341#issuecomment-590139655 @smarthi could you review this when you get a chance? This is an

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions

2020-02-23 Thread GitBox
garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions URL: https://github.com/apache/incubator-hudi/pull/1348#discussion_r383055959 ## File path: hudi-spark/src/test/scala/TestDataSource.scala ## @@ -135,6

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions

2020-02-23 Thread GitBox
garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions URL: https://github.com/apache/incubator-hudi/pull/1348#discussion_r383055617 ## File path: hudi-spark/src/main/scala/org/apache/hudi/IncrementalRelation.scala

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions

2020-02-23 Thread GitBox
garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions URL: https://github.com/apache/incubator-hudi/pull/1348#discussion_r383055560 ## File path: hudi-spark/src/main/scala/org/apache/hudi/IncrementalRelation.scala

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043098#comment-17043098 ] lamber-ken edited comment on HUDI-625 at 2/24/20 12:29 AM: --- hi [~vinoth], I sent

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043098#comment-17043098 ] lamber-ken edited comment on HUDI-625 at 2/24/20 12:23 AM: --- hi [~vinoth], I sent

[jira] [Comment Edited] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043098#comment-17043098 ] lamber-ken edited comment on HUDI-625 at 2/24/20 12:18 AM: --- hi [~vinoth], I sent

[jira] [Commented] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043098#comment-17043098 ] lamber-ken commented on HUDI-625: - hi [~vinoth], I send some messages to you use slack, may be these

[jira] [Updated] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated HUDI-625: Attachment: image-2020-02-24-08-15-48-615.png > Address performance concerns on DiskBasedMap.get() during

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-02-23 Thread GitBox
smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r382958076 ## File path:

[jira] [Commented] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043040#comment-17043040 ] Vinoth Chandar commented on HUDI-625: - https://github.com/apache/incubator-hudi/pull/1351/files With

[jira] [Updated] (HUDI-625) Address performance concerns on DiskBasedMap.get() during upsert of thin records

2020-02-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-625: Labels: pull-request-available (was: ) > Address performance concerns on DiskBasedMap.get() during

[GitHub] [incubator-hudi] vinothchandar opened a new pull request #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo

2020-02-23 Thread GitBox
vinothchandar opened a new pull request #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo URL: https://github.com/apache/incubator-hudi/pull/1351 - This is very rough cut of few things I tried; Just for sharing purposes - Kryo needs serializers and once we

[jira] [Created] (HUDI-631) HoodieAvroUtils.rewrite does not handle schema change such as optional fields removal

2020-02-23 Thread Yixue (Andrew) Zhu (Jira)
Yixue (Andrew) Zhu created HUDI-631: --- Summary: HoodieAvroUtils.rewrite does not handle schema change such as optional fields removal Key: HUDI-631 URL: https://issues.apache.org/jira/browse/HUDI-631

[jira] [Comment Edited] (HUDI-603) HoodieDeltaStreamer should periodically fetch table schema update

2020-02-23 Thread Yixue (Andrew) Zhu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043016#comment-17043016 ] Yixue (Andrew) Zhu edited comment on HUDI-603 at 2/23/20 6:36 PM: -- I am

[jira] [Comment Edited] (HUDI-603) HoodieDeltaStreamer should periodically fetch table schema update

2020-02-23 Thread Yixue (Andrew) Zhu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043016#comment-17043016 ] Yixue (Andrew) Zhu edited comment on HUDI-603 at 2/23/20 6:35 PM: -- I am

[jira] [Comment Edited] (HUDI-603) HoodieDeltaStreamer should periodically fetch table schema update

2020-02-23 Thread Yixue (Andrew) Zhu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043016#comment-17043016 ] Yixue (Andrew) Zhu edited comment on HUDI-603 at 2/23/20 6:33 PM: -- I am

[jira] [Commented] (HUDI-603) HoodieDeltaStreamer should periodically fetch table schema update

2020-02-23 Thread Yixue (Andrew) Zhu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043016#comment-17043016 ] Yixue (Andrew) Zhu commented on HUDI-603: - I think one possible approach would work: # A

[jira] [Resolved] (HUDI-617) Add support for data types convertible to String in TimestampBasedKeyGenerator

2020-02-23 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf resolved HUDI-617. Fix Version/s: 0.5.2 Resolution: Fixed Fixed via master: c2b08cdfc9b762801a63fee988f1c24cc17df4ce > Add

[jira] [Updated] (HUDI-617) Add support for data types convertible to String in TimestampBasedKeyGenerator

2020-02-23 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf updated HUDI-617: --- Status: Open (was: New) > Add support for data types convertible to String in TimestampBasedKeyGenerator >