[GitHub] [hudi] garyli1019 commented on a change in pull request #2616: [HUDI-1625] Support range partition keygen

2021-06-05 Thread GitBox
garyli1019 commented on a change in pull request #2616: URL: https://github.com/apache/hudi/pull/2616#discussion_r646079155 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/RangePartitionAvroKeyGenerator.java ## @@ -0,0 +1,97 @@ +/* + *

[GitHub] [hudi] arun990 commented on issue #3009: Dependency error when attempt to build Hudi from git source ..

2021-06-05 Thread GitBox
arun990 commented on issue #3009: URL: https://github.com/apache/hudi/issues/3009#issuecomment-855328928 Hi, checked it and the build was completed without the reported error. Thank you. Closing the issue. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hudi] arun990 closed issue #3009: Dependency error when attempt to build Hudi from git source ..

2021-06-05 Thread GitBox
arun990 closed issue #3009: URL: https://github.com/apache/hudi/issues/3009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[hudi] branch master updated (2a7e1e0 -> 08464a6)

2021-06-05 Thread garyli
This is an automated email from the ASF dual-hosted git repository. garyli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from 2a7e1e0 [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY in HoodieSparkSqlWriter (#3036) add

[GitHub] [hudi] garyli1019 merged pull request #3026: [HUDI-1931] BucketAssignFunction use ValueState instead of MapState

2021-06-05 Thread GitBox
garyli1019 merged pull request #3026: URL: https://github.com/apache/hudi/pull/3026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hudi] garyli1019 commented on pull request #3026: [HUDI-1931] BucketAssignFunction use ValueState instead of MapState

2021-06-05 Thread GitBox
garyli1019 commented on pull request #3026: URL: https://github.com/apache/hudi/pull/3026#issuecomment-855327366 merging. we can address the minor comment in #3024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 480c169776dcf2260cbfebc7dc90bd2f1807e411 UNKNOWN * e2cac1f9ec077d1e033c358168864db967dbeea5 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 4b7f6c639c497e89b8ca90be6a0742715ea18209 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 4b7f6c639c497e89b8ca90be6a0742715ea18209 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 0070398ad4cd0bdebd084fe91acc2daa046fc16d Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 0070398ad4cd0bdebd084fe91acc2daa046fc16d Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 0070398ad4cd0bdebd084fe91acc2daa046fc16d Azure:

[GitHub] [hudi] nsivabalan commented on a change in pull request #2967: Added blog for Hudi cleaner service

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #2967: URL: https://github.com/apache/hudi/pull/2967#discussion_r646041232 ## File path: docs/_posts/2021-06-03-employing-right-configurations-for-hudi-cleaner.md ## @@ -0,0 +1,106 @@ +--- +title: "Employing correct

[hudi] branch master updated: [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY in HoodieSparkSqlWriter (#3036)

2021-06-05 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 2a7e1e0 [HUDI-1942] Add Default value for

[GitHub] [hudi] nsivabalan merged pull request #3036: [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY

2021-06-05 Thread GitBox
nsivabalan merged pull request #3036: URL: https://github.com/apache/hudi/pull/3036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hudi] nsivabalan commented on a change in pull request #3036: [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #3036: URL: https://github.com/apache/hudi/pull/3036#discussion_r646041047 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -423,7 +423,8 @@ private[hudi] object

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 0070398ad4cd0bdebd084fe91acc2daa046fc16d Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * b9bab751eb85f5295ee475eba4d75e25d29880e0 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * b9bab751eb85f5295ee475eba4d75e25d29880e0 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * b9bab751eb85f5295ee475eba4d75e25d29880e0 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * e79a1a416f733e0aeb360849a1ee5162db27bb0f Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * e79a1a416f733e0aeb360849a1ee5162db27bb0f Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * e79a1a416f733e0aeb360849a1ee5162db27bb0f Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 3b1e629f57e94809e4a79e4583d291c23868b1a7 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 24baac9967e7f0d3e1c814e41583092068156146 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 24baac9967e7f0d3e1c814e41583092068156146 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2984: (Azure CI) test PR

2021-06-05 Thread GitBox
hudi-bot edited a comment on pull request #2984: URL: https://github.com/apache/hudi/pull/2984#issuecomment-846794102 ## CI report: * 24baac9967e7f0d3e1c814e41583092068156146 Azure:

[GitHub] [hudi] veenaypatil commented on pull request #3040: [HUDI-1148] Remove Hadoop Conf Logs

2021-06-05 Thread GitBox
veenaypatil commented on pull request #3040: URL: https://github.com/apache/hudi/pull/3040#issuecomment-855260089 @bvaradar Can you please review this, I have tested this with DelaStreamer and do not see any other logs which is bloated or not useful -- This is an automated message from

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3040: [HUDI-1148] Remove Hadoop Conf Logs

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3040: URL: https://github.com/apache/hudi/pull/3040#issuecomment-855251170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2993: URL: https://github.com/apache/hudi/pull/2993#issuecomment-848384059 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3040: [HUDI-1148] Remove Hadoop Conf Logs

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3040: URL: https://github.com/apache/hudi/pull/3040#issuecomment-855251170 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2993: URL: https://github.com/apache/hudi/pull/2993#issuecomment-848384059 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2993: URL: https://github.com/apache/hudi/pull/2993#issuecomment-848384059 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2993: URL: https://github.com/apache/hudi/pull/2993#issuecomment-848384059 #

[GitHub] [hudi] wangxianghu commented on a change in pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
wangxianghu commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r645996864 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/factory/HoodieAvroKeyGeneratorFactory.java ## @@ -0,0 +1,94 @@ +/* +

[GitHub] [hudi] codecov-commenter commented on pull request #3040: [HUDI-1148] Remove Hadoop Conf Logs

2021-06-05 Thread GitBox
codecov-commenter commented on pull request #3040: URL: https://github.com/apache/hudi/pull/3040#issuecomment-855251170 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3040?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[jira] [Updated] (HUDI-1148) Revisit log messages seen when wiriting or reading through Hudi

2021-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1148: - Labels: pull-request-available (was: ) > Revisit log messages seen when wiriting or reading

[GitHub] [hudi] veenaypatil opened a new pull request #3040: [HUDI-1148] Remove Hadoop Conf Logs

2021-06-05 Thread GitBox
veenaypatil opened a new pull request #3040: URL: https://github.com/apache/hudi/pull/3040 ## What is the purpose of the pull request Remove Hadoop configuration log because it prints a lot of times in the log and does not add value while debugging as well ## Brief change log

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2993: URL: https://github.com/apache/hudi/pull/2993#issuecomment-848384059 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] wangxianghu commented on a change in pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
wangxianghu commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r645997489 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/factory/HoodieAvroKeyGeneratorFactory.java ## @@ -0,0 +1,94 @@ +/* +

[GitHub] [hudi] wangxianghu commented on a change in pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
wangxianghu commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r645996864 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/factory/HoodieAvroKeyGeneratorFactory.java ## @@ -0,0 +1,94 @@ +/* +

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3038: URL: https://github.com/apache/hudi/pull/3038#issuecomment-855220122 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3038: URL: https://github.com/apache/hudi/pull/3038#issuecomment-855220122 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846613183 #

[GitHub] [hudi] vaibhav-sinha commented on a change in pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
vaibhav-sinha commented on a change in pull request #2923: URL: https://github.com/apache/hudi/pull/2923#discussion_r645993113 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestTimestampBasedKeyGenerator.java ## @@ -378,4 +382,46 @@ public

[GitHub] [hudi] vaibhav-sinha commented on a change in pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
vaibhav-sinha commented on a change in pull request #2923: URL: https://github.com/apache/hudi/pull/2923#discussion_r645993107 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestTimestampBasedKeyGenerator.java ## @@ -378,4 +382,46 @@ public

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3039: [HUDI-1864][WIP] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3039: URL: https://github.com/apache/hudi/pull/3039#issuecomment-855239677 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3038: URL: https://github.com/apache/hudi/pull/3038#issuecomment-855220122 #

[jira] [Created] (HUDI-1981) Introduce --enable-sync option in HoodieMultiTableDeltaStreamer

2021-06-05 Thread Pratyaksh Sharma (Jira)
Pratyaksh Sharma created HUDI-1981: -- Summary: Introduce --enable-sync option in HoodieMultiTableDeltaStreamer Key: HUDI-1981 URL: https://issues.apache.org/jira/browse/HUDI-1981 Project: Apache Hudi

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3038: URL: https://github.com/apache/hudi/pull/3038#issuecomment-855220122 #

[GitHub] [hudi] codecov-commenter commented on pull request #3039: [HUDI-1864][WIP] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
codecov-commenter commented on pull request #3039: URL: https://github.com/apache/hudi/pull/3039#issuecomment-855239677 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3039?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #2967: Added blog for Hudi cleaner service

2021-06-05 Thread GitBox
pratyakshsharma commented on a change in pull request #2967: URL: https://github.com/apache/hudi/pull/2967#discussion_r645990277 ## File path: docs/_posts/2021-06-03-employing-right-configurations-for-hudi-cleaner.md ## @@ -0,0 +1,106 @@ +--- +title: "Employing correct

[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-855236580 @vaibhav-sinha : I recreated this PR cleanly [here](https://github.com/apache/hudi/pull/3039). Have not made fixes to TestCopyOnWrite yet. will wait for flink experts to chime

[GitHub] [hudi] nsivabalan opened a new pull request #3039: [HUDI-1864][WIP] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
nsivabalan opened a new pull request #3039: URL: https://github.com/apache/hudi/pull/3039 Redo of https://github.com/apache/hudi/pull/2923 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before

[GitHub] [hudi] Carl-Zhou-CN commented on a change in pull request #3036: [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY

2021-06-05 Thread GitBox
Carl-Zhou-CN commented on a change in pull request #3036: URL: https://github.com/apache/hudi/pull/3036#discussion_r645987505 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -423,7 +423,8 @@ private[hudi] object

[GitHub] [hudi] Carl-Zhou-CN commented on a change in pull request #3036: [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY

2021-06-05 Thread GitBox
Carl-Zhou-CN commented on a change in pull request #3036: URL: https://github.com/apache/hudi/pull/3036#discussion_r645987505 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -423,7 +423,8 @@ private[hudi] object

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3035: [HUDI-1936] Introduce a optional property for conditional upsert

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3035: URL: https://github.com/apache/hudi/pull/3035#issuecomment-855229410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] nsivabalan commented on a change in pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #2923: URL: https://github.com/apache/hudi/pull/2923#discussion_r645985325 ## File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java ## @@ -380,12 +380,12 @@ public void testUpsertWithDelete() throws

[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-855233374 @vaibhav-sinha : in the mean time, can you address nishith's feedback on test naming. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hudi] nsivabalan commented on a change in pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #2923: URL: https://github.com/apache/hudi/pull/2923#discussion_r645984981 ## File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java ## @@ -380,12 +380,12 @@ public void testUpsertWithDelete() throws

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3035: [HUDI-1936] Introduce a optional property for conditional upsert

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3035: URL: https://github.com/apache/hudi/pull/3035#issuecomment-855229410 #

[GitHub] [hudi] codecov-commenter commented on pull request #3035: [HUDI-1936] Introduce a optional property for conditional upsert

2021-06-05 Thread GitBox
codecov-commenter commented on pull request #3035: URL: https://github.com/apache/hudi/pull/3035#issuecomment-855229410 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3035?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [hudi] nsivabalan commented on a change in pull request #2963: [HUDI-1904] Make SchemaProvider spark free and move it to hudi-client-common

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #2963: URL: https://github.com/apache/hudi/pull/2963#discussion_r645980835 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/schema/SchemaProvider.java ## @@ -34,18 +32,9 @@ @PublicAPIClass(maturity =

[GitHub] [hudi] veenaypatil commented on a change in pull request #3036: [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY

2021-06-05 Thread GitBox
veenaypatil commented on a change in pull request #3036: URL: https://github.com/apache/hudi/pull/3036#discussion_r645981297 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -423,7 +423,8 @@ private[hudi] object

[GitHub] [hudi] leesf commented on a change in pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
leesf commented on a change in pull request #3038: URL: https://github.com/apache/hudi/pull/3038#discussion_r645980679 ## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java ## @@ -35,33 +38,18 @@ import

[hudi] branch master updated: [HUDI-1979] Optimize logic to improve code readability (#3037)

2021-06-05 Thread leesf
This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new dab13f7 [HUDI-1979] Optimize logic to improve

[GitHub] [hudi] leesf merged pull request #3037: [HUDI-1979] Optimize logic to improve code readability

2021-06-05 Thread GitBox
leesf merged pull request #3037: URL: https://github.com/apache/hudi/pull/3037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hudi] leesf commented on a change in pull request #2616: [HUDI-1625] Support range partition keygen

2021-06-05 Thread GitBox
leesf commented on a change in pull request #2616: URL: https://github.com/apache/hudi/pull/2616#discussion_r645980052 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/RangePartitionAvroKeyGenerator.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to

[GitHub] [hudi] nsivabalan commented on a change in pull request #3036: [HUDI-1942] Add Default value for HIVE_AUTO_CREATE_DATABASE_OPT_KEY

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #3036: URL: https://github.com/apache/hudi/pull/3036#discussion_r645979488 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -423,7 +423,8 @@ private[hudi] object

[GitHub] [hudi] nsivabalan commented on pull request #2616: [HUDI-1625] Support range partition keygen

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2616: URL: https://github.com/apache/hudi/pull/2616#issuecomment-855225713 @garyli1019 : Did you get a chance to follow up on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Support configure KeyGenerator by type

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r645978567 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/factory/HoodieAvroKeyGeneratorFactory.java ## @@ -0,0 +1,94 @@ +/* + *

[GitHub] [hudi] nsivabalan commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2768: URL: https://github.com/apache/hudi/pull/2768#issuecomment-855224613 yes, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] nsivabalan commented on pull request #2967: Added blog for Hudi cleaner service

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2967: URL: https://github.com/apache/hudi/pull/2967#issuecomment-855224324 We can land once addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hudi] nsivabalan commented on pull request #2967: Added blog for Hudi cleaner service

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2967: URL: https://github.com/apache/hudi/pull/2967#issuecomment-855224297 sorry, one last comment. in the figure, instead of addressing as fielIds (fileId1, fileId2...), can we use fileGroup1 , fileGroup2 etc. A file group represents all files in

[GitHub] [hudi] nsivabalan commented on pull request #2925: [HUDI-1879] Fix RO Tables Returning Snapshot Result

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2925: URL: https://github.com/apache/hudi/pull/2925#issuecomment-855223971 Once you move the config to HiveSyncConfig or HiveSyncTool, we should be good to merge this in. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] nsivabalan commented on a change in pull request #2925: [HUDI-1879] Fix RO Tables Returning Snapshot Result

2021-06-05 Thread GitBox
nsivabalan commented on a change in pull request #2925: URL: https://github.com/apache/hudi/pull/2925#discussion_r645977253 ## File path: hudi-common/src/main/java/org/apache/hudi/common/config/DefaultHoodieConfig.java ## @@ -26,6 +26,11 @@ */ public class

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3038: URL: https://github.com/apache/hudi/pull/3038#issuecomment-855220122 #

[GitHub] [hudi] nsivabalan commented on pull request #2896: [HUDI-1790] Added SqlSource to fetch data from any partitions for backfill use case

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2896: URL: https://github.com/apache/hudi/pull/2896#issuecomment-855221106 @vingov : hey vinoth. Did you get a chance to check out my feedback. We can merge this in once addressed. -- This is an automated message from the Apache Git Service. To

[GitHub] [hudi] nsivabalan commented on pull request #2747: [HUDI-1743] Added support for SqlFileBasedTransformer

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2747: URL: https://github.com/apache/hudi/pull/2747#issuecomment-855221039 @vingov : Did you get a chance to check out my feedback. Once addressed, we can land this. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] codecov-commenter commented on pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
codecov-commenter commented on pull request #3038: URL: https://github.com/apache/hudi/pull/3038#issuecomment-855220122 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3038?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [hudi] Xuehai-Chen edited a comment on pull request #2854: [HUDI-1771] Propagate CDC format for hoodie

2021-06-05 Thread GitBox
Xuehai-Chen edited a comment on pull request #2854: URL: https://github.com/apache/hudi/pull/2854#issuecomment-855218182 Maybe I get it wrong, but it looks like the "_hoodie_cdc_operation" field is not set properly when it's flushing to files. I think problem is when

[GitHub] [hudi] Xuehai-Chen commented on pull request #2854: [HUDI-1771] Propagate CDC format for hoodie

2021-06-05 Thread GitBox
Xuehai-Chen commented on pull request #2854: URL: https://github.com/apache/hudi/pull/2854#issuecomment-855218182 Maybe I get it wrong, but it looks like the "_hoodie_cdc_operation" field is not set properly. When StreamWriteFunction.bufferRecord convert HoodieRecord to DataItem --

[jira] [Updated] (HUDI-1980) Optimize the code to prevent other exceptions from causing resources not to be closed

2021-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1980: - Labels: pull-request-available (was: ) > Optimize the code to prevent other exceptions from

[GitHub] [hudi] chaplinthink opened a new pull request #3038: [HUDI-1980] Optimize the code to prevent other exceptions from causin…

2021-06-05 Thread GitBox
chaplinthink opened a new pull request #3038: URL: https://github.com/apache/hudi/pull/3038 …g resources not to be closed ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull

[jira] [Updated] (HUDI-1980) Optimize the code to prevent other exceptions from causing resources not to be closed

2021-06-05 Thread Wei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei updated HUDI-1980: -- Description:  When  *HoodieHiveClient* initializing resources, some exceptions may cause resources to fail to close >

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3037: [HUDI-1979] Optimize logic to improve code readability

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3037: URL: https://github.com/apache/hudi/pull/3037#issuecomment-855211206 #

[jira] [Created] (HUDI-1980) Optimize the code to prevent other exceptions from causing resources not to be closed

2021-06-05 Thread Wei (Jira)
Wei created HUDI-1980: - Summary: Optimize the code to prevent other exceptions from causing resources not to be closed Key: HUDI-1980 URL: https://issues.apache.org/jira/browse/HUDI-1980 Project: Apache Hudi

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3037: [HUDI-1979] Optimize logic to improve code readability

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3037: URL: https://github.com/apache/hudi/pull/3037#issuecomment-855211206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3037: [HUDI-1979] Optimize logic to improve code readability

2021-06-05 Thread GitBox
codecov-commenter edited a comment on pull request #3037: URL: https://github.com/apache/hudi/pull/3037#issuecomment-855211206 #

[GitHub] [hudi] codecov-commenter commented on pull request #3037: [HUDI-1979] Optimize logic to improve code readability

2021-06-05 Thread GitBox
codecov-commenter commented on pull request #3037: URL: https://github.com/apache/hudi/pull/3037#issuecomment-855211206 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3037?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[jira] [Updated] (HUDI-1979) Optimize logic to improve code readability

2021-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1979: - Labels: pull-request-available (was: ) > Optimize logic to improve code readability >

[GitHub] [hudi] chaplinthink opened a new pull request #3037: [HUDI-1979] Optimize logic to improve code readability

2021-06-05 Thread GitBox
chaplinthink opened a new pull request #3037: URL: https://github.com/apache/hudi/pull/3037 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of

[jira] [Assigned] (HUDI-1847) Add ability to decouple configs for scheduling inline and running async

2021-06-05 Thread Vinay (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay reassigned HUDI-1847: --- Assignee: Vinay > Add ability to decouple configs for scheduling inline and running async >

[jira] [Commented] (HUDI-1847) Add ability to decouple configs for scheduling inline and running async

2021-06-05 Thread Vinay (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357787#comment-17357787 ] Vinay commented on HUDI-1847: - [~nishith29]  Thank you for mentioning all the steps clearly, I would like to

[jira] [Commented] (HUDI-1942) HIVE_AUTO_CREATE_DATABASE_OPT_KEY This should default to true when Hudi synchronizes Hive

2021-06-05 Thread Vinay (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357786#comment-17357786 ] Vinay commented on HUDI-1942: - [~yao.z...@yuanxi.onaliyun.com] yes, I have already added that in the PR, can

[jira] [Updated] (HUDI-1979) Optimize logic to improve code readability

2021-06-05 Thread Wei (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei updated HUDI-1979: -- Status: In Progress (was: Open) > Optimize logic to improve code readability >

[jira] [Created] (HUDI-1979) Optimize logic to improve code readability

2021-06-05 Thread Wei (Jira)
Wei created HUDI-1979: - Summary: Optimize logic to improve code readability Key: HUDI-1979 URL: https://issues.apache.org/jira/browse/HUDI-1979 Project: Apache Hudi Issue Type: Improvement

  1   2   >