vaibhav-sinha commented on a change in pull request #2923: URL: https://github.com/apache/hudi/pull/2923#discussion_r645993107
########## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestTimestampBasedKeyGenerator.java ########## @@ -378,4 +382,46 @@ public void test_ExpectsMatch_MultipleInputFormats_ShortDate_OutputCustomDate() baseRow = genericRecordToRow(baseRecord); assertEquals("04/01/2020", keyGen.getPartitionPath(baseRow)); } + + @Test + public void test_ExpectsMatch_LogicalType_Date() throws IOException { Review comment: Had named the test based on the naming convention for existing tests in this class. Have updated names of all tests to camelCase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org