[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-10 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r943051969 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-10 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r943051969 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-10 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r943050236 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-10 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r942197333 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-09 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r94273 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-09 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r941989799 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-09 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r941989799 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-09 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r941968046 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala: ## @@ -473,26 +473,25 @@ case class HoodieResolveReferences(sp

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-09 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r941958365 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/connector/catalog/HoodieCatalogAndIdentifier.scala: ## @@ -0,0 +1,52 @@ +/* + * Licensed t

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-09 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r941956169 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940847876 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940847507 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940832883 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/connector/catalog/HoodieCatalogAndIdentifier.scala: ## @@ -0,0 +1,52 @@ +/* + * Licensed t

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940830378 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940830255 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +57,56 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940825126 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSpark3Catalog.scala: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940311939 ## hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala: ## @@ -52,8 +64,51 @@ abstract class HoodieSpark3Cata

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940310284 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSpark3Catalog.scala: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [hudi] YannByron commented on a diff in pull request #6264: [HUDI-4503] support for parsing identifier with catalog

2022-08-08 Thread GitBox
YannByron commented on code in PR #6264: URL: https://github.com/apache/hudi/pull/6264#discussion_r940308259 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestSpark3Catalog.scala: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundat