[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578216168 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -749,22 +739,49 @@ private HoodieTimel

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578081554 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -181,7 +171,7 @@ public boolean commit

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578081171 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -236,17 +226,16 @@ protected void sync

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578080521 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -598,6 +588,9 @@ public HoodieRestoreM

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578080521 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -598,6 +588,9 @@ public HoodieRestoreM

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578080260 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HeartbeatUtils.java ## @@ -0,0 +1,95 @@ +/* + * Licensed to the A

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578080111 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -912,5 +929,6 @@ public void close() {

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578079857 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -617,11 +610,8 @@ public HoodieCleanMe

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578071340 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -424,15 +411,15 @@ protected void post

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r578071271 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -236,17 +226,16 @@ protected void sync

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r569156786 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,265 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r569155127 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/HeartbeatUtils.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r569154776 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/HeartbeatUtils.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r569154530 ## File path: hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/heartbeat/TestHoodieHeartbeatClient.java ## @@ -0,0 +1,145 @@ +/* + * Licen

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r569150307 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -750,24 +767,49 @@ private HoodieTimel

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r569149254 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -128,11 +133,26 @@ public AbstractHood

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553164370 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -232,17 +250,18 @@ void emitCommitMetr

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553165180 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -580,6 +602,11 @@ public HoodieRestore

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553758784 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -707,24 +739,51 @@ public void rollbac

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553758341 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -707,24 +739,51 @@ public void rollbac

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553182089 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,265 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553198185 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -707,24 +739,51 @@ public void rollbac

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553182089 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,265 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553177992 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -408,13 +426,14 @@ protected void post

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553171497 ## File path: hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/heartbeat/TestHoodieHeartbeatClient.java ## @@ -0,0 +1,152 @@ +/* + * Licen

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553170553 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java ## @@ -260,6 +264,11 @@ public Builder withClea

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553169905 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,265 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553168356 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -859,6 +931,10 @@ protected void setW

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553165180 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -580,6 +602,11 @@ public HoodieRestore

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r553164370 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -232,17 +250,18 @@ void emitCommitMetr

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550360249 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,196 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550405611 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,196 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550405508 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,196 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550367996 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,196 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550366868 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java ## @@ -217,6 +218,13 @@ public String getMetaAuxiliaryPath()

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550365963 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java ## @@ -107,7 +107,7 @@ public HoodieTimeline filter

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550360249 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,196 @@ +/* + * Licensed

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r550360059 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -615,6 +640,11 @@ public String startC

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549997626 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -875,5 +924,6 @@ public void close() {

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549997200 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -232,17 +254,18 @@ void emitCommitMetr

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549982138 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -712,24 +742,43 @@ public void rollbac

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549981815 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java ## @@ -165,13 +167,17 @@ public boolean archiv

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549977661 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/clean/SparkCleanActionExecutor.java ## @@ -23,9 +23,9 @@ import org.a

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549970709 ## File path: hudi-hadoop-mr/src/test/java/org/apache/hudi/hadoop/TestHoodieROTablePathFilter.java ## @@ -84,7 +84,6 @@ public void testNonHoodiePaths() thro

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549952800 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java ## @@ -145,6 +146,11 @@ public void scan() {

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549938046 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java ## @@ -100,7 +107,9 @@ public static SparkConf regi

[GitHub] [hudi] n3nash commented on a change in pull request #2359: [HUDI-1486] Remove inflight rollback in hoodie writer

n3nash commented on a change in pull request #2359: URL: https://github.com/apache/hudi/pull/2359#discussion_r549937742 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java ## @@ -0,0 +1,196 @@ +/* + * Licensed