[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-06-02 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r643861744 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/constant/KeyGeneratorType.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-06-02 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r643863514 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java ## @@ -98,53 +103,145 @@ private TypedProper

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-31 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r642503029 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java ## @@ -98,8 +105,9 @@ private TypedPropertie

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-31 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r642498863 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -72,8 +71,11 @@ public static final Str

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-30 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r642184643 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -72,8 +71,11 @@ public static final Str

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-29 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r641931702 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -72,8 +71,11 @@ public static final Str

[GitHub] [hudi] nsivabalan commented on a change in pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

2021-05-29 Thread GitBox
nsivabalan commented on a change in pull request #2993: URL: https://github.com/apache/hudi/pull/2993#discussion_r641931227 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -72,8 +71,11 @@ public static final Str