waywtdcc commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1884005603
The meta file of version 1.0.0 is in avro format, and the old version is in
json format. This should also be compatible.
--
This is an automated message from the Apache Git Service.
To re
boneanxs commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1882755083
> > No, we would fix the ugrade for 1.0.0 GA release.
>
> Does this mean that the official version 1.0.0 will support automatic
upgrade and fix this bug?
@waywtdcc Yeap, will f
waywtdcc commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1882506165
> No, we would fix the ugrade for 1.0.0 GA release.
Does this mean that the official version 1.0.0 will support automatic
upgrade and fix this bug?
--
This is an automated message
danny0405 commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1877989899
No, we would fix the ugrade for 1.0.0 GA release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
waywtdcc commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1876697501
![image](https://github.com/apache/hudi/assets/59957056/6cf60022-5d42-4e12-afd2-dac7a1f85e4b)
This is an error when upgrading from 0.12.1 to 1.0.0-beta1. Is this
compatible with the file
boneanxs commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1361422542
##
hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java:
##
@@ -35,19 +35,23 @@ public class LockConfiguration implements Serializable {
publ
yihua commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1361379762
##
hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java:
##
@@ -35,19 +35,23 @@ public class LockConfiguration implements Serializable {
public
danny0405 merged PR #9617:
URL: https://github.com/apache/hudi/pull/9617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1758932211
## CI report:
* 8821b701b0ae25d6bcf17dd95f36be9cc8de084b UNKNOWN
* 9262fe65ccfb3d7f74eb0ee35d4f822eeb1a67ea Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1758826067
## CI report:
* 8821b701b0ae25d6bcf17dd95f36be9cc8de084b UNKNOWN
* bfea4593820ae5257f93f822986ef58168f69dde Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1758820588
## CI report:
* 8821b701b0ae25d6bcf17dd95f36be9cc8de084b UNKNOWN
* bfea4593820ae5257f93f822986ef58168f69dde Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1757581642
## CI report:
* 8821b701b0ae25d6bcf17dd95f36be9cc8de084b UNKNOWN
* bfea4593820ae5257f93f822986ef58168f69dde Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1757366765
## CI report:
* 8821b701b0ae25d6bcf17dd95f36be9cc8de084b UNKNOWN
* 2543e0a84a337b02e4af14a3f8b2c4dafbd6d558 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1757346235
## CI report:
* 8821b701b0ae25d6bcf17dd95f36be9cc8de084b UNKNOWN
* 2543e0a84a337b02e4af14a3f8b2c4dafbd6d558 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
boneanxs commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1354592241
##
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimeGeneratorBase.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
boneanxs commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1757292134
> Looks good overall, is there anyway we can abstract that failure retries
as a common utility? Add add a UT for TimeGenerator.
done
--
This is an automated message from the Apache Git
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1754921125
## CI report:
* 8821b701b0ae25d6bcf17dd95f36be9cc8de084b UNKNOWN
* 2543e0a84a337b02e4af14a3f8b2c4dafbd6d558 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1754602002
## CI report:
* ceede4af8af859baa21e5a2178e421bfd84c7ead Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2014
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1754587571
## CI report:
* ceede4af8af859baa21e5a2178e421bfd84c7ead Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2014
boneanxs commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1351725337
##
hudi-common/src/main/java/org/apache/hudi/client/transaction/lock/InProcessLockProvider.java:
##
@@ -19,16 +19,15 @@
package org.apache.hudi.client.transaction.lock
hudi-bot commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1754573890
## CI report:
* ceede4af8af859baa21e5a2178e421bfd84c7ead Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2014
boneanxs commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1351289121
##
packaging/hudi-kafka-connect-bundle/pom.xml:
##
@@ -107,6 +107,7 @@
com.lmax:disruptor
com.g
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343399866
##
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimeGeneratorBase.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343399866
##
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimeGeneratorBase.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343397772
##
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##
@@ -370,6 +377,28 @@ public synchronized HoodieActiveTimeline
reloadActiveTimel
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343395847
##
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##
@@ -187,7 +188,11 @@ public static String maskWithoutFileId(String instantTime,
int taskPartitio
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343376582
##
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTimeGeneratorConfig.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343376222
##
packaging/hudi-kafka-connect-bundle/pom.xml:
##
@@ -107,6 +107,7 @@
com.lmax:disruptor
com.
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343361124
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkTableServiceClient.java:
##
@@ -137,6 +137,7 @@ protected void completeClustering(
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343359738
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##
@@ -261,7 +261,10 @@ protected void finishRollb
danny0405 commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1343355515
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##
@@ -964,7 +976,7 @@ public void update(HoodieRestoreMet
vinothchandar commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1342547848
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##
@@ -261,7 +261,10 @@ protected void finishR
32 matches
Mail list logo