[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-26 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r269256381 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-22 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r268372630 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-22 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r268266115 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-21 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267929149 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-21 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267917741 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267098298 ## File path: tests/python/unittest/test_gluon_estimator.py ##

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267095204 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267095204 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267094192 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267094300 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267094252 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267091700 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267090923 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267091016 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -

[GitHub] [incubator-mxnet] abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API

2019-03-19 Thread GitBox
abhinavs95 commented on a change in pull request #14442: [MXNet-1349][Fit API]Add validation support and unit tests for fit() API URL: https://github.com/apache/incubator-mxnet/pull/14442#discussion_r267090968 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -