[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-04-02 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r271490567 ## File path: src/engine/threaded_engine.cc ## @@ -415,6 +415,23 @@ void

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-21 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267954833 ## File path: src/engine/threaded_engine.cc ## @@ -415,6 +415,25 @@ void

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-21 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267954717 ## File path: src/engine/threaded_engine.cc ## @@ -415,6 +415,25 @@ void

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-21 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267954019 ## File path: src/engine/threaded_engine.cc ## @@ -415,6 +415,25 @@ void

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-21 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267953972 ## File path: src/engine/threaded_engine.cc ## @@ -415,6 +415,25 @@ void

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-21 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267953823 ## File path: tests/python/unittest/test_exc_handling.py ## @@ -77,46 +86,83 @@ def

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-21 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267939991 ## File path: src/engine/threaded_engine.h ## @@ -60,6 +60,9 @@ namespace engine { //

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-20 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267557502 ## File path: src/resource.cc ## @@ -190,12 +190,14 @@ class ResourceManagerImpl : public

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

2019-03-20 Thread GitBox
anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267557161 ## File path: src/engine/threaded_engine.cc ## @@ -428,6 +447,14 @@ inline void