pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780634166
##
File path: arch/risc-v/src/mpfs/mpfs_head.S
##
@@ -24,7 +24,7 @@
#include
#include
-#include
+#include
Review comment:
``
no1wudi commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780626882
##
File path: arch/risc-v/src/qemu-rv32/qemu_rv32_head.S
##
@@ -105,21 +105,6 @@ exception_common:
sw x30, 30*4(sp) /* t5 */
sw x31, 31
no1wudi commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780626571
##
File path: arch/risc-v/src/fe310/fe310_irq_dispatch.c
##
@@ -52,10 +52,10 @@ volatile uint32_t * g_current_regs;
* fe310_dispatch_irq
*
no1wudi commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780626530
##
File path: arch/risc-v/src/common/riscv_schedulesigaction.c
##
@@ -37,6 +37,18 @@
#include "riscv_internal.h"
#include "riscv_arch.h"
+/***
no1wudi commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780624976
##
File path: arch/risc-v/include/common/irq.h
##
@@ -121,7 +121,13 @@
#define INT_XCPT_REGS 33
#endif
-#define INT_XCPT_SIZE (8 *
pkarashchenko commented on pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#issuecomment-1007835849
> How does the choice with both setting as default work?
>
> Seeing the defconfig change:
>
> CONFIG_PRIORITY_INHERITANCE=y
> CONFIG_PTHREAD_MUTEX
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 80e7ea4 Publishing web
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780566773
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780566773
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780557491
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780557282
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780436831
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780436831
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko opened a new pull request #5194:
URL: https://github.com/apache/incubator-nuttx/pull/5194
## Summary
Fix typos in Kconfig files
## Impact
MAX326XX users
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to t
pkarashchenko merged pull request #5193:
URL: https://github.com/apache/incubator-nuttx/pull/5193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 73ea0c1 xtensa: Improve Kconfig
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780531230
##
File path: arch/risc-v/src/qemu-rv32/qemu_rv32_head.S
##
@@ -154,21 +139,6 @@ exception_common:
lw s0, 32*4(sp) /* restore mstatus *
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780529819
##
File path: arch/risc-v/src/fe310/fe310_irq_dispatch.c
##
@@ -52,10 +52,10 @@ volatile uint32_t * g_current_regs;
* fe310_dispatch_irq
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780529480
##
File path: arch/risc-v/src/common/riscv_swint.c
##
@@ -455,7 +455,7 @@ int riscv_swint(int irq, void *context, void *arg)
rt
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780528189
##
File path: arch/risc-v/src/common/riscv_internal.h
##
@@ -184,8 +173,8 @@ uint32_t riscv_get_newintctx(void);
void riscv_savefpu(uint64_
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780527694
##
File path: arch/risc-v/src/common/riscv_internal.h
##
@@ -171,8 +160,8 @@ void riscv_ack_irq(int irq);
void riscv_copystate(uint64_t *de
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780524344
##
File path: arch/risc-v/include/common/irq.h
##
@@ -134,6 +140,14 @@
# error not supported !!!
#endif
+/* REG size */
+
+#ifdef CONFI
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780524344
##
File path: arch/risc-v/include/common/irq.h
##
@@ -134,6 +140,14 @@
# error not supported !!!
#endif
+/* REG size */
+
+#ifdef CONFI
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780524344
##
File path: arch/risc-v/include/common/irq.h
##
@@ -134,6 +140,14 @@
# error not supported !!!
#endif
+/* REG size */
+
+#ifdef CONFI
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780521089
##
File path: arch/risc-v/include/common/irq.h
##
@@ -134,6 +140,14 @@
# error not supported !!!
Review comment:
32-bit variant ha
pkarashchenko commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780519890
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutexat
pkarashchenko commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780516418
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutexat
pkarashchenko commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780516418
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutexat
pkarashchenko commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780516418
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutexat
gustavonihei opened a new pull request #5193:
URL: https://github.com/apache/incubator-nuttx/pull/5193
## Summary
Also fix the wrong "dual-core" statement, since all ESP32-S2 chips are
composed of a single Xtensa LX7 core.
## Impact
No impact, Kconfig help text only.
##
hartmannathan commented on a change in pull request #5151:
URL: https://github.com/apache/incubator-nuttx/pull/5151#discussion_r780506415
##
File path: arch/arm/src/tiva/hardware/tiva_can.h
##
@@ -0,0 +1,459 @@
+/*
pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780389520
##
File path: arch/risc-v/src/common/riscv_fault.c
##
@@ -54,61 +66,61 @@
*
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d296f9c085b22b397af882832cdc14b229b1d351
Author: Xiang Xiao
AuthorDate: Thu Jan 6 13:48:21 2022 +0800
a
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6e31d0dd87ab918b88548f036868b7e85b3ea6c4
Author: Xiang Xiao
AuthorDate: Fri Jan 7 01:41:32 2022 +0800
b
xiaoxiang781216 merged pull request #5179:
URL: https://github.com/apache/incubator-nuttx/pull/5179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from ee916bd CEVA: add ceva platform xc5 xm6 support
new d296f9c arch/sim: Move spiflash simulation to
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 3156a96a1b54577adba65c50350d890a485e6990
Author: Xiang Xiao
AuthorDate: Thu Jan 6 15:10:25 2022 +0800
a
xiaoxiang781216 commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780346942
##
File path: arch/risc-v/include/common/irq.h
##
@@ -1,5 +1,5 @@
/**
no1wudi opened a new pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192
## Summary
Replace all register width relative data type (uint32_t/uint64_t) with
uintptr_t.
## Impact
Refactor only.
## Testing
CI
--
This is an automated message from th
xiaoxiang781216 commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780265031
##
File path: drivers/motor/foc/foc_dummy.c
##
@@ -93,64 +94,64 @@ struct sim_foc_data_s
/* Lower-half FOC operations */
-static int
pkarashchenko commented on a change in pull request #5187:
URL: https://github.com/apache/incubator-nuttx/pull/5187#discussion_r780245434
##
File path: arch/xtensa/src/esp32/esp32_ledc.c
##
@@ -0,0 +1,822 @@
+/
pkarashchenko commented on a change in pull request #5187:
URL: https://github.com/apache/incubator-nuttx/pull/5187#discussion_r780245216
##
File path: arch/xtensa/src/esp32/esp32_ledc.c
##
@@ -0,0 +1,822 @@
+/
pkarashchenko commented on a change in pull request #5187:
URL: https://github.com/apache/incubator-nuttx/pull/5187#discussion_r780244979
##
File path: arch/xtensa/src/esp32/esp32_ledc.c
##
@@ -0,0 +1,822 @@
+/
xiaoxiang781216 commented on a change in pull request #5191:
URL: https://github.com/apache/incubator-nuttx/pull/5191#discussion_r780241333
##
File path: arch/arm/src/armv8-m/arm_trustzone.c
##
@@ -0,0 +1,78 @@
+/*
anchao closed pull request #5191:
URL: https://github.com/apache/incubator-nuttx/pull/5191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
acassis commented on pull request #5151:
URL: https://github.com/apache/incubator-nuttx/pull/5151#issuecomment-1007373434
@MTres19 please fix these coding styles issues:
```
Error:
/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/tiva/common/tiva_can.c:2166:49:
er
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 3fceaf1 drivers/ioexpander: fix the kconfig warning
add ee916bd CEVA: add ceva platform xc5 xm6 supp
acassis merged pull request #5165:
URL: https://github.com/apache/incubator-nuttx/pull/5165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
acassis commented on a change in pull request #5165:
URL: https://github.com/apache/incubator-nuttx/pull/5165#discussion_r780235186
##
File path: arch/ceva/include/types.h
##
@@ -0,0 +1,96 @@
+/
+ * arc
acassis commented on a change in pull request #5187:
URL: https://github.com/apache/incubator-nuttx/pull/5187#discussion_r780233682
##
File path: arch/xtensa/src/esp32/esp32_ledc.c
##
@@ -0,0 +1,812 @@
+/**
acassis commented on a change in pull request #5187:
URL: https://github.com/apache/incubator-nuttx/pull/5187#discussion_r780233682
##
File path: arch/xtensa/src/esp32/esp32_ledc.c
##
@@ -0,0 +1,812 @@
+/**
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780217854
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780217854
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
raiden00pl commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780214828
##
File path: drivers/motor/foc/foc_dummy.c
##
@@ -93,64 +94,64 @@ struct sim_foc_data_s
/* Lower-half FOC operations */
-static int sim_f
raiden00pl commented on pull request #5169:
URL: https://github.com/apache/incubator-nuttx/pull/5169#issuecomment-1007340251
> CONFIG_CAN->CONFIG_STM32_CAN_CHARDRIVER will be a breaking change and
needs to be reflected in the release notes.
CONFIG_STM32_CAN_CHARDRIVER is selected by
anchao opened a new pull request #5191:
URL: https://github.com/apache/incubator-nuttx/pull/5191
## Summary
armv8-m/tz: Set target state for exceptions not banked between security
states
Sets the security state (Secure or Non-Secure) target
for ARMv8-M HardFault, NMI, and B
zhaoxiu-zeng commented on a change in pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171#discussion_r780196314
##
File path: sched/semaphore/sem_holder.c
##
@@ -1035,18 +1014,57 @@ void nxsem_release_holder(FAR sem_t *sem)
{
FAR struct tcb_s *rtcb
xiaoxiang781216 commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780157173
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780132591
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutexat
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780130847
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
xiaoxiang781216 commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780129746
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutex
xiaoxiang781216 commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780127247
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780125534
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutexat
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780121558
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780121558
##
File path: drivers/ioexpander/ioe_dummy.c
##
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
pkarashchenko commented on a change in pull request #5187:
URL: https://github.com/apache/incubator-nuttx/pull/5187#discussion_r780111691
##
File path: arch/xtensa/src/esp32/Kconfig
##
@@ -1282,6 +1283,91 @@ config ESP32_FREERUN
endmenu # Timer/counter Configuration
endif # E
xiaoxiang781216 commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780108849
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutex
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 3fceaf1 drivers/ioexpander: fix
pkarashchenko merged pull request #5190:
URL: https://github.com/apache/incubator-nuttx/pull/5190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pkarashchenko commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780094017
##
File path: libs/libc/pthread/pthread_mutexattr_setprotocol.c
##
@@ -54,21 +54,24 @@ int pthread_mutexattr_setprotocol(FAR pthread_mutexat
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0cb858edd5dd2c89a926485e91862c5c35eccb77
Author: Xiang Xiao
AuthorDate: Fri Jan 7 02:26:04 2022 +0800
b
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7060408c623b324041eb5650f3f9a0332609ad40
Author: Xiang Xiao
AuthorDate: Fri Jan 7 10:37:26 2022 +0800
F
xiaoxiang781216 merged pull request #5186:
URL: https://github.com/apache/incubator-nuttx/pull/5186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 49c00e0 arch/sim: Rename up_vfork[32|64].S to up_vfork_x86[_64].S
new 7060408 Fix net/rpmsgdrv.c:4
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 8c35d31 Kconfig: Remove CONFIG_ prefix from config definition
add 1a02556 Revert "arch/sim: Rename
75 matches
Mail list logo