masayuki2009 commented on pull request #5506:
URL: https://github.com/apache/incubator-nuttx/pull/5506#issuecomment-1041201987
@anchao
I tried this PR with sabre-6quad:netnsh_smp (QEMU) and sabre-6quad:smp (Dev
board) and confirmed both works.
However, sabre-6quad:netknsh (QEMU) whic
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 5f67662 libc/sim: Rename arch_setjmp[64].S to arch_setjmp_x86[_64].S
add 1d89d9a libc.csv: Add pth
xiaoxiang781216 merged pull request #5509:
URL: https://github.com/apache/incubator-nuttx/pull/5509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
no1wudi commented on a change in pull request #5498:
URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r807604891
##
File path: sched/task/task_tls_alloc.c
##
@@ -0,0 +1,113 @@
+/
+ *
no1wudi opened a new pull request #5510:
URL: https://github.com/apache/incubator-nuttx/pull/5510
## Summary
`vnc_remove_queue` would waiting for new frame update request forever
even if the connection is lost, the updater thread wouldn't exit.
But the server thread will join update
yamt commented on pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#issuecomment-1041131247
@xiaoxiang781216 i changed it as you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
xiaoxiang781216 commented on a change in pull request #5496:
URL: https://github.com/apache/incubator-nuttx/pull/5496#discussion_r807529757
##
File path: arch/common/src/Makefile
##
@@ -0,0 +1,27 @@
+
+
xiaoxiang781216 commented on a change in pull request #5496:
URL: https://github.com/apache/incubator-nuttx/pull/5496#discussion_r807529757
##
File path: arch/common/src/Makefile
##
@@ -0,0 +1,27 @@
+
+
yamt commented on pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507#issuecomment-1041094156
> > i tested this. sim:ostest on macOS (intel) just crashed immediately.
EXC_I386_GPFLT in printf, a common symptom of misaligned stack.
>
> you test on x86, not x64
xiaoxiang781216 commented on pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507#issuecomment-1041093008
> i tested this. sim:ostest on macOS (intel) just crashed immediately.
EXC_I386_GPFLT in printf, a common symptom of misaligned stack.
you test on x86, no
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 5f50547 libdsp: cosmetics changes from code review
add 5f67662 libc/sim: Rename arch_setjmp[64].S
xiaoxiang781216 merged pull request #5508:
URL: https://github.com/apache/incubator-nuttx/pull/5508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
yamt opened a new pull request #5509:
URL: https://github.com/apache/incubator-nuttx/pull/5509
## Summary
a followup fix for https://github.com/apache/incubator-nuttx/pull/5417
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respon
anchao commented on pull request #5506:
URL: https://github.com/apache/incubator-nuttx/pull/5506#issuecomment-1041045520
> @anchao Let me confirm the intention of this PR. I know that Cortex-M uses
a software interrupt-based context switch. So, are you going to apply the same
approach to a
xiaoxiang781216 edited a comment on pull request #5503:
URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1040337193
> Same question I raised at nuttx-apps: @xiaoxiang781216 what happened to
CLOCK_REALTIME? If I'm not wrong CLOCK_REALTIME is affected when you change the
zhuyanlinzyl commented on pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1041040646
@Ouss4 :
but ESP32 chip only have two swi interrupt:
```
#define ESP32_CPUINT_SOFTWARE0 7
#define ESP32_CPUINT_SOFTWARE1 29
```
only `E
yamt edited a comment on pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507#issuecomment-1040928306
i tested this.
sim:ostest on macOS (intel) just crashed immediately.
EXC_I386_GPFLT in printf, a common symptom of misaligned stack.
--
This is an automated
yamt commented on pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507#issuecomment-1040928306
i tested this.
sim:ostest on macOS just crashed immediately.
EXC_I386_GPFLT in printf, a common symptom of misaligned stack.
--
This is an automated message from th
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new b606cfa Publishing web
ptka commented on a change in pull request #5401:
URL: https://github.com/apache/incubator-nuttx/pull/5401#discussion_r807420665
##
File path: arch/sim/src/sim/up_initialstate.c
##
@@ -84,10 +97,10 @@ void up_initial_state(struct tcb_s *tcb)
* the return address.
*/
-
ptka edited a comment on pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507#issuecomment-1040920309
I tested this change together with
https://github.com/apache/incubator-nuttx/pull/5401 on MacBook Air M1 2020
running Monterey 12.2.1. Executed test: sim:nsh with a
ptka commented on pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507#issuecomment-1040920309
I tested this change together with
https://github.com/apache/incubator-nuttx/pull/5401 on MacBook Air M1 2020
running Monterey 12.2.1. Executed test: sim:nsh with addition
masayuki2009 commented on pull request #5506:
URL: https://github.com/apache/incubator-nuttx/pull/5506#issuecomment-1040891612
```
Configuration/Tool: sama5d2-xult/nsh,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABI
masayuki2009 commented on pull request #5506:
URL: https://github.com/apache/incubator-nuttx/pull/5506#issuecomment-1040884808
@anchao
Let me confirm the intention of this PR.
I know that Cortex-M uses a software interrupt-based context switch.
So, are you going to apply the same a
xiaoxiang781216 opened a new pull request #5508:
URL: https://github.com/apache/incubator-nuttx/pull/5508
Signed-off-by: Xiang Xiao
## Summary
to follow other arch/x86 arch/x86_64 convention:
https://github.com/apache/incubator-nuttx/pull/5188
## Impact
Refactor o
xiaoxiang781216 commented on a change in pull request #5401:
URL: https://github.com/apache/incubator-nuttx/pull/5401#discussion_r807272886
##
File path: arch/sim/src/sim/up_initialstate.c
##
@@ -84,10 +97,10 @@ void up_initial_state(struct tcb_s *tcb)
* the return address.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from fd8b087 Fix JLinkGDBServer crash attaching to target
add 26f1be2 libdsp/lib_observer.c: separate a
xiaoxiang781216 commented on pull request #5483:
URL: https://github.com/apache/incubator-nuttx/pull/5483#issuecomment-1040693268
> LGTM!
>
> But seems that CI fails because of some Beta feature "Unchanged files with
check annotations"
This is because this patch doesn't rebase
xiaoxiang781216 merged pull request #5483:
URL: https://github.com/apache/incubator-nuttx/pull/5483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 opened a new pull request #5507:
URL: https://github.com/apache/incubator-nuttx/pull/5507
## Summary
since the stack alignment handle correctly on sim now, we can remove the
hack from sim's up_initial_state.
## Impact
Fix the stack alignment on arm, lm32, minerv
xiaoxiang781216 commented on pull request #5503:
URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1040337193
> Same question I raised at nuttx-apps: @xiaoxiang781216 what happened to
CLOCK_REALTIME? If I'm not wrong CLOCK_REALTIME is affected when you change the
time/d
acassis commented on a change in pull request #5498:
URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r806862494
##
File path: sched/task/task_tls_alloc.c
##
@@ -0,0 +1,113 @@
+/
+ *
michi-jung commented on a change in pull request #5505:
URL: https://github.com/apache/incubator-nuttx/pull/5505#discussion_r806862156
##
File path: tools/jlink-nuttx.c
##
@@ -424,6 +449,11 @@ struct symbols_s *RTOS_GetSymbols(void)
uint32_t RTOS_GetNumThreads(void)
{
+ if
acassis commented on pull request #1005:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1005#issuecomment-1040326632
@xiaoxiang781216 what happened to CLOCK_REALTIME? If I'm not wrong
CLOCK_REALTIME is affected when you change the time/date and CLOCK_MONOTONIC is
not. Isn't goin
hartmannathan commented on pull request #1005:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1005#issuecomment-1040526737
> @xiaoxiang781216 what happened to CLOCK_REALTIME? If I'm not wrong
CLOCK_REALTIME is affected when you change the time/date and CLOCK_MONOTONIC is
not. Is
pkarashchenko commented on pull request #5503:
URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1040370659
I didn't have time to take a look to this change today. I will review it and
provide feedback asap
--
This is an automated message from the Apache Git Service.
xiaoxiang781216 edited a comment on pull request #5503:
URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1040337193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
acassis commented on pull request #5475:
URL: https://github.com/apache/incubator-nuttx/pull/5475#issuecomment-1040315890
@xiaoxiang781216 please fix the commit text:
Don't use shced_[lock|unlock] to do protection -> Don't use
sched_[lock|unlock] to do protection
--
This is an automat
pkarashchenko commented on a change in pull request #5505:
URL: https://github.com/apache/incubator-nuttx/pull/5505#discussion_r806858785
##
File path: tools/jlink-nuttx.c
##
@@ -424,6 +449,11 @@ struct symbols_s *RTOS_GetSymbols(void)
uint32_t RTOS_GetNumThreads(void)
{
+
xiaoxiang781216 merged pull request #5505:
URL: https://github.com/apache/incubator-nuttx/pull/5505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
acassis commented on pull request #5503:
URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1040327353
Same question I raised at nuttx-apps:
@xiaoxiang781216 what happened to CLOCK_REALTIME? If I'm not wrong
CLOCK_REALTIME is affected when you change the time/date and
pkarashchenko merged pull request #5500:
URL: https://github.com/apache/incubator-nuttx/pull/5500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
masayuki2009 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r806327482
##
File path: arch/arm/src/rtl8720c/Toolchain.defs
##
@@ -50,8 +50,8 @@ ifneq ($(CONFIG_ARMV8M_STACKCHECK),y)
endif
endif
-ARCHCFLAGS = -
xiaoxiang781216 commented on pull request #5475:
URL: https://github.com/apache/incubator-nuttx/pull/5475#issuecomment-1040341915
> @xiaoxiang781216 please fix the commit text: Don't use shced_[lock|unlock]
to do protection -> Don't use sched_[lock|unlock] to do protection
@acassis,
hartmannathan commented on pull request #5503:
URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1040528269
> > Same question I raised at nuttx-apps: @xiaoxiang781216 what happened to
CLOCK_REALTIME? If I'm not wrong CLOCK_REALTIME is affected when you change the
time/d
pkarashchenko merged pull request #5495:
URL: https://github.com/apache/incubator-nuttx/pull/5495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Ouss4 commented on a change in pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#discussion_r806687930
##
File path: arch/xtensa/include/syscall.h
##
@@ -29,10 +29,34 @@
* Included Files
zhuyanlinzyl commented on pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1039995268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
AlanRosenthal commented on a change in pull request #5375:
URL: https://github.com/apache/incubator-nuttx/pull/5375#discussion_r806261705
##
File path: boards/arm/samv7/common/scripts/flat.memory
##
@@ -22,10 +22,6 @@ include $(TOPDIR)/.config
include $(TOPDIR)/tools/Config.mk
masayuki2009 merged pull request #5490:
URL: https://github.com/apache/incubator-nuttx/pull/5490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
masayuki2009 commented on pull request #5490:
URL: https://github.com/apache/incubator-nuttx/pull/5490#issuecomment-1039662198
> @masayuki2009 could you try the new approach?
@no1wudi @xiaoxiang781216
Thanks, the new approach works.
--
This is an automated message from the
pkarashchenko merged pull request #1000:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
no1wudi commented on a change in pull request #5498:
URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r806781547
##
File path: libs/libc/tls/Kconfig
##
@@ -54,4 +54,14 @@ config TLS_NELEM
NOTE that the special value of CONFIG_TLS_NELEM disable
pkarashchenko commented on a change in pull request #5495:
URL: https://github.com/apache/incubator-nuttx/pull/5495#discussion_r806175553
##
File path: tools/jlink-nuttx.c
##
@@ -72,7 +72,7 @@ enum symbol_e
NSYMBOLS
};
-__attribute__ ((packed)) struct tcbinfo_s
+struct __
xiaoxiang781216 commented on pull request #5500:
URL: https://github.com/apache/incubator-nuttx/pull/5500#issuecomment-1040253066
> @xiaoxiang781216 please take a look at the conflict.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
pkarashchenko commented on a change in pull request #5347:
URL: https://github.com/apache/incubator-nuttx/pull/5347#discussion_r806208692
##
File path: arch/arm/src/cxd56xx/cxd56_sph.c
##
@@ -240,7 +240,7 @@ static inline int cxd56_sphdevinit(FAR const char *devname,
int num)
xiaoxiang781216 commented on pull request #5495:
URL: https://github.com/apache/incubator-nuttx/pull/5495#issuecomment-1040168590
I fine with either if both side is sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
xiaoxiang781216 merged pull request #4995:
URL: https://github.com/apache/incubator-nuttx/pull/4995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
pkarashchenko merged pull request #5492:
URL: https://github.com/apache/incubator-nuttx/pull/5492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiaoxiang781216 merged pull request #5497:
URL: https://github.com/apache/incubator-nuttx/pull/5497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
zhuyanlinzyl commented on a change in pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#discussion_r806730263
##
File path: arch/xtensa/include/syscall.h
##
@@ -29,10 +29,34 @@
* Included Files
*
xiaoxiang781216 commented on a change in pull request #5495:
URL: https://github.com/apache/incubator-nuttx/pull/5495#discussion_r806395702
##
File path: tools/jlink-nuttx.c
##
@@ -72,7 +72,7 @@ enum symbol_e
NSYMBOLS
};
-__attribute__ ((packed)) struct tcbinfo_s
+struct
raiden00pl commented on pull request #5483:
URL: https://github.com/apache/incubator-nuttx/pull/5483#issuecomment-1039260056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
yamt commented on pull request #5476:
URL: https://github.com/apache/incubator-nuttx/pull/5476#issuecomment-1039809571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
yamt commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r806330264
##
File path: tools/ci/testlist/sim-02.dat
##
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Review commen
Ouss4 edited a comment on pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1040222128
Note that enabling a CPU interrupt must be done from the specific CPU. We
cannot enable CPU1's interrupts from CPU0.
In this case then, I believe we need:
1.
pkarashchenko commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r806135123
##
File path: arch/arm/src/rtl8720c/Toolchain.defs
##
@@ -50,8 +50,8 @@ ifneq ($(CONFIG_ARMV8M_STACKCHECK),y)
endif
endif
-ARCHCFLAGS =
davids5 commented on pull request #5493:
URL: https://github.com/apache/incubator-nuttx/pull/5493#issuecomment-1039317266
@acassis - please merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xiaoxiang781216 commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-nuttx/pull/5382#discussion_r806410039
##
File path: tools/ci/testlist/sim-02.dat
##
@@ -1,5 +1,8 @@
/sim/*/*/*/[o-z]*
+# heavy test, moved to a separate set
+-sim:ostest
Re
xiaoxiang781216 commented on pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#issuecomment-1039826690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
xiaoxiang781216 merged pull request #5502:
URL: https://github.com/apache/incubator-nuttx/pull/5502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
pkarashchenko commented on a change in pull request #5375:
URL: https://github.com/apache/incubator-nuttx/pull/5375#discussion_r806215491
##
File path: boards/arm/samv7/common/scripts/flat.memory
##
@@ -22,10 +22,6 @@ include $(TOPDIR)/.config
include $(TOPDIR)/tools/Config.mk
Ouss4 commented on pull request #5500:
URL: https://github.com/apache/incubator-nuttx/pull/5500#issuecomment-1040230136
@xiaoxiang781216 please take a look at the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pkarashchenko commented on a change in pull request #5504:
URL: https://github.com/apache/incubator-nuttx/pull/5504#discussion_r806748839
##
File path: mm/mm_heap/mm_sem.c
##
@@ -104,9 +104,23 @@ bool mm_takesemaphore(FAR struct mm_heap_s *heap)
#if defined(CONFIG_BUILD_FLAT)
michi-jung commented on a change in pull request #5495:
URL: https://github.com/apache/incubator-nuttx/pull/5495#discussion_r806181491
##
File path: tools/jlink-nuttx.c
##
@@ -72,7 +72,7 @@ enum symbol_e
NSYMBOLS
};
-__attribute__ ((packed)) struct tcbinfo_s
+struct __att
zhuyanlinzyl edited a comment on pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1040176487
@Ouss4 I think I have find the reason:
CPU1 have not generate swi interrupt at all.
As esp32 only have two software interrupt bit:
`#de
pkarashchenko commented on a change in pull request #5490:
URL: https://github.com/apache/incubator-nuttx/pull/5490#discussion_r806133654
##
File path: arch/risc-v/src/k210/k210_head.S
##
@@ -53,6 +53,13 @@ __start:
j2f
1:
+ /* In case of single CPU config, stop here
freakishness closed pull request #1004:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
AlanRosenthal commented on a change in pull request #5496:
URL: https://github.com/apache/incubator-nuttx/pull/5496#discussion_r806283845
##
File path: tools/Config.mk
##
@@ -548,3 +548,11 @@ else
ARCHXXINCLUDES += ${shell $(INCDIR) -s "$(CC)"
$(TOPDIR)$(DELIM)include$(DELI
pkarashchenko merged pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pkarashchenko commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473#discussion_r806139302
##
File path: arch/sim/src/sim/up_vfork.c
##
@@ -93,8 +93,8 @@ pid_t up_vfork(const xcpt_reg_t *context)
xcpt_reg_t stackutil;
sinfo
xiaoxiang781216 commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#discussion_r806405475
##
File path: arch/arm/src/rtl8720c/Toolchain.defs
##
@@ -50,8 +50,8 @@ ifneq ($(CONFIG_ARMV8M_STACKCHECK),y)
endif
endif
-ARCHCFLAGS
pkarashchenko commented on a change in pull request #5496:
URL: https://github.com/apache/incubator-nuttx/pull/5496#discussion_r806270884
##
File path: boards/arm/samv7/common/scripts/flat.memory
##
@@ -22,10 +22,6 @@ include $(TOPDIR)/.config
include $(TOPDIR)/tools/Config.mk
masayuki2009 merged pull request #5477:
URL: https://github.com/apache/incubator-nuttx/pull/5477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
xiaoxiang781216 merged pull request #5363:
URL: https://github.com/apache/incubator-nuttx/pull/5363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
pkarashchenko commented on a change in pull request #5498:
URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r806720452
##
File path: libs/libc/tls/Kconfig
##
@@ -54,4 +54,14 @@ config TLS_NELEM
NOTE that the special value of CONFIG_TLS_NELEM d
michi-jung commented on pull request #5495:
URL: https://github.com/apache/incubator-nuttx/pull/5495#issuecomment-1039928286
Current GCC documentation states:
> packed - This attribute, attached to a struct, union, or C++ class type
definition, specifies that each of its members (oth
pkarashchenko commented on pull request #5495:
URL: https://github.com/apache/incubator-nuttx/pull/5495#issuecomment-1039744199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
xiaoxiang781216 merged pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 merged pull request #5493:
URL: https://github.com/apache/incubator-nuttx/pull/5493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
Ouss4 commented on pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1040217940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
AlanRosenthal commented on pull request #5375:
URL: https://github.com/apache/incubator-nuttx/pull/5375#issuecomment-1039572920
To make this PR easier to review, I moved a lot of the changes to #5496
--
This is an automated message from the Apache Git Service.
To respond to the message, p
xiaoxiang781216 commented on pull request #5499:
URL: https://github.com/apache/incubator-nuttx/pull/5499#issuecomment-1040020296
@freakishness please fix the style issue report here:
https://github.com/apache/incubator-nuttx/runs/5194562951?check_suite_focus=true
you can check locall
zhuyanlinzyl commented on pull request #5407:
URL: https://github.com/apache/incubator-nuttx/pull/5407#issuecomment-1039800932
@Ouss4 It's my mistake. qemu-system-xtensa work now. Thanks for you advice.
--
This is an automated message from the Apache Git Service.
To respond t
xiaoxiang781216 commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473#discussion_r806427648
##
File path: arch/sim/src/sim/up_vfork.c
##
@@ -93,8 +93,8 @@ pid_t up_vfork(const xcpt_reg_t *context)
xcpt_reg_t stackutil;
sin
xiaoxiang781216 commented on a change in pull request #5496:
URL: https://github.com/apache/incubator-nuttx/pull/5496#discussion_r806410593
##
File path: arch/arm/src/Makefile
##
@@ -19,6 +19,7 @@
xiaoxiang781216 commented on pull request #5501:
URL: https://github.com/apache/incubator-nuttx/pull/5501#issuecomment-1039965544
> mention it in boards/sim/sim/sim/README.txt? otherwise lgtm
Done.
--
This is an automated message from the Apache Git Service.
To respond to the messa
xiaoxiang781216 merged pull request #5494:
URL: https://github.com/apache/incubator-nuttx/pull/5494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
pkarashchenko commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-nuttx/pull/5483#discussion_r806142300
##
File path: include/dsp.h
##
@@ -529,31 +535,32 @@ void foc_vdq_mag_max_get(FAR struct foc_data_f32_s *foc,
FAR float *max);
/* BLDC/P
davids5 commented on a change in pull request #5504:
URL: https://github.com/apache/incubator-nuttx/pull/5504#discussion_r806782591
##
File path: mm/mm_heap/mm_sem.c
##
@@ -104,9 +104,23 @@ bool mm_takesemaphore(FAR struct mm_heap_s *heap)
#if defined(CONFIG_BUILD_FLAT) || def
1 - 100 of 170 matches
Mail list logo
