Re: [PR] nuttx/crypto: support new algorithm about crc32 and aes-cmac [nuttx]

2025-07-24 Thread via GitHub
yamt commented on code in PR #13173: URL: https://github.com/apache/nuttx/pull/13173#discussion_r2230259211 ## include/crypto/cryptodev.h: ## @@ -215,6 +220,7 @@ struct cryptop caddr_t crp_mac; caddr_t crp_dst; caddr_t crp_iv; + caddr_t crp_aad; Review Comment: who

Re: [PR] pci: epc add dma heap [nuttx]

2025-07-24 Thread via GitHub
lipengfei28 commented on code in PR #16767: URL: https://github.com/apache/nuttx/pull/16767#discussion_r2230240796 ## drivers/pci/pci_epc.c: ## @@ -993,6 +996,17 @@ pci_epc_create(FAR const char *name, FAR void *priv, return NULL; } + if (dma_addr && dma_len) +

Re: [PR] pci: epc add dma heap [nuttx]

2025-07-24 Thread via GitHub
lipengfei28 commented on code in PR #16767: URL: https://github.com/apache/nuttx/pull/16767#discussion_r2230241127 ## drivers/pci/pci_epc.c: ## @@ -1036,3 +1054,92 @@ void pci_epc_destroy(FAR struct pci_epc_ctrl_s *epc) nxmutex_destroy(&epc->lock); kmm_free(epc); } + +/**

Re: [PR] pci: epc add dma heap [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #16767: URL: https://github.com/apache/nuttx/pull/16767#discussion_r2230232358 ## drivers/pci/pci_epc.c: ## @@ -975,8 +978,8 @@ void pci_epc_bme_notify(FAR struct pci_epc_ctrl_s *epc) *

Re: [PR] arch/sim: avoid host-call being interrupted before getting errno [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on PR #16742: URL: https://github.com/apache/nuttx/pull/16742#issuecomment-3116524592 > > > > > > This commit disable interrupts before and after host-APIs, make sure that errno is correct. > > > > > > > > > > > > the interrupt must be disabled, since man

[PR] esp32s3_extraheaps.c: add a missing include for xtensa_imm_initialize [nuttx]

2025-07-24 Thread via GitHub
yamt opened a new pull request, #16769: URL: https://github.com/apache/nuttx/pull/16769 ## Summary esp32s3_extraheaps.c: add a missing include for xtensa_imm_initialize ## Impact build fix ## Testing i have had an equivalent of this in my local tree for a wh

Re: [PR] arch/sim: avoid host-call being interrupted before getting errno [nuttx]

2025-07-24 Thread via GitHub
yamt commented on PR #16742: URL: https://github.com/apache/nuttx/pull/16742#issuecomment-3116354526 > 2. Many host APIs lack robust error recovery when interrupted by signals. For example, when read() a file is interruped by a signal, it will return error directly. (here disable interr

Re: [PR] arch/sim: avoid host-call being interrupted before getting errno [nuttx]

2025-07-24 Thread via GitHub
yamt commented on PR #16742: URL: https://github.com/apache/nuttx/pull/16742#issuecomment-3116338055 > > > > > This commit disable interrupts before and after host-APIs, make sure that errno is correct. > > > > > > > > > the interrupt must be disabled, since many host API can't wo

Re: [PR] include: Fix bug related to string.h's str[|n]dup [nuttx]

2025-07-24 Thread via GitHub
GUIDINGLI commented on PR #16766: URL: https://github.com/apache/nuttx/pull/16766#issuecomment-3116329298 @tmedicci Please see: https://github.com/apache/nuttx/pull/16768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] libc: fix assert "Free memory from the wrong heap" with flat mode and… [nuttx]

2025-07-24 Thread via GitHub
GUIDINGLI commented on PR #16768: URL: https://github.com/apache/nuttx/pull/16768#issuecomment-3116325268 @royfengsss kernel code, like net driver fs ... strdup -> nx_strdup -> kmm_malloc lib_free -> kmm_free app code, like stdlib... strdup -> malloc free -> free

Re: [PR] arch/sim: avoid host-call being interrupted before getting errno [nuttx]

2025-07-24 Thread via GitHub
zzby0 commented on PR #16742: URL: https://github.com/apache/nuttx/pull/16742#issuecomment-3116315589 > > > > This commit disable interrupts before and after host-APIs, make sure that errno is correct. > > > > > > the interrupt must be disabled, since many host API can't work well

[PR] libc: fix assert "Free memory from the wrong heap" with flat mode and… [nuttx]

2025-07-24 Thread via GitHub
GUIDINGLI opened a new pull request, #16768: URL: https://github.com/apache/nuttx/pull/16768 ## Summary libc: fix assert "Free memory from the wrong heap" with flat mode and user separated heap enabled mode In flat mode: kernel code, like net driver... strdup-> nx

Re: [PR] arch/sim: avoid host-call being interrupted before getting errno [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on PR #16742: URL: https://github.com/apache/nuttx/pull/16742#issuecomment-3116304244 > > > > This commit disable interrupts before and after host-APIs, make sure that errno is correct. > > > > > > the interrupt must be disabled, since many host API can't

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
yamt commented on PR #16756: URL: https://github.com/apache/nuttx/pull/16756#issuecomment-3116293490 > > > please let me test a bit. > > > > > > this breaks my configuration. > > my configuration assumes spiram is available for text heap. (for wamr) the configuration also uses

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
yamt commented on code in PR #16756: URL: https://github.com/apache/nuttx/pull/16756#discussion_r2230061679 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -1090,9 +1090,12 @@ choice ESP32S3_SPIRAM_HEAP config ESP32S3_SPIRAM_COMMON_HEAP bool "Additional region to kernel hea

Re: [PR] include: Fix bug related to string.h's str[|n]dup [nuttx]

2025-07-24 Thread via GitHub
GUIDINGLI commented on PR #16766: URL: https://github.com/apache/nuttx/pull/16766#issuecomment-3116260727 @tmedicci Please provide the detail malloc backtrace & free backtrace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] arch/sim: avoid host-call being interrupted before getting errno [nuttx]

2025-07-24 Thread via GitHub
yamt commented on PR #16742: URL: https://github.com/apache/nuttx/pull/16742#issuecomment-3116238071 > > > This commit disable interrupts before and after host-APIs, make sure that errno is correct. > > the interrupt must be disabled, since many host API can't work well if the interr

Re: [PR] pci: epc add dma heap [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #16767: URL: https://github.com/apache/nuttx/pull/16767#discussion_r2230037570 ## drivers/pci/pci_epc.c: ## @@ -975,8 +978,8 @@ void pci_epc_bme_notify(FAR struct pci_epc_ctrl_s *epc) *

Re: [PR] tools/nix: Add Nix flake for reproducible dev environment [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on PR #16763: URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3116218377 @comejv please fix the documentation build warning: ``` Warning, treated as error: /home/runner/work/nuttx/nuttx/Documentation/guides/nix_flake.rst:2:Title underline too s

[PR] pci: epc add dma heap [nuttx]

2025-07-24 Thread via GitHub
lipengfei28 opened a new pull request, #16767: URL: https://github.com/apache/nuttx/pull/16767 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary add pci epc dma heap,The PCI inbound address space and the CPU

(nuttx) branch master updated: drivers/sensors/l86xxx: Fix kernel crashes on failed registration

2025-07-24 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new da72df9ab6 drivers/sensors/l86xxx: Fix kernel

Re: [PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 merged PR #16764: URL: https://github.com/apache/nuttx/pull/16764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [I] [HELP] NuttX fatfs vs elm-chan.org fatfs [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on issue #16761: URL: https://github.com/apache/nuttx/issues/16761#issuecomment-3115952378 @Donny9 look at this question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] nucleo-h743zi: Add ADC2 support and expand ADC channel list [nuttx]

2025-07-24 Thread via GitHub
acassis commented on code in PR #16765: URL: https://github.com/apache/nuttx/pull/16765#discussion_r2229611690 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_adc.c: ## @@ -66,30 +64,46 @@ #ifdef CONFIG_STM32H7_ADC1 /* Identifying number of each ADC channel: Variable Resistor.

Re: [I] [HELP] Timer capture on nucleo stm32h743zi [nuttx]

2025-07-24 Thread via GitHub
acassis commented on issue #16762: URL: https://github.com/apache/nuttx/issues/16762#issuecomment-3114991478 @comejv I think he have example support only for Espressif chip. @raiden00pl did you get it working on STM32? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] tools/nix: Add Nix flake for reproducible dev environment [nuttx]

2025-07-24 Thread via GitHub
acassis commented on PR #16763: URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3114981572 > Woops, not sure if I should have force pushed there... But I added a very simple doc page, and added it to the index.rst too. Do I need to do something else? I've never worked with this

[PR] include: Fix bug related to string.h's str[|n]dup [nuttx]

2025-07-24 Thread via GitHub
tmedicci opened a new pull request, #16766: URL: https://github.com/apache/nuttx/pull/16766 ## Summary * include: Fix bug related to string.h's str[|n]dup Defining `strdup` and `strndup` to (respectively) `nx_strdup` and `nx_strndup` should only apply when `CONFIG_BUILD_FLAT` i

Re: [PR] tools/nix: Add Nix flake for reproducible dev environment [nuttx]

2025-07-24 Thread via GitHub
comejv commented on PR #16763: URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3114820138 Woops, not sure if I should have force pushed there... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] nucleo-h743zi: Add ADC2 support and expand ADC channel list [nuttx]

2025-07-24 Thread via GitHub
comejv opened a new pull request, #16765: URL: https://github.com/apache/nuttx/pull/16765 ## Summary Updates `nucleo-stm32h743zi/include/board.h` and `nucleo-stm32h743zi` to add initialization for ADC2 and more channels and their pin mappings. ## Impact This change makes

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2229481914 ## drivers/misc/optee.c: ## @@ -1218,15 +1239,18 @@ int optee_shm_alloc(FAR struct optee_priv_data *priv, FAR void *addr, ptr = addr; } - if (ptr =

Re: [PR] tools/nix: Add Nix flake for reproducible dev environment [nuttx]

2025-07-24 Thread via GitHub
acassis commented on PR #16763: URL: https://github.com/apache/nuttx/pull/16763#issuecomment-3114780039 @comejv please include a Documentation/ entry to let more people discover and use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2229392329 ## drivers/misc/optee.c: ## @@ -980,49 +1031,34 @@ optee_ioctl_shm_alloc(FAR struct optee_priv_data *priv, FAR struct tee_ioctl_shm_alloc_da

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2229436507 ## drivers/misc/optee.c: ## @@ -1088,6 +1034,130 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return ret; } +#ifdef CONFIG_DEV_OPTEE_SUPPLI

[PR] drivers/sensors/l86xxx: Fix driver registration crashes [nuttx]

2025-07-24 Thread via GitHub
linguini1 opened a new pull request, #16764: URL: https://github.com/apache/nuttx/pull/16764 ## Summary Sometimes this driver will boot when the serial port is of the wrong baud rate, and it cannot set the correct baud rate or verify communication. This commit prevents registration i

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2229392329 ## drivers/misc/optee.c: ## @@ -980,49 +1031,34 @@ optee_ioctl_shm_alloc(FAR struct optee_priv_data *priv, FAR struct tee_ioctl_shm_alloc_da

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2229358257 ## drivers/misc/optee.c: ## @@ -1088,6 +1034,130 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return ret; } +#ifdef CONFIG_DEV_OPTEE_SUPPLI

[PR] tools/nix: Add Nix flake for reproducible dev environment [nuttx]

2025-07-24 Thread via GitHub
comejv opened a new pull request, #16763: URL: https://github.com/apache/nuttx/pull/16763 # Add Nix flake for reproducible development environment This pull request introduces a Nix flake (`flake.nix` and `flake.lock`) to provide a reproducible development shell for NuttX using Nix an

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2229341353 ## drivers/misc/optee.c: ## @@ -1218,15 +1239,18 @@ int optee_shm_alloc(FAR struct optee_priv_data *priv, FAR void *addr, ptr = addr; } - if (ptr =

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2229245524 ## sched/sched/sched_unlock.c: ## @@ -81,18 +89,28 @@ void sched_unlock(void) sched_note_preemption(rtcb, false); /* Release any ready-t

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2229101591 ## drivers/misc/optee.c: ## @@ -491,6 +488,60 @@ static int optee_shm_close(FAR struct file *filep) return 0; } +/

Re: [PR] examples/xedge: Add Xedge example with BAS integration [nuttx-apps]

2025-07-24 Thread via GitHub
JorgeGzm commented on code in PR #3120: URL: https://github.com/apache/nuttx-apps/pull/3120#discussion_r2229151601 ## netutils/xedge/Make.defs: ## @@ -0,0 +1,35 @@ + +# apps/netutils/xedge/Make.defs +# +

Re: [I] [HELP] Timer capture on nucleo stm32h743zi [nuttx]

2025-07-24 Thread via GitHub
comejv commented on issue #16762: URL: https://github.com/apache/nuttx/issues/16762#issuecomment-3114179848 My goal is timer capture on four inputs. With HAL i can do it with HAL_TIM_IC_Start_IT and HAL_TIM_IC_ConfigChannel on all 4 channels of timer 4, can I use different channels for one

[I] [HELP] Timer capture on nucleo stm32h743zi [nuttx]

2025-07-24 Thread via GitHub
comejv opened a new issue, #16762: URL: https://github.com/apache/nuttx/issues/16762 ### Description Hello, I need to use timer capture on my nucleo-stm32h743zi. I haven't found anything related to it in the sources, but there are lower half drivers for capture in the stm32/ folder (

Re: [PR] drivers/misc/optee: expand RPC suppport for IMX9 [nuttx]

2025-07-24 Thread via GitHub
tkaratapanis commented on code in PR #16734: URL: https://github.com/apache/nuttx/pull/16734#discussion_r2228987021 ## drivers/misc/optee_supplicant.h: ## @@ -0,0 +1,73 @@ +/ + * drivers/misc/optee_suppl

Re: [PR] tee/optee_supplicant: Added optee supplicant [nuttx-apps]

2025-07-24 Thread via GitHub
tkaratapanis commented on PR #3141: URL: https://github.com/apache/nuttx-apps/pull/3141#issuecomment-3114082461 > Thank you @tkaratapanis :-) Please remember to `git commit -s` (put a signature on the commits, this is mandatory, see https://github.com/apache/nuttx/blob/master/CONTRIBUTING.m

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228959313 ## sched/sched/sched_unlock.c: ## @@ -69,28 +76,41 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228956996 ## sched/sched/sched.h: ## @@ -518,23 +514,51 @@ static inline_function bool nxsched_add_prioritized(FAR struct tcb_s *tcb, } # ifdef CONFIG_SMP + +/* Try to swi

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228953083 ## sched/sched/sched_process_delivered.c: ## @@ -78,67 +72,31 @@ void nxsched_process_delivered(int cpu) g_cpu_irqset |= (1 << cpu); } - tcb = current_t

Re: [I] [HELP] NuttX fatfs vs elm-chan.org fatfs [nuttx]

2025-07-24 Thread via GitHub
Laczen commented on issue #16761: URL: https://github.com/apache/nuttx/issues/16761#issuecomment-3113990870 @acassis @xiaoxiang781216 thanks for replying. I am wondering what (if any) the advantage would be of using elm-chan.org fatfs. I am mainly interested in creating really small (

Re: [PR] drivers/usbhost: Update usbhost_hidkbd.c [nuttx]

2025-07-24 Thread via GitHub
acassis commented on PR #15917: URL: https://github.com/apache/nuttx/pull/15917#issuecomment-3113984263 @StagiaireAbritek ping! Please fix the issue "Wrong column position of comment right of code" at line 620 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] examples/xedge: Add Xedge example with BAS integration [nuttx-apps]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #3120: URL: https://github.com/apache/nuttx-apps/pull/3120#discussion_r2228778191 ## examples/xedge_demo/xedge_main.c: ## @@ -0,0 +1,254 @@ +/*** + * apps/examples/xed

Re: [PR] examples/xedge: Add Xedge example with BAS integration [nuttx-apps]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #3120: URL: https://github.com/apache/nuttx-apps/pull/3120#discussion_r2228777579 ## netutils/xedge/Make.defs: ## @@ -0,0 +1,35 @@ + +# apps/netutils/xedge/Make.de

Re: [I] [HELP] NuttX fatfs vs elm-chan.org fatfs [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on issue #16761: URL: https://github.com/apache/nuttx/issues/16761#issuecomment-3113800688 We are using elm-chan version for many years, here is the porting: https://github.com/open-vela/nuttx/tree/dev/fs/fatfs -- This is an automated message from the Apache Git

Re: [I] [HELP] NuttX fatfs vs elm-chan.org fatfs [nuttx]

2025-07-24 Thread via GitHub
acassis commented on issue #16761: URL: https://github.com/apache/nuttx/issues/16761#issuecomment-3113773275 @Laczen the NuttX fatfs is very stable and works fine. There are many products using it in the field. But elm-chan.org fatfs has more features including exFAT support (that could req

Re: [PR] examples/xedge: Add Xedge example with BAS integration [nuttx-apps]

2025-07-24 Thread via GitHub
JorgeGzm commented on code in PR #3120: URL: https://github.com/apache/nuttx-apps/pull/3120#discussion_r2228742300 ## examples/xedge_demo/Make.defs: ## @@ -0,0 +1,24 @@ + +# apps/examples/xedge_demo/Make

Re: [PR] tools/nxstyle.c: Updating white list to xedge example [nuttx]

2025-07-24 Thread via GitHub
acassis commented on PR #16759: URL: https://github.com/apache/nuttx/pull/16759#issuecomment-3113731412 > Out of curiosity, can't you use aliases like `boards/xtensa/esp32/common/scripts/esp32_aliases.ld`? The xedge demo was using alias, but @xiaoxiang781216 suggested to use ignore b

Re: [PR] tools/nxstyle.c: Updating white list to xedge example [nuttx]

2025-07-24 Thread via GitHub
acassis merged PR #16759: URL: https://github.com/apache/nuttx/pull/16759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated: tools/nxstyle.c: Updating white list to xedge example

2025-07-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b78b870d68 tools/nxstyle.c: Updating white list

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
tmedicci commented on PR #16756: URL: https://github.com/apache/nuttx/pull/16756#issuecomment-3113695534 > > > please let me test a bit. > > > > > > this breaks my configuration. > > my configuration assumes spiram is available for text heap. (for wamr) the configuration also u

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
tmedicci commented on PR #16756: URL: https://github.com/apache/nuttx/pull/16756#issuecomment-3113650554 Sorry, closed by accident. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
tmedicci commented on PR #16756: URL: https://github.com/apache/nuttx/pull/16756#issuecomment-3113648999 > up_textheap_memalign -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
tmedicci closed pull request #16756: esp32s3: Fix bug related to the PSRAM-allocated task stack URL: https://github.com/apache/nuttx/pull/16756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
tmedicci commented on code in PR #16756: URL: https://github.com/apache/nuttx/pull/16756#discussion_r2228649111 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -1090,9 +1090,12 @@ choice ESP32S3_SPIRAM_HEAP config ESP32S3_SPIRAM_COMMON_HEAP bool "Additional region to kernel

Re: [PR] reduce the dup of errno and errno str, add host_errno_convert method [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on code in PR #1: URL: https://github.com/apache/nuttx/pull/1#discussion_r2228637029 ## arch/sim/src/sim/posix/sim_host_v4l2.c: ## @@ -187,7 +189,7 @@ int host_video_start_capture(struct host_video_dev_s *vdev) if (-1 == host_video_ioctl(vdev

Re: [PR] esp32s3: Fix bug related to the PSRAM-allocated task stack [nuttx]

2025-07-24 Thread via GitHub
tmedicci commented on PR #16756: URL: https://github.com/apache/nuttx/pull/16756#issuecomment-3113617106 > > please let me test a bit. > > this breaks my configuration. > > my configuration assumes spiram is available for text heap. (for wamr) the configuration also uses wifi.

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on PR #16673: URL: https://github.com/apache/nuttx/pull/16673#issuecomment-3113580029 Thanks @fdcavalcanti for testing! I'll check it tomorrow! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
hujun260 commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228525984 ## sched/sched/sched_unlock.c: ## @@ -69,28 +76,41 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
hujun260 commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228505079 ## sched/sched/sched.h: ## @@ -518,23 +514,51 @@ static inline_function bool nxsched_add_prioritized(FAR struct tcb_s *tcb, } # ifdef CONFIG_SMP + +/* Try to swi

Re: [PR] tools/nxstyle.c: Updating white list to xedge example [nuttx]

2025-07-24 Thread via GitHub
fdcavalcanti commented on PR #16759: URL: https://github.com/apache/nuttx/pull/16759#issuecomment-3113456406 Out of curiosity, can't you use aliases like `boards/xtensa/esp32/common/scripts/esp32_aliases.ld`? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
fdcavalcanti commented on PR #16673: URL: https://github.com/apache/nuttx/pull/16673#issuecomment-3113434882 I found issues on ESP32S3, can you check please? This error happened on: `esp32s3-lcd-ev:audio`, `esp32s3-devkit:fastboot_tcp` and a few others. ``` 2025-07-24 12:49:

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
hujun260 commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228471323 ## sched/sched/sched_process_delivered.c: ## @@ -78,67 +72,31 @@ void nxsched_process_delivered(int cpu) g_cpu_irqset |= (1 << cpu); } - tcb = current_t

[I] [HELP] NuttX fatfs vs elm-chan.org fatfs [nuttx]

2025-07-24 Thread via GitHub
Laczen opened a new issue, #16761: URL: https://github.com/apache/nuttx/issues/16761 ### Description NuttX contains support for the fat filesystem. There also is a fatfs library from elm-chan.org that seems to be quite popular. The fatfs library from elm-chan.org seems to be well mai

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
fdcavalcanti commented on PR #16673: URL: https://github.com/apache/nuttx/pull/16673#issuecomment-3113140740 > I made some testing; executed some px4 based FC apps on MFPS with CONFIG_BUILD_KERNEL=y, CONFIG_SMP_NCPUS=4, CONFIG_DEBUG_ASSERTIONS=y, CONFIG_PRIORITY_INHERITANCE=y > > Thi

Re: [PR] example/xedge_demo: Updating white list to xedge example [nuttx]

2025-07-24 Thread via GitHub
simbit18 commented on PR #16759: URL: https://github.com/apache/nuttx/pull/16759#issuecomment-3112820641 @JorgeGzm maybe better to change part of the title from **example/xedge_demo:** to **tools/nxstyle.c:** -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228006231 ## sched/sched/sched_unlock.c: ## @@ -69,10 +69,12 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2228006231 ## sched/sched/sched_unlock.c: ## @@ -69,10 +69,12 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -

[I] [BUG] rand()'s cycle seems too short [nuttx]

2025-07-24 Thread via GitHub
yamt opened a new issue, #16760: URL: https://github.com/apache/nuttx/issues/16760 ### Description / Steps to reproduce the issue nuttx's rand() implementation is a bit poor and, with the default CONFIG_LIBC_RAND_ORDER=1, it seems to produce the same values for every 903 calls. 9

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2227827796 ## sched/sched/sched_unlock.c: ## @@ -69,10 +69,12 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -

Re: [PR] arch/arm/rp23xx : Fix gpio for RP2350B [nuttx]

2025-07-24 Thread via GitHub
xiaoxiang781216 commented on PR #16703: URL: https://github.com/apache/nuttx/pull/16703#issuecomment-3112509839 I saw you approve the patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
hujun260 commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2227766487 ## sched/sched/sched_unlock.c: ## @@ -69,10 +69,12 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
jlaitine commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2227717113 ## sched/sched/sched_unlock.c: ## @@ -69,10 +69,12 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -

Re: [PR] arch/arm/rp23xx : Fix gpio for RP2350B [nuttx]

2025-07-24 Thread via GitHub
jerpelea commented on PR #16703: URL: https://github.com/apache/nuttx/pull/16703#issuecomment-3112380831 @xiaoxiang781216 this patch has been merged without proper commit messages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-24 Thread via GitHub
hujun260 commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2227644642 ## sched/sched/sched_unlock.c: ## @@ -69,10 +69,12 @@ void sched_unlock(void) * then pre-emption has been re-enabled. */ - if (rtcb != NULL && -