Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-25 Thread via GitHub
jasonbu commented on PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#issuecomment-2309419719 there is a memleak case can reproduce in current code. ```C int main(int argc, FAR char *argv[]) { printf("Hello, World!!\n"); system("111 &"); // system("sle

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730400928 ## builtin/exec_builtin.c: ## @@ -24,11 +24,11 @@ #include -#include #include #include #include +#include "nshlib/nshlib.h" Review Comment:

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730400928 ## builtin/exec_builtin.c: ## @@ -24,11 +24,11 @@ #include -#include #include #include #include +#include "nshlib/nshlib.h" Review Comment:

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-24 Thread via GitHub
anchao commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730047526 ## builtin/exec_builtin.c: ## @@ -24,11 +24,11 @@ #include -#include #include #include #include +#include "nshlib/nshlib.h" Review Comment: For exa

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-24 Thread via GitHub
anchao commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730047037 ## builtin/exec_builtin.c: ## @@ -24,11 +24,11 @@ #include -#include #include #include #include +#include "nshlib/nshlib.h" Review Comment: nshlib

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-24 Thread via GitHub
anchao commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730047037 ## builtin/exec_builtin.c: ## @@ -24,11 +24,11 @@ #include -#include #include #include #include +#include "nshlib/nshlib.h" Review Comment: nshlib

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-24 Thread via GitHub
jasonbu commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730039637 ## nshlib/nsh_parse.c: ## @@ -441,97 +421,25 @@ static void nsh_alist_free(FAR struct nsh_vtbl_s *vtbl, } #endif -/**

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-24 Thread via GitHub
pkarashchenko commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730034274 ## nshlib/nsh_parse.c: ## @@ -441,97 +421,25 @@ static void nsh_alist_free(FAR struct nsh_vtbl_s *vtbl, } #endif -/

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-24 Thread via GitHub
xiaoxiang781216 commented on PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#issuecomment-2308438785 > looks like the nuttx/boards/arm64/qemu/qemu-armv8a/configs/knsh/defconfig did not export the **task_spawn** API ? task_spawn doesn't exist in kernel build. -- This i

Re: [PR] nshlib: add nsh_spawn to avoid the code duplication [nuttx-apps]

2024-08-24 Thread via GitHub
jasonbu commented on PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#issuecomment-2308428680 looks like the nuttx/boards/arm64/qemu/qemu-armv8a/configs/knsh/defconfig did not export the **task_spawn** API ? -- This is an automated message from the Apache Git Service. To re