[GitHub] [incubator-pinot] jackjlli opened a new pull request #4623: [Pinot Bench Service] Implement cluster management component

2019-09-18 Thread GitBox
jackjlli opened a new pull request #4623: [Pinot Bench Service] Implement cluster management component URL: https://github.com/apache/incubator-pinot/pull/4623 This PR implements cluster management component. API to create perf table: ``` curl 'localhost:9008/cluster/createTabl

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4622: Standardize the Dictionary interface, ensure the BYTES support

2019-09-18 Thread GitBox
Jackie-Jiang opened a new pull request #4622: Standardize the Dictionary interface, ensure the BYTES support URL: https://github.com/apache/incubator-pinot/pull/4622 - Type conversion between INT/LONG/FLOAT/DOUBLE/STRING are allowed - Type conversion between STRING/BYTES are allowed -

[incubator-pinot] branch enhance_dictionary created (now 404c79f)

2019-09-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch enhance_dictionary in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 404c79f Standardize the Dictionary interface, ensure the BYTES support No new revisions were a

[GitHub] [incubator-pinot] icefury71 commented on issue #4585: Presence vector

2019-09-18 Thread GitBox
icefury71 commented on issue #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#issuecomment-532923579 > Sorry for the delay. I was out for a while for the conference. > > Would you add the following to the commit message? > > 1. Link #4230 for the

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

2019-09-18 Thread GitBox
icefury71 commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r325952566 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/BitmapDocIdSet.java ## @@ -33,7 +36,8 @@

[GitHub] [incubator-pinot] jihaozh commented on issue #4619: [TE] Add data set display name and show it on UI

2019-09-18 Thread GitBox
jihaozh commented on issue #4619: [TE] Add data set display name and show it on UI URL: https://github.com/apache/incubator-pinot/pull/4619#issuecomment-532909223 > It looks good, but it's failing CI tests Thanks. Just pushed the fix for the front end tests.

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4621: [TE] fix the last time stamp filter out the generated anomalies

2019-09-18 Thread GitBox
jihaozh commented on a change in pull request #4621: [TE] fix the last time stamp filter out the generated anomalies URL: https://github.com/apache/incubator-pinot/pull/4621#discussion_r325931369 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detecti

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter

2019-09-18 Thread GitBox
jihaozh commented on a change in pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter URL: https://github.com/apache/incubator-pinot/pull/4620#discussion_r325930055 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter

2019-09-18 Thread GitBox
jihaozh commented on a change in pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter URL: https://github.com/apache/incubator-pinot/pull/4620#discussion_r325926448 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter

2019-09-18 Thread GitBox
jihaozh commented on a change in pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter URL: https://github.com/apache/incubator-pinot/pull/4620#discussion_r325927989 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4621: [TE] fix the last time stamp filter out the generated anomalies

2019-09-18 Thread GitBox
akshayrai commented on a change in pull request #4621: [TE] fix the last time stamp filter out the generated anomalies URL: https://github.com/apache/incubator-pinot/pull/4621#discussion_r325924451 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detec

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4621: [TE] fix the last time stamp filter out the generated anomalies

2019-09-18 Thread GitBox
jihaozh opened a new pull request #4621: [TE] fix the last time stamp filter out the generated anomalies URL: https://github.com/apache/incubator-pinot/pull/4621 - Remove the check that to filter out generated anomalies based on the last timestamp. This may filter out useful anomalies.

[GitHub] [incubator-pinot] jihaozh commented on issue #4619: [TE] Add data set display name and show it on UI

2019-09-18 Thread GitBox
jihaozh commented on issue #4619: [TE] Add data set display name and show it on UI URL: https://github.com/apache/incubator-pinot/pull/4619#issuecomment-532874914 > @jihaozh can you provide some context (example might help) behind why we need the display name? Added this per the req

[GitHub] [incubator-pinot] harleyjj commented on issue #4619: [TE] Add data set display name and show it on UI

2019-09-18 Thread GitBox
harleyjj commented on issue #4619: [TE] Add data set display name and show it on UI URL: https://github.com/apache/incubator-pinot/pull/4619#issuecomment-532851936 It looks good, but it's failing CI tests This is an automated

[GitHub] [incubator-pinot] akshayrai commented on issue #4619: [TE] Add data set display name and show it on UI

2019-09-18 Thread GitBox
akshayrai commented on issue #4619: [TE] Add data set display name and show it on UI URL: https://github.com/apache/incubator-pinot/pull/4619#issuecomment-532827199 @jihaozh can you provide some context (example might help) behind why we need the display name?

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter

2019-09-18 Thread GitBox
akshayrai opened a new pull request #4620: [TE] [Notification] Refactor email filters to a generalized alert filter URL: https://github.com/apache/incubator-pinot/pull/4620 Alert filter to return a map of (alert-properties, anomalies) rather than just the (recipients, anomalies). This will

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4619: [TE] Add data set display name and show it on UI

2019-09-18 Thread GitBox
jihaozh opened a new pull request #4619: [TE] Add data set display name and show it on UI URL: https://github.com/apache/incubator-pinot/pull/4619 - Add the ability to set dataset's display name. If the display name is set, the UI will show the display name instead of the dataset key. -

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-18 Thread GitBox
mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325800046 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-18 Thread GitBox
mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325797789 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-18 Thread GitBox
mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325807516 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java #

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-18 Thread GitBox
mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325795302 ## File path: pinot-common/src/main/java/org/apache/pinot/common/response/broker/ResultTable.java ##

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-18 Thread GitBox
mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325806695 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java #

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-18 Thread GitBox
mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325805705 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/query/AggregationGroupByOperato

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-18 Thread GitBox
mayankshriv commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r325804508 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java #