[GitHub] jerrypeng opened a new pull request #2930: Instance expose metrics

2018-11-05 Thread GitBox
jerrypeng opened a new pull request #2930: Instance expose metrics URL: https://github.com/apache/pulsar/pull/2930 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifications Describe the mo

[GitHub] ivankelly commented on issue #2883: Add healthcheck HTTP endpoint

2018-11-05 Thread GitBox
ivankelly commented on issue #2883: Add healthcheck HTTP endpoint URL: https://github.com/apache/pulsar/pull/2883#issuecomment-435866148 rerun integration tests This is an automated message from the Apache Git Service. To

[GitHub] legendtkl opened a new pull request #2931: fix go client demo

2018-11-05 Thread GitBox
legendtkl opened a new pull request #2931: fix go client demo URL: https://github.com/apache/pulsar/pull/2931 ### Motivation fix ### Modifications fix golang demo code ### Result fix golang demo code

[GitHub] rdhabalia closed pull request #2909: Handle broker shutdown for already deleted load-balancer znode

2018-11-05 Thread GitBox
rdhabalia closed pull request #2909: Handle broker shutdown for already deleted load-balancer znode URL: https://github.com/apache/pulsar/pull/2909 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[pulsar] branch master updated: Handle broker shutdown for already deleted load-balancer znode (#2909)

2018-11-05 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e5d79bf Handle broker shutdown for already d

[GitHub] srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230856203 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.j

[GitHub] srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230856915 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java

[pulsar] branch master updated: fix bugs in python metrics (#2928)

2018-11-05 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 169534d fix bugs in python metrics (#2928) 1

[GitHub] jerrypeng closed pull request #2928: fix bugs in python metrics

2018-11-05 Thread GitBox
jerrypeng closed pull request #2928: fix bugs in python metrics URL: https://github.com/apache/pulsar/pull/2928 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fr

[GitHub] sijie commented on a change in pull request #2883: Add healthcheck HTTP endpoint

2018-11-05 Thread GitBox
sijie commented on a change in pull request #2883: Add healthcheck HTTP endpoint URL: https://github.com/apache/pulsar/pull/2883#discussion_r230874198 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java ## @@ -196,4 +210,90 @@ pub

[GitHub] jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230875513 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java

[GitHub] sijie commented on issue #2931: fix go client demo code

2018-11-05 Thread GitBox
sijie commented on issue #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931#issuecomment-435998911 @legendtkl nice catch! This is an automated message from the Apache Git Service. To respond to the

[GitHub] jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230875950 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.j

[GitHub] sijie commented on issue #2931: fix go client demo code

2018-11-05 Thread GitBox
sijie commented on issue #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931#issuecomment-435999059 run integration tests This is an automated message from the Apache Git Service. To respond to the m

[GitHub] sijie commented on issue #2901: pulsar-io/hdfs Maven compilation failed

2018-11-05 Thread GitBox
sijie commented on issue #2901: pulsar-io/hdfs Maven compilation failed URL: https://github.com/apache/pulsar/issues/2901#issuecomment-436002680 @nanguawu did you manually change the hdfs client to 2.6.0? This is an automated

[GitHub] merlimat commented on issue #2931: fix go client demo code

2018-11-05 Thread GitBox
merlimat commented on issue #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931#issuecomment-436002972 @legendtkl can you also update in the "master" docs for next versions? https://github.com/apache/pulsar/blob/master/site2/docs/client-libraries-go.md --

[GitHub] srkukarni opened a new pull request #2932: Made Window Context up to date with Context

2018-11-05 Thread GitBox
srkukarni opened a new pull request #2932: Made Window Context up to date with Context URL: https://github.com/apache/pulsar/pull/2932 ### Motivation A lot has been changed in the Context interface over the last couple of releases that is not reflected in WindowContext. This pr brin

[GitHub] srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230889012 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.j

[GitHub] srkukarni commented on issue #2932: Made Window Context up to date with Context

2018-11-05 Thread GitBox
srkukarni commented on issue #2932: Made Window Context up to date with Context URL: https://github.com/apache/pulsar/pull/2932#issuecomment-436040603 rerun integration tests This is an automated message from the Apache Git Se

[GitHub] srkukarni commented on issue #2931: fix go client demo code

2018-11-05 Thread GitBox
srkukarni commented on issue #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931#issuecomment-436044367 rerun integration tests This is an automated message from the Apache Git Service. To respond to

[GitHub] jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230922997 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.j

[GitHub] srkukarni opened a new pull request #2933: Rejigger SecretsProviderConfigurator interface to make checking more generic

2018-11-05 Thread GitBox
srkukarni opened a new pull request #2933: Rejigger SecretsProviderConfigurator interface to make checking more generic URL: https://github.com/apache/pulsar/pull/2933 ### Motivation A SecretsConfigurator might want to do more checks than just check the secrets. This pr makes th

[GitHub] srkukarni commented on issue #2933: Rejigger SecretsProviderConfigurator interface to make checking more generic

2018-11-05 Thread GitBox
srkukarni commented on issue #2933: Rejigger SecretsProviderConfigurator interface to make checking more generic URL: https://github.com/apache/pulsar/pull/2933#issuecomment-436084468 rerun integration tests This is an automa

[GitHub] srkukarni commented on issue #2931: fix go client demo code

2018-11-05 Thread GitBox
srkukarni commented on issue #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931#issuecomment-436087082 rerun integration tests This is an automated message from the Apache Git Service. To respond to

[GitHub] aahmed-se commented on issue #2929: NullPointerException On Send Message

2018-11-05 Thread GitBox
aahmed-se commented on issue #2929: NullPointerException On Send Message URL: https://github.com/apache/pulsar/issues/2929#issuecomment-436091869 So this was a one time event ? This is an automated message from the Apache Git

[pulsar] branch master updated: Rejigger SecretsProviderConfigurator interface to make checking more generic (#2933)

2018-11-05 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 33ab2e0 Rejigger SecretsProviderConfigurator int

[GitHub] sijie closed pull request #2933: Rejigger SecretsProviderConfigurator interface to make checking more generic

2018-11-05 Thread GitBox
sijie closed pull request #2933: Rejigger SecretsProviderConfigurator interface to make checking more generic URL: https://github.com/apache/pulsar/pull/2933 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] codelipenghui commented on issue #2929: NullPointerException On Send Message

2018-11-05 Thread GitBox
codelipenghui commented on issue #2929: NullPointerException On Send Message URL: https://github.com/apache/pulsar/issues/2929#issuecomment-436094927 @aahmed-se No, it happens on a instance all the time until restart the instance. ---

[GitHub] aahmed-se commented on issue #2929: NullPointerException On Send Message

2018-11-05 Thread GitBox
aahmed-se commented on issue #2929: NullPointerException On Send Message URL: https://github.com/apache/pulsar/issues/2929#issuecomment-436095697 lot's of changes and fixes in ProducerImpl.java in 2.2.0 so will to check to see if it's replicated there. -

[GitHub] srkukarni closed pull request #2931: fix go client demo code

2018-11-05 Thread GitBox
srkukarni closed pull request #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[pulsar] branch master updated: fix go client demo (#2931)

2018-11-05 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 74b6af2 fix go client demo (#2931) 74b6af2 i

[GitHub] srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230974775 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManag

[GitHub] srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230975142 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/LocalRunner.java

[GitHub] srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
srkukarni commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230975745 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManag

[GitHub] jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#discussion_r230976417 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java

[GitHub] legendtkl commented on issue #2931: fix go client demo code

2018-11-05 Thread GitBox
legendtkl commented on issue #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931#issuecomment-436106680 > @legendtkl can you also update in the "master" docs for next versions? https://github.com/apache/pulsar/blob/master/site2/docs/client-libraries-go.md n

[GitHub] legendtkl opened a new pull request #2934: fix go-client demo code

2018-11-05 Thread GitBox
legendtkl opened a new pull request #2934: fix go-client demo code URL: https://github.com/apache/pulsar/pull/2934 ### Motivation fix ### Modifications add lost package to import ### Result fix T

[GitHub] legendtkl commented on issue #2931: fix go client demo code

2018-11-05 Thread GitBox
legendtkl commented on issue #2931: fix go client demo code URL: https://github.com/apache/pulsar/pull/2931#issuecomment-436109561 > @legendtkl can you also update in the "master" docs for next versions? https://github.com/apache/pulsar/blob/master/site2/docs/client-libraries-go.md r

[GitHub] codelipenghui commented on issue #2929: NullPointerException On Send Message

2018-11-05 Thread GitBox
codelipenghui commented on issue #2929: NullPointerException On Send Message URL: https://github.com/apache/pulsar/issues/2929#issuecomment-436109628 @aahmed-se I'm already discuss with @sijie yesterday, discuss list in slack china channel. -

[GitHub] merlimat opened a new pull request #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-05 Thread GitBox
merlimat opened a new pull request #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935 ### Motivation In some cases the broker can immediately gets assigned traffic before it's fully boostrapped. This

[GitHub] sijie commented on issue #2883: Add healthcheck HTTP endpoint

2018-11-05 Thread GitBox
sijie commented on issue #2883: Add healthcheck HTTP endpoint URL: https://github.com/apache/pulsar/pull/2883#issuecomment-436113826 run integration tests This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on issue #2930: Expose metrics via http port in function instance

2018-11-05 Thread GitBox
sijie commented on issue #2930: Expose metrics via http port in function instance URL: https://github.com/apache/pulsar/pull/2930#issuecomment-436114810 run cpp tests This is an automated message from the Apache Git Service.

[GitHub] sijie opened a new pull request #2936: [io][docs] introduce annotations for generating connector yaml config files

2018-11-05 Thread GitBox
sijie opened a new pull request #2936: [io][docs] introduce annotations for generating connector yaml config files URL: https://github.com/apache/pulsar/pull/2936 *Motivation* Currently all io connectors lack example yaml files. Manually write those files is error-prone.

[GitHub] sijie commented on issue #2898: Remove guava usage in pulsar-storm

2018-11-05 Thread GitBox
sijie commented on issue #2898: Remove guava usage in pulsar-storm URL: https://github.com/apache/pulsar/pull/2898#issuecomment-436120871 run integration tests This is an automated message from the Apache Git Service. To respo

[GitHub] srkukarni opened a new pull request #2937: Infer missing arguments before starting localrun

2018-11-05 Thread GitBox
srkukarni opened a new pull request #2937: Infer missing arguments before starting localrun URL: https://github.com/apache/pulsar/pull/2937 ### Motivation Since client side validation is all gone, the functionconfig that's passed on to localrunner might be lacking certain fields. We nee

[GitHub] srkukarni opened a new pull request #2938: When killing process make sure to use the force mode

2018-11-05 Thread GitBox
srkukarni opened a new pull request #2938: When killing process make sure to use the force mode URL: https://github.com/apache/pulsar/pull/2938 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifi

[GitHub] codelipenghui opened a new issue #2939: Config maxUnackMessagesPerConsumer and maxUnackMessagesPerSubscription on a namespace

2018-11-05 Thread GitBox
codelipenghui opened a new issue #2939: Config maxUnackMessagesPerConsumer and maxUnackMessagesPerSubscription on a namespace URL: https://github.com/apache/pulsar/issues/2939 For now, we can config maxUnackMessagesPerConsumer and maxUnackMessagesPerSubscription in broker.conf. It's

[GitHub] srkukarni commented on issue #2938: When killing process make sure to use the force mode

2018-11-05 Thread GitBox
srkukarni commented on issue #2938: When killing process make sure to use the force mode URL: https://github.com/apache/pulsar/pull/2938#issuecomment-436135377 rerun integration tests This is an automated message from the Apa

[GitHub] srkukarni closed pull request #2937: Infer missing arguments before starting localrun

2018-11-05 Thread GitBox
srkukarni closed pull request #2937: Infer missing arguments before starting localrun URL: https://github.com/apache/pulsar/pull/2937 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[pulsar] branch master updated: Infer missing arguments before starting localrun (#2937)

2018-11-05 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d1c531a Infer missing arguments before start

[GitHub] merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-05 Thread GitBox
merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#issuecomment-436136547 run integration tests This is an automated messa

[GitHub] merlimat commented on issue #2883: Add healthcheck HTTP endpoint

2018-11-05 Thread GitBox
merlimat commented on issue #2883: Add healthcheck HTTP endpoint URL: https://github.com/apache/pulsar/pull/2883#issuecomment-436136657 run integration tests This is an automated message from the Apache Git Service. To respon

[GitHub] srkukarni commented on issue #2932: Made Window Context up to date with Context

2018-11-05 Thread GitBox
srkukarni commented on issue #2932: Made Window Context up to date with Context URL: https://github.com/apache/pulsar/pull/2932#issuecomment-436137775 rerun integration tests This is an automated message from the Apache Git Se

[GitHub] srkukarni commented on issue #2932: Made Window Context up to date with Context

2018-11-05 Thread GitBox
srkukarni commented on issue #2932: Made Window Context up to date with Context URL: https://github.com/apache/pulsar/pull/2932#issuecomment-436143755 rerun integration tests This is an automated message from the Apache Git Se

[GitHub] merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-05 Thread GitBox
merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#issuecomment-436143838 run integration tests This is an automat

[GitHub] srkukarni opened a new pull request #2940: Fix the conversion process of windowing functions

2018-11-05 Thread GitBox
srkukarni opened a new pull request #2940: Fix the conversion process of windowing functions URL: https://github.com/apache/pulsar/pull/2940 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modificat

[GitHub] srkukarni closed pull request #2938: When killing process make sure to use the force mode

2018-11-05 Thread GitBox
srkukarni closed pull request #2938: When killing process make sure to use the force mode URL: https://github.com/apache/pulsar/pull/2938 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[pulsar] branch master updated: When killing process make sure to use the force mode (#2938)

2018-11-05 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bc1d94c When killing process make sure to us

[pulsar] branch master updated: Add healthcheck HTTP endpoint (#2883)

2018-11-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4fb60ee Add healthcheck HTTP endpoint (#2883) 4

[GitHub] merlimat closed pull request #2883: Add healthcheck HTTP endpoint

2018-11-05 Thread GitBox
merlimat closed pull request #2883: Add healthcheck HTTP endpoint URL: https://github.com/apache/pulsar/pull/2883 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[GitHub] srkukarni opened a new pull request #2941: Handle case where function produces some output but no output topic given

2018-11-05 Thread GitBox
srkukarni opened a new pull request #2941: Handle case where function produces some output but no output topic given URL: https://github.com/apache/pulsar/pull/2941 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to

[GitHub] sijie commented on issue #2934: fix go-client demo code

2018-11-05 Thread GitBox
sijie commented on issue #2934: fix go-client demo code URL: https://github.com/apache/pulsar/pull/2934#issuecomment-436151101 run java8 tests This is an automated message from the Apache Git Service. To respond to the message

[GitHub] srkukarni commented on issue #2932: Made Window Context up to date with Context

2018-11-05 Thread GitBox
srkukarni commented on issue #2932: Made Window Context up to date with Context URL: https://github.com/apache/pulsar/pull/2932#issuecomment-436151593 rerun integration tests This is an automated message from the Apache Git Se

[GitHub] srkukarni commented on issue #2940: Fix the conversion process of windowing functions

2018-11-05 Thread GitBox
srkukarni commented on issue #2940: Fix the conversion process of windowing functions URL: https://github.com/apache/pulsar/pull/2940#issuecomment-436151679 rerun integration tests This is an automated message from the Apache

[GitHub] merlimat opened a new issue #2942: Intermittent test failure in TestS3Offload

2018-11-05 Thread GitBox
merlimat opened a new issue #2942: Intermittent test failure in TestS3Offload URL: https://github.com/apache/pulsar/issues/2942 ``` Error Message arrays differ firstly at element [15]; expected value is <48> but was <49>. Stacktrace java.lang.AssertionError: arrays differ firstl

[GitHub] merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself

2018-11-05 Thread GitBox
merlimat commented on issue #2935: Ensure broker is fully boostrapped before load manager register itself URL: https://github.com/apache/pulsar/pull/2935#issuecomment-436156305 run integration tests This is an automated messa