[GitHub] [pulsar] BewareMyPower commented on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
BewareMyPower commented on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618794964 The problem may be the strange value (538973717) of `readIdx_` 。Could you provide the `payload` info of each frame? Following is the lifetime of `payload` (if I don't

[GitHub] [pulsar] BewareMyPower commented on pull request #6812: [C++] Fix message id is always the default value in send callback

2020-04-23 Thread GitBox
BewareMyPower commented on pull request #6812: URL: https://github.com/apache/pulsar/pull/6812#issuecomment-618793369 /pulsarbot run unit-tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] jiazhai commented on a change in pull request #4848: Consumer can getValue return null

2020-04-23 Thread GitBox
jiazhai commented on a change in pull request #4848: URL: https://github.com/apache/pulsar/pull/4848#discussion_r414277906 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java ## @@ -270,7 +270,11 @@ public T getValue() {

[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code

2020-04-23 Thread GitBox
zplinuxlover commented on pull request #6775: URL: https://github.com/apache/pulsar/pull/6775#issuecomment-618786237 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code

2020-04-23 Thread GitBox
zplinuxlover commented on pull request #6775: URL: https://github.com/apache/pulsar/pull/6775#issuecomment-618786155 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] zplinuxlover commented on pull request #6775: change `org.apache.pulsar.broker.admin.impl.NamespacesBase` code

2020-04-23 Thread GitBox
zplinuxlover commented on pull request #6775: URL: https://github.com/apache/pulsar/pull/6775#issuecomment-618786115 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] hangc0276 commented on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-23 Thread GitBox
hangc0276 commented on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-618784699 > @hangc0276 Good catch! @wolfstudy could please help take a look the last comment? maybe you need to move the `messageId` to the end of params list. Thanks for your

[GitHub] [pulsar] BewareMyPower commented on pull request #6812: [C++] Fix message id is always the default value in send callback

2020-04-23 Thread GitBox
BewareMyPower commented on pull request #6812: URL: https://github.com/apache/pulsar/pull/6812#issuecomment-618779875 /pulsarbot run cpp-tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] wolfstudy commented on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-23 Thread GitBox
wolfstudy commented on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-618775410 ![image](https://user-images.githubusercontent.com/20965307/80170680-156e2380-861b-11ea-9bb1-d1bf3627df91.png) @hangc0276 @codelipenghui Thanks feedback, fixed done,

[GitHub] [pulsar] wolfstudy removed a comment on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-23 Thread GitBox
wolfstudy removed a comment on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-618772842 ![image](https://user-images.githubusercontent.com/20965307/80169997-89a7c780-8619-11ea-8cd9-b31b386688a0.png) Thanks @hangc0276 feedback, fixed done, PTAL again

[GitHub] [pulsar] codelipenghui commented on issue #6811: Wrong admin REST API documentation for create subscription

2020-04-23 Thread GitBox
codelipenghui commented on issue #6811: URL: https://github.com/apache/pulsar/issues/6811#issuecomment-618775036 close via #6759 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] BewareMyPower opened a new pull request #6812: [C++] Fix message id is always the default value in send callback

2020-04-23 Thread GitBox
BewareMyPower opened a new pull request #6812: URL: https://github.com/apache/pulsar/pull/6812 ### Motivation After commit of [#4817](https://github.com/apache/pulsar/pull/4811), the send callback's 2nd argument became `MessageId`, but the `MessageId` in callback is always the

[GitHub] [pulsar] wolfstudy commented on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-23 Thread GitBox
wolfstudy commented on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-618772842 ![image](https://user-images.githubusercontent.com/20965307/80169997-89a7c780-8619-11ea-8cd9-b31b386688a0.png) Thanks @hangc0276 feedback, fixed done, PTAL again

[GitHub] [pulsar] codelipenghui opened a new issue #6811: Wrong admin REST API documentation for create subscription

2020-04-23 Thread GitBox
codelipenghui opened a new issue #6811: URL: https://github.com/apache/pulsar/issues/6811 **Describe the bug** ![image](https://user-images.githubusercontent.com/12592133/80169049-fd94a080-8616-11ea-9f9e-e3337be35286.png)

[GitHub] [pulsar] tuteng opened a new pull request #6034: [Pulsar IO][Issue 5633]Support avro schema for debezium connector

2020-04-23 Thread GitBox
tuteng opened a new pull request #6034: URL: https://github.com/apache/pulsar/pull/6034 Fixes #5633 ### Motivation Currently, some users want to support Avro schema in debezium, so this pr supports this feature. For Kafka's Avro schema, it depends on the Avro 1.8

[GitHub] [pulsar] codelipenghui commented on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-23 Thread GitBox
codelipenghui commented on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-618764842 @hangc0276 Good catch! @wolfstudy could please help take a look the last comment? maybe you need to move the `messageId` to the end of params list.

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #6763: [docs] Fix encryption examples

2020-04-23 Thread GitBox
Anonymitaet commented on a change in pull request #6763: URL: https://github.com/apache/pulsar/pull/6763#discussion_r414238608 ## File path: site2/docs/security-encryption.md ## @@ -144,11 +148,12 @@ for (int i = 0; i < 10; i++) { // Acknowledge the consumption of all

[GitHub] [pulsar] KannarFr commented on a change in pull request #6799: optional auth method name header in http authentication

2020-04-23 Thread GitBox
KannarFr commented on a change in pull request #6799: URL: https://github.com/apache/pulsar/pull/6799#discussion_r414239613 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java ## @@ -83,13 +83,29 @@ public String

[GitHub] [pulsar] merlimat opened a new pull request #6810: [C++] Subscription InitialPosition is not correctly set on regex consumers

2020-04-23 Thread GitBox
merlimat opened a new pull request #6810: URL: https://github.com/apache/pulsar/pull/6810 ### Motivation The subscription `InitialPosition` is not currently set when using the multi-topic or regex consumers in C++/Python. That makes that if you try to start from

[GitHub] [pulsar] sijie commented on issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
sijie commented on issue #6807: URL: https://github.com/apache/pulsar/issues/6807#issuecomment-618704820 Yes, I think Token Authentication Provider is not serializable. Use configuration to pass the auth plugins and params are the recommended way.

[GitHub] [pulsar] sijie commented on issue #6809: Unable to create/register functions via REST API

2020-04-23 Thread GitBox
sijie commented on issue #6809: URL: https://github.com/apache/pulsar/issues/6809#issuecomment-618703430 @qmnonic The `v2` endpoint still takes a serialized json string of FunctionConfig: `/admin/v3/functions/{tenant}/{namespace}/{functionName} ` There was a change in

[GitHub] [pulsar-client-go] frankjkelly opened a new issue #233: Reader cannot read first message produced to new topic

2020-04-23 Thread GitBox
frankjkelly opened a new issue #233: URL: https://github.com/apache/pulsar-client-go/issues/233 Expected behavior Tell us what should happen: When creating a new topic - the consumer should be able to receive the first message Actual behavior Tell us what

[GitHub] [pulsar] cdbartholomew commented on issue #6809: Unable to create/register functions via REST API

2020-04-23 Thread GitBox
cdbartholomew commented on issue #6809: URL: https://github.com/apache/pulsar/issues/6809#issuecomment-618693846 @qmnonic I am not sure if this is helpful, but I am able to upload functions via the REST API in versions 2.4.2 to 2.5.1 using this JavaScript code: ``` createFunction

[GitHub] [pulsar] qmnonic opened a new issue #6809: Unable to create/register functions via REST API

2020-04-23 Thread GitBox
qmnonic opened a new issue #6809: URL: https://github.com/apache/pulsar/issues/6809 **Describe the bug** Seems there was a change in the https://pulsar.apache.org/admin/v3/functions/{tenant}/{namespace}/{functionName} function, where the method signature changed, specifically the

[GitHub] [pulsar] merlimat commented on pull request #6796: Support cumulative acknowledgement when consuming partitioned topics for C++ client

2020-04-23 Thread GitBox
merlimat commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-618600371 > acknowledgementCumulative on a partitioned topic means acknowledging cumulative the messages of the partition inferred by the MessageId. If I'm consuming from a

[GitHub] [pulsar] merlimat opened a new pull request #6808: [PY] Fix serialization of enums with json/avro schemas

2020-04-23 Thread GitBox
merlimat opened a new pull request #6808: URL: https://github.com/apache/pulsar/pull/6808 ### Motivation In Python client, the serialization of enums when using the schema is currently broken, throwing error because it's not possible to directly serialize them into json.

[GitHub] [pulsar] gaoran10 commented on issue #6034: [Pulsar IO][Issue 5633]Support avro schema for debezium connector

2020-04-23 Thread GitBox
gaoran10 commented on issue #6034: URL: https://github.com/apache/pulsar/pull/6034#issuecomment-618533772 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] merlimat commented on issue #6791: Use consistent hashing in KeyShared distribution

2020-04-23 Thread GitBox
merlimat commented on issue #6791: URL: https://github.com/apache/pulsar/pull/6791#issuecomment-618531886 > I see there is a problem in the current algorithm when scaling down the number of consumers. But I don't think its broken. The Key Shared subscriptions has 2 stated goals:

[GitHub] [pulsar] addisonj commented on issue #6800: [broker] Expose BookKeeper GetBookieInfo settings

2020-04-23 Thread GitBox
addisonj commented on issue #6800: URL: https://github.com/apache/pulsar/pull/6800#issuecomment-618502915 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] addisonj commented on issue #6801: [functions] Don't auth functions worker metrics endpoint

2020-04-23 Thread GitBox
addisonj commented on issue #6801: URL: https://github.com/apache/pulsar/pull/6801#issuecomment-618503075 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] merlimat commented on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
merlimat commented on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618497703 > This only covers 50% of the contract. If a reader is scanning a log, it should receive events in order and there are no data gaps. That's not what the contract is. And it's

[GitHub] [pulsar] addisonj commented on issue #6801: [functions] Don't auth functions worker metrics endpoint

2020-04-23 Thread GitBox
addisonj commented on issue #6801: URL: https://github.com/apache/pulsar/pull/6801#issuecomment-618461858 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] addisonj commented on issue #6800: [broker] Expose BookKeeper GetBookieInfo settings

2020-04-23 Thread GitBox
addisonj commented on issue #6800: URL: https://github.com/apache/pulsar/pull/6800#issuecomment-618461247 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] bschofield edited a comment on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-23 Thread GitBox
bschofield edited a comment on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-618379476 These are not quite the same bug. The problem with the go/C client is that there is no way to set the topic name in a message ID, whereas the problem with the Java library

[GitHub] [pulsar] bschofield edited a comment on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-23 Thread GitBox
bschofield edited a comment on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-618379476 These are not quite the same bug. The problem with the go/C client is that there is no way to set the topic name in a message ID, whereas the problem with the Java library

[GitHub] [pulsar] why198852 commented on issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
why198852 commented on issue #6807: URL: https://github.com/apache/pulsar/issues/6807#issuecomment-618393481 good idea,Mr qianmoQ. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] qianmoQ edited a comment on issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
qianmoQ edited a comment on issue #6807: URL: https://github.com/apache/pulsar/issues/6807#issuecomment-618388237 I don't recommend using it this way because it can cause serialization problems `public class ClientConfigurationData implements Serializable` source code

[GitHub] [pulsar] qianmoQ edited a comment on issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
qianmoQ edited a comment on issue #6807: URL: https://github.com/apache/pulsar/issues/6807#issuecomment-618388237 I don't recommend using it this way because it can cause serialization problems `public class ClientConfigurationData implements Serializable` source code

[GitHub] [pulsar] qianmoQ edited a comment on issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
qianmoQ edited a comment on issue #6807: URL: https://github.com/apache/pulsar/issues/6807#issuecomment-618388237 I don't recommend using it this way because it can cause serialization problems please init client For example: ```java val confData = new

[GitHub] [pulsar] qianmoQ edited a comment on issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
qianmoQ edited a comment on issue #6807: URL: https://github.com/apache/pulsar/issues/6807#issuecomment-618388237 I don't recommend using it this way because it can cause serialization problems please init client egg: ```java val confData = new ClientConfigurationData()

[GitHub] [pulsar] qianmoQ commented on issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
qianmoQ commented on issue #6807: URL: https://github.com/apache/pulsar/issues/6807#issuecomment-618388237 I don't recommend using it this way because it can cause serialization problems please init client : ```java val confData = new ClientConfigurationData()

[GitHub] [pulsar] cbornet edited a comment on issue #6720: Make ServerCnx, Producer and Consumer independent of Netty

2020-04-23 Thread GitBox
cbornet edited a comment on issue #6720: URL: https://github.com/apache/pulsar/pull/6720#issuecomment-617403363 The change is already in this PR. I did it in the 2nd commit. The interface to implement by protocol handlers is `ServerCnx`.

[GitHub] [pulsar] bschofield commented on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-23 Thread GitBox
bschofield commented on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-618379476 These are not quite the same bug. The problem with the go/C client is that there is no way to set the topic name in a message ID, whereas the problem with the Java library is that

[GitHub] [pulsar] wangyunpeng666 opened a new issue #6807: errors met when Using sparkstreaming with token to consume

2020-04-23 Thread GitBox
wangyunpeng666 opened a new issue #6807: URL: https://github.com/apache/pulsar/issues/6807 when I consume topic by sparkstreming with token ,it meet errors. The code and error is as follows:

[GitHub] [pulsar] bschofield edited a comment on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield edited a comment on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618298060 Here are the DEBUG messages from the C++ library immediately before the crash: ``` DEBUG [x.x.x.x:46978 -> y.y.y.y:29841] Received a message from the server for

[GitHub] [pulsar] zplinuxlover commented on issue #6758: change test case code org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup

2020-04-23 Thread GitBox
zplinuxlover commented on issue #6758: URL: https://github.com/apache/pulsar/pull/6758#issuecomment-618299158 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] zplinuxlover commented on issue #6783: resolve issue 6578

2020-04-23 Thread GitBox
zplinuxlover commented on issue #6783: URL: https://github.com/apache/pulsar/pull/6783#issuecomment-618298816 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] zplinuxlover commented on issue #6783: resolve issue 6578

2020-04-23 Thread GitBox
zplinuxlover commented on issue #6783: URL: https://github.com/apache/pulsar/pull/6783#issuecomment-618298669 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] bschofield commented on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield commented on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618298060 Here are the DEBUG messages from the C++ library immediately before the crash: ``` DEBUG [x.x.x.x:46978 -> y.y.y.y:29841] Received a message from the server for

[GitHub] [pulsar] bschofield removed a comment on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield removed a comment on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618297295 Here are the DEBUG messages from the C++ library immediately before the crash: ``` DEBUG [192.168.2.191:46978 -> 51.79.31.254:29841] Received a message from the

[GitHub] [pulsar] bschofield commented on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield commented on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618297295 Here are the DEBUG messages from the C++ library immediately before the crash: ``` DEBUG [192.168.2.191:46978 -> 51.79.31.254:29841] Received a message from the server

[GitHub] [pulsar] bschofield removed a comment on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield removed a comment on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618291497 Here are the DEBUG messages from the C++ library, immediately before the segfault: ``` DEBUG [192.168.2.191:46978 -> 51.79.31.254:29841] Received a message from

[GitHub] [pulsar] bschofield edited a comment on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield edited a comment on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618291497 Here are the DEBUG messages from the C++ library, immediately before the segfault: ``` DEBUG [192.168.2.191:46978 -> 51.79.31.254:29841] Received a message from

[GitHub] [pulsar] bschofield commented on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield commented on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618291497 Here's a dump of 489 bytes starting at `uncompressedPayload.ptr_`: ``` (gdb) xxd uncompressedPayload.ptr_ 489 : 2020 1611 5b7f 2020 1611 5b7f

[GitHub] [pulsar] sijie commented on issue #6791: Use consistent hashing in KeyShared distribution

2020-04-23 Thread GitBox
sijie commented on issue #6791: URL: https://github.com/apache/pulsar/pull/6791#issuecomment-618267027 > The current implementation is severely broken. This PR is fixing the bug. I don't see an easy way to fix it based on the splitting range design. I see there is a problem in the

[GitHub] [pulsar] sijie edited a comment on issue #6791: Use consistent hashing in KeyShared distribution

2020-04-23 Thread GitBox
sijie edited a comment on issue #6791: URL: https://github.com/apache/pulsar/pull/6791#issuecomment-618267027 > The current implementation is severely broken. This PR is fixing the bug. I don't see an easy way to fix it based on the splitting range design. I see there is a problem

[GitHub] [pulsar] bschofield commented on issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield commented on issue #6806: URL: https://github.com/apache/pulsar/issues/6806#issuecomment-618262902 If we go up a stack frame, then `uncompressedPayload` looks pretty suspect to me: it has `readIdx_` much larger than `capacity_`, which doesn't seem right: ``` (gdb) up

[GitHub] [pulsar] sijie commented on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
sijie commented on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618259435 > The contract is clear and it's that a reader can read all the data that is being retained based on max time and size. This only covers 50% of the contract. If a reader is

[GitHub] [pulsar] bschofield opened a new issue #6806: Segmentation fault in C++ library whilst deserializing messages

2020-04-23 Thread GitBox
bschofield opened a new issue #6806: URL: https://github.com/apache/pulsar/issues/6806 I am using the go client, which is a wrapper around the C++ client. I encountered a bug where all my consumers on a namespace suddenly died and could not be restarted. It seems that they are segfaulting

[GitHub] [pulsar] sijie commented on issue #6796: Support cumulative acknowledgement when consuming partitioned topics for C++ client

2020-04-23 Thread GitBox
sijie commented on issue #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-618248226 @BewareMyPower @merlimat The `MessageId` is used for identifying the position within a topic. For a partitioned topic, the `MessageId` includes the partition index for identifying

[GitHub] [pulsar] sijie commented on a change in pull request #6799: optional auth method name header in http authentication

2020-04-23 Thread GitBox
sijie commented on a change in pull request #6799: URL: https://github.com/apache/pulsar/pull/6799#discussion_r413589283 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationService.java ## @@ -83,13 +83,29 @@ public String

[pulsar] branch master updated (550f155 -> 53407fc)

2020-04-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 550f155 Add apache pulsar 2.5.1 blog (#6805) add 53407fc Fix some empty message related problems in the

[pulsar] branch master updated (fb6e43a -> 550f155)

2020-04-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fb6e43a [hotfix]Website publish failed for ko language (#6803) add 550f155 Add apache pulsar 2.5.1 blog

[GitHub] [pulsar] itaross edited a comment on issue #6797: "Retain Orderning cannot be altered" exception on Pulsar Sink update

2020-04-23 Thread GitBox
itaross edited a comment on issue #6797: URL: https://github.com/apache/pulsar/issues/6797#issuecomment-618232785 I have used a json field "retainOrdering" as written here

[GitHub] [pulsar] itaross commented on issue #6797: "Retain Orderning cannot be altered" exception on Pulsar Sink update

2020-04-23 Thread GitBox
itaross commented on issue #6797: URL: https://github.com/apache/pulsar/issues/6797#issuecomment-618232785 I have used a json field "retainOrdering" as written here https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java

[GitHub] [pulsar] merlimat commented on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
merlimat commented on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618228354 > The behavior of a non-durable cursor reading a managed ledger should be close to the behavior of a file reader reading a file in the filesystem. If a reader is actively reading a

[GitHub] [pulsar] merlimat commented on issue #6791: Use consistent hashing in KeyShared distribution

2020-04-23 Thread GitBox
merlimat commented on issue #6791: URL: https://github.com/apache/pulsar/pull/6791#issuecomment-618223059 > Since the current algorithm has been used in many production environments already, we should be concerned about removing an existing implementation. Providing a way to opt-in a

[GitHub] [pulsar] shiv4289 commented on issue #6782: [pulsar-storm] Fix: Authentication is failing with storm adapter

2020-04-23 Thread GitBox
shiv4289 commented on issue #6782: URL: https://github.com/apache/pulsar/pull/6782#issuecomment-618217216 > @shiv4289 - did you remember which Authentication is not serializable in #4283? @rdhabalia @sijie AuthenticationToken.java

[GitHub] [pulsar] tuteng commented on issue #6805: Add apache pulsar 2.5.1 blog

2020-04-23 Thread GitBox
tuteng commented on issue #6805: URL: https://github.com/apache/pulsar/pull/6805#issuecomment-618207811 @Huanli-Meng PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] jerrypeng edited a comment on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
jerrypeng edited a comment on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618205635 @sijie the default behavior of stored data in pulsar is not exactly the same as data stored in a file. By default data is not persisted in Pulsar at all. Only if a topic has

[GitHub] [pulsar] jerrypeng edited a comment on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
jerrypeng edited a comment on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618205635 @sijie the default behavior of stored data in pulsar is not exactly the same as data stored in a file. By default data is not persisted in Pulsar at all. Only if a topic has

[GitHub] [pulsar] jerrypeng edited a comment on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
jerrypeng edited a comment on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618205635 @sijie the default behavior of stored data in pulsar is not exactly the same as data stored in a file. By default data is not persisted in Pulsar at all. Only if a topic has

[GitHub] [pulsar] tuteng opened a new pull request #6805: Add apache pulsar 2.5.1 blog

2020-04-23 Thread GitBox
tuteng opened a new pull request #6805: URL: https://github.com/apache/pulsar/pull/6805 ### Motivation * Add apache pulsar 2.5.1 features blog ### Modifications * Add apache pulsar 2.5.1 features blog

[GitHub] [pulsar] jerrypeng edited a comment on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
jerrypeng edited a comment on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618205635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] jerrypeng edited a comment on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
jerrypeng edited a comment on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618205635 @sijie the default behavior of stored data in pulsar is not exactly the same as data stored in a file. By default data is not persisted in Pulsar at all. Only if a topic has

[GitHub] [pulsar] jerrypeng commented on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
jerrypeng commented on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618205635 @sijie the default behavior of stored data in pulsar is not exactly the same as data in a file. By default data is not persisted in Pulsar at all. Only if a topic has a

[pulsar] branch master updated (5542126 -> fb6e43a)

2020-04-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5542126 Fixed website publish failed (#6802) add fb6e43a [hotfix]Website publish failed for ko language

[GitHub] [pulsar] Huanli-Meng commented on issue #6804: [Tech blog]--Apache Pulsar 2.5.1

2020-04-23 Thread GitBox
Huanli-Meng commented on issue #6804: URL: https://github.com/apache/pulsar/pull/6804#issuecomment-618201728 close the This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] sijie commented on issue #6798: Sanitize Perm Checks

2020-04-23 Thread GitBox
sijie commented on issue #6798: URL: https://github.com/apache/pulsar/pull/6798#issuecomment-618200536 > Tenant admin has the ability to produce/consume. This is honored by the http api, but not the binary api. I am confused by this statement. Http doesn't provide any ability to

[GitHub] [pulsar] sijie commented on a change in pull request #6798: Sanitize Perm Checks

2020-04-23 Thread GitBox
sijie commented on a change in pull request #6798: URL: https://github.com/apache/pulsar/pull/6798#discussion_r413535462 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -935,6 +937,38 @@ private SchemaData

[GitHub] [pulsar] codelipenghui commented on issue #6554: Dispatch messages to the new consumer after exist consumer acknowledged all dispatched messages in Key_Shared Subscription.

2020-04-23 Thread GitBox
codelipenghui commented on issue #6554: URL: https://github.com/apache/pulsar/issues/6554#issuecomment-618198792 @merlimat I like the approach you have mentioned. This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Huanli-Meng opened a new pull request #6804: [Tech blog]--Apache Pulsar 2.5.1

2020-04-23 Thread GitBox
Huanli-Meng opened a new pull request #6804: URL: https://github.com/apache/pulsar/pull/6804 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] sijie commented on issue #6787: Using Readers still causes backlog quota to be observed

2020-04-23 Thread GitBox
sijie commented on issue #6787: URL: https://github.com/apache/pulsar/pull/6787#issuecomment-618196829 @jerrypeng @merlimat I think this should be a flag to allow people to choose whether to include readers for backlog quota consideration or not. The behavior of a non-durable cursor

[GitHub] [pulsar] phemmer commented on issue #6790: Go function panic due to non-canonical topic

2020-04-23 Thread GitBox
phemmer commented on issue #6790: URL: https://github.com/apache/pulsar/issues/6790#issuecomment-618196763 Unfortunately not. I do not know Java at all. Otherwise I probably would as I'm sure it's a simple change. This is