[GitHub] [pulsar] merlimat merged pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-22 Thread GitBox
merlimat merged pull request #10997: URL: https://github.com/apache/pulsar/pull/10997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[pulsar] branch master updated (96b293a -> 0a67b45)

2021-06-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 96b293a Fix flaky test testEnableAndDisableTopicDelayedDelivery (#11009) add 0a67b45 release multiTopicsConsu

[GitHub] [pulsar-client-go] freeznet commented on pull request #548: regenerate the certs & tokens to work with Java 11

2021-06-22 Thread GitBox
freeznet commented on pull request #548: URL: https://github.com/apache/pulsar-client-go/pull/548#issuecomment-865661689 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar-client-go] omnilight commented on a change in pull request #497: [Issue 496] Support for correct reconnections limit in consumer

2021-06-22 Thread GitBox
omnilight commented on a change in pull request #497: URL: https://github.com/apache/pulsar-client-go/pull/497#discussion_r655941309 ## File path: pulsar/consumer.go ## @@ -165,6 +165,9 @@ type Consumer interface { // Unsubscribe the consumer Unsubscribe() error

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: [Broker] Support new topic format for broker admin healthcheck endpoint

2021-06-22 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655913864 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-22 Thread GitBox
BewareMyPower commented on a change in pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#discussion_r655280679 ## File path: site2/docs/client-libraries-python.md ## @@ -4,15 +4,15 @@ title: Pulsar Python client sidebar_label: Python --- -Pulsar Python c

[GitHub] [pulsar] kjaggann commented on issue #10021: Websocket Encryption

2021-06-22 Thread GitBox
kjaggann commented on issue #10021: URL: https://github.com/apache/pulsar/issues/10021#issuecomment-865108954 The recent change to the pulsar websocket allows the encrypted payload to be passed thru to the client. However, it does not appear that the (aes) encrypted data key is included

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-22 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655738605 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicVersion.java ## @@ -0,0 +1,24 @@ +/** + * Licensed to the Apac

[GitHub] [pulsar] BewareMyPower edited a comment on pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-06-22 Thread GitBox
BewareMyPower edited a comment on pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#issuecomment-865158870 @liangyepianzhou What's the need to run `source conf/standalone.conf`? `conf/standalone.conf` is just the configuration file that is read by pulsar standalone star

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10961: Fix incorrect port of advertisedListener

2021-06-22 Thread GitBox
Anonymitaet commented on a change in pull request #10961: URL: https://github.com/apache/pulsar/pull/10961#discussion_r655150896 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -1360,10 +1360,13 @@ public ShutdownService getShutdownS

[GitHub] [pulsar] lhotari commented on a change in pull request #10961: Fix incorrect port of advertisedListener

2021-06-22 Thread GitBox
lhotari commented on a change in pull request #10961: URL: https://github.com/apache/pulsar/pull/10961#discussion_r655138308 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -1360,10 +1360,13 @@ public ShutdownService getShutdownServi

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-22 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865080247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [pulsar] nlu90 commented on pull request #10631: [Functions] reorganize the context hierarchy for functions

2021-06-22 Thread GitBox
nlu90 commented on pull request #10631: URL: https://github.com/apache/pulsar/pull/10631#issuecomment-865359519 @sijie I rebased the master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pulsar] cckellogg commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-22 Thread GitBox
cckellogg commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655724390 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicVersion.java ## @@ -0,0 +1,24 @@ +/** + * Licensed to the Apac

[GitHub] [pulsar] 315157973 commented on a change in pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-22 Thread GitBox
315157973 commented on a change in pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#discussion_r655438083 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -560,12 +560,9 @@ public void negativeAckno

[GitHub] [pulsar] Anonymitaet commented on pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#issuecomment-865468050 @fengtao1998 can you take a look at suggestions and resolve them as needed? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] lhotari closed pull request #10480: [Broker] Fix race condition in invalidating ledger cache entries

2021-06-22 Thread GitBox
lhotari closed pull request #10480: URL: https://github.com/apache/pulsar/pull/10480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [pulsar] Anonymitaet commented on issue #10971: [Doc] Transaction

2021-06-22 Thread GitBox
Anonymitaet commented on issue #10971: URL: https://github.com/apache/pulsar/issues/10971#issuecomment-864845975 @newur thanks for your feedback. Does it make sense to move the contents of `integration` to the `what feature do transactions provide` section under the `overview` chapter?

[GitHub] [pulsar] 315157973 merged pull request #11009: Fix flaky test testEnableAndDisableTopicDelayedDelivery

2021-06-22 Thread GitBox
315157973 merged pull request #11009: URL: https://github.com/apache/pulsar/pull/11009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] Jason918 commented on pull request #10999: [Issue 9173] [Persistent Topics] Auto-create partitions even when the auto-creation is disabled

2021-06-22 Thread GitBox
Jason918 commented on pull request #10999: URL: https://github.com/apache/pulsar/pull/10999#issuecomment-864909093 @codelipenghui @jiazhai Hi, can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] lanwen edited a comment on issue #5059: [Feature request] Per key cleanup for the GDPR requirements

2021-06-22 Thread GitBox
lanwen edited a comment on issue #5059: URL: https://github.com/apache/pulsar/issues/5059#issuecomment-865199980 @rcusters we offload everything to a database on an event gateway (see https://github.com/bsideup/liiklus) with a custom plugin and keep only references and meta information in

[GitHub] [pulsar-client-go] dferstay commented on a change in pull request #535: Fix data race while accessing connection in partitionConsumer

2021-06-22 Thread GitBox
dferstay commented on a change in pull request #535: URL: https://github.com/apache/pulsar-client-go/pull/535#discussion_r655572053 ## File path: pulsar/consumer_partition.go ## @@ -1113,6 +1114,17 @@ func (pc *partitionConsumer) discardCorruptedMessage(msgID *pb.MessageIdData

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-06-22 Thread GitBox
BewareMyPower commented on a change in pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#discussion_r655267689 ## File path: conf/standalone.conf ## @@ -590,7 +590,7 @@ managedLedgerDefaultAckQuorum=1 # How frequently to flush the cursor positions that we

[GitHub] [pulsar] Anonymitaet commented on pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#issuecomment-865470913 @Shoothzj thanks for your contribution. For this PR, do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] newur commented on issue #10971: [Doc] Transaction

2021-06-22 Thread GitBox
newur commented on issue #10971: URL: https://github.com/apache/pulsar/issues/10971#issuecomment-865272604 @Anonymitaet I would say so, yes. For me transaction are all about the boundaries, so I want to know where does it start and till which point can it rollback. And pictures are pretty

[GitHub] [pulsar] codelipenghui commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-22 Thread GitBox
codelipenghui commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865093565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [pulsar] sijie merged pull request #10939: [Issue 10938] [pulsar-functions] Include common-io in java function instance

2021-06-22 Thread GitBox
sijie merged pull request #10939: URL: https://github.com/apache/pulsar/pull/10939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] gaoran10 commented on pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-22 Thread GitBox
gaoran10 commented on pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#issuecomment-865504984 Only need to change docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pulsar-client-go] jonyhy96 commented on a change in pull request #535: Fix data race while accessing connection in partitionConsumer

2021-06-22 Thread GitBox
jonyhy96 commented on a change in pull request #535: URL: https://github.com/apache/pulsar-client-go/pull/535#discussion_r655283656 ## File path: pulsar/consumer_partition.go ## @@ -21,6 +21,7 @@ import ( "fmt" "math" "sync" + syncAtomic "sync/atom

[GitHub] [pulsar] eolivelli merged pull request #10976: Change the nar package name for pulsar-io-kafka-connect-adaptor

2021-06-22 Thread GitBox
eolivelli merged pull request #10976: URL: https://github.com/apache/pulsar/pull/10976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] fengtao1998 commented on pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-22 Thread GitBox
fengtao1998 commented on pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#issuecomment-865484229 > @fengtao1998 can you take a look at suggestions and resolve them as needed? Sorry for the delay. I have revised these suggestions. Thank you for your suggestion -

[GitHub] [pulsar-client-go] uiot-stack closed issue #545: client panic when on high throughput

2021-06-22 Thread GitBox
uiot-stack closed issue #545: URL: https://github.com/apache/pulsar-client-go/issues/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [pulsar] codelipenghui closed issue #10990: confusing documentation for bookkeeper.httpServerPort

2021-06-22 Thread GitBox
codelipenghui closed issue #10990: URL: https://github.com/apache/pulsar/issues/10990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [pulsar] Shoothzj commented on a change in pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-22 Thread GitBox
Shoothzj commented on a change in pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#discussion_r655847450 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -560,12 +560,9 @@ public void negativeAcknow

[GitHub] [pulsar] KannarFr removed a comment on issue #5059: [Feature request] Per key cleanup for the GDPR requirements

2021-06-22 Thread GitBox
KannarFr removed a comment on issue #5059: URL: https://github.com/apache/pulsar/issues/5059#issuecomment-537467046 It could be great to be able to set retention or expiration date for offloaded data too. Today there is no way to clean offloaded data, right? @sijie -- This is an

[GitHub] [pulsar] hsaputra commented on pull request #10939: [Issue 10938] [pulsar-functions] Include common-io in java function instance

2021-06-22 Thread GitBox
hsaputra commented on pull request #10939: URL: https://github.com/apache/pulsar/pull/10939#issuecomment-865385690 @sijie - could you review this to unblock the merge request? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] sijie merged pull request #10961: Fix incorrect port of advertisedListener

2021-06-22 Thread GitBox
sijie merged pull request #10961: URL: https://github.com/apache/pulsar/pull/10961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] liangyepianzhou commented on pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-06-22 Thread GitBox
liangyepianzhou commented on pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#issuecomment-864945060 Sorry,I haven't express clearly. This is happened in iTerm with source command. Such as this: liangyepianzhou@liangyepianzhoudeMacBook-Pro conf % source standalon

[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config

2021-06-22 Thread GitBox
linlinnn commented on pull request #10731: URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864790537 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] wolfstudy commented on issue #10994: [Doc] generate 2.8.1 doc set

2021-06-22 Thread GitBox
wolfstudy commented on issue #10994: URL: https://github.com/apache/pulsar/issues/10994#issuecomment-865491172 I will process it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar] Anonymitaet commented on pull request #11011: [Doc] Add explanations for inactive topics

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #11011: URL: https://github.com/apache/pulsar/pull/11011#issuecomment-865511376 @MarvinCai could you please help review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] codelipenghui merged pull request #10966: [Broker] Fix the backlog issue with --precise-backlog=true

2021-06-22 Thread GitBox
codelipenghui merged pull request #10966: URL: https://github.com/apache/pulsar/pull/10966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] rcusters commented on issue #5059: [Feature request] Per key cleanup for the GDPR requirements

2021-06-22 Thread GitBox
rcusters commented on issue #5059: URL: https://github.com/apache/pulsar/issues/5059#issuecomment-865040466 We have a similar requirement. The issue is already a year old. @lanwen how did you solve this in the end? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] codelipenghui merged pull request #10992: [Issue 10990] Fix the default value of httpServerPort in reference conf

2021-06-22 Thread GitBox
codelipenghui merged pull request #10992: URL: https://github.com/apache/pulsar/pull/10992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] codelipenghui merged pull request #10963: [Broker] Fix create partitioned topic in replicated namespace

2021-06-22 Thread GitBox
codelipenghui merged pull request #10963: URL: https://github.com/apache/pulsar/pull/10963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar-client-go] omnilight commented on a change in pull request #497: [Issue 496] Support for correct reconnections limit in consumer

2021-06-22 Thread GitBox
omnilight commented on a change in pull request #497: URL: https://github.com/apache/pulsar-client-go/pull/497#discussion_r655941309 ## File path: pulsar/consumer.go ## @@ -165,6 +165,9 @@ type Consumer interface { // Unsubscribe the consumer Unsubscribe() error

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-22 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655765724 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] BewareMyPower commented on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-22 Thread GitBox
BewareMyPower commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865472623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [pulsar] lanwen commented on issue #5059: [Feature request] Per key cleanup for the GDPR requirements

2021-06-22 Thread GitBox
lanwen commented on issue #5059: URL: https://github.com/apache/pulsar/issues/5059#issuecomment-865199980 @rcusters we offload everything to a database on an event gateway (see github.com/bsideup/liiklus) with a custom plugin and keep only references and meta information in pulsar. Then if

[GitHub] [pulsar] congbobo184 commented on a change in pull request #10995: [issue 10989 ] Java Client: KeyValueSchema with AutoConsume component - make it work if the topic schema is still not set

2021-06-22 Thread GitBox
congbobo184 commented on a change in pull request #10995: URL: https://github.com/apache/pulsar/pull/10995#discussion_r655892250 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleSchemaTest.java ## @@ -555,7 +555,16 @@ public void testAutoKeyValueCon

[GitHub] [pulsar] codelipenghui commented on pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-06-22 Thread GitBox
codelipenghui commented on pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#issuecomment-864857474 @liangyepianzhou Could you please provide more information about the error you have mentioned in the description? The change looks good to me. -- This is an automated m

[GitHub] [pulsar] gaoran10 commented on pull request #10963: [Broker] Fix create partitioned topic in replicated namespace

2021-06-22 Thread GitBox
gaoran10 commented on pull request #10963: URL: https://github.com/apache/pulsar/pull/10963#issuecomment-864919993 > LGTM > > please switch to using newUniqueName in the tests Ok, I'll fix this. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] sijie closed issue #10938: pulsar-function-instance has dependency on pulsar-common-io, but the dependency is not captured in pom.xml

2021-06-22 Thread GitBox
sijie closed issue #10938: URL: https://github.com/apache/pulsar/issues/10938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [pulsar] Shoothzj commented on pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-22 Thread GitBox
Shoothzj commented on pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#issuecomment-865475498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[GitHub] [pulsar] dinghram commented on issue #10433: NPE in broker: EntryImpl.getLength()

2021-06-22 Thread GitBox
dinghram commented on issue #10433: URL: https://github.com/apache/pulsar/issues/10433#issuecomment-865107202 @lhotari Thanks for the feedback. We tested with the -Dio.netty.recycler.maxCapacityPerThread=0 option and saw no negative performance impact. In fact, the CPU usage was lower with

[GitHub] [pulsar] 315157973 commented on pull request #10988: Fix wrong configuration name

2021-06-22 Thread GitBox
315157973 commented on pull request #10988: URL: https://github.com/apache/pulsar/pull/10988#issuecomment-864801897 > @315157973 thanks for your contribution. Does this affect only master or other versioned docs? > If latter, could you please help update all affected versions? Thanks

[GitHub] [pulsar] sijie merged pull request #11005: Do not expose meaningless stats for consumer.

2021-06-22 Thread GitBox
sijie merged pull request #11005: URL: https://github.com/apache/pulsar/pull/11005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] lhotari commented on pull request #10944: [Proxy] Limit replay buffer size in AdminProxyHandler

2021-06-22 Thread GitBox
lhotari commented on pull request #10944: URL: https://github.com/apache/pulsar/pull/10944#issuecomment-864933234 @addisonj I added `httpInputMaxReplayBufferSize` config parameter with the default of 5MB. PTAL. Can we get this PR merged or does it need more changes? -- This is an aut

[GitHub] [pulsar] lhotari commented on pull request #10918: [Build] Fix java-test-functions dependencies and packaging

2021-06-22 Thread GitBox
lhotari commented on pull request #10918: URL: https://github.com/apache/pulsar/pull/10918#issuecomment-864804723 UPDATE: I learned from @eolivelli that there's PR #10922 in progress which will address the Pulsar Functions classloading issue. -- This is an automated message from the Apac

[GitHub] [pulsar-client-go] freeznet commented on pull request #548: regenerate the certs & tokens to work with Java 11

2021-06-22 Thread GitBox
freeznet commented on pull request #548: URL: https://github.com/apache/pulsar-client-go/pull/548#issuecomment-865622358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [pulsar] BewareMyPower commented on pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-06-22 Thread GitBox
BewareMyPower commented on pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#issuecomment-865158870 @liangyepianzhou What's the need to run `source conf/standalone.conf`? `conf/standalone.conf` is just the configuration file that is read by pulsar standalone starter. Fo

[GitHub] [pulsar] 315157973 commented on a change in pull request #10961: Fix incorrect port of advertisedListener

2021-06-22 Thread GitBox
315157973 commented on a change in pull request #10961: URL: https://github.com/apache/pulsar/pull/10961#discussion_r655154188 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -1360,10 +1360,13 @@ public ShutdownService getShutdownSer

[GitHub] [pulsar] eolivelli commented on a change in pull request #10963: [Broker] Fix create partitioned topic in replicated namespace

2021-06-22 Thread GitBox
eolivelli commented on a change in pull request #10963: URL: https://github.com/apache/pulsar/pull/10963#discussion_r655245674 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/BrokerTestUtil.java ## @@ -29,4 +31,8 @@ public static String newUniqueName(String

[GitHub] [pulsar] gaoran10 commented on a change in pull request #10999: [Issue 9173] [Persistent Topics] Auto-create partitions even when the auto-creation is disabled

2021-06-22 Thread GitBox
gaoran10 commented on a change in pull request #10999: URL: https://github.com/apache/pulsar/pull/10999#discussion_r655852937 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -863,8 +863,19 @@ public void unloadNamespaceBundle

[GitHub] [pulsar] hsaputra commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-22 Thread GitBox
hsaputra commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655770029 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java ## @@ -0,0 +1,150 @@ +/** + * License

[GitHub] [pulsar] merlimat merged pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-22 Thread GitBox
merlimat merged pull request #10997: URL: https://github.com/apache/pulsar/pull/10997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [pulsar] fengtao1998 commented on a change in pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-22 Thread GitBox
fengtao1998 commented on a change in pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#discussion_r655828390 ## File path: site2/docs/client-libraries-python.md ## @@ -62,7 +62,7 @@ The complete Python API reference is available at [api/python](/api/python)

[GitHub] [pulsar] codelipenghui opened a new pull request #11005: Do not expose meaningless stats for consumer.

2021-06-22 Thread GitBox
codelipenghui opened a new pull request #11005: URL: https://github.com/apache/pulsar/pull/11005 ### Motivation Currently, we have exposed some meaningless consumer stats to users such as ``` addressLength addressOffset connectedSinceOffset connectedSinceLength c

[GitHub] [pulsar] newur commented on pull request #10982: [docs] Replace endless while loops with MessageListner

2021-06-22 Thread GitBox
newur commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865246513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [pulsar] newur edited a comment on issue #10971: [Doc] Transaction

2021-06-22 Thread GitBox
newur edited a comment on issue #10971: URL: https://github.com/apache/pulsar/issues/10971#issuecomment-865272604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [pulsar] newur edited a comment on pull request #10982: [docs] Replace endless while loops with MessageListner

2021-06-22 Thread GitBox
newur edited a comment on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865246513 @Anonymitaet the versioned docs are the content in `site2/website/versioned_docs`? Sure I would update them when the change gets approval. How far back do you norma

[GitHub] [pulsar] Anonymitaet commented on pull request #10982: [docs] Replace endless while loops with MessageListner

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865464250 Yes, all versioned docs are stored in [pulsar/site2/website/versioned_docs/](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs). You can "batch and

[GitHub] [pulsar] Anonymitaet commented on pull request #10999: [Issue 9173] [Persistent Topics] Auto-create partitions even when the auto-creation is disabled

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #10999: URL: https://github.com/apache/pulsar/pull/10999#issuecomment-865469960 Hi @Jason918 thanks for your contribution. For this PR, do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-22 Thread GitBox
jerrypeng commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655886394 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceUsageTopicTransportManager.java ## @@ -0,0 +1,275 @@ +/** + *

[GitHub] [pulsar] Anonymitaet commented on pull request #10978: [docs] use offical postgres docker image for debezium

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #10978: URL: https://github.com/apache/pulsar/pull/10978#issuecomment-865470254 @tuteng any feedback on this? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] kjaggann removed a comment on issue #10021: Websocket Encryption

2021-06-22 Thread GitBox
kjaggann removed a comment on issue #10021: URL: https://github.com/apache/pulsar/issues/10021#issuecomment-844133130 Is this change in pulsar 2.7.1 version. however we have upgraded the websocket version to 2.7.1 in our websocket proxies but still the user is unable to connect the when

[GitHub] [pulsar] Anonymitaet commented on pull request #10988: Fix wrong configuration name

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #10988: URL: https://github.com/apache/pulsar/pull/10988#issuecomment-864776361 @315157973 thanks for your contribution. Does this affect only master or other versioned docs? If latter, could you please help update all affected versions? Thanks --

[GitHub] [pulsar] zhucanyi commented on issue #10998: K8S environment sending message connection exception

2021-06-22 Thread GitBox
zhucanyi commented on issue #10998: URL: https://github.com/apache/pulsar/issues/10998#issuecomment-865630890 Is it possible that only pod can send messages in K8S? Or there may be other solutions that enable local access to pulsar in K8s -- This is an automated message from the Apache G

[GitHub] [pulsar] sijie closed issue #10951: Function worker uses raw webService Port against adverisedListener and advertisedAddress

2021-06-22 Thread GitBox
sijie closed issue #10951: URL: https://github.com/apache/pulsar/issues/10951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [pulsar] Anonymitaet merged pull request #10988: Fix wrong configuration name

2021-06-22 Thread GitBox
Anonymitaet merged pull request #10988: URL: https://github.com/apache/pulsar/pull/10988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners

2021-06-22 Thread GitBox
gaoran10 commented on a change in pull request #11006: URL: https://github.com/apache/pulsar/pull/11006#discussion_r655842848 ## File path: docker-compose/kitchen-sink/docker-compose.yml ## @@ -377,6 +377,9 @@ services: zookeeperServers: zk1:2181,zk2:2181,zk3:2181

[GitHub] [pulsar] 315157973 removed a comment on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-22 Thread GitBox
315157973 removed a comment on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865468882 I will fix this flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10981: [python-client] Fixed crash when using Python logger

2021-06-22 Thread GitBox
BewareMyPower commented on a change in pull request #10981: URL: https://github.com/apache/pulsar/pull/10981#discussion_r655484022 ## File path: pulsar-client-cpp/python/src/config.cc ## @@ -110,21 +112,29 @@ class LoggerWrapper: public Logger { public: -LoggerWrapp

[GitHub] [pulsar] Anonymitaet commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-22 Thread GitBox
Anonymitaet commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865469387 @codelipenghui thanks for your contribution. For this PR, do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] aloyszhang opened a new issue #11013: Field 'publish_time' is not set

2021-06-22 Thread GitBox
aloyszhang opened a new issue #11013: URL: https://github.com/apache/pulsar/issues/11013 **Describe the bug** KoP deserialize error after upgrade from 2.7.2 to 2.8.0. Similiar to https://github.com/apache/pulsar/issues/9467 ```shell [BookKeeperClientWorker-OrderedExecuto

[GitHub] [pulsar] linusmotu commented on issue #9594: Could not find a version that satisfies the requirement pulsar-client==2.7.0

2021-06-22 Thread GitBox
linusmotu commented on issue #9594: URL: https://github.com/apache/pulsar/issues/9594#issuecomment-865701082 Anyone have any success with this? I wanted to try and compile on the Raspberry Pi but I don't know where to even start. -- This is an automated message from the Apache Git Servic

[GitHub] [pulsar] aloyszhang opened a new pull request #11014: fix deserialized error

2021-06-22 Thread GitBox
aloyszhang opened a new pull request #11014: URL: https://github.com/apache/pulsar/pull/11014 Fixes #11013 ### Motivation Fix deserialized error caused by not check field before get. ### Modifications Check `publish_time` exist before get this field.

[GitHub] [pulsar] zhucanyi removed a comment on issue #10998: K8S environment sending message connection exception

2021-06-22 Thread GitBox
zhucanyi removed a comment on issue #10998: URL: https://github.com/apache/pulsar/issues/10998#issuecomment-865630890 Is it possible that only pod can send messages in K8S? Or there may be other solutions that enable local access to pulsar in K8s -- This is an automated message from the

[GitHub] [pulsar-client-go] jonyhy96 commented on a change in pull request #535: Fix data race while accessing connection in partitionConsumer

2021-06-22 Thread GitBox
jonyhy96 commented on a change in pull request #535: URL: https://github.com/apache/pulsar-client-go/pull/535#discussion_r655970263 ## File path: pulsar/consumer_partition.go ## @@ -1113,6 +1114,17 @@ func (pc *partitionConsumer) discardCorruptedMessage(msgID *pb.MessageIdData

[pulsar-dotpulsar] branch master updated: Update NuGet packages. Fix warnings.

2021-06-22 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new d2a3204 Update NuGet packages

[GitHub] [pulsar] BewareMyPower commented on pull request #11014: fix deserialized error

2021-06-22 Thread GitBox
BewareMyPower commented on pull request #11014: URL: https://github.com/apache/pulsar/pull/11014#issuecomment-865711649 After discussing with @aloyszhang , we need to find why the **required** `publish_time` field is missed first. -- This is an automated message from the Apache Git Servi

[GitHub] [pulsar] codelipenghui merged pull request #11010: Add 2.8.1 docs for repo

2021-06-22 Thread GitBox
codelipenghui merged pull request #11010: URL: https://github.com/apache/pulsar/pull/11010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] codelipenghui closed issue #10994: [Doc] generate 2.8.1 doc set

2021-06-22 Thread GitBox
codelipenghui closed issue #10994: URL: https://github.com/apache/pulsar/issues/10994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[pulsar] branch master updated (0a67b45 -> 37d3fea)

2021-06-22 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 0a67b45 release multiTopicsConsumerImpl when unsubscribe (#10997) add 37d3fea Add 2.8.1 docs for repo (#11010

[GitHub] [pulsar] mattisonchao opened a new pull request #11015: Feat # add test for TopicCountEquallyDivideBundleSplitAlgorithm.

2021-06-22 Thread GitBox
mattisonchao opened a new pull request #11015: URL: https://github.com/apache/pulsar/pull/11015 ### Modifications add test for TopicCountEquallyDivideBundleSplitAlgorithm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] codelipenghui opened a new pull request #11016: [Tests] Fix the flaky test in the ManagedLedgerTest

2021-06-22 Thread GitBox
codelipenghui opened a new pull request #11016: URL: https://github.com/apache/pulsar/pull/11016 ``` Error: testExpiredLedgerDeletionAfterManagedLedgerRestart(org.apache.bookkeeper.mledger.impl.ManagedLedgerTest) Time elapsed: 0.024 s <<< FAILURE! java.lang.AssertionError: expecte

[GitHub] [pulsar] lhotari commented on a change in pull request #11015: Feat # add test for TopicCountEquallyDivideBundleSplitAlgorithm.

2021-06-22 Thread GitBox
lhotari commented on a change in pull request #11015: URL: https://github.com/apache/pulsar/pull/11015#discussion_r656010644 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/common/naming/TopicCountEquallyDivideBundleSplitAlgorithmTest.java ## @@ -0,0 +1,93 @@ +/**

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11015: Feat # add test for TopicCountEquallyDivideBundleSplitAlgorithm.

2021-06-22 Thread GitBox
mattisonchao commented on a change in pull request #11015: URL: https://github.com/apache/pulsar/pull/11015#discussion_r656019367 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/common/naming/TopicCountEquallyDivideBundleSplitAlgorithmTest.java ## @@ -0,0 +1,93 @@

[GitHub] [pulsar] mattisonchao commented on pull request #11015: Feat # add test for TopicCountEquallyDivideBundleSplitAlgorithm.

2021-06-22 Thread GitBox
mattisonchao commented on pull request #11015: URL: https://github.com/apache/pulsar/pull/11015#issuecomment-865780291 i've been fix it,could you review it ? @lhotari -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] mattisonchao removed a comment on pull request #11015: Feat # add test for TopicCountEquallyDivideBundleSplitAlgorithm.

2021-06-22 Thread GitBox
mattisonchao removed a comment on pull request #11015: URL: https://github.com/apache/pulsar/pull/11015#issuecomment-865780291 i've been fix it,could you review it ? @lhotari -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

  1   2   3   >