[GitHub] [pulsar] BewareMyPower commented on pull request #11447: [python] Support CryptoKeyReader for Reader API in python clients

2021-08-10 Thread GitBox
BewareMyPower commented on pull request #11447: URL: https://github.com/apache/pulsar/pull/11447#issuecomment-895779718 Could you rebase to master for the fixed C++ CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-client-go] leizhiyuan commented on a change in pull request #586: [issue 585] retryRouter should Nack this message if error is not nil

2021-08-10 Thread GitBox
leizhiyuan commented on a change in pull request #586: URL: https://github.com/apache/pulsar-client-go/pull/586#discussion_r685745945 ## File path: pulsar/retry_router.go ## @@ -87,10 +87,15 @@ func (r *retryRouter) run() { producer := r.getProducer()

[GitHub] [pulsar-client-go] leizhiyuan commented on a change in pull request #588: fix:fail all pending requests when occurs ServerError_TopicTerminated…

2021-08-10 Thread GitBox
leizhiyuan commented on a change in pull request #588: URL: https://github.com/apache/pulsar-client-go/pull/588#discussion_r685747380 ## File path: pulsar/internal/connection.go ## @@ -697,6 +697,16 @@ func (c *connection) deletePendingRequest(requestID uint64) (*request, bool

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #588: fix:fail all pending requests when occurs ServerError_TopicTerminated…

2021-08-10 Thread GitBox
cckellogg commented on a change in pull request #588: URL: https://github.com/apache/pulsar-client-go/pull/588#discussion_r685755025 ## File path: pulsar/internal/connection.go ## @@ -764,7 +769,8 @@ func (c *connection) handleSendError(cmdError *pb.CommandError) {

[GitHub] [pulsar] jerrypeng opened a new pull request #11618: Allow Pulsar Functions / Sinks to pool messages

2021-08-10 Thread GitBox
jerrypeng opened a new pull request #11618: URL: https://github.com/apache/pulsar/pull/11618 ### Motivation Allow Pulsar Functions / Sinks to be configured so that the message pooling feature from the consumer can be leveraged. Functions / Sinks must have input type ByteBu

[GitHub] [pulsar] Anonymitaet merged pull request #11615: Fix schema-understand doc.

2021-08-10 Thread GitBox
Anonymitaet merged pull request #11615: URL: https://github.com/apache/pulsar/pull/11615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pulsar] branch master updated (31231d6 -> 723121a)

2021-08-10 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 31231d6 Use ZK persistent watches (#11198) add 723121a Fix schema-understand doc. (#11615) No new revisions we

[GitHub] [pulsar] eolivelli commented on a change in pull request #9298: [Issue 9297][broker] Try to fix flaky infinite reconnection

2021-08-10 Thread GitBox
eolivelli commented on a change in pull request #9298: URL: https://github.com/apache/pulsar/pull/9298#discussion_r685767050 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/OwnershipCache.java ## @@ -238,7 +239,32 @@ public OwnershipCache(PulsarSer

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11598: [Blog] Add 2.7.3 announcement blog

2021-08-10 Thread GitBox
Anonymitaet commented on a change in pull request #11598: URL: https://github.com/apache/pulsar/pull/11598#discussion_r685776019 ## File path: site2/website/blog/2021-08-xx-Apache-Pulsar-2-7-3.md ## @@ -0,0 +1,139 @@ +--- +author: Bo Cong, Anonymitaet +title: Apache Pulsar 2.7.

[GitHub] [pulsar-client-go] leizhiyuan commented on a change in pull request #588: fix:fail all pending requests when occurs ServerError_TopicTerminated…

2021-08-10 Thread GitBox
leizhiyuan commented on a change in pull request #588: URL: https://github.com/apache/pulsar-client-go/pull/588#discussion_r685778535 ## File path: pulsar/internal/connection.go ## @@ -764,7 +769,8 @@ func (c *connection) handleSendError(cmdError *pb.CommandError) {

[GitHub] [pulsar] wuzhanpeng commented on a change in pull request #11606: Fix race condition in concurrent schema deletion

2021-08-10 Thread GitBox
wuzhanpeng commented on a change in pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#discussion_r685787550 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -372,6 +374,21 @@ public String getReplicatorPref

[GitHub] [pulsar] gaozhangmin opened a new issue #11619: NPE when getPreviousPosition

2021-08-10 Thread GitBox
gaozhangmin opened a new issue #11619: URL: https://github.com/apache/pulsar/issues/11619 There's a chance that headMap might be empty even if a empty check added. because remove would be executed in `ledgers`. after the empty check between line 3214 and line 3219 in following code snipp

[GitHub] [pulsar] gaozhangmin commented on issue #11619: NPE when getPreviousPosition

2021-08-10 Thread GitBox
gaozhangmin commented on issue #11619: URL: https://github.com/apache/pulsar/issues/11619#issuecomment-895833089 Please assign to me. I will fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] gaozhangmin closed issue #11619: NPE when getPreviousPosition

2021-08-10 Thread GitBox
gaozhangmin closed issue #11619: URL: https://github.com/apache/pulsar/issues/11619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pulsar] eolivelli commented on a change in pull request #11606: Fix race condition in concurrent schema deletion

2021-08-10 Thread GitBox
eolivelli commented on a change in pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#discussion_r685804787 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -372,6 +374,21 @@ public String getReplicatorPrefi

[GitHub] [pulsar] timmyyuan opened a new issue #11620: [Build] Building the pulsar-standalone image requires user interaction

2021-08-10 Thread GitBox
timmyyuan opened a new issue #11620: URL: https://github.com/apache/pulsar/issues/11620 **Describe the bug** Building the pulsar-standalone image requires user interaction, which prevents automation of the release process **To Reproduce** Steps to reproduce the behavior:

[GitHub] [pulsar] gaozhangmin opened a new pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
gaozhangmin opened a new pull request #11621: URL: https://github.com/apache/pulsar/pull/11621 Fixes #11619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [pulsar] gaozhangmin removed a comment on issue #11619: NPE when getPreviousPosition

2021-08-10 Thread GitBox
gaozhangmin removed a comment on issue #11619: URL: https://github.com/apache/pulsar/issues/11619#issuecomment-895833089 Please assign to me. I will fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] congbobo184 opened a new pull request #11622: Fix pulsar website publish

2021-08-10 Thread GitBox
congbobo184 opened a new pull request #11622: URL: https://github.com/apache/pulsar/pull/11622 Fix pulsar website publish .add `.asf.yaml` config doc : https://s.apache.org/asfyamlpublishing discussion https://the-asf.slack.com/archives/CBX4TSBQ8/p1628582435202100 -- This is an automat

[GitHub] [pulsar] timmyyuan opened a new pull request #11623: Fix unnecessary user interactions in building pulsar-standalone image

2021-08-10 Thread GitBox
timmyyuan opened a new pull request #11623: URL: https://github.com/apache/pulsar/pull/11623 Fix https://github.com/apache/pulsar/issues/11620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-go] leizhiyuan opened a new issue #589: incorrect close of connection

2021-08-10 Thread GitBox
leizhiyuan opened a new issue #589: URL: https://github.com/apache/pulsar-client-go/issues/589 Expected behavior only close cnx,not connection ``` // Close closes the connection by // closing underlying socket connection and closeCh. // This also triggers callbac

[GitHub] [pulsar] congbobo184 merged pull request #11622: Fix pulsar website publish

2021-08-10 Thread GitBox
congbobo184 merged pull request #11622: URL: https://github.com/apache/pulsar/pull/11622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pulsar] branch asf-site updated: Fix pulsar website publish (#11622)

2021-08-10 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 3c94dfa Fix pulsar website publish (#11622)

[GitHub] [pulsar-client-go] leizhiyuan opened a new pull request #590: [issue 589]fix incorrect close,should close cnx, not connection

2021-08-10 Thread GitBox
leizhiyuan opened a new pull request #590: URL: https://github.com/apache/pulsar-client-go/pull/590 Fixes #589 ### Motivation The Close method will not be executed twice. It seems we need close the cnx ,not connection ### Modifications close the cnx ##

[GitHub] [pulsar] sijia-w opened a new pull request #11624: [docs] [Fix 10893] Add a note to suggest running 'ldconfig' after installing C++ libs from RPMs

2021-08-10 Thread GitBox
sijia-w opened a new pull request #11624: URL: https://github.com/apache/pulsar/pull/11624 Fixes #10893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [pulsar] sijia-w commented on pull request #11624: [docs] [Fix 10893] Add a note to suggest running 'ldconfig' after installing C++ libs from RPMs

2021-08-10 Thread GitBox
sijia-w commented on pull request #11624: URL: https://github.com/apache/pulsar/pull/11624#issuecomment-895863445 @Jennifer88huang @hangc0276 PTAL. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pulsar] frankxieke commented on a change in pull request #11555: [Offload] Add offload performance metrics for tiered storage.

2021-08-10 Thread GitBox
frankxieke commented on a change in pull request #11555: URL: https://github.com/apache/pulsar/pull/11555#discussion_r685845386 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlockAwareSegmentInputStreamImpl.java ## @@ -113,

[GitHub] [pulsar] sijia-w commented on issue #11291: [Doc] Remove Pulsar Dashboard contents

2021-08-10 Thread GitBox
sijia-w commented on issue #11291: URL: https://github.com/apache/pulsar/issues/11291#issuecomment-895876798 @Anonymitaet @Jennifer88huang I have checked the docs that contain `Pulsar dashboard`. I found that actually there is always a note to remind the users that `Pulsar dashboard` is de

[GitHub] [pulsar] sijia-w edited a comment on issue #11291: [Doc] Remove Pulsar Dashboard contents

2021-08-10 Thread GitBox
sijia-w edited a comment on issue #11291: URL: https://github.com/apache/pulsar/issues/11291#issuecomment-895876798 @Anonymitaet @Jennifer88huang I have checked the docs that contain `Pulsar dashboard` and here is what I think: - In file `administration dashboard`: remove everything

[GitHub] [pulsar] aloyszhang commented on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-10 Thread GitBox
aloyszhang commented on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-895880668 > Do we have the same problem but when you create a NonDurable subscription and then you use the same name to create a Durable subscription = Yes, this also has the same p

[GitHub] [pulsar] aloyszhang edited a comment on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-10 Thread GitBox
aloyszhang edited a comment on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-895880668 > Do we have the same problem but when you create a NonDurable subscription and then you use the same name to create a Durable subscription = Yes, this also has

[GitHub] [pulsar] Jennifer88huang commented on issue #11380: CLI in TTL config is not clear

2021-08-10 Thread GitBox
Jennifer88huang commented on issue #11380: URL: https://github.com/apache/pulsar/issues/11380#issuecomment-895895239 @sijia-w could you like to investigate and try to fix the issue? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pulsar] Jennifer88huang commented on issue #8357: [docs] Add doc on how to use batching for key_shared subscription

2021-08-10 Thread GitBox
Jennifer88huang commented on issue #8357: URL: https://github.com/apache/pulsar/issues/8357#issuecomment-895898399 @sijia-w could you like to investigate and try to fix the issue? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Jennifer88huang commented on issue #8671: [Doc] hardware recommodations (Cores, RAM, storage) for dev

2021-08-10 Thread GitBox
Jennifer88huang commented on issue #8671: URL: https://github.com/apache/pulsar/issues/8671#issuecomment-895899484 @sijia-w could you like to investigate and try to fix the issue? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Jennifer88huang opened a new issue #11625: [doc] Message redelivery and acknowledgement

2021-08-10 Thread GitBox
Jennifer88huang opened a new issue #11625: URL: https://github.com/apache/pulsar/issues/11625 **Is your feature request related to a problem? Please describe.** In the current messaging docs, there is no content related to message redelivery and acknowledgement. **Describe the sol

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
BewareMyPower commented on a change in pull request #11621: URL: https://github.com/apache/pulsar/pull/11621#discussion_r685887182 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3202,8 +3203,9 @@ public PositionImpl

[GitHub] [pulsar] frankxieke opened a new issue #11626: metrics label with a redundant comma at the last

2021-08-10 Thread GitBox
frankxieke opened a new issue #11626: URL: https://github.com/apache/pulsar/issues/11626 **Describe the bug** Metrics problem , it seems that some prometheus metrics lable with a redundant comma. pulsar_function_worker_stop_instance_process_time_ms{cluster="standalone",qu

[GitHub] [pulsar] codelipenghui merged pull request #11500: Add metrics for writing or reading size of cursor

2021-08-10 Thread GitBox
codelipenghui merged pull request #11500: URL: https://github.com/apache/pulsar/pull/11500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (723121a -> bfae8f6)

2021-08-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 723121a Fix schema-understand doc. (#11615) add bfae8f6 Add metrics for writing or reading size of cursor (#1

[GitHub] [pulsar] aloyszhang commented on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-10 Thread GitBox
aloyszhang commented on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-895925836 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] aloyszhang edited a comment on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-10 Thread GitBox
aloyszhang edited a comment on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-895880668 > Do we have the same problem but when you create a NonDurable subscription and then you use the same name to create a Durable subscription = Yes, this also has

[GitHub] [pulsar] lhotari commented on pull request #11601: [Issue 11096][Tests] Attempt to fix flaky test ResourceGroupConfigListenerTest

2021-08-10 Thread GitBox
lhotari commented on pull request #11601: URL: https://github.com/apache/pulsar/pull/11601#issuecomment-895958400 closing this since #11198 should fix the flakiness issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] lhotari closed pull request #11601: [Issue 11096][Tests] Attempt to fix flaky test ResourceGroupConfigListenerTest

2021-08-10 Thread GitBox
lhotari closed pull request #11601: URL: https://github.com/apache/pulsar/pull/11601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] lhotari commented on pull request #11292: fix issue-11282

2021-08-10 Thread GitBox
lhotari commented on pull request #11292: URL: https://github.com/apache/pulsar/pull/11292#issuecomment-895962872 FYI, there are some thread safety issues in OpReadEntry . PR #11387 attempts to fix some of the thread safety issues. -- This is an automated message from the Apache Git Serv

[GitHub] [pulsar] vroyer commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-10 Thread GitBox
vroyer commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685946972 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -16,11 +48,45 @@ The configuration of the ElasticSearch sink connector has the following properti

[GitHub] [pulsar] leizhiyuan commented on issue #11626: metrics label with a redundant comma at the last

2021-08-10 Thread GitBox
leizhiyuan commented on issue #11626: URL: https://github.com/apache/pulsar/issues/11626#issuecomment-895966458 org.apache.pulsar.functions.worker.WorkerStatsManager#writeMetric ``` for (int i = 0; i < metricsLabelNames.length; i++) { stream.write(metricsLabelNames[i]);

[GitHub] [pulsar] lhotari commented on issue #11521: NPE in managed ledger on read failed

2021-08-10 Thread GitBox
lhotari commented on issue #11521: URL: https://github.com/apache/pulsar/issues/11521#issuecomment-895969683 > For this issue, on a given OpReadEntry object one of readEntriesFailed() and checkReadCompletion() needs to get invoked more than once. From reading through the code, I am not ent

[GitHub] [pulsar] ivankelly opened a new pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-10 Thread GitBox
ivankelly opened a new pull request #11627: URL: https://github.com/apache/pulsar/pull/11627 This patch contains a number of changes. TooManyRequests is retried for partition metadata and lookups Lookup timeout configuration has been added. By default it matches operation ti

[GitHub] [pulsar-client-go] leizhiyuan opened a new issue #591: dlqRouter do not process error correctly when SendAsync

2021-08-10 Thread GitBox
leizhiyuan opened a new issue #591: URL: https://github.com/apache/pulsar-client-go/issues/591 Expected behavior dlqRouter process error correctly when SendAsync ,when send error, shoud nack the message Actual behavior dlqRouter do not process error correctly

[GitHub] [pulsar-client-go] leizhiyuan opened a new pull request #592: [issue 591] when send error,dlqrouter nack the message

2021-08-10 Thread GitBox
leizhiyuan opened a new pull request #592: URL: https://github.com/apache/pulsar-client-go/pull/592 Fixes #591 ### Motivation dlqrouter should process correctly ### Modifications when send error,dlqrouter nack the message ### Verifying this change

[GitHub] [pulsar] ivankelly commented on pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-10 Thread GitBox
ivankelly commented on pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#issuecomment-896001749 Some tests are failing. At least one of the failures is legit, so I'll look into it and post an update -- This is an automated message from the Apache Git Service. To respo

[pulsar] branch asf-site updated: add .asf.yaml

2021-08-10 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new d1eb8bd add .asf.yaml d1eb8bd is described

[GitHub] [pulsar] Technoboy- opened a new issue #11628: Flaky-test: ElasticSearchClientTests.testBulkRetry

2021-08-10 Thread GitBox
Technoboy- opened a new issue #11628: URL: https://github.com/apache/pulsar/issues/11628 ElasticSearchClientTests is flaky. The [testBulkRetry] test method fails sporadically. [example failure](https://github.com/apache/pulsar/pull/11564/checks?check_run_id=3290485512)

[GitHub] [pulsar] Technoboy- commented on issue #11628: Flaky-test: ElasticSearchClientTests.testBulkRetry

2021-08-10 Thread GitBox
Technoboy- commented on issue #11628: URL: https://github.com/apache/pulsar/issues/11628#issuecomment-896022784 Hi @eolivelli I take a look at the ElasticSearchClientTests#testBulkRetry, I think we may name every index randomly or delete index after each test . ``` @Test publi

[GitHub] [pulsar] Technoboy- commented on pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-10 Thread GitBox
Technoboy- commented on pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#issuecomment-896023532 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-10 Thread GitBox
BewareMyPower commented on a change in pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#discussion_r686023466 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java ## @@ -327,6 +333,14 @@ public boolean i

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-10 Thread GitBox
BewareMyPower commented on a change in pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#discussion_r686026221 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientException.java ## @@ -957,77 +1003,110 @@ public static Pul

[GitHub] [pulsar] hangc0276 commented on pull request #11293: [IO] Pass client builder to debezium database history

2021-08-10 Thread GitBox
hangc0276 commented on pull request #11293: URL: https://github.com/apache/pulsar/pull/11293#issuecomment-896056576 move to 2.8.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [pulsar] eolivelli commented on pull request #11293: [IO] Pass client builder to debezium database history

2021-08-10 Thread GitBox
eolivelli commented on pull request #11293: URL: https://github.com/apache/pulsar/pull/11293#issuecomment-896061700 @hangc0276 this is a new API, probably it won't be delivered in 2.8.x. I suggest to remove the 2.8.2 label. in point releases we should not add new APIs -- This is a

[GitHub] [pulsar] codelipenghui opened a new pull request #11629: Avoid redundant calls for getting the offload policies from the offloader

2021-08-10 Thread GitBox
codelipenghui opened a new pull request #11629: URL: https://github.com/apache/pulsar/pull/11629 If we have many ledgers in a managed ledger, for checking if need to delete the offloaded ledger from bookies, for each ledger, will call getOffloadPolicies() from the Offloader. For the Blo

[GitHub] [pulsar] codelipenghui merged pull request #11494: Pending ack set managed ledger config true

2021-08-10 Thread GitBox
codelipenghui merged pull request #11494: URL: https://github.com/apache/pulsar/pull/11494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (bfae8f6 -> daf457d)

2021-08-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bfae8f6 Add metrics for writing or reading size of cursor (#11500) add daf457d Pending ack set managed ledger

[GitHub] [pulsar] sanjivr commented on pull request #11447: [python] Support CryptoKeyReader for Reader API in python clients

2021-08-10 Thread GitBox
sanjivr commented on pull request #11447: URL: https://github.com/apache/pulsar/pull/11447#issuecomment-896076120 > Could you rebase to master for the fixed C++ CI? Sure. However this will result in a force push to this branch/pr -- This is an automated message from the Apache Git

[GitHub] [pulsar] ivankelly commented on a change in pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-10 Thread GitBox
ivankelly commented on a change in pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#discussion_r686083771 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientException.java ## @@ -957,77 +1003,110 @@ public static PulsarC

[GitHub] [pulsar] ivankelly commented on a change in pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-10 Thread GitBox
ivankelly commented on a change in pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#discussion_r686084378 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java ## @@ -327,6 +333,14 @@ public boolean isUse

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
codelipenghui commented on a change in pull request #11621: URL: https://github.com/apache/pulsar/pull/11621#discussion_r686085678 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3202,8 +3203,9 @@ public PositionImpl

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
codelipenghui commented on a change in pull request #11621: URL: https://github.com/apache/pulsar/pull/11621#discussion_r686085678 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3202,8 +3203,9 @@ public PositionImpl

[GitHub] [pulsar] hangc0276 commented on a change in pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
hangc0276 commented on a change in pull request #11621: URL: https://github.com/apache/pulsar/pull/11621#discussion_r686088081 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3202,8 +3203,9 @@ public PositionImpl getP

[GitHub] [pulsar] hangc0276 commented on pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
hangc0276 commented on pull request #11621: URL: https://github.com/apache/pulsar/pull/11621#issuecomment-896092475 move to 2.8.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
BewareMyPower commented on a change in pull request #11621: URL: https://github.com/apache/pulsar/pull/11621#discussion_r686102144 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3202,8 +3203,9 @@ public PositionImpl

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-10 Thread GitBox
BewareMyPower commented on a change in pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#discussion_r686103662 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientException.java ## @@ -957,77 +1003,110 @@ public static Pul

[GitHub] [pulsar] michaeljmarshall commented on pull request #11609: [Java Client] Switch from pretty print to compact print for configs

2021-08-10 Thread GitBox
michaeljmarshall commented on pull request #11609: URL: https://github.com/apache/pulsar/pull/11609#issuecomment-896115096 @Anonymitaet - correct, no need to change any documentation. The PR is just a change to log format. The content of the logs will be the same. (`N/A` means not applicab

[pulsar-client-go] branch master updated (29414db -> 2109f3d)

2021-08-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. from 29414db [issue 574] Fix handle send error panic (#576) add 2109f3d [issue 585] retryRouter should Na

[GitHub] [pulsar] bharanic-dev closed pull request #11157: [Issue 11153] [pulsar-broker] Fix for missing metadata-store watch events

2021-08-10 Thread GitBox
bharanic-dev closed pull request #11157: URL: https://github.com/apache/pulsar/pull/11157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [pulsar] bharanic-dev commented on pull request #11157: [Issue 11153] [pulsar-broker] Fix for missing metadata-store watch events

2021-08-10 Thread GitBox
bharanic-dev commented on pull request #11157: URL: https://github.com/apache/pulsar/pull/11157#issuecomment-896124498 Closing this as, #11198 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] codelipenghui merged pull request #11609: [Java Client] Switch from pretty print to compact print for configs

2021-08-10 Thread GitBox
codelipenghui merged pull request #11609: URL: https://github.com/apache/pulsar/pull/11609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] aloyszhang commented on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-10 Thread GitBox
aloyszhang commented on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-896123481 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11621: fix getPreviousPosition npe

2021-08-10 Thread GitBox
codelipenghui commented on a change in pull request #11621: URL: https://github.com/apache/pulsar/pull/11621#discussion_r686120797 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3202,8 +3203,9 @@ public PositionImpl

[GitHub] [pulsar-client-go] merlimat merged pull request #586: [issue 585] retryRouter should Nack this message if error is not nil

2021-08-10 Thread GitBox
merlimat merged pull request #586: URL: https://github.com/apache/pulsar-client-go/pull/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [pulsar-client-go] merlimat closed issue #585: retryRouter should Nack this message if error is not nil

2021-08-10 Thread GitBox
merlimat closed issue #585: URL: https://github.com/apache/pulsar-client-go/issues/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #590: [issue 589]fix incorrect close,should close cnx, not connection

2021-08-10 Thread GitBox
cckellogg commented on a change in pull request #590: URL: https://github.com/apache/pulsar-client-go/pull/590#discussion_r686134560 ## File path: pulsar/internal/connection.go ## @@ -428,7 +428,7 @@ func (c *connection) runPingCheck(pingCheckTicker *time.Ticker) {

[pulsar] branch master updated (9af5e53 -> 73bddae)

2021-08-10 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 9af5e53 [Java Client] Switch from pretty print to compact print for configs (#11609) add 73bddae Allow Pul

[GitHub] [pulsar] jerrypeng merged pull request #11618: Allow Pulsar Functions / Sinks to pool messages

2021-08-10 Thread GitBox
jerrypeng merged pull request #11618: URL: https://github.com/apache/pulsar/pull/11618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #588: [issue 587] fail all pending requests when occurs ServerError_TopicTerminated…

2021-08-10 Thread GitBox
cckellogg commented on a change in pull request #588: URL: https://github.com/apache/pulsar-client-go/pull/588#discussion_r686139920 ## File path: pulsar/internal/connection.go ## @@ -697,6 +692,29 @@ func (c *connection) deletePendingRequest(requestID uint64) (*request, bool)

[GitHub] [pulsar] bharanic-dev commented on pull request #11198: Use ZK persistent watches

2021-08-10 Thread GitBox
bharanic-dev commented on pull request #11198: URL: https://github.com/apache/pulsar/pull/11198#issuecomment-896142833 @merlimat now that this is merged, I would like to merge the unit test that I used to reproduce the problem. Please take a look: https://github.com/apache/pulsar/pull/1115

[GitHub] [pulsar] bharanic-dev commented on pull request #11155: [Issue 11153 ] [pulsar-broker] Unit test to reproduce metadata-store watch events

2021-08-10 Thread GitBox
bharanic-dev commented on pull request #11155: URL: https://github.com/apache/pulsar/pull/11155#issuecomment-896143218 @merlimat @lhotari please help review this, now that https://github.com/apache/pulsar/pull/11198 is merged. -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] bharanic-dev commented on issue #11521: NPE in managed ledger on read failed

2021-08-10 Thread GitBox
bharanic-dev commented on issue #11521: URL: https://github.com/apache/pulsar/issues/11521#issuecomment-896145422 @lhotari thank you. I agree that some of the issues that can arise if thread safety rules are broken, can be impossible to figure out just reading the code. I will try #11387 a

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-10 Thread GitBox
michaeljmarshall commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r686152453 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1809,9 +1811,25 @@ public Top

[GitHub] [pulsar] aloyszhang commented on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-10 Thread GitBox
aloyszhang commented on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-896151514 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] aloyszhang removed a comment on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-10 Thread GitBox
aloyszhang removed a comment on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-896123481 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-10 Thread GitBox
michaeljmarshall commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r686153350 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1809,9 +1811,25 @@ public Top

[GitHub] [pulsar] merlimat commented on pull request #11623: Fix unnecessary user interactions when building pulsar-standalone image

2021-08-10 Thread GitBox
merlimat commented on pull request #11623: URL: https://github.com/apache/pulsar/pull/11623#issuecomment-896192705 We should just get rid of the `pulsar-standalone` Docker image. The only point of this was to include the web dashboard which was already deprecated and removed from master.

[GitHub] [pulsar] Vanlightly commented on pull request #11570: [Issue 11496][C++] Allow partitioned producers to start lazily

2021-08-10 Thread GitBox
Vanlightly commented on pull request #11570: URL: https://github.com/apache/pulsar/pull/11570#issuecomment-896206401 @Anonymitaet I have added to the documentation a section about lazy producers and also added examples of both synchronous and asynchronous producers and consumers. -- Thi

[GitHub] [pulsar] merlimat closed issue #10893: Update documentation to suggest running 'ldconfig' after installing C++ libs from RPMs

2021-08-10 Thread GitBox
merlimat closed issue #10893: URL: https://github.com/apache/pulsar/issues/10893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pulsar] merlimat merged pull request #11624: [docs] [Fix 10893] Add a note to suggest running 'ldconfig' after installing C++ libs from RPMs

2021-08-10 Thread GitBox
merlimat merged pull request #11624: URL: https://github.com/apache/pulsar/pull/11624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated: add note (#11624)

2021-08-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ce4ad9d add note (#11624) ce4ad9d is described

[GitHub] [pulsar] oversearch opened a new pull request #11630: [C++] Fixing use-after-free and constructor bugs in UnAckedMessageTrackerEnabled

2021-08-10 Thread GitBox
oversearch opened a new pull request #11630: URL: https://github.com/apache/pulsar/pull/11630 ### Motivation This is very similar to a previous fix I submitted in commit 87ebe80. It's the same basic problem, but this class isn't part of the HandlerBase hierarchy, so it needs an ind

[GitHub] [pulsar] eolivelli commented on pull request #11623: Fix unnecessary user interactions when building pulsar-standalone image

2021-08-10 Thread GitBox
eolivelli commented on pull request #11623: URL: https://github.com/apache/pulsar/pull/11623#issuecomment-896247590 > We should just get rid of the `pulsar-standalone` Docker image. The only point of this was to include the web dashboard which was already deprecated and removed from master

[GitHub] [pulsar] eolivelli merged pull request #11623: Fix unnecessary user interactions when building pulsar-standalone image

2021-08-10 Thread GitBox
eolivelli merged pull request #11623: URL: https://github.com/apache/pulsar/pull/11623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] eolivelli closed issue #11620: [Build] Building the pulsar-standalone image requires user interaction

2021-08-10 Thread GitBox
eolivelli closed issue #11620: URL: https://github.com/apache/pulsar/issues/11620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

  1   2   >