[GitHub] [pulsar] eolivelli commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-17 Thread GitBox
eolivelli commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690091488 ## File path: pulsar-io/alluxio/src/main/java/org/apache/pulsar/io/alluxio/sink/AlluxioAbstractSink.java ## @@ -0,0 +1,272 @@ +/** + * Licensed to the A

[GitHub] [pulsar] urfreespace opened a new pull request #11680: website upgrade

2021-08-17 Thread GitBox
urfreespace opened a new pull request #11680: URL: https://github.com/apache/pulsar/pull/11680 ### Base - [ ] init website-next base project - [ ] add versioned-docs support ### Md Plugin Migration converted `Docusaurus v1 Remarkable plugins` to `Docusaurus v2 Remark/Rehype pl

[GitHub] [pulsar] lhotari opened a new pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari opened a new pull request #11681: URL: https://github.com/apache/pulsar/pull/11681 Fixes #11548 ### Motivation Disabling non-TLS service ports isn't possible at the moment. Issue #11548 has been reported and contains instructions to reproduce the issue. ### Modi

[GitHub] [pulsar] eolivelli commented on a change in pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
eolivelli commented on a change in pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#discussion_r690162266 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java ## @@ -1122,7 +1122,7 @@ private String

[GitHub] [pulsar] lhotari commented on a change in pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari commented on a change in pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#discussion_r690183362 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java ## @@ -1122,7 +1122,7 @@ private String g

[GitHub] [pulsar] lhotari commented on pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari commented on pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900130782 > I am not sure how does your PR solve #11548. From what I can see, you are basically changing the function worker service and tests. There is nothing related to brokers. Can y

[GitHub] [pulsar] lhotari edited a comment on pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari edited a comment on pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900130782 > I am not sure how does your PR solve #11548. From what I can see, you are basically changing the function worker service and tests. There is nothing related to brokers

[GitHub] [pulsar] ivankelly commented on pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-17 Thread GitBox
ivankelly commented on pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#issuecomment-900132986 @eolivelli this has 4 approvals and no changes requested. IMO it's ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar] lhotari commented on issue #11548: Pulsar server non-tls ports are still listening when TLS in-transit encryption is enabled

2021-08-17 Thread GitBox
lhotari commented on issue #11548: URL: https://github.com/apache/pulsar/issues/11548#issuecomment-900134923 @yabinmeng There's a PR #11681 to fix some issues. Most of the fixed issues in that PR apply to Pulsar Standalone. Setting TLS only requires setting `brokerClientTlsEnabled=tr

[GitHub] [pulsar] lhotari edited a comment on issue #11548: Pulsar server non-tls ports are still listening when TLS in-transit encryption is enabled

2021-08-17 Thread GitBox
lhotari edited a comment on issue #11548: URL: https://github.com/apache/pulsar/issues/11548#issuecomment-900134923 @yabinmeng There's a PR #11681 to fix some issues. Most of the fixed issues in that PR apply to Pulsar Standalone. Setting TLS only requires setting `brokerClientTlsEna

[GitHub] [pulsar] lhotari commented on pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari commented on pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900142910 @sijie This was the 2nd exception that this PR fixed in Pulsar Standalone (with TLS ports only config mentioned in my previous comment): ``` 12:29:46.424 [main] ERROR

[GitHub] [pulsar] murong00 commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-17 Thread GitBox
murong00 commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690208988 ## File path: pulsar-io/alluxio/pom.xml ## @@ -0,0 +1,161 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-

[GitHub] [pulsar] lhotari commented on pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari commented on pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900151810 without making any changes, disabling non-TLS service ports works for Pulsar Stanadlone when Function Worker is disabled and when `loadManagerClassName=org.apache.pulsar.broker

[GitHub] [pulsar] murong00 commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-17 Thread GitBox
murong00 commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690210294 ## File path: pulsar-io/alluxio/src/main/java/org/apache/pulsar/io/alluxio/sink/AlluxioStringSink.java ## @@ -0,0 +1,42 @@ +/** + * Licensed to the Apach

[GitHub] [pulsar] gaozhangmin opened a new issue #11682: failed update partition of topic。

2021-08-17 Thread GitBox
gaozhangmin opened a new issue #11682: URL: https://github.com/apache/pulsar/issues/11682 1、I tried to update partition num of a topic, but got error: ![image](https://user-images.githubusercontent.com/9278488/129704089-372137f4-4192-45a8-92cb-579bfbfab45e.png) 2、When I attempted to t

[GitHub] [pulsar] gaozhangmin opened a new pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
gaozhangmin opened a new pull request #11683: URL: https://github.com/apache/pulsar/pull/11683 Fixes #11682 1、`tryCreatePartitionsAsync` would create znode under `managed-ledgers/public/default/persistent/` 2、there are chance, `updatePartitionedTopic` would failed, and managed

[GitHub] [pulsar] eolivelli commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-17 Thread GitBox
eolivelli commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690220029 ## File path: pulsar-io/alluxio/pom.xml ## @@ -0,0 +1,161 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema

[GitHub] [pulsar] eolivelli commented on pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-17 Thread GitBox
eolivelli commented on pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#issuecomment-900168385 > @eolivelli this has 4 approvals and no changes requested. IMO it's ready to merge. agreed. merging now -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] eolivelli merged pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-17 Thread GitBox
eolivelli merged pull request #11627: URL: https://github.com/apache/pulsar/pull/11627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pulsar] branch master updated: PIP-91: Separate lookup timeout from operation timeout (#11627)

2021-08-17 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b557e24 PIP-91: Separate lookup timeout from

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
BewareMyPower commented on a change in pull request #11683: URL: https://github.com/apache/pulsar/pull/11683#discussion_r690236513 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3636,6 +3638,13 @@ private Persiste

[GitHub] [pulsar] ivankelly commented on pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-17 Thread GitBox
ivankelly commented on pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#issuecomment-900176730 @eolivelli thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
BewareMyPower commented on a change in pull request #11683: URL: https://github.com/apache/pulsar/pull/11683#discussion_r690239608 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3628,6 +3628,8 @@ private Persisten

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
BewareMyPower commented on a change in pull request #11683: URL: https://github.com/apache/pulsar/pull/11683#discussion_r690241329 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3636,6 +3638,13 @@ private Persiste

[GitHub] [pulsar] ivankelly opened a new pull request #11684: [client] Make request IDs more unique

2021-08-17 Thread GitBox
ivankelly opened a new pull request #11684: URL: https://github.com/apache/pulsar/pull/11684 When investigating an error, it's nice to be able to correlate client errors with logs on the broker side. Normally some sort of trace ID is used for this, but since we already have request ID

[GitHub] [pulsar] Lucgarg commented on issue #11457: [sink jdbc-clickhouse] avro (and possibly others) sink is broken

2021-08-17 Thread GitBox
Lucgarg commented on issue #11457: URL: https://github.com/apache/pulsar/issues/11457#issuecomment-900186161 I think the problem is that to enter data in JSON format, you have to specify the clickhouse type of JSONEachRow format. But i think the jdbc connector doesn't give that option.

[GitHub] [pulsar] Nicklee007 opened a new issue #11685: can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
Nicklee007 opened a new issue #11685: URL: https://github.com/apache/pulsar/issues/11685 **Describe the bug** can not update topic when the update topicName is contained by an existed topic as a part ![image](https://user-images.githubusercontent.com/84127069/129704520-93293d10

[GitHub] [pulsar] Nicklee007 opened a new pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
Nicklee007 opened a new pull request #11686: URL: https://github.com/apache/pulsar/pull/11686 Fixes #11685 validatePartitionTopicUpdate use contain to check if there has a exist topic will cause conflict, which will cause a failed when exist a topic which contain the new topic's p

[GitHub] [pulsar] Lucgarg edited a comment on issue #11457: [sink jdbc-clickhouse] avro (and possibly others) sink is broken

2021-08-17 Thread GitBox
Lucgarg edited a comment on issue #11457: URL: https://github.com/apache/pulsar/issues/11457#issuecomment-900186161 I think the problem is that to enter data in JSON format, you have to specify the clickhouse type of JSONEachRow format. But i think the jdbc connector doesn't give that opti

[GitHub] [pulsar] eolivelli commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-17 Thread GitBox
eolivelli commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690322751 ## File path: pulsar-io/alluxio/pom.xml ## @@ -0,0 +1,161 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema

[GitHub] [pulsar] Maxzouz opened a new issue #11687: Excessive RAM consumption on kubernetes pulsar bookie pods

2021-08-17 Thread GitBox
Maxzouz opened a new issue #11687: URL: https://github.com/apache/pulsar/issues/11687 Expected behavior RAM usage of pulsar bookie pods shouldn't exceeds xms/xmx values Actual behavior RAM usage is way over the limits fixed in config file Steps to r

[GitHub] [pulsar] codelipenghui merged pull request #11513: Avoid to cal getMaximumRolloverTimeMs everytime

2021-08-17 Thread GitBox
codelipenghui merged pull request #11513: URL: https://github.com/apache/pulsar/pull/11513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (b557e24 -> f0692ad)

2021-08-17 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b557e24 PIP-91: Separate lookup timeout from operation timeout (#11627) add f0692ad Avoid to cal getMaximumR

[GitHub] [pulsar] ivankelly opened a new pull request #11688: [client] Consider a timed-out lookup equivalent to TooManyRequests

2021-08-17 Thread GitBox
ivankelly opened a new pull request #11688: URL: https://github.com/apache/pulsar/pull/11688 Lookups and PartitionMetadataRequests(PMR) will get TooManyRequest if the broker they are talking to is making a lot of async requests to ZK and thus accepting and parking a lot of requests. Th

[GitHub] [pulsar] Vanlightly opened a new issue #11689: Java consumer can block forever on batchReceive

2021-08-17 Thread GitBox
Vanlightly opened a new issue #11689: URL: https://github.com/apache/pulsar/issues/11689 **Describe the bug** When `Consumer.batchReceive()` is called concurrently by different threads there exists a race condition in `ConsumerBase.java` which when triggered causes a CompletableFuture i

[GitHub] [pulsar] lhotari opened a new issue #11690: Flaky-test: LockManagerTest.revalidateLockOnDifferentSession

2021-08-17 Thread GitBox
lhotari opened a new issue #11690: URL: https://github.com/apache/pulsar/issues/11690 LockManagerTest is flaky. The revalidateLockOnDifferentSession test method fails sporadically. [example failure](https://github.com/apache/pulsar/pull/11681/checks?check_run_id=3348683996#step:

[GitHub] [pulsar] lhotari commented on a change in pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
lhotari commented on a change in pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#discussion_r690464641 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3773,9 +3773,9 @@ private void validatePa

[GitHub] [pulsar] Vanlightly opened a new pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-17 Thread GitBox
Vanlightly opened a new pull request #11691: URL: https://github.com/apache/pulsar/pull/11691 Fixes #11689 ### Motivation When `Consumer.batchReceive()` is called concurrently by different threads there exists a race condition in `ConsumerBase.java` which when triggered cause

[GitHub] [pulsar] ivankelly commented on pull request #11688: [client] Consider a timed-out lookup equivalent to TooManyRequests

2021-08-17 Thread GitBox
ivankelly commented on pull request #11688: URL: https://github.com/apache/pulsar/pull/11688#issuecomment-900402126 Test failure was a mixup with how testng initializes classes. Fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] ivankelly merged pull request #11684: [client] Make request IDs more unique

2021-08-17 Thread GitBox
ivankelly merged pull request #11684: URL: https://github.com/apache/pulsar/pull/11684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pulsar] branch master updated (f0692ad -> f401b10)

2021-08-17 Thread ivank
This is an automated email from the ASF dual-hosted git repository. ivank pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f0692ad Avoid to cal getMaximumRolloverTimeMs everytime (#11513) add f401b10 Make request IDs more unique (#116

[GitHub] [pulsar] lhotari commented on pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-17 Thread GitBox
lhotari commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-900428600 Good work @Vanlightly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] ivankelly merged pull request #11688: [client] Consider a timed-out lookup equivalent to TooManyRequests

2021-08-17 Thread GitBox
ivankelly merged pull request #11688: URL: https://github.com/apache/pulsar/pull/11688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pulsar] branch master updated (f401b10 -> fdd7170)

2021-08-17 Thread ivank
This is an automated email from the ASF dual-hosted git repository. ivank pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f401b10 Make request IDs more unique (#11684) add fdd7170 [client] Consider a timed-out lookup equivalent to T

[GitHub] [pulsar] merlimat commented on issue #10734: Pulsar C++ key-shared subscriber runs out of memory for non-persistent topic

2021-08-17 Thread GitBox
merlimat commented on issue #10734: URL: https://github.com/apache/pulsar/issues/10734#issuecomment-900567121 @marcoguest The memory limit in 2.8 is currently only working on limiting the amount of memory used by producers. In this the problem is also reproducible with non-persiste

[GitHub] [pulsar] harissecic commented on issue #4861: Support for long running message consumer

2021-08-17 Thread GitBox
harissecic commented on issue #4861: URL: https://github.com/apache/pulsar/issues/4861#issuecomment-900621392 Stumbled upon this looking for another answer. However in case it helps anyone I'll leave a comment. For such cases I guess it's possible to combine DLQ with ackTimeout. Default va

[GitHub] [pulsar] merlimat opened a new pull request #11692: KeyShared dispatcher on non-persistent topics was not respecting consumer flow-control

2021-08-17 Thread GitBox
merlimat opened a new pull request #11692: URL: https://github.com/apache/pulsar/pull/11692 ### Motivation Fixes #10734 The KeyShared dispatcher for non-persistent topics is not taking the flow control advertised by consumers to apply back pressure from consumer. That results

[GitHub] [pulsar] jerrypeng merged pull request #11679: [Issue 11678 ] [pulsar-functions] When the action has no 'continueOn', continue to invoke subsequent actions

2021-08-17 Thread GitBox
jerrypeng merged pull request #11679: URL: https://github.com/apache/pulsar/pull/11679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] jerrypeng closed issue #11678: Pulsar functions terminateFunction doesn't clean up intermediate topics created for batchSource.

2021-08-17 Thread GitBox
jerrypeng closed issue #11678: URL: https://github.com/apache/pulsar/issues/11678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pulsar] branch master updated: When the action has no 'continueOn', continue to invoke subsequent actions. (#11679)

2021-08-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new efe5109b When the action has no 'continueOn',

[GitHub] [pulsar] merlimat opened a new pull request #11693: Refactored PulsarResources to avoid building metadata paths everywhere

2021-08-17 Thread GitBox
merlimat opened a new pull request #11693: URL: https://github.com/apache/pulsar/pull/11693 ### Motivation The `PulsarResources` and its companion classes are all taking `String`s with paths for resources in the metadata store. This has lead to a proliferation of string composition

[GitHub] [pulsar] hangc0276 commented on pull request #11172: [broker] fix `GetTopicsOfNamespace` with binary lookup service not check auth

2021-08-17 Thread GitBox
hangc0276 commented on pull request #11172: URL: https://github.com/apache/pulsar/pull/11172#issuecomment-900718522 > @hangc0276 - I believe this commit should be cherry picked to `branch-2.7` as well. @michaeljmarshall Thanks for your remind, i have add release-2.7.4 label, this PR

[GitHub] [pulsar] Huanli-Meng merged pull request #11667: [docs] [ISSUE 11625] Update the intro of Messaging doc

2021-08-17 Thread GitBox
Huanli-Meng merged pull request #11667: URL: https://github.com/apache/pulsar/pull/11667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] Huanli-Meng closed issue #11625: [doc] Message redelivery and acknowledgement

2021-08-17 Thread GitBox
Huanli-Meng closed issue #11625: URL: https://github.com/apache/pulsar/issues/11625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[pulsar] branch master updated: [docs] [ISSUE 11625] Update the intro of Messaging doc (#11667)

2021-08-17 Thread huanlimeng
This is an automated email from the ASF dual-hosted git repository. huanlimeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b742c96 [docs] [ISSUE 11625] Update the int

[GitHub] [pulsar] Anonymitaet commented on pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
Anonymitaet commented on pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900740090 Thanks for your contribution. Do we need to update docs here https://pulsar.apache.org/docs/en/next/reference-configuration/#broker? -- This is an automated message from

[GitHub] [pulsar] Anonymitaet commented on pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
Anonymitaet commented on pull request #11683: URL: https://github.com/apache/pulsar/pull/11683#issuecomment-900740383 Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/

[GitHub] [pulsar] Anonymitaet commented on pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
Anonymitaet commented on pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#issuecomment-900740552 Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/

[GitHub] [pulsar] Nicklee007 commented on a change in pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
Nicklee007 commented on a change in pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#discussion_r690830592 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3773,9 +3773,9 @@ private void validat

[GitHub] [pulsar] codelipenghui closed issue #10734: Pulsar C++ key-shared subscriber runs out of memory for non-persistent topic

2021-08-17 Thread GitBox
codelipenghui closed issue #10734: URL: https://github.com/apache/pulsar/issues/10734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] codelipenghui merged pull request #11692: KeyShared dispatcher on non-persistent topics was not respecting consumer flow-control

2021-08-17 Thread GitBox
codelipenghui merged pull request #11692: URL: https://github.com/apache/pulsar/pull/11692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] Anonymitaet commented on pull request #11693: Refactored PulsarResources to avoid building metadata paths everywhere

2021-08-17 Thread GitBox
Anonymitaet commented on pull request #11693: URL: https://github.com/apache/pulsar/pull/11693#issuecomment-900741551 Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/

[pulsar] branch master updated (b742c96 -> 5835fd2)

2021-08-17 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b742c96 [docs] [ISSUE 11625] Update the intro of Messaging doc (#11667) add 5835fd2 KeyShared dispatcher on

[GitHub] [pulsar] merlimat commented on pull request #11693: Refactored PulsarResources to avoid building metadata paths everywhere

2021-08-17 Thread GitBox
merlimat commented on pull request #11693: URL: https://github.com/apache/pulsar/pull/11693#issuecomment-900742467 > Thanks for your contribution. For this PR, do we need to update docs? @Anonymitaet no need for docs changes here. Just labeled. -- This is an automated message from the

[GitHub] [pulsar] merlimat commented on a change in pull request #11553: Exposing the broker entry metadata to client

2021-08-17 Thread GitBox
merlimat commented on a change in pull request #11553: URL: https://github.com/apache/pulsar/pull/11553#discussion_r690832856 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java ## @@ -243,8 +243,13 @@ public ChannelPromise s

[GitHub] [pulsar] gaozhangmin commented on pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
gaozhangmin commented on pull request #11683: URL: https://github.com/apache/pulsar/pull/11683#issuecomment-900754094 > Thanks for your contribution. For this PR, do we need to update docs? > > (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.g

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
gaozhangmin commented on a change in pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#discussion_r690845106 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3773,9 +3773,9 @@ private void valida

[GitHub] [pulsar] Nicklee007 commented on a change in pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
Nicklee007 commented on a change in pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#discussion_r690845275 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3773,9 +3773,9 @@ private void validat

[GitHub] [pulsar] Nicklee007 commented on pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
Nicklee007 commented on pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#issuecomment-900756328 > Thanks for your contribution. For this PR, do we need to update docs? > > (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.gi

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
gaozhangmin commented on a change in pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#discussion_r690845106 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3773,9 +3773,9 @@ private void valida

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
gaozhangmin commented on a change in pull request #11683: URL: https://github.com/apache/pulsar/pull/11683#discussion_r690847754 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3636,6 +3638,13 @@ private Persistent

[GitHub] [pulsar] codelipenghui commented on pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-17 Thread GitBox
codelipenghui commented on pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#issuecomment-900768221 @michaeljmarshall Please help review the PR again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] codelipenghui merged pull request #11694: Fix branch-2.8 cherry-pick issue.

2021-08-17 Thread GitBox
codelipenghui merged pull request #11694: URL: https://github.com/apache/pulsar/pull/11694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11683: failed update partition of topic

2021-08-17 Thread GitBox
gaozhangmin commented on a change in pull request #11683: URL: https://github.com/apache/pulsar/pull/11683#discussion_r690847754 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3636,6 +3638,13 @@ private Persistent

[pulsar] branch branch-2.8 updated: Fix branch-2.8 cherry-pick issue. (#11694)

2021-08-17 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 92d3e41 Fix branch-2.8 cherry-pick iss

[GitHub] [pulsar] 315157973 commented on a change in pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-17 Thread GitBox
315157973 commented on a change in pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#discussion_r690863726 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@ -82,6 +79,7 @@ protected final ConsumerIntercepto

[GitHub] [pulsar] 315157973 commented on a change in pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-17 Thread GitBox
315157973 commented on a change in pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#discussion_r690864190 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@ -204,26 +205,11 @@ protected ConsumerBase(PulsarClient

[GitHub] [pulsar] 315157973 commented on a change in pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-17 Thread GitBox
315157973 commented on a change in pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#discussion_r690865866 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@ -790,31 +778,20 @@ protected void notifyPendingBatchRe

[pulsar] branch branch-2.8 updated: [feature][pulsar-broker]: Add additional servlet support to broker (#11498)

2021-08-17 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 5c3ddc2 [feature][pulsar-broker]: Add

svn commit: r49553 - /dev/pulsar/KEYS

2021-08-17 Thread chenhang
Author: chenhang Date: Wed Aug 18 03:29:43 2021 New Revision: 49553 Log: Added gpg key for chenhang Modified: dev/pulsar/KEYS Modified: dev/pulsar/KEYS == --- dev/pulsar/KEYS (original) +++ dev/pulsar/KEYS Wed Aug 18

[GitHub] [pulsar] murong00 commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-17 Thread GitBox
murong00 commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690881616 ## File path: pulsar-io/alluxio/src/main/java/org/apache/pulsar/io/alluxio/sink/AlluxioSink.java ## @@ -0,0 +1,284 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pulsar] murong00 commented on a change in pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-17 Thread GitBox
murong00 commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690882739 ## File path: pulsar-io/alluxio/pom.xml ## @@ -0,0 +1,161 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-

[GitHub] [pulsar] lhotari commented on pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari commented on pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900821479 > Thanks for your contribution. Do we need to update docs here https://pulsar.apache.org/docs/en/next/reference-configuration/#broker? @Anonymitaet Yes, it would be usefu

[GitHub] [pulsar] lhotari commented on pull request #11681: [Broker] Support disabling non-TLS service ports

2021-08-17 Thread GitBox
lhotari commented on pull request #11681: URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900824889 @Anonymitaet I added docs to `security-tls-keystore.md` file. Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] wangjialing218 opened a new issue #11695: Stop one broker may cause another broker shutdown when enable function woker in broker

2021-08-17 Thread GitBox
wangjialing218 opened a new issue #11695: URL: https://github.com/apache/pulsar/issues/11695 **To Reproduce** 1. Start pulsar cluster with 3 brokers and `functionsWorkerEnabled=true` 2. Stop the broker which is the leader of function worker and the owner of function worker coordinate

[GitHub] [pulsar] abhilashmandaliya commented on a change in pull request #11671: [server] Allow broker to start with default backlogquota in bytes

2021-08-17 Thread GitBox
abhilashmandaliya commented on a change in pull request #11671: URL: https://github.com/apache/pulsar/pull/11671#discussion_r690920856 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java ## @@ -53,9 +53,10 @@ public Backlo

[GitHub] [pulsar] abhilashmandaliya commented on a change in pull request #11671: [server] Allow broker to start with default backlogquota in bytes

2021-08-17 Thread GitBox
abhilashmandaliya commented on a change in pull request #11671: URL: https://github.com/apache/pulsar/pull/11671#discussion_r690920856 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java ## @@ -53,9 +53,10 @@ public Backlo

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11686: fix the bug, can not update topic when the update topicName is contained by an existed topic as a part

2021-08-17 Thread GitBox
gaozhangmin commented on a change in pull request #11686: URL: https://github.com/apache/pulsar/pull/11686#discussion_r690926200 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -3773,9 +3773,9 @@ private void valida

[GitHub] [pulsar] abhilashmandaliya commented on a change in pull request #11671: [server] Allow broker to start with default backlogquota in bytes

2021-08-17 Thread GitBox
abhilashmandaliya commented on a change in pull request #11671: URL: https://github.com/apache/pulsar/pull/11671#discussion_r690920856 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java ## @@ -53,9 +53,10 @@ public Backlo

[GitHub] [pulsar] lhotari opened a new issue #11696: Flaky-test: test_producer_routing_mode (__main__.PulsarTest)

2021-08-17 Thread GitBox
lhotari opened a new issue #11696: URL: https://github.com/apache/pulsar/issues/11696 test_producer_routing_mode (__main__.PulsarTest) is flaky. [example failure](https://github.com/apache/pulsar/pull/11681/checks?check_run_id=3357855612#step:12:1565) ``` ==

[GitHub] [pulsar] eolivelli commented on a change in pull request #11671: [server] Allow broker to start with default backlogquota in bytes

2021-08-17 Thread GitBox
eolivelli commented on a change in pull request #11671: URL: https://github.com/apache/pulsar/pull/11671#discussion_r690940233 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java ## @@ -53,9 +53,10 @@ public BacklogQuotaMa

[GitHub] [pulsar] Vanlightly commented on a change in pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-17 Thread GitBox
Vanlightly commented on a change in pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#discussion_r690942099 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@ -204,26 +205,11 @@ protected ConsumerBase(PulsarClien

[GitHub] [pulsar] Vanlightly commented on a change in pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-17 Thread GitBox
Vanlightly commented on a change in pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#discussion_r690942499 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@ -790,31 +778,20 @@ protected void notifyPendingBatchR

[GitHub] [pulsar] eolivelli commented on a change in pull request #11293: [IO] Pass client builder to debezium database history

2021-08-17 Thread GitBox
eolivelli commented on a change in pull request #11293: URL: https://github.com/apache/pulsar/pull/11293#discussion_r690950396 ## File path: pulsar-io/debezium/core/pom.xml ## @@ -62,12 +62,6 @@ ${kafka-client.version} - - ${project.groupId} - pulsa