eolivelli commented on a change in pull request #11553:
URL: https://github.com/apache/pulsar/pull/11553#discussion_r690962783
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java
##
@@ -243,8 +243,13 @@ public ChannelPromise
eolivelli commented on a change in pull request #11681:
URL: https://github.com/apache/pulsar/pull/11681#discussion_r690968459
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java
##
@@ -1122,7 +1122,7 @@ private String
BewareMyPower commented on pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#issuecomment-900885644
Please fix the code style.
```
Error:
src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:[3641,21]
(whitespace) WhitespaceAround: 'for
BewareMyPower commented on a change in pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#discussion_r690975274
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##
@@ -3636,6 +3636,15 @@ private Persiste
abhilashmandaliya opened a new pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697
Fixed a casting error introduced in #11671.
The double value of user-configured backlogQuota in GB is converted to long
before converting to bytes.
--
This is an automated message from
abhilashmandaliya commented on a change in pull request #11671:
URL: https://github.com/apache/pulsar/pull/11671#discussion_r690976781
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java
##
@@ -53,9 +53,10 @@
public Backlo
beyondyinjl2 opened a new issue #594:
URL: https://github.com/apache/pulsar-client-go/issues/594
system: macos big sur11.4
go version
go version go1.15.6 darwin/amd64
Run code error:
# github.com/99designs/keyring
../../pkg/mod/github.com/99designs/keyring@v1.1.5/keych
BewareMyPower commented on a change in pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#discussion_r690988315
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##
@@ -3636,6 +3637,20 @@ private Persiste
rayliu419 opened a new issue #11698:
URL: https://github.com/apache/pulsar/issues/11698
Hi team,
I can't find a template to ask general question so I just post it here,
please direct me to the right template/place if I am wrong.
1. Kafka(<2.8) use ZK to do leader broker elec
315157973 commented on pull request #11691:
URL: https://github.com/apache/pulsar/pull/11691#issuecomment-900911001
The main reason for this to be locked is the following two pieces of logic:
`pendingBatchReceiveTask` is run by the timed thread pool of ConsumerBase,
and pollNextBatchRece
lhotari commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-900911565
Good catch @abhilashmandaliya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
eolivelli commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-900912023
@lhotari which kind of test are you requiring ?
I am not sure it is worth to add the needed instrumentation to test this
change.
The rounding error is quite evident
codelipenghui commented on a change in pull request #11553:
URL: https://github.com/apache/pulsar/pull/11553#discussion_r691027666
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java
##
@@ -243,8 +243,13 @@ public ChannelProm
Anonymitaet commented on a change in pull request #11681:
URL: https://github.com/apache/pulsar/pull/11681#discussion_r691044967
##
File path: site2/docs/security-tls-keystore.md
##
@@ -131,6 +131,13 @@ brokerClientTlsTrustStorePassword=clientpw
NOTE: it is important to rest
marcoguest commented on issue #10734:
URL: https://github.com/apache/pulsar/issues/10734#issuecomment-900951071
Thank you @merlimat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sijia-w opened a new issue #11699:
URL: https://github.com/apache/pulsar/issues/11699
**Is your enhancement request related to a problem? Please describe.**
The links for `pulsar-java-tutorial` and relevant content on page
https://pulsar.apache.org/docs/en/deploy-docs/#download-and-prepa
sijia-w commented on pull request #11648:
URL: https://github.com/apache/pulsar/pull/11648#issuecomment-900969857
@Huanli-Meng A new issue for `pulsar-java-tutorial` can be found #11699.
Shall we close this pr if there is nothing else to modify for now?
--
This is an automated message fr
gaozhangmin commented on pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#issuecomment-900989358
@eolivelli @lhotari PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Huanli-Meng closed issue #11291:
URL: https://github.com/apache/pulsar/issues/11291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
Huanli-Meng merged pull request #11648:
URL: https://github.com/apache/pulsar/pull/11648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
This is an automated email from the ASF dual-hosted git repository.
huanlimeng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 5835fd2 KeyShared dispatcher on non-persistent topics was not
respecting consumer flow-control (#11692)
ad
lhotari commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901002619
> @lhotari which kind of test are you requiring ?
a unit test that verifies that the GB -> bytes calculation works as
expected.
>
> I am not sure it is worth
frankjkelly opened a new issue #10627:
URL: https://github.com/apache/pulsar/issues/10627
**Is your enhancement request related to a problem? Please describe.**
Add documentation for how to choose between load balancing algorithms
**Describe the solution you'd like**
* `support
congbobo184 closed issue #10627:
URL: https://github.com/apache/pulsar/issues/10627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
congbobo184 commented on issue #10627:
URL: https://github.com/apache/pulsar/issues/10627#issuecomment-901007011
> I have a few questions:
>
> * How does each algorithm work with other [split bundle
configurations](https://github.com/apache/pulsar/blob/b1ff552333c20b081e914766ba54a17
congbobo184 removed a comment on issue #10627:
URL: https://github.com/apache/pulsar/issues/10627#issuecomment-901007011
> I have a few questions:
>
> * How does each algorithm work with other [split bundle
configurations](https://github.com/apache/pulsar/blob/b1ff552333c20b081e91476
lhotari commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901008509
To unit test the logic, I'd recommend doing a refactoring.
It seems that it's possible to just override the setter
"setBacklogQuotaDefaultLimitGB" in ServiceConfiguration
congbobo184 commented on issue #10627:
URL: https://github.com/apache/pulsar/issues/10627#issuecomment-901009444
@Anonymitaet each algorithm is affected by these configurations the same.
`range_equally_divide` use hash range, `topic_count_equally_divide` is evenly
distributed.
--
This i
congbobo184 commented on issue #8357:
URL: https://github.com/apache/pulsar/issues/8357#issuecomment-901013897
batch is every subscription mode feature, there is no need document
key_shared separately. Is there an issue link?
--
This is an automated message from the Apache Git Service.
congbobo184 commented on issue #4856:
URL: https://github.com/apache/pulsar/issues/4856#issuecomment-901023857
@grantwwu The document has now been added. Does this problem still exist? If
there are no problems, we will close this issue.
--
This is an automated message from the Apache Git
lhotari commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901028370
> It seems that it's possible to just override the setter
"setBacklogQuotaDefaultLimitGB" in ServiceConfiguration class and update the
backlogQuotaDefaultLimitBytes field on th
lhotari opened a new issue #11700:
URL: https://github.com/apache/pulsar/issues/11700
ReplicatorTest is flaky. The testTopicReplicatedAndProducerCreate test
method fails sporadically.
[example
failure](https://github.com/apache/pulsar/pull/11681/checks?check_run_id=3359802221#st
lhotari opened a new issue #11701:
URL: https://github.com/apache/pulsar/issues/11701
BrokerServiceThrottlingTest is flaky. The
testLookupThrottlingForClientByBroker test method fails sporadically.
[example
failure](https://github.com/apache/pulsar/pull/11681/checks?check_run_id
Huanli-Meng commented on issue #4856:
URL: https://github.com/apache/pulsar/issues/4856#issuecomment-901083922
@congbobo184 could you please help provide the link/PR for the added
document? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
abhilashmandaliya commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901099857
> > It seems that it's possible to just override the setter
"setBacklogQuotaDefaultLimitGB" in ServiceConfiguration class and update the
backlogQuotaDefaultLimitBytes
abhilashmandaliya edited a comment on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901099857
> > It seems that it's possible to just override the setter
"setBacklogQuotaDefaultLimitGB" in ServiceConfiguration class and update the
backlogQuotaDefaultLim
lhotari commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691219392
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licens
lhotari commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691222376
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licens
lhotari commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691224136
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licens
lhotari commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691226429
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licens
LeBW commented on a change in pull request #11553:
URL: https://github.com/apache/pulsar/pull/11553#discussion_r691230182
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java
##
@@ -243,8 +243,13 @@ public ChannelPromise sendM
LeBW commented on a change in pull request #11553:
URL: https://github.com/apache/pulsar/pull/11553#discussion_r691230182
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java
##
@@ -243,8 +243,13 @@ public ChannelPromise sendM
lhotari commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691239823
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,82 @@
+/**
+ * Licens
Vanlightly commented on pull request #11691:
URL: https://github.com/apache/pulsar/pull/11691#issuecomment-901139152
@315157973 we could look at something like that. The ConsumerImpl has its
`internalPinnedExecutor` so could be leveraged to avoid multi-threaded calls by
submitting some par
sijia-w commented on issue #7663:
URL: https://github.com/apache/pulsar/issues/7663#issuecomment-901170493
@sergescevenels-naspers The functions are available in the latest version.
See https://pulsar.apache.org/docs/en/next/functions-package/#python. Do you
have further questions regardin
lhotari commented on pull request #11681:
URL: https://github.com/apache/pulsar/pull/11681#issuecomment-901175813
> Thanks for your contribution. I've made some comments, PTAL.
@Anonymitaet thanks for the suggestions. I committed them. Please PTAL
--
This is an automated message f
eolivelli commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691319160
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,82 @@
+/**
+ * Lice
sijia-w opened a new pull request #11702:
URL: https://github.com/apache/pulsar/pull/11702
Fixes #10627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
liangyuanpeng commented on issue #11529:
URL: https://github.com/apache/pulsar/issues/11529#issuecomment-901236710
I suggest you use a higher version...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
abhilashmandaliya commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901238374
Thanks, @lhotari, and @eolivelli for a thorough review and for helping me
make it cleaner. I have considered all the suggestions.
--
This is an automated message fr
gaozhangmin removed a comment on pull request #10853:
URL: https://github.com/apache/pulsar/pull/10853#issuecomment-879630968
@MarvinCai Could u please review it again? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gaozhangmin commented on pull request #10853:
URL: https://github.com/apache/pulsar/pull/10853#issuecomment-901239396
Please review this pr since I had changed, Only support a non-partitioned
topic or a specific topic partition @MarvinCai
--
This is an automated message from the Apache
gaozhangmin commented on pull request #10853:
URL: https://github.com/apache/pulsar/pull/10853#issuecomment-901244616
@codelipenghui @cckellogg @MarvinCai this pr has been continued for a
long time. PTAL. thanks
--
This is an automated message from the Apache Git Service.
To respond t
lhotari commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901250163
LGTM. Good work @abhilashmandaliya ! Thanks for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
ivankelly merged pull request #11688:
URL: https://github.com/apache/pulsar/pull/11688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
315157973 commented on a change in pull request #11691:
URL: https://github.com/apache/pulsar/pull/11691#discussion_r690863726
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##
@@ -82,6 +79,7 @@
protected final ConsumerIntercepto
eolivelli commented on a change in pull request #11553:
URL: https://github.com/apache/pulsar/pull/11553#discussion_r690962783
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java
##
@@ -243,8 +243,13 @@ public ChannelPromise
sijia-w commented on issue #7663:
URL: https://github.com/apache/pulsar/issues/7663#issuecomment-901170493
@sergescevenels-naspers The functions are available in the latest version.
See https://pulsar.apache.org/docs/en/next/functions-package/#python. Do you
have further questions regardin
315157973 commented on pull request #11691:
URL: https://github.com/apache/pulsar/pull/11691#issuecomment-900911001
The main reason for this to be locked is the following two pieces of logic:
`pendingBatchReceiveTask` is run by the timed thread pool of ConsumerBase,
and pollNextBatchRece
abhilashmandaliya commented on a change in pull request #11671:
URL: https://github.com/apache/pulsar/pull/11671#discussion_r690920856
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java
##
@@ -53,9 +53,10 @@
public Backlo
eolivelli commented on a change in pull request #11671:
URL: https://github.com/apache/pulsar/pull/11671#discussion_r690940233
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java
##
@@ -53,9 +53,10 @@
public BacklogQuotaMa
gaozhangmin removed a comment on pull request #10853:
URL: https://github.com/apache/pulsar/pull/10853#issuecomment-879630968
@MarvinCai Could u please review it again? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
merlimat commented on issue #10734:
URL: https://github.com/apache/pulsar/issues/10734#issuecomment-900567121
@marcoguest The memory limit in 2.8 is currently only working on limiting
the amount of memory used by producers.
In this the problem is also reproducible with non-persiste
congbobo184 removed a comment on issue #10627:
URL: https://github.com/apache/pulsar/issues/10627#issuecomment-901007011
> I have a few questions:
>
> * How does each algorithm work with other [split bundle
configurations](https://github.com/apache/pulsar/blob/b1ff552333c20b081e91476
jerrypeng closed issue #11678:
URL: https://github.com/apache/pulsar/issues/11678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
Anonymitaet commented on pull request #11681:
URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900740090
Thanks for your contribution. Do we need to update docs here
https://pulsar.apache.org/docs/en/next/reference-configuration/#broker?
--
This is an automated message from
congbobo184 commented on issue #4856:
URL: https://github.com/apache/pulsar/issues/4856#issuecomment-901023857
@grantwwu The document has now been added. Does this problem still exist? If
there are no problems, we will close this issue.
--
This is an automated message from the Apache Git
ivankelly commented on pull request #11688:
URL: https://github.com/apache/pulsar/pull/11688#issuecomment-900402126
Test failure was a mixup with how testng initializes classes. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
gaozhangmin commented on pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#issuecomment-900754094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
merlimat commented on pull request #11693:
URL: https://github.com/apache/pulsar/pull/11693#issuecomment-900742467
> Thanks for your contribution. For this PR, do we need to update docs?
@Anonymitaet no need for docs changes here. Just labeled.
--
This is an automated message from the
eolivelli commented on a change in pull request #11293:
URL: https://github.com/apache/pulsar/pull/11293#discussion_r690950396
##
File path: pulsar-io/debezium/core/pom.xml
##
@@ -62,12 +62,6 @@
${kafka-client.version}
-
- ${project.groupId}
- pulsa
congbobo184 commented on issue #8357:
URL: https://github.com/apache/pulsar/issues/8357#issuecomment-901013897
batch is every subscription mode feature, there is no need document
key_shared separately. Is there an issue link?
--
This is an automated message from the Apache Git Service.
abhilashmandaliya edited a comment on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901099857
> > It seems that it's possible to just override the setter
"setBacklogQuotaDefaultLimitGB" in ServiceConfiguration class and update the
backlogQuotaDefaultLim
murong00 commented on a change in pull request #3823:
URL: https://github.com/apache/pulsar/pull/3823#discussion_r690881616
##
File path:
pulsar-io/alluxio/src/main/java/org/apache/pulsar/io/alluxio/sink/AlluxioSink.java
##
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Sof
abhilashmandaliya commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901099857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lhotari commented on pull request #11681:
URL: https://github.com/apache/pulsar/pull/11681#issuecomment-900821479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
Huanli-Meng merged pull request #11648:
URL: https://github.com/apache/pulsar/pull/11648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
BewareMyPower commented on a change in pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#discussion_r690975274
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##
@@ -3636,6 +3636,15 @@ private Persiste
gaozhangmin commented on a change in pull request #11686:
URL: https://github.com/apache/pulsar/pull/11686#discussion_r690845106
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##
@@ -3773,9 +3773,9 @@ private void valida
Anonymitaet commented on pull request #11693:
URL: https://github.com/apache/pulsar/pull/11693#issuecomment-900741551
Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/master/.github/
eolivelli commented on pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#issuecomment-900912023
@lhotari which kind of test are you requiring ?
I am not sure it is worth to add the needed instrumentation to test this
change.
The rounding error is quite evident
Vanlightly commented on a change in pull request #11691:
URL: https://github.com/apache/pulsar/pull/11691#discussion_r690942099
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##
@@ -204,26 +205,11 @@ protected ConsumerBase(PulsarClien
lhotari commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691219392
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licens
liangyuanpeng commented on issue #11529:
URL: https://github.com/apache/pulsar/issues/11529#issuecomment-901236710
I suggest you use a higher version...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
congbobo184 closed issue #10627:
URL: https://github.com/apache/pulsar/issues/10627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
Anonymitaet commented on pull request #11686:
URL: https://github.com/apache/pulsar/pull/11686#issuecomment-900740552
Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/master/.github/
Huanli-Meng closed issue #11291:
URL: https://github.com/apache/pulsar/issues/11291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
merlimat commented on a change in pull request #11553:
URL: https://github.com/apache/pulsar/pull/11553#discussion_r690832856
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java
##
@@ -243,8 +243,13 @@ public ChannelPromise s
gaozhangmin commented on a change in pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#discussion_r690847754
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##
@@ -3636,6 +3638,13 @@ private Persistent
BewareMyPower commented on pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#issuecomment-900885644
Please fix the code style.
```
Error:
src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:[3641,21]
(whitespace) WhitespaceAround: 'for
Nicklee007 commented on pull request #11686:
URL: https://github.com/apache/pulsar/pull/11686#issuecomment-900756328
> Thanks for your contribution. For this PR, do we need to update docs?
>
> (The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/master/.gi
Anonymitaet commented on a change in pull request #11681:
URL: https://github.com/apache/pulsar/pull/11681#discussion_r691044967
##
File path: site2/docs/security-tls-keystore.md
##
@@ -131,6 +131,13 @@ brokerClientTlsTrustStorePassword=clientpw
NOTE: it is important to rest
codelipenghui closed issue #10734:
URL: https://github.com/apache/pulsar/issues/10734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
marcoguest commented on issue #10734:
URL: https://github.com/apache/pulsar/issues/10734#issuecomment-900951071
Thank you @merlimat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Nicklee007 commented on a change in pull request #11686:
URL: https://github.com/apache/pulsar/pull/11686#discussion_r690830592
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##
@@ -3773,9 +3773,9 @@ private void validat
jerrypeng merged pull request #11679:
URL: https://github.com/apache/pulsar/pull/11679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
congbobo184 commented on issue #10627:
URL: https://github.com/apache/pulsar/issues/10627#issuecomment-901007011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
eolivelli commented on a change in pull request #11681:
URL: https://github.com/apache/pulsar/pull/11681#discussion_r690968459
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java
##
@@ -1122,7 +1122,7 @@ private String
Huanli-Meng closed issue #11625:
URL: https://github.com/apache/pulsar/issues/11625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
eolivelli commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691319160
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##
@@ -0,0 +1,82 @@
+/**
+ * Lice
1 - 100 of 177 matches
Mail list logo
