[GitHub] [pulsar] RobertIndie commented on issue #16244: 从2.8版本到2.10版本,启动还在报错org.apache.pulsar.broker.web.RestException: Cluster already exists

2022-06-27 Thread GitBox
RobertIndie commented on issue #16244: URL: https://github.com/apache/pulsar/issues/16244#issuecomment-1168309784 Could you provide the broker log and other related information if possible? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16201: [fix][broker] Fix passing incorrect authentication data

2022-06-27 Thread GitBox
BewareMyPower commented on code in PR #16201: URL: https://github.com/apache/pulsar/pull/16201#discussion_r908103534 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxAuthorizationTest.java: ## @@ -0,0 +1,434 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] [pulsar] mattisonchao opened a new pull request, #16263: [DON'T MERGE] Test OWASP check

2022-06-27 Thread GitBox
mattisonchao opened a new pull request, #16263: URL: https://github.com/apache/pulsar/pull/16263 ### Motivation Test OWASP check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] gaozhangmin commented on issue #16242: version 2.10单机启动出现近10个异常,我已经无语了,和2.8,2.9版本一样,旧版有的启动异常新版还有!

2022-06-27 Thread GitBox
gaozhangmin commented on issue #16242: URL: https://github.com/apache/pulsar/issues/16242#issuecomment-1168297639 @startjava This is not a bug, maybe need some improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[pulsar] branch master updated: [fix][broker] Fix NPE when drop backlog for time limit. (#16235)

2022-06-27 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d24d82780fd [fix][broker] Fix NPE when drop bac

[GitHub] [pulsar] codelipenghui merged pull request #16235: [fix][broker] Fix NPE when drop backlog for time limit.

2022-06-27 Thread GitBox
codelipenghui merged PR #16235: URL: https://github.com/apache/pulsar/pull/16235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[pulsar] branch master updated: [fix][Java Client] Fix large message sometimes cannot be split into chunks after PIP-132 (#16196)

2022-06-27 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 742158932c0 [fix][Java Client] Fix large message so

[GitHub] [pulsar] BewareMyPower closed issue #16195: Message chunking might not work in certain cases after PIP 132

2022-06-27 Thread GitBox
BewareMyPower closed issue #16195: Message chunking might not work in certain cases after PIP 132 URL: https://github.com/apache/pulsar/issues/16195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] BewareMyPower merged pull request #16196: [fix][Java Client] Fix large message sometimes cannot be split into chunks after PIP-132

2022-06-27 Thread GitBox
BewareMyPower merged PR #16196: URL: https://github.com/apache/pulsar/pull/16196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16171: [fix][client] Fix duplicate messages caused by seek

2022-06-27 Thread GitBox
codelipenghui commented on code in PR #16171: URL: https://github.com/apache/pulsar/pull/16171#discussion_r908087403 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -248,6 +248,10 @@ private void startReceivingMessages(List> newC

[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async

2022-06-27 Thread GitBox
nodece commented on code in PR #16221: URL: https://github.com/apache/pulsar/pull/16221#discussion_r908073601 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicNam

[GitHub] [pulsar] startjava opened a new issue, #16262: 哎,2.10版本,启动有近25个exception!

2022-06-27 Thread GitBox
startjava opened a new issue, #16262: URL: https://github.com/apache/pulsar/issues/16262 [启动报错.txt](https://github.com/apache/pulsar/files/8998151/default.txt) 越来越多,比2.8启动的异常数都多 官方能不能update一下啊,每个版本启动时都报错,很多人在官方发问,但新版还是没有解决。 细看所有的常用中间件,,数pulsar在启动时的异常数最多,而且新版还没有fix,真替你们着急。 -

[GitHub] [pulsar] maxsxu opened a new pull request, #16261: [feat][workflow] Enable required status check of docbot label job

2022-06-27 Thread GitBox
maxsxu opened a new pull request, #16261: URL: https://github.com/apache/pulsar/pull/16261 Master Issue: #15797 ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you wil

[GitHub] [pulsar] nodece commented on pull request #16201: [fix][broker] Fix passing incorrect authentication data

2022-06-27 Thread GitBox
nodece commented on PR #16201: URL: https://github.com/apache/pulsar/pull/16201#issuecomment-1168271172 @BewareMyPower Great idea, we should distinguish between the `isProxyAuthorizedFuture` and `isAuthorized`. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] mattisonchao opened a new pull request, #16260: [Branch 2.10] Fix some OWASP dependency problems.

2022-06-27 Thread GitBox
mattisonchao opened a new pull request, #16260: URL: https://github.com/apache/pulsar/pull/16260 ### Motivation Fix some OWASP dependency problems, the details as below: - #16148 - #15829 - #15864 ### Modifications - Fix some OWASP dependency problems

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#b596a9c)

2022-06-27 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 80e945e2c73 Docs sync done from apache/pulsar(#

[GitHub] [pulsar] github-actions[bot] commented on pull request #16259: [improve][standalone]Remove check if default namespace exists

2022-06-27 Thread GitBox
github-actions[bot] commented on PR #16259: URL: https://github.com/apache/pulsar/pull/16259#issuecomment-1168262094 @gaozhangmin Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t

[GitHub] [pulsar] Shoothzj commented on pull request #16254: [dependency] Use parent pom commons-lang3 version

2022-06-27 Thread GitBox
Shoothzj commented on PR #16254: URL: https://github.com/apache/pulsar/pull/16254#issuecomment-1168261942 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] gaozhangmin opened a new pull request, #16259: [improve][standalone]Remove check if default namespace exists

2022-06-27 Thread GitBox
gaozhangmin opened a new pull request, #16259: URL: https://github.com/apache/pulsar/pull/16259 ### Motivation When startup of standalone, the below error would be throw ``` 2022-06-27T21:29:38,779+0800 [client-scheduler-OrderedScheduler-0-0] ERROR org.apache.bookkeeper.clients.impl

[GitHub] [pulsar] AnonHxy commented on pull request #16238: [test][fix][broker]Fix getInternalStats occasional lack of LeaderInfo again

2022-06-27 Thread GitBox
AnonHxy commented on PR #16238: URL: https://github.com/apache/pulsar/pull/16238#issuecomment-1168259706 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async

2022-06-27 Thread GitBox
AnonHxy commented on code in PR #16221: URL: https://github.com/apache/pulsar/pull/16221#discussion_r908061231 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicNa

[GitHub] [pulsar] BewareMyPower commented on pull request #16201: [fix][broker] Fix passing incorrect authentication data

2022-06-27 Thread GitBox
BewareMyPower commented on PR #16201: URL: https://github.com/apache/pulsar/pull/16201#issuecomment-1168249833 Actually I think the logic is not clear. The key point is that both `originalAuthData` and `authenticationData` might be used in `isProxyAuthorizedFuture`, but `authenticationData`

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16236: [improve][java-client] Replace ScheduledExecutor to improve performance of message consumption

2022-06-27 Thread GitBox
michaeljmarshall commented on code in PR #16236: URL: https://github.com/apache/pulsar/pull/16236#discussion_r908049474 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -193,6 +196,8 @@ private PulsarClientImpl(ClientConfigurationData con

[GitHub] [pulsar] gaozhangmin commented on issue #16210: Problems with Reader mode

2022-06-27 Thread GitBox
gaozhangmin commented on issue #16210: URL: https://github.com/apache/pulsar/issues/16210#issuecomment-1168240078 The reader interface provides Pulsar clients with the low-level abstraction necessary to "manually position" themselves within a topic. If you want manually manage offset, re

[pulsar] branch master updated: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+ (#16163)

2022-06-27 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b596a9cff71 [pulsar-sql] Bump presto.version to

[GitHub] [pulsar] codelipenghui merged pull request #16163: [pulsar-sql] Bump presto.version to run PrestoServer on JDK11+

2022-06-27 Thread GitBox
codelipenghui merged PR #16163: URL: https://github.com/apache/pulsar/pull/16163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[pulsar-site] branch main updated: Remove trailing slash from clientVersionUrl (#125)

2022-06-27 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 26c93ce30e3 Remove trailing slash from clien

[GitHub] [pulsar] michaeljmarshall commented on issue #12023: Tenant namespace topic length limit

2022-06-27 Thread GitBox
michaeljmarshall commented on issue #12023: URL: https://github.com/apache/pulsar/issues/12023#issuecomment-1168237752 I don't know of length restrictions, but there are character restrictions for tenants and namespaces. Here is the comment in the code: https://github.com/apache/puls

[GitHub] [pulsar] startjava commented on issue #16242: version 2.10单机启动出现近10个异常,我已经无语了,和2.8,2.9版本一样,旧版有的启动异常新版还有!

2022-06-27 Thread GitBox
startjava commented on issue #16242: URL: https://github.com/apache/pulsar/issues/16242#issuecomment-1168237809 @gaozhangmin error is ok ??? why ??? bug ?? thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] gaozhangmin commented on issue #16242: version 2.10单机启动出现近10个异常,我已经无语了,和2.8,2.9版本一样,旧版有的启动异常新版还有!

2022-06-27 Thread GitBox
gaozhangmin commented on issue #16242: URL: https://github.com/apache/pulsar/issues/16242#issuecomment-1168236845 @startjava ``` Reason for the failure {} io.grpc.StatusRuntimeException: NOT_FOUND ``` This error is ok when startup. -- This is an automated message from the Ap

[GitHub] [pulsar] mattisonchao opened a new pull request, #16258: [Branch-2.10] Remove redundant pulsar-zookeeper-utils module

2022-06-27 Thread GitBox
mattisonchao opened a new pull request, #16258: URL: https://github.com/apache/pulsar/pull/16258 ### Motivation Cherry-pick pull request #16109 ### Modifications Remove pulsar-zookeeper-utils module and move remaining utils to pulsar-broker module. ### Verifying t

[GitHub] [pulsar] mattisonchao closed pull request #16257: [branch-2.10] Remove redundant pulsar-zookeeper-utils module

2022-06-27 Thread GitBox
mattisonchao closed pull request #16257: [branch-2.10] Remove redundant pulsar-zookeeper-utils module URL: https://github.com/apache/pulsar/pull/16257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] michaeljmarshall closed issue #13289: c++ client Producer with name 'xxx-18-31667' is already connected to topic

2022-06-27 Thread GitBox
michaeljmarshall closed issue #13289: c++ client Producer with name 'xxx-18-31667' is already connected to topic URL: https://github.com/apache/pulsar/issues/13289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] michaeljmarshall commented on issue #13289: c++ client Producer with name 'xxx-18-31667' is already connected to topic

2022-06-27 Thread GitBox
michaeljmarshall commented on issue #13289: URL: https://github.com/apache/pulsar/issues/13289#issuecomment-1168231560 I'm going to close this issue for the same justification provided here https://github.com/apache/pulsar/issues/13342#issuecomment-1145151323. It's like that this issu

[GitHub] [pulsar] mattisonchao opened a new pull request, #16257: [branch-2.10] Remove redundant pulsar-zookeeper-utils module

2022-06-27 Thread GitBox
mattisonchao opened a new pull request, #16257: URL: https://github.com/apache/pulsar/pull/16257 ### Motivation Cherry-picked pull request #16109 ### Modifications Remove pulsar-zookeeper-utils module and move remaining utils to pulsar-broker module. ### Verifyin

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16201: [fix][broker] Fix passing incorrect authentication data

2022-06-27 Thread GitBox
BewareMyPower commented on code in PR #16201: URL: https://github.com/apache/pulsar/pull/16201#discussion_r908035655 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -512,7 +517,7 @@ protected void handlePartitionMetadataRequest(CommandParti

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16165: [improve][client] [PIP-165] Auto release client useless connections

2022-06-27 Thread GitBox
poorbarcode commented on code in PR #16165: URL: https://github.com/apache/pulsar/pull/16165#discussion_r908034600 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java: ## @@ -1188,4 +1201,164 @@ private void checkRequestTimeout() { } private s

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16201: [fix][broker] Fix passing incorrect authentication data

2022-06-27 Thread GitBox
BewareMyPower commented on code in PR #16201: URL: https://github.com/apache/pulsar/pull/16201#discussion_r908032084 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -512,7 +517,7 @@ protected void handlePartitionMetadataRequest(CommandParti

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16201: [fix][broker] Fix passing incorrect authentication data

2022-06-27 Thread GitBox
BewareMyPower commented on code in PR #16201: URL: https://github.com/apache/pulsar/pull/16201#discussion_r908028138 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -411,9 +412,13 @@ private CompletableFuture isTopicOperationAllowed(TopicNa

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16201: [fix][broker] Fix passing incorrect authentication data

2022-06-27 Thread GitBox
BewareMyPower commented on code in PR #16201: URL: https://github.com/apache/pulsar/pull/16201#discussion_r908019720 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -185,7 +185,7 @@ public class ServerCnx extends PulsarHandler implements Tr

[GitHub] [pulsar] Anonymitaet commented on issue #12023: Tenant namespace topic length limit

2022-06-27 Thread GitBox
Anonymitaet commented on issue #12023: URL: https://github.com/apache/pulsar/issues/12023#issuecomment-1168217698 I think it makes sense to document this to reduce guesswork. Other users may have the same issue if we do not explain it explicitly. -- This is an automated message from the

[GitHub] [pulsar] BewareMyPower commented on pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
BewareMyPower commented on PR #16256: URL: https://github.com/apache/pulsar/pull/16256#issuecomment-1168202259 > if we could have the recyle method call some kind of initialization method so we don't need to maintain the same initialization value in two places. Yes. -- This is an a

[GitHub] [pulsar] RobertIndie commented on pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
RobertIndie commented on PR #16256: URL: https://github.com/apache/pulsar/pull/16256#issuecomment-1168201771 > In addition, adding initial values to a recyclable class is dangerous. For a recyclable class, we should make constructors private and only expose some factory methods and set the

[GitHub] [pulsar] BewareMyPower commented on pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
BewareMyPower commented on PR #16256: URL: https://github.com/apache/pulsar/pull/16256#issuecomment-1168201122 The best practice might be adding an `initialize()` method to a recyclable class and calling this method at the beginning of each factory method, like: ```java private

[GitHub] [pulsar] BewareMyPower commented on pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
BewareMyPower commented on PR #16256: URL: https://github.com/apache/pulsar/pull/16256#issuecomment-1168198787 > I have explained it in the PR description. Is there something unclear? Sorry at the time I replied, the PR description was not updated. Then, please see my another comment.

[GitHub] [pulsar] BewareMyPower commented on pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
BewareMyPower commented on PR #16256: URL: https://github.com/apache/pulsar/pull/16256#issuecomment-1168198165 In addition, adding initial values to a recyclable class is dangerous. For a recyclable class, we should make constructors private and only expose some factory methods and set the

[GitHub] [pulsar] RobertIndie commented on pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
RobertIndie commented on PR #16256: URL: https://github.com/apache/pulsar/pull/16256#issuecomment-1168196968 > Please explain what's the affect of these fields without initial values. I have explained it in the PR description. Is there something unclear? -- This is an automated mess

[GitHub] [pulsar] RobertIndie closed pull request #14064: [Broker] Make PersistentTopicsBase#terminate async

2022-06-27 Thread GitBox
RobertIndie closed pull request #14064: [Broker] Make PersistentTopicsBase#terminate async URL: https://github.com/apache/pulsar/pull/14064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] RobertIndie commented on pull request #14064: [Broker] Make PersistentTopicsBase#terminate async

2022-06-27 Thread GitBox
RobertIndie commented on PR #14064: URL: https://github.com/apache/pulsar/pull/14064#issuecomment-1168196527 These changes have been moved to https://github.com/apache/pulsar/pull/16227 . So close this PR. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] RobertIndie commented on a diff in pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
RobertIndie commented on code in PR #16256: URL: https://github.com/apache/pulsar/pull/16256#discussion_r908009895 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -1337,15 +1337,15 @@ protected static final class OpSendMsg { SendCal

[GitHub] [pulsar] poorbarcode closed pull request #16246: [fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete

2022-06-27 Thread GitBox
poorbarcode closed pull request #16246: [fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete with each other URL: https://github.com/apache/pulsar/pull/16246 -- This is an automated message from the Apac

[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async

2022-06-27 Thread GitBox
nodece commented on code in PR #16221: URL: https://github.com/apache/pulsar/pull/16221#discussion_r907999571 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicNam

[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async

2022-06-27 Thread GitBox
nodece commented on code in PR #16221: URL: https://github.com/apache/pulsar/pull/16221#discussion_r907999571 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicNam

[GitHub] [pulsar] HQebupt commented on a diff in pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
HQebupt commented on code in PR #16256: URL: https://github.com/apache/pulsar/pull/16256#discussion_r907996118 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -1337,15 +1337,15 @@ protected static final class OpSendMsg { SendCallbac

[pulsar] branch master updated: [improve][broker] Reduce the re-schedule message read operation for PersistentDispatcherMultipleConsumers (#16241)

2022-06-27 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new eec46ddcba4 [improve][broker] Reduce the re-sch

[GitHub] [pulsar] codelipenghui merged pull request #16241: [improve][broker] Reduce the re-schedule message read operation for PersistentDispatcherMultipleConsumers

2022-06-27 Thread GitBox
codelipenghui merged PR #16241: URL: https://github.com/apache/pulsar/pull/16241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar] codelipenghui merged pull request #16236: [improve][java-client] Replace ScheduledExecutor to improve performance of message consumption

2022-06-27 Thread GitBox
codelipenghui merged PR #16236: URL: https://github.com/apache/pulsar/pull/16236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[pulsar] branch master updated (97e278b753a -> 96237a9615f)

2022-06-27 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 97e278b753a [improve][broker][PIP-149]make deleteTopic method async (#16232) add 96237a9615f [improve][java-cli

[GitHub] [pulsar] michaeljmarshall commented on issue #15984: [Doc] The page https://pulsar.apache.org/api/ needs to be a true map into all api versions

2022-06-27 Thread GitBox
michaeljmarshall commented on issue #15984: URL: https://github.com/apache/pulsar/issues/15984#issuecomment-1168176853 Confirming that the website-next built and works correctly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] momo-jun commented on issue #16017: [Discuss][Doc]: Remove active-standby replication mode on Geo Replication doc

2022-06-27 Thread GitBox
momo-jun commented on issue #16017: URL: https://github.com/apache/pulsar/issues/16017#issuecomment-1168176601 @codelipenghui can you pls share your idea on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] codelipenghui commented on pull request #16241: [improve][broker] Reduce the re-schedule message read operation for PersistentDispatcherMultipleConsumers

2022-06-27 Thread GitBox
codelipenghui commented on PR #16241: URL: https://github.com/apache/pulsar/pull/16241#issuecomment-1168176174 @shibd https://github.com/jvm-profiling-tools/async-profiler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] shibd commented on pull request #16241: [improve][broker] Reduce the re-schedule message read operation for PersistentDispatcherMultipleConsumers

2022-06-27 Thread GitBox
shibd commented on PR #16241: URL: https://github.com/apache/pulsar/pull/16241#issuecomment-1168170885 @codelipenghui How this graph of CPU usage is generated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] momo-jun commented on issue #12023: Tenant namespace topic length limit

2022-06-27 Thread GitBox
momo-jun commented on issue #12023: URL: https://github.com/apache/pulsar/issues/12023#issuecomment-1168169138 > @momo-jun should this be documented? > > > Currently, Pulsar didn't introduce the length limit for the name of tenants, namespaces, and topics. I think it is not nec

[GitHub] [pulsar] Shoothzj commented on pull request #16254: [dependency] Use parent pom commons-lang3 version

2022-06-27 Thread GitBox
Shoothzj commented on PR #16254: URL: https://github.com/apache/pulsar/pull/16254#issuecomment-1168167347 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16238: [test][fix][broker]Fix getInternalStats occasional lack of LeaderInfo again

2022-06-27 Thread GitBox
AnonHxy commented on code in PR #16238: URL: https://github.com/apache/pulsar/pull/16238#discussion_r907971130 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1971,40 +1971,43 @@ public CompletableFuture getInternalStats(b

[GitHub] [pulsar] poorbarcode commented on pull request #16247: [fix] [broker] Repeat creates same topic

2022-06-27 Thread GitBox
poorbarcode commented on PR #16247: URL: https://github.com/apache/pulsar/pull/16247#issuecomment-1168166411 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] michaeljmarshall commented on issue #15984: [Doc] The page https://pulsar.apache.org/api/ needs to be a true map into all api versions

2022-06-27 Thread GitBox
michaeljmarshall commented on issue #15984: URL: https://github.com/apache/pulsar/issues/15984#issuecomment-1168161169 Following up here, I now see how the docs are made. Some docs are synced from this repo to the pulsar-site repo. Then, there are scripts in the site2/website site2/website-

[GitHub] [pulsar] michaeljmarshall closed issue #15984: [Doc] The page https://pulsar.apache.org/api/ needs to be a true map into all api versions

2022-06-27 Thread GitBox
michaeljmarshall closed issue #15984: [Doc] The page https://pulsar.apache.org/api/ needs to be a true map into all api versions URL: https://github.com/apache/pulsar/issues/15984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[pulsar-site] branch main updated: Fix versioned links (#124)

2022-06-27 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new feb9cee5520 Fix versioned links (#124) feb9c

[GitHub] [pulsar] RobertIndie opened a new pull request, #16256: [fix][client] Specify the init parameters value in the OpSendMsg

2022-06-27 Thread GitBox
RobertIndie opened a new pull request, #16256: URL: https://github.com/apache/pulsar/pull/16256 ### Motivation Some parameters in OpSendMsg are not specified with initialized values. ### Modifications * Specify the init value for these parameters according to

[GitHub] [pulsar] poorbarcode commented on pull request #16247: [fix] [broker] Repeat creates same topic

2022-06-27 Thread GitBox
poorbarcode commented on PR #16247: URL: https://github.com/apache/pulsar/pull/16247#issuecomment-1168152495 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16238: [test][fix][broker]Fix getInternalStats occasional lack of LeaderInfo again

2022-06-27 Thread GitBox
AnonHxy commented on code in PR #16238: URL: https://github.com/apache/pulsar/pull/16238#discussion_r907971130 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1971,40 +1971,43 @@ public CompletableFuture getInternalStats(b

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16238: [test][fix][broker]Fix getInternalStats occasional lack of LeaderInfo again

2022-06-27 Thread GitBox
AnonHxy commented on code in PR #16238: URL: https://github.com/apache/pulsar/pull/16238#discussion_r907971130 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1971,40 +1971,43 @@ public CompletableFuture getInternalStats(b

[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #16165: [improve][client] [PIP-165] Auto release client useless connections

2022-06-27 Thread GitBox
gaozhangmin commented on code in PR #16165: URL: https://github.com/apache/pulsar/pull/16165#discussion_r907968490 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java: ## @@ -1188,4 +1201,164 @@ private void checkRequestTimeout() { } private s

[GitHub] [pulsar] HQebupt commented on a diff in pull request #16238: [test][fix][broker]Fix getInternalStats occasional lack of LeaderInfo again

2022-06-27 Thread GitBox
HQebupt commented on code in PR #16238: URL: https://github.com/apache/pulsar/pull/16238#discussion_r907968607 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1971,40 +1971,43 @@ public CompletableFuture getInternalStats(b

[pulsar] branch master updated (68484f9162b -> 97e278b753a)

2022-06-27 Thread jianghaiting
This is an automated email from the ASF dual-hosted git repository. jianghaiting pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 68484f9162b [improve][broker] Avoid go through all the consumers to get the message ack owner (#16245) add

[GitHub] [pulsar] Jason918 merged pull request #16232: [improve][broker][PIP-149]make deleteTopic method async

2022-06-27 Thread GitBox
Jason918 merged PR #16232: URL: https://github.com/apache/pulsar/pull/16232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[GitHub] [pulsar] github-actions[bot] commented on pull request #16255: [client][python] getLastMessageIdAsync C binding

2022-06-27 Thread GitBox
github-actions[bot] commented on PR #16255: URL: https://github.com/apache/pulsar/pull/16255#issuecomment-1168137355 @komalatammal Please select only one documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2

[GitHub] [pulsar] komalatammal opened a new pull request, #16255: [client][python] getLastMessageIdAsync C binding

2022-06-27 Thread GitBox
komalatammal opened a new pull request, #16255: URL: https://github.com/apache/pulsar/pull/16255 ### Motivation Python function getLastMessageId It is a C binding for https://github.com/apache/pulsar/pull/16182 to implement get_last_message_id() in Python client. ### Mod

[GitHub] [pulsar] RobertIndie commented on a diff in pull request #16248: [fix] [transaction] Cmd-Subscribe and Cmd-Producer will not succeed even after 100 retries

2022-06-27 Thread GitBox
RobertIndie commented on code in PR #16248: URL: https://github.com/apache/pulsar/pull/16248#discussion_r907956787 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckReplyCallBack.java: ## @@ -53,8 +54,10 @@ public void replayComplete

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16241: [improve][broker] Reduce the re-schedule message read operation for PersistentDispatcherMultipleConsumers

2022-06-27 Thread GitBox
codelipenghui commented on code in PR #16241: URL: https://github.com/apache/pulsar/pull/16241#discussion_r907946465 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -291,8 +294,17 @@ public synchronized

[GitHub] [pulsar] momo-jun commented on issue #15972: [Doc] docker improvments

2022-06-27 Thread GitBox
momo-jun commented on issue #15972: URL: https://github.com/apache/pulsar/issues/15972#issuecomment-1168108731 We closed this doc issue because the reported doc gaps have been fulfilled. Regarding the log levels, the doc cannot be changed unless the code is changed. So you can create a new

[GitHub] [pulsar] github-actions[bot] commented on pull request #16254: [dependency] Use parent pom commons-lang3 version

2022-06-27 Thread GitBox
github-actions[bot] commented on PR #16254: URL: https://github.com/apache/pulsar/pull/16254#issuecomment-1168106324 @Shoothzj Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r

[GitHub] [pulsar] Shoothzj opened a new pull request, #16254: [dependency] Use parent pom commons-lang3 version

2022-06-27 Thread GitBox
Shoothzj opened a new pull request, #16254: URL: https://github.com/apache/pulsar/pull/16254 ### Modifications Use parent `commons-lang3` version instead of define it each module -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] startjava opened a new issue, #16253: 2.10版本执行./pulsar standalone -nss -nfw命令启动出现异常。

2022-06-27 Thread GitBox
startjava opened a new issue, #16253: URL: https://github.com/apache/pulsar/issues/16253 六月 28, 2022 9:19:02 上午 org.glassfish.jersey.internal.Errors logErrors 警告: The following warnings have been detected: WARNING: Return type, java.util.Map, of method, public java.util.Map org.apache.p

[pulsar] branch master updated: [improve][broker] Avoid go through all the consumers to get the message ack owner (#16245)

2022-06-27 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 68484f9162b [improve][broker] Avoid go through

[GitHub] [pulsar] hangc0276 merged pull request #16245: [improve][broker] Avoid go through all the consumers to get the message ack owner

2022-06-27 Thread GitBox
hangc0276 merged PR #16245: URL: https://github.com/apache/pulsar/pull/16245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar] hangc0276 commented on pull request #16243: [improve][broker] Reduce the consumers list sort by priority level

2022-06-27 Thread GitBox
hangc0276 commented on PR #16243: URL: https://github.com/apache/pulsar/pull/16243#issuecomment-1168100457 Good job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar] hangc0276 commented on a diff in pull request #16241: [improve][broker] Reduce the re-schedule message read operation for PersistentDispatcherMultipleConsumers

2022-06-27 Thread GitBox
hangc0276 commented on code in PR #16241: URL: https://github.com/apache/pulsar/pull/16241#discussion_r907931428 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -291,8 +294,17 @@ public synchronized voi

[pulsar] branch branch-2.10 updated: [improve][broker] Reduce the consumers list sort by priority level (#16243)

2022-06-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 4bdaa32bc7c [improve][broker] Reduce t

[pulsar] branch master updated (ebcc47ee7ce -> 291fedcd2dc)

2022-06-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from ebcc47ee7ce [improve][broker][PIP-149]make terminate method async (#16227) add 291fedcd2dc [improve][broker] Red

[GitHub] [pulsar] merlimat merged pull request #16243: [improve][broker] Reduce the consumers list sort by priority level

2022-06-27 Thread GitBox
merlimat merged PR #16243: URL: https://github.com/apache/pulsar/pull/16243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[GitHub] [pulsar] startjava opened a new issue, #16252: what mean param : pulsar -nss

2022-06-27 Thread GitBox
startjava opened a new issue, #16252: URL: https://github.com/apache/pulsar/issues/16252 -nss param what mean ? thank you ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #16218: [improve][broker][PIP-149]make getBacklog method async

2022-06-27 Thread GitBox
mattisonchao commented on code in PR #16218: URL: https://github.com/apache/pulsar/pull/16218#discussion_r907917870 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -3040,44 +3040,46 @@ private Response generateResponseWithEntry

[GitHub] [pulsar] benbro commented on issue #15972: [Doc] docker improvments

2022-06-27 Thread GitBox
benbro commented on issue #15972: URL: https://github.com/apache/pulsar/issues/15972#issuecomment-1168063253 I don't think the log level changed. This is still an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#ebcc47e)

2022-06-27 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 52b32f732dd Docs sync done from apache/pulsar(#

[GitHub] [pulsar] merlimat commented on a diff in pull request #16062: [feat][broker] PIP-145: Notifications for faster topic discovery

2022-06-27 Thread GitBox
merlimat commented on code in PR #16062: URL: https://github.com/apache/pulsar/pull/16062#discussion_r907863444 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/TopicResources.java: ## @@ -110,4 +123,34 @@ public CompletableFuture clearTenantPersistence(

[GitHub] [pulsar] nicoloboschi opened a new pull request, #16251: [feature][cli] Pulsar Shell - pulsar-admin and pulsar-client - part 1

2022-06-27 Thread GitBox
nicoloboschi opened a new pull request, #16251: URL: https://github.com/apache/pulsar/pull/16251 Master Issue: #16250 ### Modifications * Introduced new command `bin/pulsar-shell` * Implemented all the basic shell features (autocompletion, persisted history, welcome,

[GitHub] [pulsar] Anonymitaet commented on pull request #14084: [Doc] Describe default ack timeout and update grammar in ConsumerBuilder javadoc

2022-06-27 Thread GitBox
Anonymitaet commented on PR #14084: URL: https://github.com/apache/pulsar/pull/14084#issuecomment-1167991886 @liry I mean this PR can proceed only after the checks are passed. You might need to merge master. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] nicoloboschi opened a new issue, #16250: PIP-181: Pulsar Shell

2022-06-27 Thread GitBox
nicoloboschi opened a new issue, #16250: URL: https://github.com/apache/pulsar/issues/16250 ## Motivation Currently Pulsar comes with a couple of utility scripts with the goal of managing an existing cluster, test behaviours and verify performances: these tools are available as SH sc

  1   2   >