(pulsar-site) branch bewaremypower/release-cpp-3.4.2 deleted (was e01be03cf4d9)

2023-12-15 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch bewaremypower/release-cpp-3.4.2 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git was e01be03cf4d9 Add the release note for C++ client 3.4.2 The revisions that were on this bra

[PR] [PIP-60] [Proxy-Server] Support SNI routing for Pulsar CPP client [pulsar-client-cpp]

2023-12-15 Thread via GitHub
rdhabalia opened a new pull request, #373: URL: https://github.com/apache/pulsar-client-cpp/pull/373 ### Motivation #8957 was added incorrectly and it was not supporting SNI routing for CPP client library. This PR adds support of SNI roting to Pulsar CPP client library and allows

Re: [PR] [fix][broker] Automatically create topic for remote cluster in geo [pulsar]

2023-12-15 Thread via GitHub
Technoboy- commented on code in PR #21679: URL: https://github.com/apache/pulsar/pull/21679#discussion_r1428641143 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java: ## @@ -1419,4 +1424,40 @@ public static Optional getMigratedClusterUrl(PulsarSe

Re: [PR] [fix][broker] Automatically create topic for remote cluster in geo [pulsar]

2023-12-15 Thread via GitHub
Technoboy- commented on code in PR #21679: URL: https://github.com/apache/pulsar/pull/21679#discussion_r1428640990 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java: ## @@ -1419,4 +1424,40 @@ public static Optional getMigratedClusterUrl(PulsarSe

[PR] [fix][test] Fix flaky SubscriptionMessageDispatchThrottlingTest [pulsar]

2023-12-15 Thread via GitHub
lhotari opened a new pull request, #21736: URL: https://github.com/apache/pulsar/pull/21736 ### Motivation & Modifications Fix flaky SubscriptionMessageDispatchThrottlingTest ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [

Re: [PR] [improve][misc] Upgrade Netty to 4.1.104 and io_uring to 0.0.24 [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on PR #21723: URL: https://github.com/apache/pulsar/pull/21723#issuecomment-185847 > 4.1.104 seems to be already out: https://netty.io/news/2023/12/15/4-1-104-Final.html @merlimat Thanks, Now upgraded to 4.1.104 which fixes the issue in 4.1.103. -- This is an

(pulsar) branch master updated: [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics (#21729)

2023-12-15 Thread heesung
This is an automated email from the ASF dual-hosted git repository. heesung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 88df040ed34 [fix][broker] Skip topic auto-creat

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn merged PR #21729: URL: https://github.com/apache/pulsar/pull/21729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428406364 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] docs: use variables in release-process [pulsar-dotpulsar]

2023-12-15 Thread via GitHub
entvex commented on PR #196: URL: https://github.com/apache/pulsar-dotpulsar/pull/196#issuecomment-1858394058 Thanks 😄 @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

(pulsar-dotpulsar) branch tisonkun-patch-1 deleted (was 809f2d1)

2023-12-15 Thread djensen
This is an automated email from the ASF dual-hosted git repository. djensen pushed a change to branch tisonkun-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git was 809f2d1 docs: use variables in release-process The revisions that were on this branch are still

(pulsar-dotpulsar) branch master updated: docs: use variables in release-process (#196)

2023-12-15 Thread djensen
This is an automated email from the ASF dual-hosted git repository. djensen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 692e0d5 docs: use variables in relea

Re: [PR] docs: use variables in release-process [pulsar-dotpulsar]

2023-12-15 Thread via GitHub
entvex merged PR #196: URL: https://github.com/apache/pulsar-dotpulsar/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

Re: [PR] docs: use variables in release-process [pulsar-dotpulsar]

2023-12-15 Thread via GitHub
entvex commented on code in PR #196: URL: https://github.com/apache/pulsar-dotpulsar/pull/196#discussion_r1428401940 ## docs/release-process.md: ## @@ -52,58 +52,67 @@ Bump up the version number as follows. ## Steps in detail -**In these instructions, I'm referring to an fi

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428379167 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428375944 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428373276 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428348898 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [I] [Bug] RateLimiter lock contention when use precise publish rate limiter [pulsar]

2023-12-15 Thread via GitHub
merlimat closed issue #21442: [Bug] RateLimiter lock contention when use precise publish rate limiter URL: https://github.com/apache/pulsar/issues/21442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
merlimat merged PR #21681: URL: https://github.com/apache/pulsar/pull/21681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427582411 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreationAs

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428222877 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428218791 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428220115 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [improve][misc] Upgrade Netty to 4.1.103 and io_uring to 0.0.24 [pulsar]

2023-12-15 Thread via GitHub
merlimat commented on PR #21723: URL: https://github.com/apache/pulsar/pull/21723#issuecomment-1858176757 > 4.1.103 is broken on MacOS on Intel. Let's wait for a fix to this issue in Netty: [netty/netty#13728](https://github.com/netty/netty/issues/13728) 4.1.104 seems to be already ou

[PR] [improve][broker] Improve isTopicPublishRateExceeded to uniformly check publish rate [pulsar]

2023-12-15 Thread via GitHub
nodece opened a new pull request, #21734: URL: https://github.com/apache/pulsar/pull/21734 ### Motivation 1. When `isPreciseTopicPublishRateExceeded` or `resourceGroupPublishRateExceeded` is `true`, the `throttledConnections.inc()` is not called. 2. We have multiple publish limit

(pulsar) branch branch-3.0 updated: [fix][sec] Upgrade org.bouncycastle:bc-fips to 1.0.2.4 (#21730)

2023-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 425ff7a3241 [fix][sec] Upgrade org.bounc

(pulsar) branch master updated (3fb83f7aedb -> 60522c61a3f)

2023-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 3fb83f7aedb [improve][build] Increase apt's initial timeout from 250ms to 2000ms and increase retries (#21727) a

(pulsar) branch branch-3.1 updated: [fix][sec] Upgrade org.bouncycastle:bc-fips to 1.0.2.4 (#21730)

2023-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 309cf4ba65f [fix][sec] Upgrade org.bounc

Re: [PR] [fix][sec] Upgrade org.bouncycastle:bc-fips to 1.0.2.4 [pulsar]

2023-12-15 Thread via GitHub
merlimat merged PR #21730: URL: https://github.com/apache/pulsar/pull/21730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on PR #21681: URL: https://github.com/apache/pulsar/pull/21681#issuecomment-1858050514 > Great work here! > > Can we also include the JMH benchmark from https://github.com/lhotari/async-tokenbucket/blob/master/src/jmh/java/com/github/lhotari/asynctokenbucket/AsyncTok

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1428087337 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1428088976 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1428088551 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1428088146 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428063039 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [improve][pip] PIP-310: Support custom publish rate limiters [pulsar]

2023-12-15 Thread via GitHub
grssam commented on PR #21399: URL: https://github.com/apache/pulsar/pull/21399#issuecomment-1857889100 thank you everyone who participated in the review and the discussion thread. We have a way ahead which is different from this proposal so closing this PR as well. -- This is an automat

Re: [PR] [improve][pip] PIP-310: Support custom publish rate limiters [pulsar]

2023-12-15 Thread via GitHub
grssam closed pull request #21399: [improve][pip] PIP-310: Support custom publish rate limiters URL: https://github.com/apache/pulsar/pull/21399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] [fix][ci] Disable `testReuseFork` when runs pulsar-metadata [pulsar]

2023-12-15 Thread via GitHub
Technoboy- opened a new pull request, #21733: URL: https://github.com/apache/pulsar/pull/21733 ### Motivation Don't merge. Pulsar-metadata ran into crash many times. ![image](https://github.com/apache/pulsar/assets/6297296/54df8969-ecef-4b58-a3e3-bc9f875cbe02)

[PR] [fix][test] Close the resource after the test. [pulsar]

2023-12-15 Thread via GitHub
Technoboy- opened a new pull request, #21732: URL: https://github.com/apache/pulsar/pull/21732 ### Motivation [CI - Unit - Pulsar IO - Elastic Search](https://github.com/apache/pulsar/actions/runs/7218881587/job/19669156306#step:16:181) Summary: Tests in class org.apache.pulsar.io

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427925309 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427925063 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427830047 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add the release note for C++ client 3.4.2 [pulsar-site]

2023-12-15 Thread via GitHub
shibd merged PR #753: URL: https://github.com/apache/pulsar-site/pull/753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

(pulsar-site) branch main updated: Add the release note for C++ client 3.4.2 (#753)

2023-12-15 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 80e4090e04db Add the release note for C++ client

[PR] [improve][pip] PIP-325: Add command to abort transaction [pulsar]

2023-12-15 Thread via GitHub
hr opened a new pull request, #21731: URL: https://github.com/apache/pulsar/pull/21731 Releted PR: https://github.com/apache/pulsar/pull/21630 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- Th

(pulsar-dotpulsar) branch master updated: Removing more pragmas no longer needed. Wup wup Microsoft! :-D

2023-12-15 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new acb58c3 Removing more pragmas

(pulsar-dotpulsar) branch master updated: Removing pramas no longer needed.

2023-12-15 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 0736aaf Removing pramas no lo

(pulsar-dotpulsar) branch master updated: Removing 'pragma warning disable xUnit1025' (no longer nedded) and refactored to silence "Messages"

2023-12-15 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 28e0a11 Removing 'pragma warn

[PR] Add the release note for C++ client 3.4.2 [pulsar-site]

2023-12-15 Thread via GitHub
BewareMyPower opened a new pull request, #753: URL: https://github.com/apache/pulsar-site/pull/753 https://github.com/apache/pulsar-site/assets/18204803/b3bae06c-08c3-4b0d-9572-91b922e374f2";> https://github.com/apache/pulsar-site/assets/18204803/7a441da4-7428-4be3-9ea4-baf149e6d340";>

(pulsar-site) branch bewaremypower/release-cpp-3.4.2 updated (e77c405954aa -> e01be03cf4d9)

2023-12-15 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch bewaremypower/release-cpp-3.4.2 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git discard e77c405954aa Add the release note for C++ client 3.4.2 new e01be03cf4d9 Add the releas

(pulsar-site) 01/01: Add the release note for C++ client 3.4.2

2023-12-15 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch bewaremypower/release-cpp-3.4.2 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit e01be03cf4d97874fab0796d12083bbc67202595 Author: Yunze Xu AuthorDate: Fri Dec 15 18:51:31 202

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427837307 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427837113 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

(pulsar-site) 01/01: Add the release note for C++ client 3.4.2

2023-12-15 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch bewaremypower/release-cpp-3.4.2 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit e77c405954aafef4aa79d0654bed59d1ffdd4e57 Author: Yunze Xu AuthorDate: Fri Dec 15 18:51:31 202

(pulsar-site) branch bewaremypower/release-cpp-3.4.2 created (now e77c405954aa)

2023-12-15 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch bewaremypower/release-cpp-3.4.2 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at e77c405954aa Add the release note for C++ client 3.4.2 This branch includes the following

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427833552 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427830047 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

svn commit: r66078 - /dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.2-candidate-1/ /release/pulsar/pulsar-client-cpp-3.4.2/

2023-12-15 Thread xyz
Author: xyz Date: Fri Dec 15 10:42:50 2023 New Revision: 66078 Log: Release Apache Pulsar Client C++ 3.4.2 Added: release/pulsar/pulsar-client-cpp-3.4.2/ - copied from r66077, dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.2-candidate-1/ Removed: dev/pulsar/pulsar-client-cpp/pu

(pulsar-client-cpp) annotated tag v3.4.2 updated (1cb1bf8 -> ddd6b4c)

2023-12-15 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to annotated tag v3.4.2 in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git *** WARNING: tag v3.4.2 was modified! *** from 1cb1bf8 (commit) to ddd6b4c (tag) tagging 1cb1bf8ba

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1427826069 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/AsyncTokenBucket.java: ## @@ -0,0 +1,615 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

(pulsar-dotpulsar) branch master updated: Fixed some suggestions. Using new C# 12 features and ignoring others.

2023-12-15 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 0018cd9 Fixed some suggestion

Re: [PR] [improve][build] Add a default username in the image [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on PR #21695: URL: https://github.com/apache/pulsar/pull/21695#issuecomment-1857611095 @zymap This is how the user name is set in Hadoop Java library: https://stackoverflow.com/a/16788971 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] [improve][build] Add a default username in the image [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on PR #21695: URL: https://github.com/apache/pulsar/pull/21695#issuecomment-1857607263 > > > Add a default username in the pulsar image. When using HDFS offloader, it requires a username to transfer the file. > > > > > > How about using `HADOOP_USER_NAME` instead

Re: [I] [Bug] After upgrading to the 3.0.1, the topic was deleted! [pulsar]

2023-12-15 Thread via GitHub
crossoverJie commented on issue #21653: URL: https://github.com/apache/pulsar/issues/21653#issuecomment-1857548997 If you unfortunately encounter this bug, please do not immediately try to upgrade to the fixed version. Because restarting `broker` may still trigger the deletion of topi

Re: [PR] [improve][misc] Upgrade Netty to 4.1.103 and io_uring to 0.0.24 [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on PR #21723: URL: https://github.com/apache/pulsar/pull/21723#issuecomment-1857511167 4.1.103 is broken on MacOS on Intel. Let's wait for a fix to this issue in Netty: https://github.com/netty/netty/issues/13728 -- This is an automated message from the Apache Git Servic

Re: [I] [Bug] Pulsar RocksDB metadata driver causes JVM to crash in unit tests [pulsar]

2023-12-15 Thread via GitHub
lhotari commented on issue #19250: URL: https://github.com/apache/pulsar/issues/19250#issuecomment-1857503542 Yet another crash: https://gist.github.com/lhotari/177f186d9f73297fbfbce8b026824365 ``` Stack: [0x7f95c27ff000,0x7f95c28ff000], sp=0x7f95c28fcfd0, free space

(pulsar-client-cpp) branch main updated: Integrate vcpkg to manage dependencies for all platforms (#371)

2023-12-15 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 7baa312 Integrate vcpkg to manage dependenc

Re: [PR] Integrate vcpkg to manage dependencies for all platforms [pulsar-client-cpp]

2023-12-15 Thread via GitHub
BewareMyPower merged PR #371: URL: https://github.com/apache/pulsar-client-cpp/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

Re: [PR] [improve][build] Add a default username in the image [pulsar]

2023-12-15 Thread via GitHub
zymap commented on PR #21695: URL: https://github.com/apache/pulsar/pull/21695#issuecomment-1857489438 @lhotari Thank you for your fix! I pushed failed, then found you already fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-15 Thread via GitHub
gunli opened a new pull request, #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)