Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-19 Thread via GitHub
lhotari commented on PR #21729: URL: https://github.com/apache/pulsar/pull/21729#issuecomment-1862769497 Could be related to the increased flakiness of ExtensibleLoadManagerTest.testIsolationPolicy, #20608 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn merged PR #21729: URL: https://github.com/apache/pulsar/pull/21729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428406364 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428379167 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428375944 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428373276 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428348898 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427582411 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreationAs

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428222877 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428218791 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428220115 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfigurati

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-15 Thread via GitHub
gaoran10 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1428063039 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java: ## @@ -526,4 +534,58 @@ public void testDynamicConfiguration

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427595305 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreationAs

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
Demogorgon314 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427581077 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreatio

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427582411 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreationAs

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427582411 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreationAs

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
Demogorgon314 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427581077 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreatio

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
heesung-sn commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427579617 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreationAs

Re: [PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
Demogorgon314 commented on code in PR #21729: URL: https://github.com/apache/pulsar/pull/21729#discussion_r1427575085 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3432,10 +3432,10 @@ private CompletableFuture isAllowAutoTopicCreatio

[PR] [fix][broker] Skip topic auto-creation for ExtensibleLoadManager internal topics [pulsar]

2023-12-14 Thread via GitHub
heesung-sn opened a new pull request, #21729: URL: https://github.com/apache/pulsar/pull/21729 ### Motivation For our load data system topics such as, non-persistent://pulsar/system/loadbalancer-broker-load-data, this allowAutoTopicCreationType=parti