[GitHub] [incubator-tvm] FrozenGene opened a new pull request #5852: [BACKPORT-0.6] Fix NDArray SaveDLTensor declaration and implementation signature different

2020-06-19 Thread GitBox
FrozenGene opened a new pull request #5852: URL: https://github.com/apache/incubator-tvm/pull/5852 Port https://github.com/apache/incubator-tvm/pull/4586/ @yzhliu This is an automated message from the Apache Git Se

[GitHub] [incubator-tvm] t-vi commented on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646475548 Rebased. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
masahi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442707169 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] t-vi opened a new pull request #5853: Add Python Classes for all Attrs

2020-06-19 Thread GitBox
t-vi opened a new pull request #5853: URL: https://github.com/apache/incubator-tvm/pull/5853 This lets the all Python classes subclass Attrs cp https://discuss.tvm.ai/t/attrs-not-inheriting-from-attrs/7029 This is

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442747459 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] t-vi commented on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646552669 And the quantization test fails by a small margin. :/ I'll look into it some more. I wonder whether a better strategy for the lost types would be to run the ops on the fly in

[GitHub] [incubator-tvm] t-vi commented on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646561327 I have to ask about the test criterion for `qnn_test.py::test_serialized_modules`. It seems to pass here locally (with PyTorch 1.5 cpu wheel). It gets ~70% identical, bu

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442747459 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
masahi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442773736 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] masahi commented on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
masahi commented on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646575045 That 0.2 threshold was chosen arbitrary without a good reason. If you come up with a principled crieteria it is great. Other quantized tests also need a good test cr

[GitHub] [incubator-tvm] masahi edited a comment on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
masahi edited a comment on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646575045 That 0.2 threshold was chosen arbitrary without a good reason. If you come up with a principled crieteria it is great. Other quantized tests also need a good

[GitHub] [incubator-tvm] masahi edited a comment on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
masahi edited a comment on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646575045 That 0.2 threshold was chosen arbitrary without a good reason. If you come up with a principled crieteria it is great, as long as it won't get flaky. Other qu

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
masahi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442779640 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442784734 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0]

[GitHub] [incubator-tvm] giuseros commented on pull request #5754: [RFC] Improve quantized convolution performance for armv8 architectures

2020-06-19 Thread GitBox
giuseros commented on pull request #5754: URL: https://github.com/apache/incubator-tvm/pull/5754#issuecomment-646613001 Hi @FrozenGene , Thanks for the review! I applied your changes, but I get a (seemingly) unrelated test failure. Could you double check please, and let me kno

[GitHub] [incubator-tvm] t-vi commented on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646632715 Looks like the CI likes the revised test criteron. :slightly_smiling_face: This is an automated message from

[GitHub] [incubator-tvm] t-vi edited a comment on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi edited a comment on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646632715 Looks like the CI likes the revised test criterion. :slightly_smiling_face: This is an automated mess

[GitHub] [incubator-tvm] lixiaoquan commented on a change in pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-19 Thread GitBox
lixiaoquan commented on a change in pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#discussion_r442871822 ## File path: python/tvm/relay/op/dynamic/transform.py ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

[GitHub] [incubator-tvm] tqchen merged pull request #5851: fix #5849

2020-06-19 Thread GitBox
tqchen merged pull request #5851: URL: https://github.com/apache/incubator-tvm/pull/5851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen merged pull request #5824: [FIX] Recover global state after test_util.py

2020-06-19 Thread GitBox
tqchen merged pull request #5824: URL: https://github.com/apache/incubator-tvm/pull/5824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #5824: [FIX] Recover global state after test_util.py

2020-06-19 Thread GitBox
tqchen commented on pull request #5824: URL: https://github.com/apache/incubator-tvm/pull/5824#issuecomment-646669685 Thanks @mbaret ! Thanks @areusch for reviewing This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen merged pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-19 Thread GitBox
tqchen merged pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch v0.6 updated: fix #5849 (#5851)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch v0.6 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/v0.6 by this push: new eacc886 fix #5849 (#5851) eacc886 is describ

[GitHub] [incubator-tvm] tqchen commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646670212 @junrushao1994 please rebase against the master This is an automated message from the Apache Git Service. T

[incubator-tvm] branch v0.6 updated: fix #5849 (#5851)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch v0.6 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/v0.6 by this push: new eacc886 fix #5849 (#5851) eacc886 is describ

[GitHub] [incubator-tvm] tqchen commented on pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

2020-06-19 Thread GitBox
tqchen commented on pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#issuecomment-646669948 THanks @junrushao1994 @zhiics ! This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated (64766c2 -> c890573)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 64766c2 [AutoTVM] Suppress the warning messages when compile engine selects impls (#5821) add c890573

[incubator-tvm] branch master updated (c890573 -> 55e02af)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from c890573 [FIX] Recover global state after test_util.py (#5824) add 55e02af [Object] Introduce POD-C Comp

[GitHub] [incubator-tvm] tqchen merged pull request #5601: [DataType] Add bfloat16

2020-06-19 Thread GitBox
tqchen merged pull request #5601: URL: https://github.com/apache/incubator-tvm/pull/5601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch master updated (55e02af -> 9b7c078)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 55e02af [Object] Introduce POD-C Compliant tvm::Map (#5740) add 9b7c078 [DataType] Add bfloat16 (#5601)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5601: [DataType] Add bfloat16

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5601: URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r442879205 ## File path: include/tvm/runtime/data_type.h ## @@ -72,6 +73,9 @@ class DataType { data_.code = static_cast(code); data_.bits = static_cas

[GitHub] [incubator-tvm] tqchen commented on pull request #5601: [DataType] Add bfloat16

2020-06-19 Thread GitBox
tqchen commented on pull request #5601: URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-646674793 Thanks @Menooker for being patient and keep improving the PR to maintain a high quality standard! Thanks @ZhennanQin @junrushao1994 @liangfu for helpful reviews!

[GitHub] [incubator-tvm] tqchen commented on pull request #5854: Fix map assign issue in CI test

2020-06-19 Thread GitBox
tqchen commented on pull request #5854: URL: https://github.com/apache/incubator-tvm/pull/5854#issuecomment-646682932 cc @junrushao1994 @tmoreau89 @zhiics @jroesch This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen opened a new pull request #5854: Fix map assign issue in CI test

2020-06-19 Thread GitBox
tqchen opened a new pull request #5854: URL: https://github.com/apache/incubator-tvm/pull/5854 Fix for a minor issue due to concurrent merge of #5601 and #5740 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-tvm] giuseros commented on pull request #5754: [RFC] Improve quantized convolution performance for armv8 architectures

2020-06-19 Thread GitBox
giuseros commented on pull request #5754: URL: https://github.com/apache/incubator-tvm/pull/5754#issuecomment-646684376 It actually seems related to: https://github.com/apache/incubator-tvm/issues/5827 This is an automated m

[incubator-tvm] branch master updated (9b7c078 -> 3c733b8)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 9b7c078 [DataType] Add bfloat16 (#5601) add 3c733b8 Add Python Classes for all Attrs (#5853) No new re

[GitHub] [incubator-tvm] tqchen commented on pull request #5853: Add Python Classes for all Attrs

2020-06-19 Thread GitBox
tqchen commented on pull request #5853: URL: https://github.com/apache/incubator-tvm/pull/5853#issuecomment-646698151 Thanks @t-vi ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen merged pull request #5853: Add Python Classes for all Attrs

2020-06-19 Thread GitBox
tqchen merged pull request #5853: URL: https://github.com/apache/incubator-tvm/pull/5853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] zhiics commented on pull request #5772: [ARITH]add simplify rule for div

2020-06-19 Thread GitBox
zhiics commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-646701612 LGTM now. @yongfeng-nv @merrymercy @junrushao1994 any of you wants to take a quick look? This is an automa

[GitHub] [incubator-tvm] zhiics opened a new pull request #5855: [RELAY][VM] Add shape_of instruction

2020-06-19 Thread GitBox
zhiics opened a new pull request #5855: URL: https://github.com/apache/incubator-tvm/pull/5855 This PR adds a VM instruction `ShapeOf` to get the shape of a tensor at runtime. This instruction is always executed on CPU as there is no computation required. cc @icemelon9 @jroesch @wwe

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
ANSHUMAN87 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442940997 ## File path: tests/cpp/target_test.cc ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contrib

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5772: [ARITH]add simplify rule for div

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#discussion_r442947630 ## File path: src/arith/rewrite_simplify.cc ## @@ -353,6 +353,15 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const SubNode* op) { trunc

[GitHub] [incubator-tvm] tqchen commented on pull request #5772: [ARITH]add simplify rule for div

2020-06-19 Thread GitBox
tqchen commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-646751495 Arith simplification are key to the correctness so it would be great if we can be extra careful here. It would be great if we can write down a proof for the rule, or at lea

[GitHub] [incubator-tvm] yzhliu merged pull request #5852: [BACKPORT-0.6] Fix NDArray SaveDLTensor declaration and implementation signature different

2020-06-19 Thread GitBox
yzhliu merged pull request #5852: URL: https://github.com/apache/incubator-tvm/pull/5852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch v0.6 updated: [BACKPORT-0.6] Fix NDArray SaveDLTensor declaration and implementation signature different (#5852)

2020-06-19 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a commit to branch v0.6 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/v0.6 by this push: new da1bc3d [BACKPORT-0.6] Fix NDArray SaveDLT

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442953431 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

2020-06-19 Thread GitBox
areusch commented on a change in pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655#discussion_r442953950 ## File path: tutorials/micro/micro_tflite.py ## @@ -0,0 +1,216 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442957099 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442959777 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5854: Fix map assign issue in CI test

2020-06-19 Thread GitBox
junrushao1994 commented on pull request #5854: URL: https://github.com/apache/incubator-tvm/pull/5854#issuecomment-646781309 @tqchen CI is green. Let's get it merged quickly to unblock the mainline. This is an automated messa

[incubator-tvm] branch master updated (3c733b8 -> aaed048)

2020-06-19 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 3c733b8 Add Python Classes for all Attrs (#5853) add aaed048 Fix map assign issue in CI test (#5854) No

[GitHub] [incubator-tvm] zhiics merged pull request #5854: Fix map assign issue in CI test

2020-06-19 Thread GitBox
zhiics merged pull request #5854: URL: https://github.com/apache/incubator-tvm/pull/5854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442968000 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442969162 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442972847 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646791046 Thank you @ANSHUMAN87 for the review! This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
ANSHUMAN87 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442975202 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-19 Thread GitBox
mbrookhart commented on a change in pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#discussion_r442975459 ## File path: python/tvm/relay/op/dynamic/transform.py ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442980201 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] icemelon9 commented on pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-19 Thread GitBox
icemelon9 commented on pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#issuecomment-646810997 Shall we just call the namespace `dyn`? I'm okay with `dynamic`, but just feel it is a bit long. This i

[GitHub] [incubator-tvm] t-vi commented on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
t-vi commented on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646812154 @masahi @siju-samuel Thank you for your reviews so far. Anything else I can do to help this along? This is a

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443011655 ## File path: tests/cpp/target_test.cc ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

[GitHub] [incubator-tvm] masahi commented on pull request #5834: Improve type handling in PyTorch frontend

2020-06-19 Thread GitBox
masahi commented on pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646857542 @siju-samuel You can merge this PR with your approval. I'm blocked by your change request. This is an auto

[GitHub] [incubator-tvm] tqchen commented on pull request #5826: [DYNAMIC] Add Dynamic reshape to a dynamic namespace and add DynamicToStatic Pass

2020-06-19 Thread GitBox
tqchen commented on pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#issuecomment-646857875 I agree with @icemelon9 perhaps `dyn` is a better name here. This is an automated message from the Apache G

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #5856: Fail early before running invalid dynamic graphs

2020-06-19 Thread GitBox
mbrookhart opened a new pull request #5856: URL: https://github.com/apache/incubator-tvm/pull/5856 @zhiics In testing dynamic graphs, I've run into some pretty gnarly error messages deep in the memory planner for graph runtime or deep in nested packed function calls in the VM. In a

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646870388 @tqchen could you take another look? Changes - Added schema validation - Added several tests ---

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443061397 ## File path: src/target/target_id.cc ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] tqchen commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646878266 Note about the second level validation: ``` { "id": "cuda", "tag": "nvidia/tx2-cudnn", "keys": ["cuda", "gpu"], "libs": ["cudnn"],

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646887809 @tqchen As far as I could understand, we need validation twice, one for target, one for target_host. Therefore, the step-by-step procedure should be: 1) Let

[GitHub] [incubator-tvm] robo-corg commented on a change in pull request #5830: Rust Refactor Stage 4: Rewrite Rust graph runtime to use new APIs

2020-06-19 Thread GitBox
robo-corg commented on a change in pull request #5830: URL: https://github.com/apache/incubator-tvm/pull/5830#discussion_r442440869 ## File path: rust/tvm-graph-rt/src/allocator.rs ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen edited a comment on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646891831 Sorrt i omitted the libs and tags, they should be. Would be great if we can have a test example Th

[GitHub] [incubator-tvm] tqchen commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646891831 Sorrt i omitted the libs and tags, they should be. This is an automated message from the Apache Git Service

[GitHub] [incubator-tvm] trevor-m opened a new pull request #5857: [OpenCL] Fix OpenCL get_valid_counts errors due to intrinsic atomic_add

2020-06-19 Thread GitBox
trevor-m opened a new pull request #5857: URL: https://github.com/apache/incubator-tvm/pull/5857 Some fixes a few months ago to the `get_valid_counts` CUDA implementation broke OpenCL at the same time, because of the atomic add intrinsic which was added. This PR fixes `get_valid_cou

[incubator-tvm] branch master updated (aaed048 -> 11349c6)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from aaed048 Fix map assign issue in CI test (#5854) add 11349c6 [DOCS] Update has_dtype/has_shape to patter

[GitHub] [incubator-tvm] tqchen merged pull request #5847: [DOCS] Update has_dtype/has_shape to pattern lang doc

2020-06-19 Thread GitBox
tqchen merged pull request #5847: URL: https://github.com/apache/incubator-tvm/pull/5847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] badenh opened a new pull request #5858: Update install.rst

2020-06-19 Thread GitBox
badenh opened a new pull request #5858: URL: https://github.com/apache/incubator-tvm/pull/5858 minor cleanups/corrections Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is su

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646905854 @tqchen Just added support for `target_host`, and right now are can support validating the entire map directly via `TargetValidateSchema` --

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085167 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085301 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085167 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] tqchen commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646907966 see some additional followups about making Target as part of the schema, to recognize perhaps `Array` and `Target` and do recursive handling. -

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085597 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085746 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646908749 Future work may include: 1) Refactor the object `TargetNode` 2) Allow `Target` to be a special type supported in schema validation, so that composite/recursive

[GitHub] [incubator-tvm-vta] tmoreau89 commented on a change in pull request #9: [Hardware][OpenCL] Intelfocl support

2020-06-19 Thread GitBox
tmoreau89 commented on a change in pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r443088598 ## File path: config/intelfocl_sample.json ## @@ -0,0 +1,13 @@ +{ + "TARGET" : "intelfocl", Review comment: Agreed with the above comment

[GitHub] [incubator-tvm-vta] tmoreau89 commented on a change in pull request #9: [Hardware][OpenCL] Intelfocl support

2020-06-19 Thread GitBox
tmoreau89 commented on a change in pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r443088686 ## File path: config/vta_cost.py ## @@ -0,0 +1,102 @@ +# cost function for intelfocl 32*32 gemm version +def cal_cost(insn): +""" +Cal the r

[GitHub] [incubator-tvm-vta] tmoreau89 commented on a change in pull request #9: [Hardware][OpenCL] Intelfocl support

2020-06-19 Thread GitBox
tmoreau89 commented on a change in pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r443089629 ## File path: include/vta/hw_spec.h ## @@ -404,7 +259,7 @@ typedef struct { /*! \brief Destination index (indexes accum buffer) */ uint32_t ds

[GitHub] [incubator-tvm-vta] tmoreau89 commented on pull request #9: [Hardware][OpenCL] Intelfocl support

2020-06-19 Thread GitBox
tmoreau89 commented on pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-646916505 Thanks @zhanghaohit for the PR! I left a couple questions, but will need to review in more depth. One question: have you tested it on the Pynq board to see if some changes

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-06-19 Thread GitBox
tmoreau89 commented on a change in pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#discussion_r443090507 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -86,16 +86,19 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as();

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-06-19 Thread GitBox
tmoreau89 commented on a change in pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#discussion_r443090563 ## File path: vta/python/vta/environment.py ## @@ -241,7 +243,7 @@ def target_host(self): return "llvm -target=armv7-none-linux-gnuea

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-06-19 Thread GitBox
tmoreau89 commented on a change in pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#discussion_r443090782 ## File path: vta/tutorials/autotvm/tune_alu_vta.py ## @@ -0,0 +1,320 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5842: [VTA][OpenCL] Cloud FPGA support

2020-06-19 Thread GitBox
tmoreau89 commented on pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-646918453 Thanks @zhanghaohit for the contribution! I've taken a quick pass but will need to make a more thorough pass next. I believe it's important to check two things:

[incubator-tvm] branch master updated (11349c6 -> 2dcfd61)

2020-06-19 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 11349c6 [DOCS] Update has_dtype/has_shape to pattern lang doc (#5847) add 2dcfd61 [Target] Introduce Ta

[GitHub] [incubator-tvm] tqchen merged pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen merged pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646924759 Thanks @junrushao1994 ! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen edited a comment on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646924759 Thanks @junrushao1994 @MarisaKirisame @ashutoshparkhi This is an automated message from the Apache

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen edited a comment on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646924759 Thanks @junrushao1994 @ANSHUMAN87 ! This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-tvm] junrushao1994 opened a new pull request #5859: [Bugfix][Build] Fix building with LLVM-10 on macOS

2020-06-19 Thread GitBox
junrushao1994 opened a new pull request #5859: URL: https://github.com/apache/incubator-tvm/pull/5859 Per discussion: https://discuss.tvm.ai/t/latest-tvm-failed-to-build-on-mac-osx-with-llvm10/6993 The issue is found to be caused by LLVM's CMake returning nothing: `llvm_map_componen

[GitHub] [incubator-tvm] vinx13 commented on pull request #5758: Fix the meaning of conv{1,2}d_transpose output_padding parameter.

2020-06-19 Thread GitBox
vinx13 commented on pull request #5758: URL: https://github.com/apache/incubator-tvm/pull/5758#issuecomment-646937540 ping @abergeron This is an automated message from the Apache Git Service. To respond to the message, pleas