[GitHub] [incubator-tvm] merrymercy edited a comment on pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
merrymercy edited a comment on pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681#issuecomment-708199204 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-tvm] merrymercy commented on pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
merrymercy commented on pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681#issuecomment-708199204 @masahi It seems to be an internal error of the auto-scheduler rather than a flaky test. This is an au

[GitHub] [incubator-tvm] tmoreau89 opened a new pull request #6682: [DRAFT/WIP] Enabling vulkan in CI

2020-10-13 Thread GitBox
tmoreau89 opened a new pull request #6682: URL: https://github.com/apache/incubator-tvm/pull/6682 WIP This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-tvm] masahi commented on pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
masahi commented on pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681#issuecomment-708130142 hey @comaniac @merrymercy can you check if the error from evolutionary search test https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-6681/1/pipeline/ can be f

[GitHub] [incubator-tvm] jwfromm edited a comment on pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
jwfromm edited a comment on pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681#issuecomment-708121440 It seems very unlikely that these changes would cause that error. I'll try to rebuild. It looks like it passes locally as well. ---

[GitHub] [incubator-tvm] jwfromm commented on pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
jwfromm commented on pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681#issuecomment-708121440 It seems very unlikely that these changes would cause that error. I'll try to rebuild. This is an automat

[GitHub] [incubator-tvm] masahi commented on pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
masahi commented on pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681#issuecomment-708120348 There is an error from auto schedular test. Not sure if it is related or flaky This is an automated messag

[GitHub] [incubator-tvm] jwfromm opened a new pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
jwfromm opened a new pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681 This PR contains two otherwise unrelated bug fixes / improvements that allow us to import a class of segmentation models using the Onnx frontend. The first is the ability to broadcast the

[GitHub] [incubator-tvm] jwfromm commented on pull request #6681: [Relay][Frontend][Onnx] Allow A to B broadcasting of batch_matmul and reverse strided slice

2020-10-13 Thread GitBox
jwfromm commented on pull request #6681: URL: https://github.com/apache/incubator-tvm/pull/6681#issuecomment-708106363 @mbrookhart @masahi can you guys take a look at this PR? This is an automated message from the Apache Git

[GitHub] [incubator-tvm] merrymercy edited a comment on pull request #6671: [FIX,AUTOSCHEDULER] Fix auto_scheduler to run with multiprocessing's spawn start method

2020-10-13 Thread GitBox
merrymercy edited a comment on pull request #6671: URL: https://github.com/apache/incubator-tvm/pull/6671#issuecomment-708103769 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-tvm] merrymercy commented on pull request #6671: [FIX,AUTOSCHEDULER] Fix auto_scheduler to run with multiprocessing's spawn start method

2020-10-13 Thread GitBox
merrymercy commented on pull request #6671: URL: https://github.com/apache/incubator-tvm/pull/6671#issuecomment-708103769 Note that "spawn" is slower than "fork" (https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods). We should not change all default settings

[GitHub] [incubator-tvm] tqchen commented on pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
tqchen commented on pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#issuecomment-708084525 Thanks @spectrometerHBH I addressed your comment and added more explaination about bijective check, I also added your example as a testcase ---

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
tqchen commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r504330166 ## File path: src/arith/iter_affine_map.cc ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
tqchen commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r504331608 ## File path: src/arith/iter_affine_map.cc ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[incubator-tvm] branch main updated (7d805b5 -> e66b2e8)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 7d805b5 Fix format error in integrate.rst (#6677) add e66b2e8 Revert #5238 (#6680) No new revisions were

[GitHub] [incubator-tvm] tqchen merged pull request #6680: Revert #5238

2020-10-13 Thread GitBox
tqchen merged pull request #6680: URL: https://github.com/apache/incubator-tvm/pull/6680 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #6680: Revert #5238

2020-10-13 Thread GitBox
tqchen commented on pull request #6680: URL: https://github.com/apache/incubator-tvm/pull/6680#issuecomment-708080013 Thanks @ptrendx ! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
tqchen commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r504330166 ## File path: src/arith/iter_affine_map.cc ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [incubator-tvm] spectrometerHBH commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
spectrometerHBH commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r504328794 ## File path: src/arith/iter_affine_map.cc ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] electriclilies commented on issue #6624: [Relay] Module mutated in-place

2020-10-13 Thread GitBox
electriclilies commented on issue #6624: URL: https://github.com/apache/incubator-tvm/issues/6624#issuecomment-708048388 I am getting the exact same issue as you. It seems like the problem is being caused by the AlterOpLayout pass. For me, disabling the pass by changing `with tv

[GitHub] [incubator-tvm] tqchen commented on pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

2020-10-13 Thread GitBox
tqchen commented on pull request #6395: URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-708021897 Notably we will need to wait until the docker image is updated instead just the PR merge. I believe @jroesch might be working on an image update that we can let him chime i

[incubator-tvm] branch main updated (f196a81 -> 8d9ca2a)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f196a81 [CODEGEN][COREML] Call InferType explicitly in coreml test (#6676) add 8d9ca2a Adjust Vulkan que

[incubator-tvm] branch main updated (8d9ca2a -> d7fa9c1)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 8d9ca2a Adjust Vulkan queue selection and creation logic (#6662) add d7fa9c1 Install xgboost>=1.1.0 in CI

[incubator-tvm] branch main updated (d7fa9c1 -> 7d805b5)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from d7fa9c1 Install xgboost>=1.1.0 in CI container (#6679) add 7d805b5 Fix format error in integrate.rst (#66

[incubator-tvm] branch main updated (d7fa9c1 -> 7d805b5)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from d7fa9c1 Install xgboost>=1.1.0 in CI container (#6679) add 7d805b5 Fix format error in integrate.rst (#66

[incubator-tvm] branch main updated (8d9ca2a -> d7fa9c1)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 8d9ca2a Adjust Vulkan queue selection and creation logic (#6662) add d7fa9c1 Install xgboost>=1.1.0 in CI

[incubator-tvm] branch main updated (f196a81 -> 8d9ca2a)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f196a81 [CODEGEN][COREML] Call InferType explicitly in coreml test (#6676) add 8d9ca2a Adjust Vulkan que

[incubator-tvm] branch main updated (8d9ca2a -> d7fa9c1)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 8d9ca2a Adjust Vulkan queue selection and creation logic (#6662) add d7fa9c1 Install xgboost>=1.1.0 in CI

[incubator-tvm] branch main updated (f196a81 -> 8d9ca2a)

2020-10-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f196a81 [CODEGEN][COREML] Call InferType explicitly in coreml test (#6676) add 8d9ca2a Adjust Vulkan que

[GitHub] [incubator-tvm] tqchen merged pull request #6677: Fix format error in integrate.rst

2020-10-13 Thread GitBox
tqchen merged pull request #6677: URL: https://github.com/apache/incubator-tvm/pull/6677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #6679: [CI] Install xgboost>=1.1.0 in CI container

2020-10-13 Thread GitBox
tqchen commented on pull request #6679: URL: https://github.com/apache/incubator-tvm/pull/6679#issuecomment-708008813 This PR is now merged. cc @jroesch @tmoreau89 to followup on updating the docker images This is an automat

[GitHub] [incubator-tvm] tqchen closed issue #6673: [CI] Segfault in ci-gpu image related to xgboost version/dmlc-core

2020-10-13 Thread GitBox
tqchen closed issue #6673: URL: https://github.com/apache/incubator-tvm/issues/6673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] tqchen merged pull request #6679: [CI] Install xgboost>=1.1.0 in CI container

2020-10-13 Thread GitBox
tqchen merged pull request #6679: URL: https://github.com/apache/incubator-tvm/pull/6679 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #6662: Adjust Vulkan queue selection and creation logic

2020-10-13 Thread GitBox
tqchen commented on pull request #6662: URL: https://github.com/apache/incubator-tvm/pull/6662#issuecomment-708008426 Thanks @ishitatsuyuki ! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-tvm] tqchen merged pull request #6662: Adjust Vulkan queue selection and creation logic

2020-10-13 Thread GitBox
tqchen merged pull request #6662: URL: https://github.com/apache/incubator-tvm/pull/6662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
tqchen commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r504256910 ## File path: src/arith/iter_affine_map.cc ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
tqchen commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r504256910 ## File path: src/arith/iter_affine_map.cc ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [incubator-tvm] ptrendx commented on pull request #5238: fix to skip node not in graph.

2020-10-13 Thread GitBox
ptrendx commented on pull request #5238: URL: https://github.com/apache/incubator-tvm/pull/5238#issuecomment-707971211 @tqchen PR #6680 done. This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-tvm] ptrendx opened a new pull request #6680: Revert #5238

2020-10-13 Thread GitBox
ptrendx opened a new pull request #6680: URL: https://github.com/apache/incubator-tvm/pull/6680 As discussed in https://github.com/apache/incubator-tvm/pull/5238#issuecomment-707393506 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute

[GitHub] [incubator-tvm] trevor-m commented on pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

2020-10-13 Thread GitBox
trevor-m commented on pull request #6395: URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-707923371 > I think we can enable the test and merge after #6679 is landed since its pretty close already? Agreed, makes sense. I'll renable test once #6679 is merged.

[GitHub] [incubator-tvm] zhiics edited a comment on pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

2020-10-13 Thread GitBox
zhiics edited a comment on pull request #6395: URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-707922105 I think we can enable the test and merge after #6679 is landed since its pretty close already? Sorry for the back and forth. ---

[GitHub] [incubator-tvm] zhiics commented on pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

2020-10-13 Thread GitBox
zhiics commented on pull request #6395: URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-707922105 I think we can enable the test and merge after #6679 is landed since its pretty close already? This is an

[GitHub] [incubator-tvm] trevor-m commented on pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

2020-10-13 Thread GitBox
trevor-m commented on pull request #6395: URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-707919898 > I agree that we can merge it first. But before that, @trevor-m could you rebase against the master and run the tests again locally to see if all of them pass? I am not

[incubator-tvm] branch master created (now 98c2096)

2020-10-13 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. at 98c2096 [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics

[GitHub] [incubator-tvm] zhiics commented on pull request #6679: [CI] Install xgboost>=1.1.0 in CI container

2020-10-13 Thread GitBox
zhiics commented on pull request #6679: URL: https://github.com/apache/incubator-tvm/pull/6679#issuecomment-707896074 cc @tqchen This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
zhiics commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504131348 ## File path: python/tvm/relay/transform/transform.py ## @@ -666,7 +666,7 @@ def PartitionGraph(): return _ffi_api.PartitionGraph() -def Ann

[GitHub] [incubator-tvm] trevor-m opened a new pull request #6679: [CI] Install xgboost>=1.1.0 in CI container

2020-10-13 Thread GitBox
trevor-m opened a new pull request #6679: URL: https://github.com/apache/incubator-tvm/pull/6679 Fixes #6673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-tvm] gussmith23 commented on pull request #6678: Add BatchNormAttrs Rust bindings

2020-10-13 Thread GitBox
gussmith23 commented on pull request #6678: URL: https://github.com/apache/incubator-tvm/pull/6678#issuecomment-707874354 PTAL @jroesch This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-tvm] gussmith23 opened a new pull request #6678: Add BatchNormAttrs Rust bindings

2020-10-13 Thread GitBox
gussmith23 opened a new pull request #6678: URL: https://github.com/apache/incubator-tvm/pull/6678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-tvm] comaniac commented on pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
comaniac commented on pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#issuecomment-707867942 This solution looks too ad hoc to me. From the semantic of the changes, I think this PR can be generalized to "improve the annotate target pass to annotate non-call ops t

[GitHub] [incubator-tvm] leandron commented on issue #6668: coremltools==4.0 breaks "test_coreml_codegen.py::test_annotate"

2020-10-13 Thread GitBox
leandron commented on issue #6668: URL: https://github.com/apache/incubator-tvm/issues/6668#issuecomment-707866738 Thanks @kazum @zhiics This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
comaniac commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504078734 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -327,6 +327,42 @@ def after(): assert tvm.ir.structural_equal(expected, re

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
mbaret commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504073541 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -327,6 +327,42 @@ def after(): assert tvm.ir.structural_equal(expected, resu

[GitHub] [incubator-tvm] zhiics commented on pull request #6676: [CODEGEN][COREML] Call InferType explicitly in coreml test

2020-10-13 Thread GitBox
zhiics commented on pull request #6676: URL: https://github.com/apache/incubator-tvm/pull/6676#issuecomment-707838233 Thanks @kazum This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
comaniac commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504066854 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -327,6 +327,42 @@ def after(): assert tvm.ir.structural_equal(expected, re

[GitHub] [incubator-tvm] zhiics merged pull request #6676: [CODEGEN][COREML] Call InferType explicitly in coreml test

2020-10-13 Thread GitBox
zhiics merged pull request #6676: URL: https://github.com/apache/incubator-tvm/pull/6676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch main updated: [CODEGEN][COREML] Call InferType explicitly in coreml test (#6676)

2020-10-13 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/main by this push: new f196a81 [CODEGEN][COREML] Call InferType expli

[GitHub] [incubator-tvm] zhiics closed issue #6668: coremltools==4.0 breaks "test_coreml_codegen.py::test_annotate"

2020-10-13 Thread GitBox
zhiics closed issue #6668: URL: https://github.com/apache/incubator-tvm/issues/6668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
comaniac commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504063626 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -327,6 +327,42 @@ def after(): assert tvm.ir.structural_equal(expected, re

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
mbaret commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504054803 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -327,6 +327,42 @@ def after(): assert tvm.ir.structural_equal(expected, resu

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
manupa-arm commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504052671 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -327,6 +327,42 @@ def after(): assert tvm.ir.structural_equal(expected,

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
mbaret commented on a change in pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504044962 ## File path: tests/python/relay/test_pass_annotate_target.py ## @@ -327,6 +327,42 @@ def after(): assert tvm.ir.structural_equal(expected, resu

[GitHub] [incubator-tvm] spectrometerHBH commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
spectrometerHBH commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r504010733 ## File path: src/arith/iter_affine_map.cc ## @@ -0,0 +1,703 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[GitHub] [incubator-tvm] qixiuai opened a new pull request #6677: Fix format error in integrate.rst

2020-10-13 Thread GitBox
qixiuai opened a new pull request #6677: URL: https://github.com/apache/incubator-tvm/pull/6677 Just fixed format errors in [the current doc](https://tvm.apache.org/docs/deploy/integrate.html). @tqchen This is an automated

[GitHub] [incubator-tvm] spectrometerHBH commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
spectrometerHBH commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r503749804 ## File path: include/tvm/arith/iter_affine_map.h ## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6662: Adjust Vulkan queue selection and creation logic

2020-10-13 Thread GitBox
tqchen commented on a change in pull request #6662: URL: https://github.com/apache/incubator-tvm/pull/6662#discussion_r503934106 ## File path: src/runtime/vulkan/vulkan.cc ## @@ -490,33 +491,24 @@ VulkanDeviceAPI::VulkanDeviceAPI() { std::vector all_phy_devs(phy_dev_count);

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6663: [AutoScheduler] Add task scheduler

2020-10-13 Thread GitBox
jcf94 commented on a change in pull request #6663: URL: https://github.com/apache/incubator-tvm/pull/6663#discussion_r503867002 ## File path: python/tvm/auto_scheduler/task_scheduler.py ## @@ -0,0 +1,452 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [incubator-tvm] spectrometerHBH commented on a change in pull request #6667: [ARITH] Introduce iterator (quasi)affine map detection.

2020-10-13 Thread GitBox
spectrometerHBH commented on a change in pull request #6667: URL: https://github.com/apache/incubator-tvm/pull/6667#discussion_r503749804 ## File path: include/tvm/arith/iter_affine_map.h ## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] cbalint13 commented on a change in pull request #6675: [QNN] Optimize requantize for power of 2 and bug in dequantize

2020-10-13 Thread GitBox
cbalint13 commented on a change in pull request #6675: URL: https://github.com/apache/incubator-tvm/pull/6675#discussion_r503732613 ## File path: src/relay/qnn/op/requantize.cc ## @@ -155,17 +155,20 @@ Expr RequantizeLower(const Expr& input_tensor, const Expr& input_scale,