[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-20 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r712574114 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,118 @@ namespace tvm { namespace runtime { namespace detail { +namespace { +constexpr const

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-18 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r711621895 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,118 @@ namespace tvm { namespace runtime { namespace detail { +namespace { +constexpr const

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-18 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r711610916 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,118 @@ namespace tvm { namespace runtime { namespace detail { +namespace { +constexpr const

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-18 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r711610916 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,118 @@ namespace tvm { namespace runtime { namespace detail { +namespace { +constexpr const

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-18 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r711610622 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,118 @@ namespace tvm { namespace runtime { namespace detail { +namespace { +constexpr const

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-18 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r711610524 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,118 @@ namespace tvm { namespace runtime { namespace detail { +namespace { +constexpr const

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-18 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r711610491 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,118 @@ namespace tvm { namespace runtime { namespace detail { +namespace { +constexpr const

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-18 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r711610329 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,115 @@ namespace tvm { namespace runtime { namespace detail { +// Parse \p opt_spec as a VLOG

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-16 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r710539137 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,127 @@ namespace tvm { namespace runtime { namespace detail { +std::unordered_map

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-16 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r710502051 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,127 @@ namespace tvm { namespace runtime { namespace detail { +std::unordered_map

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-16 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r710501694 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,127 @@ namespace tvm { namespace runtime { namespace detail { +std::unordered_map

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-16 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r710500504 ## File path: include/tvm/runtime/logging.h ## @@ -409,6 +416,68 @@ inline bool DebugLoggingEnabled() { return state == 1; } +/*! \brief Helpers for

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-16 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r710497929 ## File path: include/tvm/runtime/logging.h ## @@ -409,6 +416,68 @@ inline bool DebugLoggingEnabled() { return state == 1; } +/*! \brief Helpers for

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-16 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r710497333 ## File path: include/tvm/runtime/logging.h ## @@ -129,8 +132,9 @@ * a = ... * b = ... * // if quit_on_assertion is true, if a==b, continue,

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-16 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r710487260 ## File path: include/tvm/runtime/logging.h ## @@ -409,6 +416,68 @@ inline bool DebugLoggingEnabled() { return state == 1; } +/*! \brief Helpers for

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709643127 ## File path: include/tvm/runtime/logging.h ## @@ -409,6 +416,68 @@ inline bool DebugLoggingEnabled() { return state == 1; } +/*! \brief Helpers for

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709543170 ## File path: include/tvm/runtime/logging.h ## @@ -395,10 +399,13 @@ class LogMessageVoidify { inline bool DebugLoggingEnabled() { static int state =

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709540519 ## File path: include/tvm/runtime/logging.h ## @@ -409,6 +416,68 @@ inline bool DebugLoggingEnabled() { return state == 1; } +/*! \brief Helpers for

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709539416 ## File path: include/tvm/runtime/logging.h ## @@ -395,10 +399,13 @@ class LogMessageVoidify { inline bool DebugLoggingEnabled() { static int state =

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709538852 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,127 @@ namespace tvm { namespace runtime { namespace detail { +std::unordered_map

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709537682 ## File path: include/tvm/runtime/logging.h ## @@ -129,8 +132,9 @@ * a = ... * b = ... * // if quit_on_assertion is true, if a==b, continue,

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709537186 ## File path: CMakeLists.txt ## @@ -575,7 +575,7 @@ endif() # Create the `cpptest` target if we can find GTest. If not, we create dummy # targets that

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-14 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r708736829 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,121 @@ namespace tvm { namespace runtime { namespace detail { +std::unordered_map

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-14 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r708736309 ## File path: src/runtime/logging.cc ## @@ -166,10 +167,121 @@ namespace tvm { namespace runtime { namespace detail { +std::unordered_map

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-14 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r708733988 ## File path: include/tvm/runtime/logging.h ## @@ -549,8 +644,10 @@ TVM_CHECK_FUNC(_NE, !=) (x) : (x)) // NOLINT(*) } // namespace runtime + //

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-14 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r708733647 ## File path: include/tvm/runtime/logging.h ## @@ -409,6 +413,68 @@ inline bool DebugLoggingEnabled() { return state == 1; } +/*! \brief Helpers for

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-14 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r708733308 ## File path: include/tvm/runtime/logging.h ## @@ -409,6 +413,68 @@ inline bool DebugLoggingEnabled() { return state == 1; } +/*! \brief Helpers for

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-14 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r708732062 ## File path: include/tvm/runtime/logging.h ## @@ -395,8 +399,8 @@ class LogMessageVoidify { inline bool DebugLoggingEnabled() { static int state = 0;