[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611754#comment-17611754
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263997555
> > Generally, things like 'internal' are not exported since they are not
part of a proper API or SPI.
>
> In OSGi world it is indeed. But as I wrote in description in Wicket they
ar
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611750#comment-17611750
]
ASF GitHub Bot commented on WICKET-6999:
dstoch commented on PR #540:
URL: https
dstoch commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263991579
> Generally, things like 'internal' are not exported since they are not part
of a proper API or SPI.
In OSGi world it is indeed. But as I wrote in description in Wicket they are
part o
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611747#comment-17611747
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263988806
> I described a problem in this issue description in JIRA. Eg. without
exporting org.apache.wicket.markup.html.internal package is not possible to use
Wicket in OSGi. Do you really use it i
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611738#comment-17611738
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263970031
> I described a problem in this issue description in JIRA. Eg. without
exporting org.apache.wicket.markup.html.internal package is not possible to use
Wicket in OSGi. Do you really use it i
dstoch commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263964567
I described a problem in this issue description in JIRA. Eg. without
exporting org.apache.wicket.markup.html.internal package is not possible to use
Wicket in OSGi. Do you really use it in OS
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611736#comment-17611736
]
ASF GitHub Bot commented on WICKET-6999:
dstoch commented on PR #540:
URL: https
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263959524
> MANIFESTs are broken since Wicket 8.x, so it is not a good evidence ;).
What is broken? We've been running unmodified bundles on Wicket 8.x for
years.
--
This is an automated mes
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611735#comment-17611735
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611734#comment-17611734
]
ASF GitHub Bot commented on WICKET-6999:
dstoch commented on PR #540:
URL: https
dstoch commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263950659
> @dstoch the actual _application_ bundle would need to do that as they
require. Further backing evidence is the Wicket 8.x bundles do not have
'DynamicImport-Package: *' specified.
MA
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611733#comment-17611733
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263945374
> > I've removed the DynamicImport-Package: * rule. I think that should only
be needed by the application wars to support modular pages and allow Wicket to
instantiate those classes from th
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611729#comment-17611729
]
ASF GitHub Bot commented on WICKET-6999:
dstoch commented on PR #540:
URL: https
dstoch commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263934816
> I've removed the DynamicImport-Package: * rule. I think that should only
be needed by the application wars to support modular pages and allow Wicket to
instantiate those classes from the wa
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263915218
I've removed the DynamicImport-Package: * rule. I think that should only be
needed by the application wars to support modular pages and allow Wicket to
instantiate those classes from the wa
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611719#comment-17611719
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611716#comment-17611716
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263893361
NOTE: Generate export packages list for wicket-core
```
% find . -name "*.java" -exec grep "^package" {} \; | cut -f2 -d" " | sort -u
```
--
This is an automated message from
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611710#comment-17611710
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263883424
wicket-request:
```
Export-Package =
org.apache.wicket.request;version=10.0.0,
org.apache.wicket.request.flow;version=10.0.0,
org.apache.wicket.request.hand
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611704#comment-17611704
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263869054
Commit f2edd61 fixes bundle plugin execution phase+goal to generate correct
MANIFEST and allow for enforcer plugin to be maintained.
--
This is an automated message from the Apache Git Se
mattrpav commented on PR #540:
URL: https://github.com/apache/wicket/pull/540#issuecomment-1263843086
At issue is the bundle plugin runs different at various maven phases. When
combined with the enforcer plugin to restrict config to an execution, the
bundle plugin definition will get chatty
[
https://issues.apache.org/jira/browse/WICKET-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611697#comment-17611697
]
ASF GitHub Bot commented on WICKET-6999:
mattrpav commented on PR #540:
URL: htt
28 matches
Mail list logo
