[GitHub] [incubator-zipkin-website] dependabot[bot] opened a new pull request #20: Bump nokogiri from 1.10.3 to 1.10.5

2019-11-01 Thread GitBox
dependabot[bot] opened a new pull request #20: Bump nokogiri from 1.10.3 to 1.10.5 URL: https://github.com/apache/incubator-zipkin-website/pull/20 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.3 to 1.10.5. Release notes *Sourced from [nokogiri's relea

[GitHub] [incubator-zipkin] tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component

2019-06-18 Thread GitBox
tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295106528 ## File path: zipkin-lens/src/components/GlobalSearch/GlobalSearchConditionKey.jsx ## @@ -0

[GitHub] [incubator-zipkin] tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component

2019-06-18 Thread GitBox
tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295106528 ## File path: zipkin-lens/src/components/GlobalSearch/GlobalSearchConditionKey.jsx ## @@ -0

[GitHub] [incubator-zipkin] tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component

2019-06-18 Thread GitBox
tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295104584 ## File path: zipkin-lens/package.json ## @@ -63,17 +63,21 @@ "webpack-dev-server": "^

[GitHub] [incubator-zipkin] wuchenglong1 opened a new issue #2634: can zipkin provide the function of collecting some specific request trace?

2019-06-18 Thread GitBox
wuchenglong1 opened a new issue #2634: can zipkin provide the function of collecting some specific request trace? URL: https://github.com/apache/incubator-zipkin/issues/2634 now zipkin provides the sampler,but sometimes i want to collect some specific request trace by configuration file fo

[GitHub] [incubator-zipkin] tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component

2019-06-18 Thread GitBox
tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295104396 ## File path: zipkin-lens/src/colors/index.js ## @@ -11,20 +11,16 @@ * or implied. See th

[GitHub] [incubator-zipkin] tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component

2019-06-18 Thread GitBox
tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295103996 ## File path: zipkin-lens/scss/main.scss ## @@ -39,16 +39,15 @@ $fa-font-path: "~@fortaweso

[GitHub] [incubator-zipkin] tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component

2019-06-18 Thread GitBox
tacigar commented on a change in pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633#discussion_r295103383 ## File path: zipkin-lens/package.json ## @@ -63,17 +63,21 @@ "webpack-dev-server": "^

[GitHub] [incubator-zipkin] adriancole commented on issue #2632: Fix ThrottledStorageComponent not passing through health check

2019-06-18 Thread GitBox
adriancole commented on issue #2632: Fix ThrottledStorageComponent not passing through health check URL: https://github.com/apache/incubator-zipkin/pull/2632#issuecomment-503126004 Ack. thanks for mentioning but I think this is the better optimization On Mon, Jun 17, 2019, 10:52 PM l

[GitHub] [incubator-zipkin] koushik9951 commented on issue #2627: HTTPS/SSL failing for 2.14 zipkin

2019-06-18 Thread GitBox
koushik9951 commented on issue #2627: HTTPS/SSL failing for 2.14 zipkin URL: https://github.com/apache/incubator-zipkin/issues/2627#issuecomment-503013821 @adriancole: Thanks for updating with SSL details This is an automate

[GitHub] [incubator-zipkin] tacigar opened a new pull request #2633: [WIP] Use Material-UI for GlobalSearch component

2019-06-18 Thread GitBox
tacigar opened a new pull request #2633: [WIP] Use Material-UI for GlobalSearch component URL: https://github.com/apache/incubator-zipkin/pull/2633 Close PR: #2613 GlobalSearch component is very complex now. In order to eliminate this complexity, I'm trying the following things.

[GitHub] [incubator-zipkin] tacigar closed pull request #2613: [WIP] Refactor global search component

2019-06-18 Thread GitBox
tacigar closed pull request #2613: [WIP] Refactor global search component URL: https://github.com/apache/incubator-zipkin/pull/2613 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-zipkin] tacigar commented on issue #2613: [WIP] Refactor global search component

2019-06-18 Thread GitBox
tacigar commented on issue #2613: [WIP] Refactor global search component URL: https://github.com/apache/incubator-zipkin/pull/2613#issuecomment-503002500 Sorry, I'll close this PR and make an other PR. This is an automated mes

[GitHub] [incubator-zipkin] lambcode commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check

2019-06-17 Thread GitBox
lambcode commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check URL: https://github.com/apache/incubator-zipkin/pull/2632#discussion_r294339180 ## File path: zipkin-server/src/test/kotlin/zipkin2/server/internal/throttle/Throttle

[GitHub] [incubator-zipkin] lambcode commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check

2019-06-17 Thread GitBox
lambcode commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check URL: https://github.com/apache/incubator-zipkin/pull/2632#discussion_r294338327 ## File path: zipkin/src/main/java/zipkin2/Component.java ## @@ -38,6 +38,11

[GitHub] [incubator-zipkin] tacigar commented on issue #2624: fix(ui): display user friendly span duration on reload

2019-06-17 Thread GitBox
tacigar commented on issue #2624: fix(ui): display user friendly span duration on reload URL: https://github.com/apache/incubator-zipkin/pull/2624#issuecomment-502601173 Cool!! Thank you!! This is an automated message from

[GitHub] [incubator-zipkin] adriancole edited a comment on issue #2627: HTTPS/SSL failing for 2.14 zipkin

2019-06-17 Thread GitBox
adriancole edited a comment on issue #2627: HTTPS/SSL failing for 2.14 zipkin URL: https://github.com/apache/incubator-zipkin/issues/2627#issuecomment-502591653 Hi @koushik9951 we have a related issue for armeria to accept spring boot defaults for TLS configuration. Meanwhile, here are wor

[GitHub] [incubator-zipkin] adriancole closed issue #2627: HTTPS/SSL failing for 2.14 zipkin

2019-06-17 Thread GitBox
adriancole closed issue #2627: HTTPS/SSL failing for 2.14 zipkin URL: https://github.com/apache/incubator-zipkin/issues/2627 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-zipkin] adriancole commented on issue #2627: HTTPS/SSL failing for 2.14 zipkin

2019-06-17 Thread GitBox
adriancole commented on issue #2627: HTTPS/SSL failing for 2.14 zipkin URL: https://github.com/apache/incubator-zipkin/issues/2627#issuecomment-502591653 Hi @koushik9951 we have a related issue for armeria to accept spring boot defaults for TLS configuration. Meanwhile, here are working in

[GitHub] [incubator-zipkin-brave-karaf] adriancole merged pull request #43: Restores OpenZipkin publishing configuration

2019-06-16 Thread GitBox
adriancole merged pull request #43: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/43 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-zipkin-brave-karaf] adriancole opened a new pull request #43: Restores OpenZipkin publishing configuration

2019-06-16 Thread GitBox
adriancole opened a new pull request #43: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/43 This reverts back to OpenZipkin publishing configuration. See https://github.com/apache/incubator-zipkin/issues/2629 ---

[GitHub] [incubator-zipkin-b3-propagation] adriancole merged pull request #35: Inlines resources hosted on ASF wiki and reverts disclaimers

2019-06-15 Thread GitBox
adriancole merged pull request #35: Inlines resources hosted on ASF wiki and reverts disclaimers URL: https://github.com/apache/incubator-zipkin-b3-propagation/pull/35 This is an automated message from the Apache Git Service

[GitHub] [incubator-zipkin-b3-propagation] adriancole opened a new pull request #35: Inlines resources hosted on ASF wiki and reverts disclaimers

2019-06-15 Thread GitBox
adriancole opened a new pull request #35: Inlines resources hosted on ASF wiki and reverts disclaimers URL: https://github.com/apache/incubator-zipkin-b3-propagation/pull/35 See https://github.com/apache/incubator-zipkin/issues/2629 -

[GitHub] [incubator-zipkin] tacigar commented on issue #2613: [WIP] Refactor global search component

2019-06-15 Thread GitBox
tacigar commented on issue #2613: [WIP] Refactor global search component URL: https://github.com/apache/incubator-zipkin/pull/2613#issuecomment-502388827 OK! Thank you for your information. I'll update license myself 🙇

[GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check

2019-06-14 Thread GitBox
adriancole commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check URL: https://github.com/apache/incubator-zipkin/pull/2632#discussion_r294024257 ## File path: zipkin/src/main/java/zipkin2/Component.java ## @@ -38,6 +38,

[GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check

2019-06-14 Thread GitBox
adriancole commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check URL: https://github.com/apache/incubator-zipkin/pull/2632#discussion_r294024292 ## File path: zipkin-server/src/test/kotlin/zipkin2/server/internal/throttle/Thrott

[GitHub] [incubator-zipkin] lambcode opened a new pull request #2632: Fix ThrottledStorageComponent not passing through health check

2019-06-14 Thread GitBox
lambcode opened a new pull request #2632: Fix ThrottledStorageComponent not passing through health check URL: https://github.com/apache/incubator-zipkin/pull/2632 When using the ThrottledStorageComponent the health check (/actuator/health) always reports "UP" even when the backing storage

[GitHub] [incubator-zipkin] jcchavezs commented on issue #2624: fix(ui): display user friendly span duration on reload

2019-06-14 Thread GitBox
jcchavezs commented on issue #2624: fix(ui): display user friendly span duration on reload URL: https://github.com/apache/incubator-zipkin/pull/2624#issuecomment-502082851 It makes me happy too. tor. 13. jun. 2019, 12:36 skrev Adrian Cole : > this makes me happy :) > > —

[GitHub] [incubator-zipkin] adriancole merged pull request #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-14 Thread GitBox
adriancole merged pull request #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-zipkin] adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-14 Thread GitBox
adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-502010752 rebased on master This is an automated message from the

[GitHub] [incubator-zipkin] anuraaga commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-14 Thread GitBox
anuraaga commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-502007349 To keep the variables low, reverted the Guava downgrade since not sure what version is actually correct (Elasticsearch star

[GitHub] [incubator-zipkin] adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-14 Thread GitBox
adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-501996492 will recut zipkin on green with this This is an automate

[GitHub] [incubator-zipkin] adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-14 Thread GitBox
adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-501993729 cool. on the guava downgrade, the most important thing would be checking zipkin-gcp still runs.. I think there's some dod

[GitHub] [incubator-zipkin] anuraaga commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
anuraaga commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-501993059 We were releasing `msg.content()`, which isn't correct when the gzip converter replaces that with a different `content` so

[GitHub] [incubator-zipkin-reporter-java] adriancole merged pull request #148: Restores OpenZipkin publishing configuration

2019-06-13 Thread GitBox
adriancole merged pull request #148: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-reporter-java/pull/148 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-zipkin-reporter-java] adriancole opened a new pull request #148: Restores OpenZipkin publishing configuration

2019-06-13 Thread GitBox
adriancole opened a new pull request #148: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-reporter-java/pull/148 This reverts back to OpenZipkin publishing configuration. See https://github.com/apache/incubator-zipkin/issues/2629 ---

[GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
adriancole commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#discussion_r293387701 ## File path: pom.xml ## @@ -48,9 +48,9 @@ ${project.basedir} -0.86.0 +

[GitHub] [incubator-zipkin] anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#discussion_r293386638 ## File path: pom.xml ## @@ -48,9 +48,9 @@ ${project.basedir} -0.86.0 +

[GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
adriancole commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#discussion_r293384946 ## File path: zipkin-collector/scribe/src/main/java/zipkin2/collector/scribe/ScribeInboundHandl

[GitHub] [incubator-zipkin] anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#discussion_r293384143 ## File path: zipkin-collector/scribe/src/main/java/zipkin2/collector/scribe/ScribeInboundHandler

[GitHub] [incubator-zipkin] anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#discussion_r293384482 ## File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java #

[GitHub] [incubator-zipkin] adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-501706499 fyi for sanity I did build and test right before this commit to update, including running independently and using brave t

[GitHub] [incubator-zipkin] adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-501703270 The code involved in gzip isn't in this change, btw, it is here: https://github.com/apache/incubator-zipkin/blob/m

[GitHub] [incubator-zipkin] adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
adriancole commented on issue #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631#issuecomment-501702373 @anuraaga @trustin This update fails with a message like this. It fails when gzip is used, either `ITZipkinHttpCollector

[GitHub] [incubator-zipkin] adriancole opened a new pull request #2631: Updates to Armeria 0.87 and addresses deprecations

2019-06-13 Thread GitBox
adriancole opened a new pull request #2631: Updates to Armeria 0.87 and addresses deprecations URL: https://github.com/apache/incubator-zipkin/pull/2631 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-zipkin] adriancole merged pull request #2630: Restores OpenZipkin publishing configuration

2019-06-13 Thread GitBox
adriancole merged pull request #2630: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin/pull/2630 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-zipkin] adriancole commented on issue #2613: [WIP] Refactor global search component

2019-06-13 Thread GitBox
adriancole commented on issue #2613: [WIP] Refactor global search component URL: https://github.com/apache/incubator-zipkin/pull/2613#issuecomment-501666288 @tacigar I am sorry that the switch back to openzipkin will make this conflict a lot. If you want me to fix your branch and rebase I c

[GitHub] [incubator-zipkin] adriancole commented on issue #2624: fix(ui): display user friendly span duration on reload

2019-06-13 Thread GitBox
adriancole commented on issue #2624: fix(ui): display user friendly span duration on reload URL: https://github.com/apache/incubator-zipkin/pull/2624#issuecomment-501665819 this makes me happy :) This is an automated message

[GitHub] [incubator-zipkin] adriancole closed issue #2612: User friendly span duration on reload

2019-06-13 Thread GitBox
adriancole closed issue #2612: User friendly span duration on reload URL: https://github.com/apache/incubator-zipkin/issues/2612 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-zipkin] adriancole merged pull request #2624: fix(ui): display user friendly span duration on reload

2019-06-13 Thread GitBox
adriancole merged pull request #2624: fix(ui): display user friendly span duration on reload URL: https://github.com/apache/incubator-zipkin/pull/2624 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-zipkin] adriancole opened a new pull request #2630: Restores OpenZipkin publishing configuration

2019-06-13 Thread GitBox
adriancole opened a new pull request #2630: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin/pull/2630 This reverts back to OpenZipkin publishing configuration. See https://github.com/apache/incubator-zipkin/issues/2629 ---

[GitHub] [incubator-zipkin-brave-cassandra] adriancole merged pull request #24: Restores OpenZipkin publishing configuration

2019-06-13 Thread GitBox
adriancole merged pull request #24: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-brave-cassandra/pull/24 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-zipkin-brave-cassandra] adriancole opened a new pull request #24: Restores OpenZipkin publishing configuration

2019-06-13 Thread GitBox
adriancole opened a new pull request #24: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-brave-cassandra/pull/24 This reverts back to OpenZipkin publishing configuration. See https://github.com/apache/incubator-zipkin/issues/2629 ---

[GitHub] [incubator-zipkin] adriancole commented on issue #2629: Revert migration to the ASF

2019-06-13 Thread GitBox
adriancole commented on issue #2629: Revert migration to the ASF URL: https://github.com/apache/incubator-zipkin/issues/2629#issuecomment-501621694 note: until the repositories are moved back to the openzipkin org, our deployment automation will fail (ex bintray will reject uploads even wi

[GitHub] [incubator-zipkin-api] adriancole merged pull request #76: Restores OpenZipkin publishing configuration (#12)

2019-06-13 Thread GitBox
adriancole merged pull request #76: Restores OpenZipkin publishing configuration (#12) URL: https://github.com/apache/incubator-zipkin-api/pull/76 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-zipkin-api] adriancole opened a new pull request #76: Restores OpenZipkin publishing configuration (#12)

2019-06-13 Thread GitBox
adriancole opened a new pull request #76: Restores OpenZipkin publishing configuration (#12) URL: https://github.com/apache/incubator-zipkin-api/pull/76 This reverts back to OpenZipkin publishing configuration. See https://github.com/apache/incubator-zipkin/issues/2629 -

[GitHub] [incubator-zipkin-layout-factory] adriancole merged pull request #12: Restores OpenZipkin publishing configuration

2019-06-12 Thread GitBox
adriancole merged pull request #12: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-layout-factory/pull/12 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-zipkin-layout-factory] adriancole opened a new pull request #12: Restores OpenZipkin publishing configuration

2019-06-12 Thread GitBox
adriancole opened a new pull request #12: Restores OpenZipkin publishing configuration URL: https://github.com/apache/incubator-zipkin-layout-factory/pull/12 This reverts back to OpenZipkin publishing configuration. See https://github.com/apache/incubator-zipkin/issues/2629

[GitHub] [incubator-zipkin] making commented on issue #2364: endTs remains unchanged in Zipkin Lens

2019-06-12 Thread GitBox
making commented on issue #2364: endTs remains unchanged in Zipkin Lens URL: https://github.com/apache/incubator-zipkin/issues/2364#issuecomment-501531929 A current workaround to update `endTs` is: Click 🔍 => Click "Search" => Reload the browser => click 🔍 again Pretty inconv

[GitHub] [incubator-zipkin] jcchavezs commented on issue #2364: endTs remains unchanged in Zipkin Lens

2019-06-12 Thread GitBox
jcchavezs commented on issue #2364: endTs remains unchanged in Zipkin Lens URL: https://github.com/apache/incubator-zipkin/issues/2364#issuecomment-501528049 +1 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-zipkin] adriancole commented on issue #2629: Revert migration to the ASF

2019-06-12 Thread GitBox
adriancole commented on issue #2629: Revert migration to the ASF URL: https://github.com/apache/incubator-zipkin/issues/2629#issuecomment-501519711 Added reference to https://issues.apache.org/jira/browse/INFRA-18604 This is

[GitHub] [incubator-zipkin] adriancole commented on issue #2629: Revert migration to the ASF

2019-06-12 Thread GitBox
adriancole commented on issue #2629: Revert migration to the ASF URL: https://github.com/apache/incubator-zipkin/issues/2629#issuecomment-501517503 added rough draft of steps for the website This is an automated message from

[GitHub] [incubator-zipkin] adriancole opened a new issue #2629: Revert migration to the ASF

2019-06-12 Thread GitBox
adriancole opened a new issue #2629: Revert migration to the ASF URL: https://github.com/apache/incubator-zipkin/issues/2629 As you know, [we voted to withdraw](https://lists.apache.org/thread.html/e3d911151dff081145886b620145924067267de998da40495b1f996b@%3Cdev.zipkin.apache.org%3E) from t

[GitHub] [incubator-zipkin] adriancole closed issue #401: Document how to instrument other servers

2019-06-12 Thread GitBox
adriancole closed issue #401: Document how to instrument other servers URL: https://github.com/apache/incubator-zipkin/issues/401 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-zipkin] adriancole commented on issue #401: Document how to instrument other servers

2019-06-12 Thread GitBox
adriancole commented on issue #401: Document how to instrument other servers URL: https://github.com/apache/incubator-zipkin/issues/401#issuecomment-501506568 super old This is an automated message from the Apache Git Service

[GitHub] [incubator-zipkin] adriancole closed issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题

2019-06-12 Thread GitBox
adriancole closed issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题 URL: https://github.com/apache/incubator-zipkin/issues/2626 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-zipkin] adriancole commented on issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题

2019-06-12 Thread GitBox
adriancole commented on issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题 URL: https://github.com/apache/incubator-zipkin/issues/2626#issuecomment-501213927 This affects your callback by wrapping it. This allows you to use things like CurrentSpanCustomizer. This shouldn't cause a timeout. you

[GitHub] [incubator-zipkin] adriancole closed issue #2628: Zipkin issues with MariaDB Integration

2019-06-12 Thread GitBox
adriancole closed issue #2628: Zipkin issues with MariaDB Integration URL: https://github.com/apache/incubator-zipkin/issues/2628 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-zipkin] adriancole commented on issue #2628: Zipkin issues with MariaDB Integration

2019-06-12 Thread GitBox
adriancole commented on issue #2628: Zipkin issues with MariaDB Integration URL: https://github.com/apache/incubator-zipkin/issues/2628#issuecomment-501212457 you are commenting about an old version of zipkin, about a custom server configuration, and about a configuration known to not be p

[GitHub] [incubator-zipkin] harishkadamudi opened a new issue #2628: Zipkin issues with MariaDB Integration

2019-06-12 Thread GitBox
harishkadamudi opened a new issue #2628: Zipkin issues with MariaDB Integration URL: https://github.com/apache/incubator-zipkin/issues/2628 ## Describe the Bug **Zipkin integrated with MariaDB creating duplicate Indexes** We have Zipkin server integrated with MariaDB. Of late, w

[GitHub] [incubator-zipkin] wuchenglong1 commented on issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题

2019-06-11 Thread GitBox
wuchenglong1 commented on issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题 URL: https://github.com/apache/incubator-zipkin/issues/2626#issuecomment-501143223 i mean that the following codes of the TracingFilter.class affect my own business codes: Futurefuture=rpcContext.getFuture();

[GitHub] [incubator-zipkin] koushik9951 opened a new issue #2627: HTTPS/SSL failing for 2.14 zipkin

2019-06-11 Thread GitBox
koushik9951 opened a new issue #2627: HTTPS/SSL failing for 2.14 zipkin URL: https://github.com/apache/incubator-zipkin/issues/2627 I am trying to enable HTTPS for 2.14 Zipkin version, but SSL arguments are not picking by the jar file, whereas for 2.12 version HTTPS is working fine.

[GitHub] [incubator-zipkin] wuchenglong1 opened a new issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题

2019-06-11 Thread GitBox
wuchenglong1 opened a new issue #2626: zipkin 使用brave拦截RPC异步请求影响业务代码的问题 URL: https://github.com/apache/incubator-zipkin/issues/2626 使用brave整合dubbo,使用到了brave-instrumentation-dubbo-rpc.xxx.jar,我们应用在使用dubbo的onreturn异步调用时,发现采集埋点程序的配置导致了业务代码的返回结果,经过排查发现是brave-instrumentation-dubbo-rpc.xxx.jar里面的

[GitHub] [incubator-zipkin-api] devinsba commented on issue #75: Swagger link is broken

2019-06-11 Thread GitBox
devinsba commented on issue #75: Swagger link is broken URL: https://github.com/apache/incubator-zipkin-api/issues/75#issuecomment-500950408 Thanks @narayaruna closed by ee6e17392d320a19d1613a2ac7a7a3d2722e25e5 This is an aut

[GitHub] [incubator-zipkin-api] devinsba closed issue #75: Swagger link is broken

2019-06-11 Thread GitBox
devinsba closed issue #75: Swagger link is broken URL: https://github.com/apache/incubator-zipkin-api/issues/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-zipkin-api] narayaruna commented on issue #75: Swagger link is broken

2019-06-11 Thread GitBox
narayaruna commented on issue #75: Swagger link is broken URL: https://github.com/apache/incubator-zipkin-api/issues/75#issuecomment-500946566 @adriancole This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-zipkin-api] narayaruna opened a new issue #75: Swagger link is broken

2019-06-11 Thread GitBox
narayaruna opened a new issue #75: Swagger link is broken URL: https://github.com/apache/incubator-zipkin-api/issues/75 The link `http://zipkin.io/zipkin-api/#/` isn't valid anymore but gets redirected to `https://zipkin.apache.org/#/`. -

[GitHub] [incubator-zipkin] bianxiaojin commented on issue #2590: 使用阿里云的amqp rabbitmq时报错

2019-06-09 Thread GitBox
bianxiaojin commented on issue #2590: 使用阿里云的amqp rabbitmq时报错 URL: https://github.com/apache/incubator-zipkin/issues/2590#issuecomment-500266116 "$" this character This is an automated message from the Apache Git Service. To

[GitHub] [incubator-zipkin] adriancole commented on issue #2625: Request method 'POST' not supported

2019-06-09 Thread GitBox
adriancole commented on issue #2625: Request method 'POST' not supported URL: https://github.com/apache/incubator-zipkin/issues/2625#issuecomment-500259222 we don't support custom servers. Moreover, gitter is for q/a and support, not issues. You can discuss in gitter your need for a custom

[GitHub] [incubator-zipkin] adriancole closed issue #2625: Request method 'POST' not supported

2019-06-09 Thread GitBox
adriancole closed issue #2625: Request method 'POST' not supported URL: https://github.com/apache/incubator-zipkin/issues/2625 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-zipkin] panchen66 opened a new issue #2625: Request method 'POST' not supported

2019-06-09 Thread GitBox
panchen66 opened a new issue #2625: Request method 'POST' not supported URL: https://github.com/apache/incubator-zipkin/issues/2625 i use spring-boot-starter-parent (2.1.2.RELEASE) and zipkin-autoconfigure-ui/zipkin-server(2.12.0) to make zipkin-server. i don't used official jar , be

[GitHub] [incubator-zipkin] pchiwan opened a new pull request #2624: fix(ui): display user friendly span duration on reload

2019-06-07 Thread GitBox
pchiwan opened a new pull request #2624: fix(ui): display user friendly span duration on reload URL: https://github.com/apache/incubator-zipkin/pull/2624 Closes #2612 This is an automated message from the Apache Git Service.

[GitHub] [incubator-zipkin] adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens

2019-06-06 Thread GitBox
adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens URL: https://github.com/apache/incubator-zipkin/issues/2548#issuecomment-499377995 Thanks @michaelsembwever and @WillemJiang I think there's still a question we need to answer, still package.json include

[GitHub] [incubator-zipkin] michaelsembwever commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens

2019-06-06 Thread GitBox
michaelsembwever commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens URL: https://github.com/apache/incubator-zipkin/issues/2548#issuecomment-499376855 I also used `license-checker` on Cassandra Reaper when we offered to donate it to Cassandra. > … the format needs

[GitHub] [incubator-zipkin-website] adriancole commented on issue #17: Adds sources download information for all projects except Brave

2019-06-06 Thread GitBox
adriancole commented on issue #17: Adds sources download information for all projects except Brave URL: https://github.com/apache/incubator-zipkin-website/pull/17#issuecomment-499376732 @WillemJiang slight qualification.. they are inconsistently mirrored! regardless the outcome is the sam

[GitHub] [incubator-zipkin-website] jcchavezs merged pull request #19: Fixes the asc and zip url.

2019-06-05 Thread GitBox
jcchavezs merged pull request #19: Fixes the asc and zip url. URL: https://github.com/apache/incubator-zipkin-website/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-zipkin-website] adriancole commented on issue #19: Fixes the asc and zip url.

2019-06-05 Thread GitBox
adriancole commented on issue #19: Fixes the asc and zip url. URL: https://github.com/apache/incubator-zipkin-website/pull/19#issuecomment-499372573 fixed PTAL This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-zipkin-website] adriancole commented on issue #19: Fixes the asc and zip url.

2019-06-05 Thread GitBox
adriancole commented on issue #19: Fixes the asc and zip url. URL: https://github.com/apache/incubator-zipkin-website/pull/19#issuecomment-499370576 I will add a commit to fix this This is an automated message from the Apache

[GitHub] [incubator-zipkin-website] adriancole commented on a change in pull request #19: Fixes the asc and zip url.

2019-06-05 Thread GitBox
adriancole commented on a change in pull request #19: Fixes the asc and zip url. URL: https://github.com/apache/incubator-zipkin-website/pull/19#discussion_r291038766 ## File path: pages/downloads.md ## @@ -2,7 +2,7 @@ title: Source Downloads weight: 4 --- -{% assign ba

[GitHub] [incubator-zipkin-website] adriancole commented on a change in pull request #19: Fixes the asc and zip url.

2019-06-05 Thread GitBox
adriancole commented on a change in pull request #19: Fixes the asc and zip url. URL: https://github.com/apache/incubator-zipkin-website/pull/19#discussion_r291038068 ## File path: pages/downloads.md ## @@ -2,7 +2,7 @@ title: Source Downloads weight: 4 --- -{% assign ba

[GitHub] [incubator-zipkin-website] adriancole merged pull request #18: removes hacks into the jenkins file.

2019-06-05 Thread GitBox
adriancole merged pull request #18: removes hacks into the jenkins file. URL: https://github.com/apache/incubator-zipkin-website/pull/18 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-zipkin-website] adriancole commented on issue #18: removes hacks into the jenkins file.

2019-06-05 Thread GitBox
adriancole commented on issue #18: removes hacks into the jenkins file. URL: https://github.com/apache/incubator-zipkin-website/pull/18#issuecomment-499368319 ok let's see how it goes! thanks This is an automated message from

[GitHub] [incubator-zipkin-website] jcchavezs opened a new pull request #19: Fixes the asc and zip url.

2019-06-05 Thread GitBox
jcchavezs opened a new pull request #19: Fixes the asc and zip url. URL: https://github.com/apache/incubator-zipkin-website/pull/19 This PR address https://github.com/apache/incubator-zipkin-website/pull/17#issuecomment-499365150 Ping @adriancole @WillemJiang -

[GitHub] [incubator-zipkin] WillemJiang commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens

2019-06-05 Thread GitBox
WillemJiang commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens URL: https://github.com/apache/incubator-zipkin/issues/2548#issuecomment-499366284 For the fonts and icons, as we normally don't change them and it's hard to change, I think it should be fine to treat them as

[GitHub] [incubator-zipkin-website] jcchavezs opened a new pull request #18: removes hacks into the jenkins file.

2019-06-05 Thread GitBox
jcchavezs opened a new pull request #18: removes hacks into the jenkins file. URL: https://github.com/apache/incubator-zipkin-website/pull/18 This PR cleans up the hacks we did to include the swagger files into the website. Ping @adriancole @abesto -

[GitHub] [incubator-zipkin-website] WillemJiang commented on issue #17: Adds sources download information for all projects except Brave

2019-06-05 Thread GitBox
WillemJiang commented on issue #17: Adds sources download information for all projects except Brave URL: https://github.com/apache/incubator-zipkin-website/pull/17#issuecomment-499365150 @adriancole The asc and sha512 files are not mirrored, so we still need to point these files to apach

[GitHub] [incubator-zipkin] adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens

2019-06-05 Thread GitBox
adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens URL: https://github.com/apache/incubator-zipkin/issues/2548#issuecomment-499359396 Our source uses the following cc @tacigar @zeagord ``` $fa-font-path: "~@fortawesome/fontawesome-free/webfonts"; @

[GitHub] [incubator-zipkin] adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens

2019-06-05 Thread GitBox
adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens URL: https://github.com/apache/incubator-zipkin/issues/2548#issuecomment-499357920 let's try to clarify what work has to occur and in a priority order. We do have to look into fontawesome, so let's look closely

[GitHub] [incubator-zipkin-website] jcchavezs merged pull request #17: Adds sources download information for all projects except Brave

2019-06-05 Thread GitBox
jcchavezs merged pull request #17: Adds sources download information for all projects except Brave URL: https://github.com/apache/incubator-zipkin-website/pull/17 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-zipkin-website] jcchavezs closed issue #12: Revise content around downloads

2019-06-05 Thread GitBox
jcchavezs closed issue #12: Revise content around downloads URL: https://github.com/apache/incubator-zipkin-website/issues/12 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   6   7   8   9   10   >