[GitHub] [hadoop-thirdparty] ayushtkn merged pull request #20: HADOOP-18282. Add .asf.yaml to hadoop-thirdparty.

2022-06-09 Thread GitBox
ayushtkn merged PR #20: URL: https://github.com/apache/hadoop-thirdparty/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop-thirdparty] ayushtkn opened a new pull request, #20: HADOOP-18282. Add .asf.yaml to hadoop-thirdparty.

2022-06-08 Thread GitBox
ayushtkn opened a new pull request, #20: URL: https://github.com/apache/hadoop-thirdparty/pull/20 Similar to [HADOOP-17234](https://issues.apache.org/jira/browse/HADOOP-17234) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-thirdparty] ayushtkn commented on pull request #19: HADOOP-18197. Upgrade protobuf to 3.21.1

2022-06-08 Thread GitBox
ayushtkn commented on PR #19: URL: https://github.com/apache/hadoop-thirdparty/pull/19#issuecomment-1150334147 >That said, I don't see why the version number needed to be included there. We will have to live with that. That wasn't something we wanted to do that initially, that came

[GitHub] [hadoop-thirdparty] steveloughran opened a new pull request, #19: HADOOP-18197. Upgrade protobuf to 3.20.1

2022-06-08 Thread GitBox
steveloughran opened a new pull request, #19: URL: https://github.com/apache/hadoop-thirdparty/pull/19 This patch bumps up the protobuf version so that Hadoop is not a vulnerable to CVE-2021-22569. I'm not renaming the module hadoop-shaded-protobuf_3_7 because that

[GitHub] [hadoop-thirdparty] cjolivier01 commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

2022-02-24 Thread GitBox
cjolivier01 commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-1050314164 It would be good to update this to a non-vulnerable version of protobuf -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop-thirdparty] medb edited a comment on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

2021-09-04 Thread GitBox
medb edited a comment on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242 @jojochuang I took a look at Hadoop changes in apache/hadoop#3384, and it seems that to upgrade Protobuf both PRs are required (apache/hadoop-thirdparty#13 in

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

2021-09-04 Thread GitBox
medb commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242 @jojochuang I took a look at Hadoop changes, and it seems to upgrade Protobuf both PRs are necessary (in `hadoop-thirdparty` and `hadoop` repositories) May you

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

2021-09-04 Thread GitBox
medb commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-912924915 @jojochuang sent PR to the Hadoop repo: https://github.com/apache/hadoop/pull/3384 Please, let me know if this is correct. -- This is an automated message from the

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #18: HADOOP-17730. Add back error_prone

2021-05-25 Thread GitBox
jojochuang commented on pull request #18: URL: https://github.com/apache/hadoop-thirdparty/pull/18#issuecomment-848474245 Thanks! I'll start preparing the 1.1.1 RC then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #18: HADOOP-17730. Add back error_prone

2021-05-25 Thread GitBox
jojochuang merged pull request #18: URL: https://github.com/apache/hadoop-thirdparty/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #18: HADOOP-17730. Add back error_prone

2021-05-25 Thread GitBox
jojochuang commented on pull request #18: URL: https://github.com/apache/hadoop-thirdparty/pull/18#issuecomment-848416511 @ayushtkn or @tasanuma can you review? I am thinking to add this and then start a hadoop-thirdparty 1.1.1 vote. It is not strictly required. For Ozone, I have a

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #18: HADOOP-17730. Add back error_prone

2021-05-24 Thread GitBox
jojochuang opened a new pull request #18: URL: https://github.com/apache/hadoop-thirdparty/pull/18 Tested by compiling Ozone with the modified Hadoop-thirdparty 1.1.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-23 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-846657744 Now only the "Squash and Merge" is enabled. https://issues.apache.org/jira/browse/INFRA-21905 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-20 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844761869 Actually, we asked INFRA to only allow squash merging for apache/hadoop. I will create another jira for hadoop-thirdparty.

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-20 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844755126 I don't have the privilege to see the Repo Settings page. Maybe we need to add `.asf.yml` like HADOOP-17234? -- This is an automated message from the Apache Git

[GitHub] [hadoop-thirdparty] smengcl commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-19 Thread GitBox
smengcl commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844355268 @tasanuma We can probably configure the "Merge button" config in Repo Settings page the same as apache/hadoop to only allow squash merging. -- This is an automated

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-19 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-844164345 Sorry, I forgot to squash it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-19 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-843794096 Thanks for your view, @jojochuang. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-thirdparty] tasanuma merged pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-19 Thread GitBox
tasanuma merged pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-18 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-843034859 @jojochuang I added the information about `org.checkerframework`. `failureaccess` and `listenablefuture` are included in `com.google.guava`, and both of the

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-17 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842812751 @jojochuang @smengcl Thanks for your reviews and your help. I added guava document. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-thirdparty] smengcl commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-17 Thread GitBox
smengcl commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842802932 Thanks @tasanuma @jojochuang for taking care of the doc. Posting `mvn dependency:tree` result on latest trunk here just for reference: ```bash [INFO]

[GitHub] [hadoop-thirdparty] tasanuma commented on pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-17 Thread GitBox
tasanuma commented on pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17#issuecomment-842794574 @jojochuang Could you review it? We may need it in 1.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-thirdparty] tasanuma opened a new pull request #17: HADOOP-17707. Remove jaeger document from site index.

2021-05-17 Thread GitBox
tasanuma opened a new pull request #17: URL: https://github.com/apache/hadoop-thirdparty/pull/17 JIRA: https://issues.apache.org/jira/browse/HADOOP-17707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

2021-05-17 Thread GitBox
jojochuang commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117 As I said, this PR is not needed. I'd like to ask you to work on the protobuf update in the main hadoop repository. -- This is an automated message from the Apache

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

2021-05-17 Thread GitBox
jojochuang commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117 As I said, this PR is not needed. I'd like to ask you to work on the protobuf update in the main hadoop repository. -- This is an automated message from the Apache

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

2021-05-13 Thread GitBox
medb commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840985181 @jojochuang rebased on the trunk HEAD and updated PR to the latest Protobuf version -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #16: HADOOP-17697. Fix license error in GitHub Actions workflow files.

2021-05-13 Thread GitBox
aajisaka commented on pull request #16: URL: https://github.com/apache/hadoop-thirdparty/pull/16#issuecomment-840328780 Thank you @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #16: HADOOP-17697. Fix license error in GitHub Actions workflow files.

2021-05-12 Thread GitBox
jojochuang merged pull request #16: URL: https://github.com/apache/hadoop-thirdparty/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #14: HADOOP-17692. [thirdparty] Fix the docker image

2021-05-12 Thread GitBox
jojochuang commented on pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840305102 Thanks @aajisaka ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #14: HADOOP-17692. [thirdparty] Fix the docker image

2021-05-12 Thread GitBox
jojochuang merged pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #15: HADOOP-17696. Update Hadoop-thirdparty LICENSEs and NOTICEs.

2021-05-12 Thread GitBox
jojochuang commented on pull request #15: URL: https://github.com/apache/hadoop-thirdparty/pull/15#issuecomment-840301789 Thanks @aajisaka @tasanuma ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #15: HADOOP-17696. Update Hadoop-thirdparty LICENSEs and NOTICEs.

2021-05-12 Thread GitBox
jojochuang merged pull request #15: URL: https://github.com/apache/hadoop-thirdparty/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #14: HADOOP-17692. [thirdparty] Fix the docker image

2021-05-12 Thread GitBox
jojochuang commented on a change in pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631539990 ## File path: dev-support/docker/Dockerfile ## @@ -93,20 +94,8 @@ RUN apt-get -q update \ && apt-get clean \ && rm -rf

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

2021-05-12 Thread GitBox
jojochuang commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840256223 Yeah. We have a number of redundant steps in hadoop-thirdparty Dockerfile. It was copied from the main hadoop repo but we don't need many of the packages. -- This is

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

2021-05-12 Thread GitBox
medb commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840254235 @jojochuang May you clarify, do you mean that we do not need to compile protoc in [`hadoop-thirdparty` Docker

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

2021-05-12 Thread GitBox
jojochuang commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840251431 Instead, we should do this for the main hadoop repository, not the hadoop-thirdparty repo.

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

2021-05-12 Thread GitBox
jojochuang commented on pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840250988 So at the end of the day, we probably don't need to use protobuf in the hadoop-thirdparty repository. See:

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

2021-05-12 Thread GitBox
jojochuang commented on a change in pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631526674 ## File path: dev-support/docker/Dockerfile ## @@ -93,20 +94,8 @@ RUN apt-get -q update \ && apt-get clean \ && rm -rf

[GitHub] [hadoop-thirdparty] aajisaka opened a new pull request #16: HADOOP-17697. Fix license error in GitHub Actions workflow files.

2021-05-12 Thread GitBox
aajisaka opened a new pull request #16: URL: https://github.com/apache/hadoop-thirdparty/pull/16 JIRA: HADOOP-17697 - Added the license header - Create a job to check license -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #15: HADOOP-17696. Update Hadoop-thirdparty LICENSEs and NOTICEs.

2021-05-12 Thread GitBox
jojochuang opened a new pull request #15: URL: https://github.com/apache/hadoop-thirdparty/pull/15 Update the LICENSE and NOTICE files to reflect what's bundled in hadoop-thirdparty 1.1 and above. 1. Removed licenses and notices of the thirdparty dependency that shipped along with

[GitHub] [hadoop-thirdparty] aajisaka commented on a change in pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

2021-05-12 Thread GitBox
aajisaka commented on a change in pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631520733 ## File path: dev-support/docker/Dockerfile ## @@ -93,20 +94,8 @@ RUN apt-get -q update \ && apt-get clean \ && rm -rf

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

2021-05-12 Thread GitBox
aajisaka commented on pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840239920 Thank you @jojochuang. Maybe we need to update the description to something like "Fix the docker image". In the future, I want to clean up the Dockerfile: -

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

2021-05-12 Thread GitBox
jojochuang commented on pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-839651970 This change blocks the hadoop-thirdparty 1.1.0 release. Please review @aajisaka @ayushtkn @vinayakumarb -- This is an automated message from the Apache Git Service.

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

2021-05-12 Thread GitBox
jojochuang opened a new pull request #14: URL: https://github.com/apache/hadoop-thirdparty/pull/14 (1) Hard code a python dependency version to avoid image build error. (2) Remove npm which is not used for building hadoop-thirdparty to avoid image build error. (2) Migrate to Ubuntu

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-05-01 Thread GitBox
aajisaka commented on pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-830728944 Merged. Thank you @smengcl and @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-05-01 Thread GitBox
aajisaka merged pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] medb opened a new pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

2021-05-01 Thread GitBox
medb opened a new pull request #13: URL: https://github.com/apache/hadoop-thirdparty/pull/13 Protobuf 3.7.1 is not available in any OS repo and requires manual compilation which takes time (10-15 mins). Protobuf 3.12.4 is not only newer but also available in latest Debian and

[GitHub] [hadoop-thirdparty] jojochuang merged pull request #11: HADOOP-17659. Remove hadoop-shaded-jaeger from hadoop-thirdparty 1.1.0 release.

2021-04-27 Thread GitBox
jojochuang merged pull request #11: URL: https://github.com/apache/hadoop-thirdparty/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-04-26 Thread GitBox
aajisaka commented on pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-827247977 @jojochuang @ayushtkn Do you need any additional tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-thirdparty] smengcl edited a comment on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-04-26 Thread GitBox
smengcl edited a comment on pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826852986 Thanks @aajisaka . ~~Would you trigger a re-run on your fork? looks like it is still failing on the previous java-version typo here:

[GitHub] [hadoop-thirdparty] smengcl commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-04-26 Thread GitBox
smengcl commented on pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826852986 Thanks @aajisaka . Would you trigger a re-run on your fork? looks like it is still failing on the previous java-version typo here:

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-04-26 Thread GitBox
aajisaka commented on pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826751862 Result: https://github.com/aajisaka/hadoop-thirdparty/actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-04-26 Thread GitBox
aajisaka commented on pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12#issuecomment-826744706 Umm. Maybe GitHub actions will be enabled after the PR is merged into the branch. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-thirdparty] aajisaka opened a new pull request #12: HADOOP-17667. Add precommit check for Hadoop Thirdparty repository.

2021-04-26 Thread GitBox
aajisaka opened a new pull request #12: URL: https://github.com/apache/hadoop-thirdparty/pull/12 JIRA: https://issues.apache.org/jira/browse/HADOOP-17667 Test GitHub Actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #11: HADOOP-17659. Remove hadoop-shaded-jaeger from hadoop-thirdparty 1.1.0 release.

2021-04-26 Thread GitBox
jojochuang opened a new pull request #11: URL: https://github.com/apache/hadoop-thirdparty/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #10: HADOOP-17660. Update dependency-check-maven version.

2021-04-26 Thread GitBox
aajisaka merged pull request #10: URL: https://github.com/apache/hadoop-thirdparty/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #10: HADOOP-17660. Update dependency-check-maven version.

2021-04-26 Thread GitBox
aajisaka commented on pull request #10: URL: https://github.com/apache/hadoop-thirdparty/pull/10#issuecomment-826483156 Thanks @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-26 Thread GitBox
aajisaka merged pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-26 Thread GitBox
aajisaka commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-826486797 Thank you @jojochuang and @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-25 Thread GitBox
aajisaka commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-826486797 Thank you @jojochuang and @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-25 Thread GitBox
aajisaka merged pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #10: HADOOP-17660. Update dependency-check-maven version.

2021-04-25 Thread GitBox
aajisaka commented on pull request #10: URL: https://github.com/apache/hadoop-thirdparty/pull/10#issuecomment-826483156 Thanks @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop-thirdparty] aajisaka merged pull request #10: HADOOP-17660. Update dependency-check-maven version.

2021-04-25 Thread GitBox
aajisaka merged pull request #10: URL: https://github.com/apache/hadoop-thirdparty/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #10: HADOOP-17660. Update dependency-check-maven version.

2021-04-23 Thread GitBox
jojochuang opened a new pull request #10: URL: https://github.com/apache/hadoop-thirdparty/pull/10 Manually tested by running command `mvn dependency-check:aggregate` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-20 Thread GitBox
jojochuang commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-823699977 It doesn't look like we run QA for hadoop-thirdparty repo. It's a relatively less developed repo after all. -- This is an automated message from the Apache Git

[GitHub] [hadoop-thirdparty] virajjasani commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-19 Thread GitBox
virajjasani commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822972015 I see, it was coming from `checker-qual`. Sounds good to exclude it. +1 (non-binding). @jojochuang where do we usually see QA results for hadoop-thirdparty? It

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-19 Thread GitBox
jojochuang commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822907603 The above commit fixes the shading problem. @virajjasani care to have another look? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-19 Thread GitBox
jojochuang commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822398949 Actually this PR breaks shading `Error creating shaded jar: duplicate entry: META-INF/LICENSE.txt` Looking into this error. -- This is an automated message from

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: HADOOP-17648. Update guava to 30.1.1-jre

2021-04-18 Thread GitBox
jojochuang commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822175134 Oh yeah you're right. I'm doing too much work at once. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-thirdparty] virajjasani commented on pull request #9: Update guava to 30.1.1-jre

2021-04-18 Thread GitBox
virajjasani commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822173643 Just one minor comment: We can update PR title to include `HADOOP-17648` -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #9: Update guava to 30.1.1-jre

2021-04-18 Thread GitBox
jojochuang commented on pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9#issuecomment-822173335 Yeah I think we should release hadoop-thirdparty 1.1.0 now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #9: Update guava to 30.1.1-jre

2021-04-18 Thread GitBox
jojochuang opened a new pull request #9: URL: https://github.com/apache/hadoop-thirdparty/pull/9 HADOOP-17648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [hadoop-thirdparty] vinayakumarb commented on pull request #8: HADOOP-17278. Shade guava 29.0-jre in hadoop thirdparty.

2020-09-27 Thread GitBox
vinayakumarb commented on pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#issuecomment-699645473 Merged. Thanks @ayushtkn and @jojochuang This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-thirdparty] vinayakumarb merged pull request #8: HADOOP-17278. Shade guava 29.0-jre in hadoop thirdparty.

2020-09-27 Thread GitBox
vinayakumarb merged pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-thirdparty] ayushtkn commented on pull request #8: HADOOP-17278. Shade guava 29.0-jre in hadoop thirdparty.

2020-09-27 Thread GitBox
ayushtkn commented on pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#issuecomment-699641409 Thanx @vinayakumarb for the review. @jojochuang any further comments? This is an automated message from

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #8: HADOOP-17278. Shade guava 29.0-jre in hadoop thirdparty.

2020-09-27 Thread GitBox
vinayakumarb commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r495577424 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 29.0-jre in hadoop thirdparty.

2020-09-27 Thread GitBox
ayushtkn commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r495577123 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 29.0-jre in hadoop thirdparty.

2020-09-23 Thread GitBox
ayushtkn commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r493489153 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-22 Thread GitBox
vinayakumarb commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492866355 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-22 Thread GitBox
jojochuang commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492363544 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-22 Thread GitBox
ayushtkn commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492440814 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] vinayakumarb commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-22 Thread GitBox
vinayakumarb commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492866355 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
jojochuang commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492286560 ## File path: pom.xml ## @@ -95,6 +95,7 @@ org.apache.hadoop.thirdparty ${shaded.prefix}.protobuf 3.7.1 +27.0-jre Review

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
ayushtkn commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492300681 ## File path: pom.xml ## @@ -95,6 +95,7 @@ org.apache.hadoop.thirdparty ${shaded.prefix}.protobuf 3.7.1 +27.0-jre Review

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
ayushtkn commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492440814 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
ayushtkn commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492440814 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
jojochuang commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492364864 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
jojochuang commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492363544 ## File path: hadoop-shaded-guava/pom.xml ## @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
ayushtkn commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492300681 ## File path: pom.xml ## @@ -95,6 +95,7 @@ org.apache.hadoop.thirdparty ${shaded.prefix}.protobuf 3.7.1 +27.0-jre Review

[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
jojochuang commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492286560 ## File path: pom.xml ## @@ -95,6 +95,7 @@ org.apache.hadoop.thirdparty ${shaded.prefix}.protobuf 3.7.1 +27.0-jre Review

[GitHub] [hadoop-thirdparty] ayushtkn opened a new pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox
ayushtkn opened a new pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8 https://issues.apache.org/jira/browse/HADOOP-17278 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-thirdparty] asfgit merged pull request #7: HADOOP-16919. Handle release packaging issues

2020-03-11 Thread GitBox
asfgit merged pull request #7: HADOOP-16919. Handle release packaging issues URL: https://github.com/apache/hadoop-thirdparty/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop-thirdparty] vinayakumarb commented on issue #7: HADOOP-16919. Handle release packaging issues

2020-03-11 Thread GitBox
vinayakumarb commented on issue #7: HADOOP-16919. Handle release packaging issues URL: https://github.com/apache/hadoop-thirdparty/pull/7#issuecomment-597582023 thanks @ayushtkn . merged This is an automated message from the

[GitHub] [hadoop-thirdparty] elek commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs

2020-03-11 Thread GitBox
elek commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs URL: https://github.com/apache/hadoop-thirdparty/pull/6#issuecomment-597566802 Thank you very much the work @vinayakumarb (And sorry for the occasionally delayed answer...)

[GitHub] [hadoop-thirdparty] vinayakumarb opened a new pull request #7: HADOOP-16919. Handle release packaging issues

2020-03-11 Thread GitBox
vinayakumarb opened a new pull request #7: HADOOP-16919. Handle release packaging issues URL: https://github.com/apache/hadoop-thirdparty/pull/7 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which

[GitHub] [hadoop-thirdparty] vinayakumarb commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs

2020-03-11 Thread GitBox
vinayakumarb commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs URL: https://github.com/apache/hadoop-thirdparty/pull/6#issuecomment-597510090 Thanks @elek and @aajisaka for reviews. Merged this to trunk and will cherry-pick to branch-1.0 for another RC

[GitHub] [hadoop-thirdparty] asfgit merged pull request #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs

2020-03-11 Thread GitBox
asfgit merged pull request #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs URL: https://github.com/apache/hadoop-thirdparty/pull/6 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-thirdparty] vinayakumarb commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs

2020-03-05 Thread GitBox
vinayakumarb commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs URL: https://github.com/apache/hadoop-thirdparty/pull/6#issuecomment-595151392 Thanks @elek I have made NOTICE-binary 'lightweight' by removing 'non-mandatory' mentions of all 3rd-party

[GitHub] [hadoop-thirdparty] vinayakumarb commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs

2020-03-02 Thread GitBox
vinayakumarb commented on issue #6: HADOOP-16895. [thirdparty] Revisit LICENSEs and NOTICEs URL: https://github.com/apache/hadoop-thirdparty/pull/6#issuecomment-593380030 @aajisaka Updated the PR to include License-binary and NOTICE-binary as LICENCE.txt and NOTICE.txt and all other

  1   2   >