Re: Time to address the Guava version problem

2014-10-13 Thread Steve Loughran
I've a patch for HADOOP-11102 which rolls curator back to v 2.4.1, which only pulls in Guava 14...hadoop should now be weakly consistent -at least not strongly inconsistent- in its guava versions. allowing hadoop to work on 16.x while still remaining compatible with 11.x is still something to

Re: Time to address the Guava version problem

2014-09-24 Thread Billie Rinaldi
The use of an unnecessarily old dependency encourages problems like HDFS-7040. The current Guava dependency is a big problem for downstream apps and I'd really like to see it addressed. On Tue, Sep 23, 2014 at 2:09 PM, Steve Loughran ste...@hortonworks.com wrote: I'm using curator elsewhere,

Re: Time to address the Guava version problem

2014-09-23 Thread Steve Loughran
+1 to upgrading guava. Irrespective of downstream apps, the hadoop source tree is now internally inconsistent On 22 September 2014 17:56, Sangjin Lee sj...@apache.org wrote: I agree that a more robust solution is to have better classloading isolation. Still, IMHO guava (and possibly protobuf

Re: Time to address the Guava version problem

2014-09-23 Thread Sandy Ryza
If we've broken compatibility in branch-2, that's a bug that we need to fix. HADOOP-10868 has not yet made it into a release; I don't see it as a justification for solidifying the breakage. -1 to upgrading Guava in branch-2. On Tue, Sep 23, 2014 at 3:06 AM, Steve Loughran ste...@hortonworks.com

Re: Time to address the Guava version problem

2014-09-23 Thread Robert Kanter
At the same time, not being able to use Curator will require a lot of extra code, a lot of which we probably already have from the ZKRMStateStore, but it's not available to use in hadoop-auth. We'd need to create our own ZK libraries that Hadoop components can use, but (a) that's going to take a

Re: Time to address the Guava version problem

2014-09-22 Thread Sangjin Lee
I agree that a more robust solution is to have better classloading isolation. Still, IMHO guava (and possibly protobuf as well) sticks out like a sore thumb. There are just too many issues in trying to support both guava 11 and guava 16. Independent of what we may do with the classloading

Re: Time to address the Guava version problem

2014-09-21 Thread Karthik Kambatla
Upgrading Guava version is tricky. While it helps in many cases, it can break existing applications/deployments. I understand we do not have a policy for updating dependencies, but still we should be careful with Guava. I would be more inclined towards a more permanent solution to this problem -

Re: Time to address the Guava version problem

2014-09-19 Thread Sangjin Lee
I would also agree on upgrading guava. Yes I am aware of the potential impact on customers who might rely on hadoop bringing in guava 11. However, IMHO the balance tipped over to the other side a while ago; i.e. I think there are far more people using guava 16 in their code and scrambling to make