[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids

2019-09-05 Thread GitBox
bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1360#discussion_r321585352 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids

2019-09-05 Thread GitBox
bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1360#discussion_r321585352 ## File path:

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923948#comment-16923948 ] Hadoop QA commented on HADOOP-15565: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids

2019-09-05 Thread GitBox
bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1360#discussion_r321585214 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids

2019-09-05 Thread GitBox
bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1360#discussion_r321583946 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids

2019-09-05 Thread GitBox
bharatviswa504 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1360#discussion_r321583418 ## File path:

[jira] [Comment Edited] (HADOOP-16551) The changelog*.md seems not generated when create-release

2019-09-05 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923901#comment-16923901 ] Zhankun Tang edited comment on HADOOP-16551 at 9/6/19 3:30 AM: --- Am I

[jira] [Commented] (HADOOP-16551) The changelog*.md seems not generated when create-release

2019-09-05 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923901#comment-16923901 ] Zhankun Tang commented on HADOOP-16551: --- Am I miss something before running this script? I'm

[jira] [Comment Edited] (HADOOP-16551) The changelog*.md seems not generated when create-release

2019-09-05 Thread Zhankun Tang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923901#comment-16923901 ] Zhankun Tang edited comment on HADOOP-16551 at 9/6/19 3:27 AM: --- Am I

[jira] [Created] (HADOOP-16551) The changelog*.md seems not generated when create-release

2019-09-05 Thread Zhankun Tang (Jira)
Zhankun Tang created HADOOP-16551: - Summary: The changelog*.md seems not generated when create-release Key: HADOOP-16551 URL: https://issues.apache.org/jira/browse/HADOOP-16551 Project: Hadoop Common

[GitHub] [hadoop] dineshchitlangia commented on issue #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
dineshchitlangia commented on issue #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#issuecomment-528692206 Finally, all checks are fine! The integration test failures are unrelated as mentioned previously.

[GitHub] [hadoop] hadoop-yetus commented on issue #1409: HDDS-2087. Remove the hard coded config key in ChunkManager

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1409: HDDS-2087. Remove the hard coded config key in ChunkManager URL: https://github.com/apache/hadoop/pull/1409#issuecomment-528688453 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Tsuyoshi Ozawa (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923879#comment-16923879 ] Tsuyoshi Ozawa commented on HADOOP-13363: - [~aajisaka] If we upgrade protobuf version, is any

[jira] [Comment Edited] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Tsuyoshi Ozawa (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923878#comment-16923878 ] Tsuyoshi Ozawa edited comment on HADOOP-13363 at 9/6/19 2:41 AM: -

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Tsuyoshi Ozawa (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923878#comment-16923878 ] Tsuyoshi Ozawa commented on HADOOP-13363: - [~vinayakumarb] > Have you verified this already?

[jira] [Updated] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinglun updated HADOOP-15565: - Attachment: HADOOP-15565.0008.patch > ViewFileSystem.close doesn't close child filesystems and causes

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923876#comment-16923876 ] Jinglun commented on HADOOP-15565: -- Hi [~xkrogen], I did a test about the diff 0 issue. When I wget

[jira] [Updated] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinglun updated HADOOP-15565: - Attachment: HADOOP-15565.0006.bak > ViewFileSystem.close doesn't close child filesystems and causes

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Sunil Govindan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923856#comment-16923856 ] Sunil Govindan commented on HADOOP-13363: - [https://github.com/apache/hadoop/pull/1408/files]

[GitHub] [hadoop] vivekratnavel commented on issue #1409: HDDS-2087. Remove the hard coded config key in ChunkManager

2019-09-05 Thread GitBox
vivekratnavel commented on issue #1409: HDDS-2087. Remove the hard coded config key in ChunkManager URL: https://github.com/apache/hadoop/pull/1409#issuecomment-528663174 @anuengineer @bharatviswa504 @elek @swagle Please review

[GitHub] [hadoop] vivekratnavel commented on issue #1409: HDDS-2087. Remove the hard coded config key in ChunkManager

2019-09-05 Thread GitBox
vivekratnavel commented on issue #1409: HDDS-2087. Remove the hard coded config key in ChunkManager URL: https://github.com/apache/hadoop/pull/1409#issuecomment-528663110 /label ozone This is an automated message from the

[GitHub] [hadoop] vivekratnavel opened a new pull request #1409: HDDS-2087. Remove the hard coded config key in ChunkManager

2019-09-05 Thread GitBox
vivekratnavel opened a new pull request #1409: HDDS-2087. Remove the hard coded config key in ChunkManager URL: https://github.com/apache/hadoop/pull/1409 We have a hard-coded config key in the ChunkManagerFactory.java. ``` boolean scrubber = config.getBoolean(

[GitHub] [hadoop] hadoop-yetus commented on issue #1408: HADOOP-13363. Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1408: HADOOP-13363. Upgrade protobuf from 2.5.0 to something newer URL: https://github.com/apache/hadoop/pull/1408#issuecomment-528660020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] shanyu commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error

2019-09-05 Thread GitBox
shanyu commented on a change in pull request #1399: HADOOP-16543: Cached DNS name resolution error URL: https://github.com/apache/hadoop/pull/1399#discussion_r321526544 ## File path:

[GitHub] [hadoop] arp7 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids

2019-09-05 Thread GitBox
arp7 commented on a change in pull request #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1360#discussion_r321525072 ## File path:

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Anu Engineer (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923785#comment-16923785 ] Anu Engineer commented on HADOOP-13363: --- Rebase or incomplete patch? > Upgrade protobuf from

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923780#comment-16923780 ] Hadoop QA commented on HADOOP-13363: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Vinayakumar B (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinayakumar B updated HADOOP-13363: --- Hadoop Flags: (was: Incompatible change) Assignee: Vinayakumar B

[jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread Vinayakumar B (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923768#comment-16923768 ] Vinayakumar B commented on HADOOP-13363: Created a PR by using the above method suggested by

[GitHub] [hadoop] vinayakumarb opened a new pull request #1408: HADOOP-13363. Upgrade protobuf from 2.5.0 to something newer

2019-09-05 Thread GitBox
vinayakumarb opened a new pull request #1408: HADOOP-13363. Upgrade protobuf from 2.5.0 to something newer URL: https://github.com/apache/hadoop/pull/1408 This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] anuengineer closed pull request #1406: [HDDS-1708] Add container scrubber metrics

2019-09-05 Thread GitBox
anuengineer closed pull request #1406: [HDDS-1708] Add container scrubber metrics URL: https://github.com/apache/hadoop/pull/1406 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1373: HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi…

2019-09-05 Thread GitBox
xiaoyuyao commented on a change in pull request #1373: HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… URL: https://github.com/apache/hadoop/pull/1373#discussion_r321472474 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1373: HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi…

2019-09-05 Thread GitBox
xiaoyuyao commented on a change in pull request #1373: HDDS-2053. Fix TestOzoneManagerRatisServer failure. Contributed by Xi… URL: https://github.com/apache/hadoop/pull/1373#discussion_r321472474 ## File path:

[GitHub] [hadoop] steveloughran commented on issue #1407: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-09-05 Thread GitBox
steveloughran commented on issue #1407: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1407#issuecomment-528551540 tested s3 ireland without s3guard -one failure in test teardown. I have been seeing this is a lot recently and suspect it

[GitHub] [hadoop] hadoop-yetus commented on issue #1407: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1407: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1407#issuecomment-528550341 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321443871 ## File path:

[GitHub] [hadoop] dineshchitlangia commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
dineshchitlangia commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321432258 ## File path:

[GitHub] [hadoop] dineshchitlangia commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
dineshchitlangia commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321430004 ## File path:

[GitHub] [hadoop] dineshchitlangia commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
dineshchitlangia commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321428987 ## File path:

[GitHub] [hadoop] steveloughran opened a new pull request #1407: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-09-05 Thread GitBox
steveloughran opened a new pull request #1407: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1407 This patch avoids issuing any HEAD path request when creating a file with overwrite=true, so 404s will not end up in the S3 load balancers

[GitHub] [hadoop] steveloughran commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-09-05 Thread GitBox
steveloughran commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#issuecomment-528493922 I closed the wrong PR! This is an automated message from

[GitHub] [hadoop] steveloughran commented on issue #1359: HADOOP-16430. S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread GitBox
steveloughran commented on issue #1359: HADOOP-16430. S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#issuecomment-528494093 This is merged. Thanks This is

[GitHub] [hadoop] steveloughran closed pull request #1359: HADOOP-16430. S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread GitBox
steveloughran closed pull request #1359: HADOOP-16430. S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359 This is an automated message from the Apache Git

[GitHub] [hadoop] hgadre opened a new pull request #1406: [HDDS-1708] Add container scrubber metrics

2019-09-05 Thread GitBox
hgadre opened a new pull request #1406: [HDDS-1708] Add container scrubber metrics URL: https://github.com/apache/hadoop/pull/1406 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321375262 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321374583 ## File path:

[GitHub] [hadoop] smengcl commented on issue #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids

2019-09-05 Thread GitBox
smengcl commented on issue #1360: HDDS-2007. Make ozone fs shell command work with OM HA service ids URL: https://github.com/apache/hadoop/pull/1360#issuecomment-528458580 /label ozone This is an automated message from

[GitHub] [hadoop] anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321372069 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1386: HDDS-2015. Encrypt/decrypt key using symmetric key while writing/reading URL: https://github.com/apache/hadoop/pull/1386#discussion_r321370576 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1359: HADOOP-16430. S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1359: HADOOP-16430. S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#issuecomment-528453043 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321356299 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321356555 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321356653 ## File path:

[GitHub] [hadoop] anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
anuengineer commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321355379 ## File path:

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923545#comment-16923545 ] Erik Krogen commented on HADOOP-15565: -- Thanks for the detailed explanations [~LiJinglun]! They

[jira] [Comment Edited] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923545#comment-16923545 ] Erik Krogen edited comment on HADOOP-15565 at 9/5/19 3:41 PM: -- Thanks for

[GitHub] [hadoop] hadoop-yetus commented on issue #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove URL: https://github.com/apache/hadoop/pull/1401#issuecomment-528430441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923532#comment-16923532 ] Hadoop QA commented on HADOOP-15565: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16531) Log more detail for slow RPC

2019-09-05 Thread Erik Krogen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923512#comment-16923512 ] Erik Krogen commented on HADOOP-16531: -- Thanks [~zhangchen]! This seems like a nice improvement

[jira] [Updated] (HADOOP-16550) Spark config name error on the Launching Applications Using Docker Containers page

2019-09-05 Thread Gabor Bota (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Bota updated HADOOP-16550: Description: On the "Launching Applications Using Docker Containers" page at the "Example:

[jira] [Commented] (HADOOP-16550) Spark config name error on the Launching Applications Using Docker Containers page

2019-09-05 Thread Gabor Bota (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923501#comment-16923501 ] Gabor Bota commented on HADOOP-16550: - Sure, thanks for the contribution [~attilapiros]. LGTM, +1.

[GitHub] [hadoop] hadoop-yetus commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#issuecomment-528390584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] steveloughran closed pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-09-05 Thread GitBox
steveloughran closed pull request #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-16430) S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923434#comment-16923434 ] Steve Loughran commented on HADOOP-16430: - committed -thanks for the review. Yes, I like a lot

[GitHub] [hadoop] steveloughran commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy

2019-09-05 Thread GitBox
steveloughran commented on issue #1229: HADOOP-16490. Improve S3Guard handling of FNFEs in copy URL: https://github.com/apache/hadoop/pull/1229#issuecomment-528363480 committed to trunk -thanks for all reviews This is an

[jira] [Commented] (HADOOP-16430) S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923431#comment-16923431 ] Hudson commented on HADOOP-16430: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17231 (See

[GitHub] [hadoop] steveloughran commented on issue #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread GitBox
steveloughran commented on issue #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#issuecomment-528356582 Thanks for the vote, merging in. Your reviews are always valued, and when you feel the urge to

[GitHub] [hadoop] steveloughran commented on a change in pull request #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread GitBox
steveloughran commented on a change in pull request #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#discussion_r321248863 ## File path:

[GitHub] [hadoop] steveloughran commented on a change in pull request #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions

2019-09-05 Thread GitBox
steveloughran commented on a change in pull request #1359: HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions URL: https://github.com/apache/hadoop/pull/1359#discussion_r321247382 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1375: HDDS-2048: State check during container state transition in datanode should be lock protected

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1375: HDDS-2048: State check during container state transition in datanode should be lock protected URL: https://github.com/apache/hadoop/pull/1375#issuecomment-528352725 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime

[GitHub] [hadoop] nandakumar131 merged pull request #1326: HDDS-1898. GrpcReplicationService#download cannot replicate the container.

2019-09-05 Thread GitBox
nandakumar131 merged pull request #1326: HDDS-1898. GrpcReplicationService#download cannot replicate the container. URL: https://github.com/apache/hadoop/pull/1326 This is an automated message from the Apache Git Service.

[GitHub] [hadoop] nandakumar131 commented on issue #1326: HDDS-1898. GrpcReplicationService#download cannot replicate the container.

2019-09-05 Thread GitBox
nandakumar131 commented on issue #1326: HDDS-1898. GrpcReplicationService#download cannot replicate the container. URL: https://github.com/apache/hadoop/pull/1326#issuecomment-528345055 Failures are not related to this patch. Tested them locally.

[jira] [Commented] (HADOOP-13551) hook up AwsSdkMetrics to hadoop metrics

2019-09-05 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923358#comment-16923358 ] Steve Loughran commented on HADOOP-13551: - # the way to do this is by passing in a

[GitHub] [hadoop] hadoop-yetus commented on issue #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove URL: https://github.com/apache/hadoop/pull/1401#issuecomment-528333132 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16549) Remove Unsupported SSL/TLS Versions from Docs/Properties

2019-09-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923338#comment-16923338 ] Hadoop QA commented on HADOOP-16549: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinglun updated HADOOP-15565: - Attachment: HADOOP-15565.0007.patch > ViewFileSystem.close doesn't close child filesystems and causes

[jira] [Commented] (HADOOP-15565) ViewFileSystem.close doesn't close child filesystems and causes FileSystem objects leak.

2019-09-05 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923308#comment-16923308 ] Jinglun commented on HADOOP-15565: -- Hi [~xkrogen], thanks very much for your nice review !  I followed

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321204004 ## File path:

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321203027 ## File path:

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321201465 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1364: HDDS-1843. Undetectable corruption after restart of a datanode.

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1364: HDDS-1843. Undetectable corruption after restart of a datanode. URL: https://github.com/apache/hadoop/pull/1364#issuecomment-528314940 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321199279 ## File path:

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321198662 ## File path:

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321197327 ## File path:

[GitHub] [hadoop] lokeshj1703 commented on issue #1375: HDDS-2048: State check during container state transition in datanode should be lock protected

2019-09-05 Thread GitBox
lokeshj1703 commented on issue #1375: HDDS-2048: State check during container state transition in datanode should be lock protected URL: https://github.com/apache/hadoop/pull/1375#issuecomment-528309534 @nandakumar131 Thanks for reviewing the PR! I have updated changes as per offline

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321192741 ## File path:

[GitHub] [hadoop] sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states

2019-09-05 Thread GitBox
sodonnel commented on a change in pull request #1344: HDDS-1982 Extend SCMNodeManager to support decommission and maintenance states URL: https://github.com/apache/hadoop/pull/1344#discussion_r321191360 ## File path:

[jira] [Commented] (HADOOP-16550) Spark config name error on the Launching Applications Using Docker Containers page

2019-09-05 Thread Attila Zsolt Piros (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923275#comment-16923275 ] Attila Zsolt Piros commented on HADOOP-16550: - [~gabor.bota] could you please take a look

[jira] [Updated] (HADOOP-16550) Spark config name error on the Launching Applications Using Docker Containers page

2019-09-05 Thread Attila Zsolt Piros (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Zsolt Piros updated HADOOP-16550: Summary: Spark config name error on the Launching Applications Using Docker

[jira] [Created] (HADOOP-16550) Wrong Spark config name on the "Launching Applications Using Docker Containers" page

2019-09-05 Thread Attila Zsolt Piros (Jira)
Attila Zsolt Piros created HADOOP-16550: --- Summary: Wrong Spark config name on the "Launching Applications Using Docker Containers" page Key: HADOOP-16550 URL:

[GitHub] [hadoop] echohlne opened a new pull request #1405: In yarn2 UI, ff the Spark task we submitted is still running, the finishedTime returned by the server is 0, and the time shown on the UI2 pa

2019-09-05 Thread GitBox
echohlne opened a new pull request #1405: In yarn2 UI, ff the Spark task we submitted is still running, the finishedTime returned by the server is 0, and the time shown on the UI2 page is always '1970/01/01 08:00' URL: https://github.com/apache/hadoop/pull/1405

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove

2019-09-05 Thread GitBox
lokeshj1703 commented on a change in pull request #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove URL: https://github.com/apache/hadoop/pull/1401#discussion_r321185090 ## File path:

[GitHub] [hadoop] lokeshj1703 commented on a change in pull request #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove

2019-09-05 Thread GitBox
lokeshj1703 commented on a change in pull request #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove URL: https://github.com/apache/hadoop/pull/1401#discussion_r321185076 ## File path:

[GitHub] [hadoop] lokeshj1703 commented on issue #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove

2019-09-05 Thread GitBox
lokeshj1703 commented on issue #1401: HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove URL: https://github.com/apache/hadoop/pull/1401#issuecomment-528301702 @nandakumar131 Thanks for reviewing the PR! 2nd commit addresses checkstyle issues and review comments.

[GitHub] [hadoop] mukund-thakur opened a new pull request #1404: HDFS-13660 Copy file till the source file length during distcp

2019-09-05 Thread GitBox
mukund-thakur opened a new pull request #1404: HDFS-13660 Copy file till the source file length during distcp URL: https://github.com/apache/hadoop/pull/1404 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] echohlne closed pull request #1383: In YARN ui2 applications tab, If finishTime is 0, 'NA' should be displayed at this time, indicating that the task is not finished yet

2019-09-05 Thread GitBox
echohlne closed pull request #1383: In YARN ui2 applications tab, If finishTime is 0, 'NA' should be displayed at this time, indicating that the task is not finished yet URL: https://github.com/apache/hadoop/pull/1383 This

[jira] [Commented] (HADOOP-16549) Remove Unsupported SSL/TLS Versions from Docs/Properties

2019-09-05 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923247#comment-16923247 ] Akira Ajisaka commented on HADOOP-16549: LGTM, +1 pending Jenkins. > Remove Unsupported

[GitHub] [hadoop] hadoop-yetus commented on issue #1364: HDDS-1843. Undetectable corruption after restart of a datanode.

2019-09-05 Thread GitBox
hadoop-yetus commented on issue #1364: HDDS-1843. Undetectable corruption after restart of a datanode. URL: https://github.com/apache/hadoop/pull/1364#issuecomment-528287642 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Comment Edited] (HADOOP-16549) Remove Unsupported SSL/TLS Versions from Docs/Properties

2019-09-05 Thread Daisuke Kobayashi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923211#comment-16923211 ] Daisuke Kobayashi edited comment on HADOOP-16549 at 9/5/19 8:53 AM:

[jira] [Updated] (HADOOP-16549) Remove Unsupported SSL/TLS Versions from Docs/Properties

2019-09-05 Thread Daisuke Kobayashi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daisuke Kobayashi updated HADOOP-16549: --- Attachment: HADOOP-16549.001.patch Status: Patch Available (was: Open)

  1   2   >