[GitHub] [hadoop] hadoop-yetus commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1216137263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] snmvaughan commented on pull request #4724: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request

2022-08-15 Thread GitBox
snmvaughan commented on PR #4724: URL: https://github.com/apache/hadoop/pull/4724#issuecomment-1216056960 This looks like an example of a flaky test, where a previous test execution affects tests that follow. Specifically the reported failed test is `testRollback` which does not start any

[GitHub] [hadoop] hadoop-yetus commented on pull request #4740: YARN-9708. Yarn Router Support DelegationToken.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4740: URL: https://github.com/apache/hadoop/pull/4740#issuecomment-1216050541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4741: YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4741: URL: https://github.com/apache/hadoop/pull/4741#issuecomment-1216050763 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1216015858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1215977767 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18403) Fix FileSystem leak in ITestS3AAWSCredentialsProvider

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579960#comment-17579960 ] ASF GitHub Bot commented on HADOOP-18403: - virajjasani commented on PR #4737: URL:

[GitHub] [hadoop] virajjasani commented on pull request #4737: HADOOP-18403. Fix FileSystem leak in ITestS3AAWSCredentialsProvider

2022-08-15 Thread GitBox
virajjasani commented on PR #4737: URL: https://github.com/apache/hadoop/pull/4737#issuecomment-1215968811 @mukund-thakur could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] slfan1989 commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-15 Thread GitBox
slfan1989 commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1215960490 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1215932490 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1215932491 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18371) s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579941#comment-17579941 ] ASF GitHub Bot commented on HADOOP-18371: - mukund-thakur merged PR #4730: URL:

[GitHub] [hadoop] mukund-thakur merged pull request #4730: HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread GitBox
mukund-thakur merged PR #4730: URL: https://github.com/apache/hadoop/pull/4730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-15 Thread GitBox
slfan1989 commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r946163145 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4741: YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.

2022-08-15 Thread GitBox
slfan1989 commented on code in PR #4741: URL: https://github.com/apache/hadoop/pull/4741#discussion_r946161252 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[jira] [Commented] (HADOOP-18371) s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579926#comment-17579926 ] ASF GitHub Bot commented on HADOOP-18371: - hadoop-yetus commented on PR #4730: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4730: HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4730: URL: https://github.com/apache/hadoop/pull/4730#issuecomment-1215891417 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4728: MAPREDUCE-7403. manifest-committer dynamic partitioning support.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4728: URL: https://github.com/apache/hadoop/pull/4728#issuecomment-1215819210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-15 Thread GitBox
goiri commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r946118671 ##

[GitHub] [hadoop] goiri merged pull request #4662: HDFS-16705. RBF: Support healthMonitor timeout configurable and cache NN and client proxy in NamenodeHeartbeatService

2022-08-15 Thread GitBox
goiri merged PR #4662: URL: https://github.com/apache/hadoop/pull/4662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on a diff in pull request #4741: YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.

2022-08-15 Thread GitBox
goiri commented on code in PR #4741: URL: https://github.com/apache/hadoop/pull/4741#discussion_r946113361 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
ashutoshcipher commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1215777311 Sorry @cnauroth, I got occupied with some other major work, so it took a while for me to get back on this. I have tried addressing all your comments - Can you please review it

[GitHub] [hadoop] goiri merged pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-15 Thread GitBox
goiri merged PR #4701: URL: https://github.com/apache/hadoop/pull/4701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-15 Thread GitBox
goiri commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1215773135 > @slfan1989 Thanks for your review. > > > Do we need to update the md file to explain what these parameters do? > > Do you mean which MD file? `ipc.client.rpc-timeout.ms` is

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r946109977 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -528,8

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r946109580 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -528,8

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r946109405 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -528,8

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r946108915 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -528,8

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-08-15 Thread GitBox
ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r946108671 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -528,8

[GitHub] [hadoop] hadoop-yetus commented on pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4693: URL: https://github.com/apache/hadoop/pull/4693#issuecomment-1215750317 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher commented on pull request #4731: YARN-9425. Make initialDelay configurable for FederationStateStoreService#scheduledExecutorService

2022-08-15 Thread GitBox
ashutoshcipher commented on PR #4731: URL: https://github.com/apache/hadoop/pull/4731#issuecomment-1215710302 > hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy Failure is unrelated, Ran it multiple times in local - its working fine. -- This is an automated

[jira] [Commented] (HADOOP-18371) s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579880#comment-17579880 ] ASF GitHub Bot commented on HADOOP-18371: - steveloughran commented on code in PR #4730: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4730: HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread GitBox
steveloughran commented on code in PR #4730: URL: https://github.com/apache/hadoop/pull/4730#discussion_r946072098 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -997,13 +997,17 @@ protected RequestFactory createRequestFactory() {

[GitHub] [hadoop] steveloughran commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-15 Thread GitBox
steveloughran commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1215697705 @ndimiduk just general race conditions then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] snmvaughan commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-15 Thread GitBox
snmvaughan commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1215685147 Testing refactoring of `hadoop-mapreduce-project` that is patterned after `hadoop-yarn-project`. All 3rd party dependencies are removed, leaving the dependencies to apply just to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1215647723 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4740: YARN-9708. Yarn Router Support DelegationToken.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4740: URL: https://github.com/apache/hadoop/pull/4740#issuecomment-1215588274 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4699: HDFS-16717. Replace NPE with IOException in DataNode.class

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4699: URL: https://github.com/apache/hadoop/pull/4699#issuecomment-1215582814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4741: YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4741: URL: https://github.com/apache/hadoop/pull/4741#issuecomment-1215578047 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18371) s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579847#comment-17579847 ] ASF GitHub Bot commented on HADOOP-18371: - mukund-thakur commented on code in PR #4730: URL:

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4730: HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class is unset

2022-08-15 Thread GitBox
mukund-thakur commented on code in PR #4730: URL: https://github.com/apache/hadoop/pull/4730#discussion_r946008152 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -997,13 +997,17 @@ protected RequestFactory createRequestFactory() {

[jira] [Commented] (HADOOP-18401) release files miss hadoop-3.3.4-aarch64.tar.gz

2022-08-15 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579834#comment-17579834 ] Ayush Saxena commented on HADOOP-18401: --- Can give a try with 

[GitHub] [hadoop] hadoop-yetus commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1215432652 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18383) Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579820#comment-17579820 ] ASF GitHub Bot commented on HADOOP-18383: - sunchao merged PR #4739: URL:

[jira] [Updated] (HADOOP-18383) Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-15 Thread Chao Sun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chao Sun updated HADOOP-18383: -- Fix Version/s: 3.3.9 > Codecs with @DoNotPool annotation are not closed causing memory leak >

[jira] [Commented] (HADOOP-18383) Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579821#comment-17579821 ] ASF GitHub Bot commented on HADOOP-18383: - sunchao commented on PR #4739: URL:

[GitHub] [hadoop] sunchao commented on pull request #4739: HADOOP-18383. Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-15 Thread GitBox
sunchao commented on PR #4739: URL: https://github.com/apache/hadoop/pull/4739#issuecomment-121541 Merged to branch-3.3. Thanks @kevins-29 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] sunchao merged pull request #4739: HADOOP-18383. Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-15 Thread GitBox
sunchao merged PR #4739: URL: https://github.com/apache/hadoop/pull/4739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] xkrogen commented on pull request #4628: HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs.

2022-08-15 Thread GitBox
xkrogen commented on PR #4628: URL: https://github.com/apache/hadoop/pull/4628#issuecomment-1215390129 Thanks all, appreciate you looking into this. @ZanderXu , I will try to look into HDFS-16659 and HDFS-16645. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1215298271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4731: YARN-9425. Make initialDelay configurable for FederationStateStoreService#scheduledExecutorService

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4731: URL: https://github.com/apache/hadoop/pull/4731#issuecomment-1215271786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] snmvaughan commented on a diff in pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-15 Thread GitBox
snmvaughan commented on code in PR #4693: URL: https://github.com/apache/hadoop/pull/4693#discussion_r945856788 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSDomainNameResolver.java: ## @@ -40,6 +48,16 @@ public String getHostnameByIP(InetAddress

[GitHub] [hadoop] ndimiduk commented on a diff in pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-15 Thread GitBox
ndimiduk commented on code in PR #4693: URL: https://github.com/apache/hadoop/pull/4693#discussion_r945854695 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSDomainNameResolver.java: ## @@ -40,6 +48,16 @@ public String getHostnameByIP(InetAddress

[GitHub] [hadoop] ndimiduk commented on a diff in pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-15 Thread GitBox
ndimiduk commented on code in PR #4693: URL: https://github.com/apache/hadoop/pull/4693#discussion_r945852367 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSDomainNameResolver.java: ## @@ -40,6 +48,16 @@ public String getHostnameByIP(InetAddress

[GitHub] [hadoop] slfan1989 commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

2022-08-15 Thread GitBox
slfan1989 commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1215125582 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 commented on pull request #4733: YARN-11223. [Federation] Add getAppPriority, updateApplicationPriority REST APIs for Router.

2022-08-15 Thread GitBox
slfan1989 commented on PR #4733: URL: https://github.com/apache/hadoop/pull/4733#issuecomment-1215096404 @goiri Thank you very much for your help reviewing the code, I will follow up with YARN-11224. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] slfan1989 commented on pull request #4741: YARN-11252. Yarn Federation Router Supports Update / Delete Reservation in MemoryStore.

2022-08-15 Thread GitBox
slfan1989 commented on PR #4741: URL: https://github.com/apache/hadoop/pull/4741#issuecomment-1215095183 @goiri Please help to review the code, this part of the code completes the operations of update and delete Reservation.Thank you very much! -- This is an automated message from the

[jira] [Commented] (HADOOP-18385) ITestS3ACannedACLs failure; not in a span

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579724#comment-17579724 ] ASF GitHub Bot commented on HADOOP-18385: - ashutoshcipher commented on PR #4736: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4736: HADOOP-18385. ITestS3ACannedACLs failure; fixed by adding in a span

2022-08-15 Thread GitBox
ashutoshcipher commented on PR #4736: URL: https://github.com/apache/hadoop/pull/4736#issuecomment-1215061021 My bad, Please do it whenever you have some free cycles. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-18385) ITestS3ACannedACLs failure; not in a span

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579723#comment-17579723 ] ASF GitHub Bot commented on HADOOP-18385: - steveloughran commented on PR #4736: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4736: HADOOP-18385. ITestS3ACannedACLs failure; fixed by adding in a span

2022-08-15 Thread GitBox
steveloughran commented on PR #4736: URL: https://github.com/apache/hadoop/pull/4736#issuecomment-1215054429 read my profile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Comment Edited] (HADOOP-18401) release files miss hadoop-3.3.4-aarch64.tar.gz

2022-08-15 Thread Veli-Jussi Raitila (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579716#comment-17579716 ] Veli-Jussi Raitila edited comment on HADOOP-18401 at 8/15/22 1:51 PM:

[jira] [Comment Edited] (HADOOP-18401) release files miss hadoop-3.3.4-aarch64.tar.gz

2022-08-15 Thread Veli-Jussi Raitila (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579716#comment-17579716 ] Veli-Jussi Raitila edited comment on HADOOP-18401 at 8/15/22 1:50 PM:

[jira] [Commented] (HADOOP-18401) release files miss hadoop-3.3.4-aarch64.tar.gz

2022-08-15 Thread Veli-Jussi Raitila (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579716#comment-17579716 ] Veli-Jussi Raitila commented on HADOOP-18401: - It is indeed unfortunate transitive Python

[GitHub] [hadoop] ndimiduk commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-15 Thread GitBox
ndimiduk commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1215023860 > my setup @steveloughran maven version matches my own, which is where I expected to find the difference. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] ZanderXu commented on pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-08-15 Thread GitBox
ZanderXu commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1215017852 @ferhui @xkrogen Master, this PR uses `getEditLogManifest()` to fix this problem. Please help me review it, thanks. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] ZanderXu opened a new pull request, #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-08-15 Thread GitBox
ZanderXu opened a new pull request, #4744: URL: https://github.com/apache/hadoop/pull/4744 ### Description of PR Standby NameNode may crash when transitioning to Active with a in-progress tailer if there are some abnormal JNs. And the crashed error message as blew: ```java

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-15 Thread GitBox
Hexiaoqiao commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1214980333 Committed to trunk. Thanks @ZanderXu for your contribution, Thanks @ayushtkn for your reviews. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] Hexiaoqiao merged pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-15 Thread GitBox
Hexiaoqiao merged PR #4661: URL: https://github.com/apache/hadoop/pull/4661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (HADOOP-18405) abfs testReadAndWriteWithDifferentBufferSizesAndSeek failure

2022-08-15 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18405: --- Summary: abfs testReadAndWriteWithDifferentBufferSizesAndSeek failure Key: HADOOP-18405 URL: https://issues.apache.org/jira/browse/HADOOP-18405 Project: Hadoop

[jira] [Updated] (HADOOP-18072) Über-JIRA: abfs phase III: Hadoop 3.3.x features & fixes

2022-08-15 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18072: Summary: Über-JIRA: abfs phase III: Hadoop 3.3.x features & fixes (was: Über-JIRA: abfs

[GitHub] [hadoop] ferhui commented on pull request #4628: HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs.

2022-08-15 Thread GitBox
ferhui commented on PR #4628: URL: https://github.com/apache/hadoop/pull/4628#issuecomment-1214926249 @xkrogen Thanks for pointing it out. Reverted. @ZanderXu can raise a new MR and we can discuss it later. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4743: Revert "HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs."

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4743: URL: https://github.com/apache/hadoop/pull/4743#issuecomment-1214926068 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ferhui merged pull request #4743: Revert "HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs."

2022-08-15 Thread GitBox
ferhui merged PR #4743: URL: https://github.com/apache/hadoop/pull/4743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ferhui opened a new pull request, #4743: Revert "HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs."

2022-08-15 Thread GitBox
ferhui opened a new pull request, #4743: URL: https://github.com/apache/hadoop/pull/4743 Reverts apache/hadoop#4628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18340) deleteOnExit does not work with S3AFileSystem

2022-08-15 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579644#comment-17579644 ] Steve Loughran commented on HADOOP-18340: - i moved the version number in maven of branch-3.3 to

[GitHub] [hadoop] ZanderXu commented on pull request #4699: HDFS-16717. Replace NPE with IOException in DataNode.class

2022-08-15 Thread GitBox
ZanderXu commented on PR #4699: URL: https://github.com/apache/hadoop/pull/4699#issuecomment-1214874172 @Hexiaoqiao Master, ping. Can help me review this patch? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] ZanderXu commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-15 Thread GitBox
ZanderXu commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1214872605 @Hexiaoqiao @ayushtkn Master, ping, please help me merge this PR and review [PR-4699](https://github.com/apache/hadoop/pull/4699)? Thanks -- This is an automated message from the

[GitHub] [hadoop] ZanderXu commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-15 Thread GitBox
ZanderXu commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1214869969 @slfan1989 Thanks for your review. > Do we need to update the md file to explain what these parameters do? Do you mean which MD file? `ipc.client.rpc-timeout.ms` is not been

[GitHub] [hadoop] steveloughran merged pull request #4735: HADOOP-18402. S3A committer NPE in spark job abort

2022-08-15 Thread GitBox
steveloughran merged PR #4735: URL: https://github.com/apache/hadoop/pull/4735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18402) S3A committer NPE in spark job abort

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579629#comment-17579629 ] ASF GitHub Bot commented on HADOOP-18402: - steveloughran merged PR #4735: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-15 Thread GitBox
steveloughran commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1214851440 @ndimiduk my setup ``` Maven home: /opt/homebrew/Cellar/maven/3.8.6/libexec Java version: 1.8.0_322, vendor: Azul Systems, Inc., runtime:

[jira] [Commented] (HADOOP-18385) ITestS3ACannedACLs failure; not in a span

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579623#comment-17579623 ] ASF GitHub Bot commented on HADOOP-18385: - ashutoshcipher commented on PR #4736: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4736: HADOOP-18385. ITestS3ACannedACLs failure; fixed by adding in a span

2022-08-15 Thread GitBox
ashutoshcipher commented on PR #4736: URL: https://github.com/apache/hadoop/pull/4736#issuecomment-1214849765 @steveloughran - Can you please review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18384) ITestS3AFileSystemStatistic failure in prefetch feature branch

2022-08-15 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579622#comment-17579622 ] Steve Loughran commented on HADOOP-18384: - Go ahead, but know i've locked down the branch

[jira] [Commented] (HADOOP-18401) release files miss hadoop-3.3.4-aarch64.tar.gz

2022-08-15 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579620#comment-17579620 ] Steve Loughran commented on HADOOP-18401: - thanks for that update; does imply that without an

[jira] [Commented] (HADOOP-18341) upgrade to commons-configuration2 2.8.0

2022-08-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579597#comment-17579597 ] ASF GitHub Bot commented on HADOOP-18341: - hadoop-yetus commented on PR #4578: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4578: HADOOP-18341: upgrade commons-configuration2 to 2.8.0

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4578: URL: https://github.com/apache/hadoop/pull/4578#issuecomment-1214766012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] shellwjl commented on pull request #4726: YARN-11191 Global Scheduler refreshQueue cause deadLock

2022-08-15 Thread GitBox
shellwjl commented on PR #4726: URL: https://github.com/apache/hadoop/pull/4726#issuecomment-1214712685 > Global Scheduler has muti-threads to assign containers normally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4314: YARN-11153. Make proxy server support YARN federation.

2022-08-15 Thread GitBox
hadoop-yetus commented on PR #4314: URL: https://github.com/apache/hadoop/pull/4314#issuecomment-1214700469 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #4628: HDFS-16689. NameNode may crash when transitioning to Active with in-progress tailer if there are some abnormal JNs.

2022-08-15 Thread GitBox
ZanderXu commented on PR #4628: URL: https://github.com/apache/hadoop/pull/4628#issuecomment-1214661593 @xkrogen Master, about this PR, I'm waiting for your feedback. Thanks > Because during NN0 stoping active service, it will close the current segment, last finalize segment of JN0