[GitHub] [hadoop] hadoop-yetus commented on pull request #5333: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage

hadoop-yetus commented on PR #5333: URL: https://github.com/apache/hadoop/pull/5333#issuecomment-1409797883 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5328: YARN-11222. [Federation] Add addToClusterNodeLabels, removeFromClusterNodeLabels REST APIs for Router.

hadoop-yetus commented on PR #5328: URL: https://github.com/apache/hadoop/pull/5328#issuecomment-1409797397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] meijing123 opened a new pull request, #5333: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage

meijing123 opened a new pull request, #5333: URL: https://github.com/apache/hadoop/pull/5333 1. We added a test method to test the CacheManagerSectionProcessor. 2. We fixed two bugs in the processor of CacheManagerSectionProcessor to make sure the xml parsing fsimage. ### D

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1409697250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5328: YARN-11222. [Federation] Add addToClusterNodeLabels, removeFromClusterNodeLabels REST APIs for Router.

hadoop-yetus commented on PR #5328: URL: https://github.com/apache/hadoop/pull/5328#issuecomment-1409685217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

hadoop-yetus commented on PR #5324: URL: https://github.com/apache/hadoop/pull/5324#issuecomment-1409679730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] haiyang1987 commented on pull request #5296: HDFS-16888. BlockManager#maxReplicationStreams, replicationStreamsHardLimit, blocksReplWorkMultiplier and PendingReconstructionBlocks#tim

haiyang1987 commented on PR #5296: URL: https://github.com/apache/hadoop/pull/5296#issuecomment-1409649554 Hi @tomscut @tasanuma the PR already rebase，please help review it again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] meijing123 closed pull request #5069: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage

meijing123 closed pull request #5069: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage URL: https://github.com/apache/hadoop/pull/5069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682340#comment-17682340 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1409627535 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hchaverri commented on a diff in pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

hchaverri commented on code in PR #5324: URL: https://github.com/apache/hadoop/pull/5324#discussion_r1091307738 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -339,8 +341,11 @@ protected N

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

slfan1989 commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1091306165 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4299,6 +4299,26 @@ public static boolean is

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

slfan1989 commented on code in PR #5321: URL: https://github.com/apache/hadoop/pull/5321#discussion_r1091305761 ## hadoop-yarn-project/hadoop-yarn/bin/yarn: ## @@ -180,6 +180,9 @@ ${HADOOP_COMMON_HOME}/${HADOOP_COMMON_LIB_JARS_DIR}" HADOOP_HEAPSIZE_MAX="${YARN_ROUTER_HE

[GitHub] [hadoop] cnauroth commented on pull request #4237: MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirs

cnauroth commented on PR #4237: URL: https://github.com/apache/hadoop/pull/4237#issuecomment-1409558905 @steveloughran , no problem, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hadoop] hadoop-yetus commented on pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

hadoop-yetus commented on PR #5324: URL: https://github.com/apache/hadoop/pull/5324#issuecomment-1409550402 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] goiri commented on a diff in pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

goiri commented on code in PR #5321: URL: https://github.com/apache/hadoop/pull/5321#discussion_r1091290660 ## hadoop-yarn-project/hadoop-yarn/bin/yarn: ## @@ -180,6 +180,9 @@ ${HADOOP_COMMON_HOME}/${HADOOP_COMMON_LIB_JARS_DIR}" HADOOP_HEAPSIZE_MAX="${YARN_ROUTER_HEAPSI

[GitHub] [hadoop] omalley commented on a diff in pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

omalley commented on code in PR #5324: URL: https://github.com/apache/hadoop/pull/5324#discussion_r1091288711 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -339,8 +341,11 @@ protected Nam

[GitHub] [hadoop] hchaverri commented on a diff in pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

hchaverri commented on code in PR #5324: URL: https://github.com/apache/hadoop/pull/5324#discussion_r1091259025 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNamenodeHeartbeat.java: ## @@ -318,4 +320,31 @@ private

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

simbadzina commented on code in PR #5324: URL: https://github.com/apache/hadoop/pull/5324#discussion_r1091153796 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNamenodeHeartbeat.java: ## @@ -318,4 +320,31 @@ private

[GitHub] [hadoop] lnbest0707 commented on pull request #5297: YARN-11391. Support using DNS to resolve yarn services to IP addresses.

lnbest0707 commented on PR #5297: URL: https://github.com/apache/hadoop/pull/5297#issuecomment-1409259382 @slfan1989 style issue already fixed, others issues should not be related and not able to be resolved by rebasing. Could you please review and how can I merge the change? Thanks -- T

[GitHub] [hadoop] goiri commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

goiri commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1091037486 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/cleaner/TestSubClusterCleaner.java: ## @

[GitHub] [hadoop] goiri commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

goiri commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1091027952 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4299,6 +4299,26 @@ public static boolean isAclE

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682247#comment-17682247 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1091026861 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java: ## @@ -256,7 +255,7 @@ public static void skipFully(InputStream in, long len)

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682245#comment-17682245 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090918735 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ReflectionUtils.java: ## @@ -223,35 +222,6 @@ public synchronized static void printThrea

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682243#comment-17682243 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090916375 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/ServiceOperations.java: ## @@ -67,26 +66,6 @@ public static Exception stopQuietly(Serv

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682239#comment-17682239 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: U

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1409146994 > is there a way the log4j refs can be kept inside MetricsLoggerTask Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682235#comment-17682235 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1091002213 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java: ## @@ -949,13 +947,13 @@ protected void startMetricsLogger(Con

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682229#comment-17682229 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090989404 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -8853,16 +8849,12 @@ public void logAuditEvent(boole

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682228#comment-17682228 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090991860 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -8853,16 +8849,12 @@ public void logAuditEvent(boole

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682226#comment-17682226 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090989404 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -8853,16 +8849,12 @@ public void logAuditEvent(boole

[jira] [Commented] (HADOOP-18235) vulnerability: we may leak sensitive information in LocalKeyStoreProvider

[ https://issues.apache.org/jira/browse/HADOOP-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682223#comment-17682223 ] ASF GitHub Bot commented on HADOOP-18235: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4998: HADOOP-18235. vulnerability: we may leak sensitive information in LocalKeyStoreProvider

steveloughran commented on code in PR #4998: URL: https://github.com/apache/hadoop/pull/4998#discussion_r1090918223 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/LocalKeyStoreProvider.java: ## @@ -142,20 +142,26 @@ protected void initFileS

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1768#comment-1768 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: U

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1409097037 FWIW, the parent Jira HADOOP-16206 is also marked as "incompatible change" hence I believe we would not be able to backport this whole work to branch-3.x anyways. -- This is an auto

[jira] [Commented] (HADOOP-18592) Sasl connection failure should log remote address

[ https://issues.apache.org/jira/browse/HADOOP-18592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682215#comment-17682215 ] ASF GitHub Bot commented on HADOOP-18592: - virajjasani commented on PR #5294: U

[GitHub] [hadoop] virajjasani commented on pull request #5294: HADOOP-18592 Sasl connection failure should log remote address

virajjasani commented on PR #5294: URL: https://github.com/apache/hadoop/pull/5294#issuecomment-1409075178 Thank you for recent reviews @cnauroth @liuml07 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682196#comment-17682196 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090918735 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ReflectionUtils.java: ## @@ -223,35 +222,6 @@ public synchronized static void printThrea

[jira] [Commented] (HADOOP-18235) vulnerability: we may leak sensitive information in LocalKeyStoreProvider

[ https://issues.apache.org/jira/browse/HADOOP-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682195#comment-17682195 ] ASF GitHub Bot commented on HADOOP-18235: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4998: HADOOP-18235. vulnerability: we may leak sensitive information in LocalKeyStoreProvider

steveloughran commented on code in PR #4998: URL: https://github.com/apache/hadoop/pull/4998#discussion_r1090918223 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/LocalKeyStoreProvider.java: ## @@ -142,20 +142,26 @@ protected void initFileS

[jira] [Commented] (HADOOP-18584) [NFS GW] Fix regression after netty4 migration

[ https://issues.apache.org/jira/browse/HADOOP-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682194#comment-17682194 ] ASF GitHub Bot commented on HADOOP-18584: - jojochuang merged PR #5252: URL: htt

[GitHub] [hadoop] jojochuang merged pull request #5252: HADOOP-18584. [NFS GW] Fix regression after netty4 migration.

jojochuang merged PR #5252: URL: https://github.com/apache/hadoop/pull/5252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682191#comment-17682191 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: U

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1409002069 Moreover, the main goal of this sub-task is to remove only commons-logging references hence I think it would be better to replace Datanode/Namenode async logger with SLF4J only (with l

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682187#comment-17682187 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: U

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1408995424 > I've reviewed where log4j gets used in the production code. I do worry that today there's enough reflection that if deployed with logback all is good, but now log4j is required.

[GitHub] [hadoop] steveloughran commented on pull request #4237: MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirs

steveloughran commented on PR #4237: URL: https://github.com/apache/hadoop/pull/4237#issuecomment-1408981404 sorry, @cnauroth , misread your comment and put it in -i don't think it is worth reverting now -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [hadoop] hadoop-yetus commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

hadoop-yetus commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1408966217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] steveloughran commented on pull request #4237: MAPREDUCE-7375 JobSubmissionFiles don't set right permission after mkdirs

steveloughran commented on PR #4237: URL: https://github.com/apache/hadoop/pull/4237#issuecomment-1408966067 okay, let's cherrypick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [hadoop] slfan1989 commented on pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

slfan1989 commented on PR #5321: URL: https://github.com/apache/hadoop/pull/5321#issuecomment-1408929903 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682172#comment-17682172 ] ASF GitHub Bot commented on HADOOP-18596: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

steveloughran commented on code in PR #5308: URL: https://github.com/apache/hadoop/pull/5308#discussion_r1090843134 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpConstants.java: ## @@ -142,6 +142,13 @@ private DistCpConstants() { "distcp.blocks

[GitHub] [hadoop] slfan1989 commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

slfan1989 commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1408928125 @goiri Can you help to review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18596: Target Version/s: 3.3.9 (was: site) > Distcp -update between different cloud stores to u

[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

[ https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682155#comment-17682155 ] ASF GitHub Bot commented on HADOOP-18601: - hadoop-yetus commented on PR #5331:

[jira] [Commented] (HADOOP-11452) Make FileSystem.rename(path, path, options) public, specified, tested

[ https://issues.apache.org/jira/browse/HADOOP-11452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682156#comment-17682156 ] ASF GitHub Bot commented on HADOOP-11452: - hadoop-yetus commented on PR #2735:

[GitHub] [hadoop] hadoop-yetus commented on pull request #2735: HADOOP-11452 make rename/3 public

hadoop-yetus commented on PR #2735: URL: https://github.com/apache/hadoop/pull/2735#issuecomment-1408865087 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5331: HADOOP-18601. Fix build failure with docs profile.

hadoop-yetus commented on PR #5331: URL: https://github.com/apache/hadoop/pull/5331#issuecomment-1408864757 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

slfan1989 commented on code in PR #5309: URL: https://github.com/apache/hadoop/pull/5309#discussion_r1090779876 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/SharedCacheClientImpl.java: ## @@ -158,14 +158,8 @@ public v

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682096#comment-17682096 ] ASF GitHub Bot commented on HADOOP-18206: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

steveloughran commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090640899 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/ServiceOperations.java: ## @@ -67,26 +66,6 @@ public static Exception stopQuietly(Se

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1408638903 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682084#comment-17682084 ] ASF GitHub Bot commented on HADOOP-18206: - steveloughran commented on PR #5315:

[GitHub] [hadoop] steveloughran commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

steveloughran commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1408635376 so those production classes I am worrying about are already explicitly requiring log4j on the CP? OK, that's not as bad as I feared...I was worrying that the code was going from comm

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1408537446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Created] (HADOOP-18607) Fix TestAddOverReplicatedStripedBlocks#testProcessOverReplicatedAndCorruptStripedBlock failed

Haiyang Hu created HADOOP-18607: --- Summary: Fix TestAddOverReplicatedStripedBlocks#testProcessOverReplicatedAndCorruptStripedBlock failed Key: HADOOP-18607 URL: https://issues.apache.org/jira/browse/HADOOP-18607

[jira] [Updated] (HADOOP-18606) Add reason in in x-ms-client-request-id on a retry API call.

[ https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18606: Labels: pull-request-available (was: ) > Add reason in in x-ms-client-request-id on a re

[jira] [Commented] (HADOOP-18606) Add reason in in x-ms-client-request-id on a retry API call.

[ https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682023#comment-17682023 ] ASF GitHub Bot commented on HADOOP-18606: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #5299: HADOOP-18606. Add reason in in x-ms-client-request-id on a retry API call.

pranavsaxena-microsoft commented on PR #5299: URL: https://github.com/apache/hadoop/pull/5299#issuecomment-1408461428 @steveloughran @mukund-thakur @mehakmeet , requesting you to kindly review the PR please. Thanks. -- This is an automated message from the Apache Git Service. To respond t

[jira] [Updated] (HADOOP-18606) Add reason in in x-ms-client-request-id on a retry API call.

[ https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Saxena updated HADOOP-18606: --- Fix Version/s: 3.4.0 > Add reason in in x-ms-client-request-id on a retry API call. > -

[jira] [Updated] (HADOOP-18606) Add reason in in x-ms-client-request-id on a retry API call.

[ https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Saxena updated HADOOP-18606: --- Component/s: fs/azure > Add reason in in x-ms-client-request-id on a retry API call. >

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682021#comment-17682021 ] ASF GitHub Bot commented on HADOOP-18596: - hadoop-yetus commented on PR #5308:

[jira] [Created] (HADOOP-18606) Add reason in in x-ms-client-request-id on a retry API call.

Pranav Saxena created HADOOP-18606: -- Summary: Add reason in in x-ms-client-request-id on a retry API call. Key: HADOOP-18606 URL: https://issues.apache.org/jira/browse/HADOOP-18606 Project: Hadoop Co

[GitHub] [hadoop] hadoop-yetus commented on pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

hadoop-yetus commented on PR #5308: URL: https://github.com/apache/hadoop/pull/5308#issuecomment-1408457069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1408378798 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5328: YARN-11222. [Federation] Add addToClusterNodeLabels, removeFromClusterNodeLabels REST APIs for Router.

hadoop-yetus commented on PR #5328: URL: https://github.com/apache/hadoop/pull/5328#issuecomment-1408374029 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Updated] (HADOOP-18605) S3A AssumedRole credentials provider should use Instance Role credentials in chain for assuming role

[ https://issues.apache.org/jira/browse/HADOOP-18605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Carl Jones updated HADOOP-18605: --- Summary: S3A AssumedRole credentials provider should use Instance Role credentials

[jira] [Created] (HADOOP-18605) S3A AssumedRoleCredProvider should use Instance Role credentials in chain for assuming role

Daniel Carl Jones created HADOOP-18605: -- Summary: S3A AssumedRoleCredProvider should use Instance Role credentials in chain for assuming role Key: HADOOP-18605 URL: https://issues.apache.org/jira/browse/HADOO

[GitHub] [hadoop] p-szucs opened a new pull request, #5332: Yarn 11041. Replace all occurences of queuePath with the new QueuePath class - followup

p-szucs opened a new pull request, #5332: URL: https://github.com/apache/hadoop/pull/5332 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-