[jira] [Commented] (HADOOP-18761) Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730814#comment-17730814 ] ASF GitHub Bot commented on HADOOP-18761: - omalley commented on PR #5724: URL:

[GitHub] [hadoop] omalley closed pull request #5724: HADOOP-18761. Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread via GitHub
omalley closed pull request #5724: HADOOP-18761. Revert HADOOP-18535 because mysql-connector-java is GPL URL: https://github.com/apache/hadoop/pull/5724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-18761) Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730815#comment-17730815 ] ASF GitHub Bot commented on HADOOP-18761: - omalley closed pull request #5724: HADOOP-18761.

[GitHub] [hadoop] omalley commented on pull request #5724: HADOOP-18761. Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread via GitHub
omalley commented on PR #5724: URL: https://github.com/apache/hadoop/pull/5724#issuecomment-1584012490 -1 we don't need this patch and it wasn't done correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HADOOP-18762) Add Qiniu Cloud Kodo File System Implementation

2023-06-08 Thread Zhiqiang Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhiqiang Zhang updated HADOOP-18762: Attachment: Qiniu-Kodo-Integrated.pdf > Add Qiniu Cloud Kodo File System Implementation

[jira] [Updated] (HADOOP-18762) Add Qiniu Cloud Kodo File System Implementation

2023-06-08 Thread Zhiqiang Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhiqiang Zhang updated HADOOP-18762: Language: (was: Java) > Add Qiniu Cloud Kodo File System Implementation >

[jira] [Updated] (HADOOP-18762) Add Qiniu Cloud Kodo File System Implementation

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18762: Labels: pull-request-available (was: ) > Add Qiniu Cloud Kodo File System

[GitHub] [hadoop] zhangzqs opened a new pull request, #5725: HADOOP-18762. Add Qiniu Cloud Kodo File System Implementation

2023-06-08 Thread via GitHub
zhangzqs opened a new pull request, #5725: URL: https://github.com/apache/hadoop/pull/5725 ### Description of PR See (HADOOP-18762)[https://issues.apache.org/jira/browse/HADOOP-18762] ### How was this patch tested? ### For code changes: - [ ] Does the

[jira] [Commented] (HADOOP-18762) Add Qiniu Cloud Kodo File System Implementation

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730807#comment-17730807 ] ASF GitHub Bot commented on HADOOP-18762: - zhangzqs opened a new pull request, #5725: URL:

[jira] [Updated] (HADOOP-18762) Add Qiniu Cloud Kodo File System Implementation

2023-06-08 Thread Zhiqiang Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhiqiang Zhang updated HADOOP-18762: Summary: Add Qiniu Cloud Kodo File System Implementation (was: Qiniu Cloud Kodo File

[jira] [Created] (HADOOP-18762) Qiniu Cloud Kodo File System Implementation

2023-06-08 Thread Zhiqiang Zhang (Jira)
Zhiqiang Zhang created HADOOP-18762: --- Summary: Qiniu Cloud Kodo File System Implementation Key: HADOOP-18762 URL: https://issues.apache.org/jira/browse/HADOOP-18762 Project: Hadoop Common

[GitHub] [hadoop] yl09099 commented on a diff in pull request #5716: YARN-11506.The formatted yarn queue list is displayed on CLI

2023-06-08 Thread via GitHub
yl09099 commented on code in PR #5716: URL: https://github.com/apache/hadoop/pull/5716#discussion_r1223807168 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml: ## @@ -175,6 +175,12 @@ org.jline jline + + + com.blinkfox + mini-table

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-08 Thread via GitHub
ayushtkn commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1223781601 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java: ## @@ -259,6 +272,39 @@ private

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-08 Thread via GitHub
ayushtkn commented on code in PR #5592: URL: https://github.com/apache/hadoop/pull/5592#discussion_r1223777426 ## hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml: ## @@ -251,10 +248,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd;> run

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730788#comment-17730788 ] ASF GitHub Bot commented on HADOOP-18718: - ayushtkn commented on code in PR #5592: URL:

[jira] [Commented] (HADOOP-18761) Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730787#comment-17730787 ] Shilun Fan commented on HADOOP-18761: - [~weichiu] Thank you for your reminder! With [~elgoiri]

[jira] [Updated] (HADOOP-18761) Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18761: Labels: pull-request-available (was: ) > Revert HADOOP-18535 because

[jira] [Commented] (HADOOP-18761) Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730777#comment-17730777 ] ASF GitHub Bot commented on HADOOP-18761: - jojochuang opened a new pull request, #5724: URL:

[GitHub] [hadoop] jojochuang opened a new pull request, #5724: HADOOP-18761. Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread via GitHub
jojochuang opened a new pull request, #5724: URL: https://github.com/apache/hadoop/pull/5724 ### Description of PR See HADOOP-18761. ### How was this patch tested? No test. Revert only. ### For code changes: - [ ] Does the title or this PR starts with the

[jira] [Created] (HADOOP-18761) Revert HADOOP-18535 because mysql-connector-java is GPL

2023-06-08 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HADOOP-18761: Summary: Revert HADOOP-18535 because mysql-connector-java is GPL Key: HADOOP-18761 URL: https://issues.apache.org/jira/browse/HADOOP-18761 Project: Hadoop

[jira] [Commented] (HADOOP-18760) 3.3.6 Release NOTICE and LICENSE file update

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730776#comment-17730776 ] Wei-Chiu Chuang commented on HADOOP-18760: -- We can't use mysql connector as it's GPL. Either

[jira] [Assigned] (HADOOP-18760) 3.3.6 Release NOTICE and LICENSE file update

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HADOOP-18760: Assignee: Wei-Chiu Chuang > 3.3.6 Release NOTICE and LICENSE file update >

[jira] [Created] (HADOOP-18760) 3.3.6 Release NOTICE and LICENSE file update

2023-06-08 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HADOOP-18760: Summary: 3.3.6 Release NOTICE and LICENSE file update Key: HADOOP-18760 URL: https://issues.apache.org/jira/browse/HADOOP-18760 Project: Hadoop Common

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730766#comment-17730766 ] ASF GitHub Bot commented on HADOOP-18207: - hadoop-yetus commented on PR #5717: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5717: HADOOP-18207. Introduce hadoop-logging module

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5717: URL: https://github.com/apache/hadoop/pull/5717#issuecomment-1583604621 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1583560536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1583542874 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18750) Spark History Server 3.3.1 fails to starts with Hadoop 3.3.x

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730756#comment-17730756 ] ASF GitHub Bot commented on HADOOP-18750: - jojochuang commented on PR #5695: URL:

[GitHub] [hadoop] jojochuang commented on pull request #5695: HADOOP-18750. Remove javax/servlet shading in hadoop-client-api

2023-06-08 Thread via GitHub
jojochuang commented on PR #5695: URL: https://github.com/apache/hadoop/pull/5695#issuecomment-1583472070 I checked out the branch and ran the exact same command in precommit test. `mvn verify -fae --batch-mode -am -pl hadoop-client-modules/hadoop-client-check-invariants -pl

[jira] [Commented] (HADOOP-18756) CachingBlockManager to use AtomicBoolean for closed flag

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730711#comment-17730711 ] ASF GitHub Bot commented on HADOOP-18756: - hadoop-yetus commented on PR #5718: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5718: URL: https://github.com/apache/hadoop/pull/5718#issuecomment-1583302372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18718) Fix several maven build warnings

2023-06-08 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18718: -- Target Version/s: 3.4.0 (was: 3.4.0, 3.3.9, 3.3.6) > Fix several maven build warnings >

[jira] [Updated] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-18487: - Target Version/s: 3.3.7 (was: 3.3.6) > protobuf-2.5.0 dependencies => provided >

[jira] [Resolved] (HADOOP-11219) [Umbrella] Upgrade to netty 4

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HADOOP-11219. -- Fix Version/s: 3.4.0 Resolution: Fixed This is done. Would be nice to

[jira] [Commented] (HADOOP-18750) Spark History Server 3.3.1 fails to starts with Hadoop 3.3.x

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730675#comment-17730675 ] ASF GitHub Bot commented on HADOOP-18750: - hadoop-yetus commented on PR #5695: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5695: HADOOP-18750. Remove javax/servlet shading in hadoop-client-api

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5695: URL: https://github.com/apache/hadoop/pull/5695#issuecomment-1583191500 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5722: YARN-11504. [Federation] YARN Federation Supports Non-HA mode.

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5722: URL: https://github.com/apache/hadoop/pull/5722#issuecomment-1583178177 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18718) Fix several maven build warnings

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-18718: - Target Version/s: 3.4.0, 3.3.9, 3.3.6 (was: 3.4.0, 3.3.9) > Fix several maven build

[jira] [Commented] (HADOOP-18655) Upgrade Kerby to 2.0.3 due to CVE-2023-25613

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730668#comment-17730668 ] Wei-Chiu Chuang commented on HADOOP-18655: -- I'm trying to understand if it's a real problem

[jira] [Updated] (HADOOP-18655) Upgrade Kerby to 2.0.3 due to CVE-2023-25613

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-18655: - Target Version/s: 3.3.9 (was: 3.3.6) > Upgrade Kerby to 2.0.3 due to CVE-2023-25613 >

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730667#comment-17730667 ] ASF GitHub Bot commented on HADOOP-18718: - dongjoon-hyun commented on PR #5592: URL:

[GitHub] [hadoop] dongjoon-hyun commented on pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-08 Thread via GitHub
dongjoon-hyun commented on PR #5592: URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1583141301 Thank you, @GauthamBanasandra . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730661#comment-17730661 ] ASF GitHub Bot commented on HADOOP-18718: - GauthamBanasandra commented on code in PR #5592:

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-08 Thread via GitHub
GauthamBanasandra commented on code in PR #5592: URL: https://github.com/apache/hadoop/pull/5592#discussion_r1223396260 ## hadoop-project-dist/pom.xml: ## @@ -106,7 +106,7 @@ ${maven.compile.source} ${maven.compile.encoding}

[jira] [Updated] (HADOOP-18655) Upgrade Kerby to 2.0.3 due to CVE-2023-25613

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-18655: - Target Version/s: 3.3.6 Priority: Blocker (was: Minor) > Upgrade Kerby to

[jira] [Updated] (HADOOP-18718) Fix several maven build warnings

2023-06-08 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-18718: - Target Version/s: 3.4.0, 3.3.9 > Fix several maven build warnings >

[jira] [Commented] (HADOOP-18756) CachingBlockManager to use AtomicBoolean for closed flag

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730655#comment-17730655 ] ASF GitHub Bot commented on HADOOP-18756: - virajjasani commented on code in PR #5718: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-08 Thread via GitHub
virajjasani commented on code in PR #5718: URL: https://github.com/apache/hadoop/pull/5718#discussion_r1223347046 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -333,37 +335,33 @@ protected Path

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730653#comment-17730653 ] ASF GitHub Bot commented on HADOOP-18073: - steveloughran merged PR #5707: URL:

[GitHub] [hadoop] steveloughran merged pull request #5707: HADOOP-18073. Upgrade S3A in 3.3 branch to AWS SDK V2.

2023-06-08 Thread via GitHub
steveloughran merged PR #5707: URL: https://github.com/apache/hadoop/pull/5707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18756) CachingBlockManager to use AtomicBoolean for closed flag

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730651#comment-17730651 ] ASF GitHub Bot commented on HADOOP-18756: - steveloughran commented on code in PR #5718: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-08 Thread via GitHub
steveloughran commented on code in PR #5718: URL: https://github.com/apache/hadoop/pull/5718#discussion_r1223339252 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -333,37 +335,33 @@ protected Path

[jira] [Commented] (HADOOP-18750) Spark History Server 3.3.1 fails to starts with Hadoop 3.3.x

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730648#comment-17730648 ] ASF GitHub Bot commented on HADOOP-18750: - hadoop-yetus commented on PR #5695: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5695: HADOOP-18750. Remove javax/servlet shading in hadoop-client-api

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5695: URL: https://github.com/apache/hadoop/pull/5695#issuecomment-1583029528 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5722: YARN-11504. [Federation] YARN Federation Supports Non-HA mode.

2023-06-08 Thread via GitHub
slfan1989 commented on code in PR #5722: URL: https://github.com/apache/hadoop/pull/5722#discussion_r1223299403 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java: ## @@ -116,6 +116,28 @@ protected static T

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730612#comment-17730612 ] ASF GitHub Bot commented on HADOOP-18718: - hadoop-yetus commented on PR #5592: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5592: URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1582818110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5696: URL: https://github.com/apache/hadoop/pull/5696#issuecomment-1582766074 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1582602740 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-08 Thread via GitHub
NishthaShah commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1222939776 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java: ## @@ -81,6 +87,17 @@ public

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-08 Thread via GitHub
NishthaShah commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1222939776 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java: ## @@ -81,6 +87,17 @@ public

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5408: HDFS-16898. Remove write lock for processCommandFromActor of DataNode to reduce impact on heartbeat.

2023-06-08 Thread via GitHub
Hexiaoqiao commented on PR #5408: URL: https://github.com/apache/hadoop/pull/5408#issuecomment-1582450852 @hfutatzhanghb Please check failed unit tests if relate to this changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-08 Thread via GitHub
NishthaShah commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1222881620 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java: ## @@ -81,6 +87,17 @@ public

[jira] [Resolved] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-08 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18752. - Fix Version/s: 3.4.0 Resolution: Fixed > Change

[jira] [Commented] (HADOOP-18748) Configuration.get is slow

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730509#comment-17730509 ] ASF GitHub Bot commented on HADOOP-18748: - hadoop-yetus commented on PR #5685: URL:

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730508#comment-17730508 ] ASF GitHub Bot commented on HADOOP-18752: - steveloughran merged PR #5689: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5685: URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1582390168 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran merged pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-08 Thread via GitHub
steveloughran merged PR #5689: URL: https://github.com/apache/hadoop/pull/5689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-08 Thread via GitHub
NishthaShah commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1222881620 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java: ## @@ -81,6 +87,17 @@ public

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730497#comment-17730497 ] ASF GitHub Bot commented on HADOOP-18073: - steveloughran commented on PR #5707: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5707: HADOOP-18073. Upgrade S3A in 3.3 branch to AWS SDK V2.

2023-06-08 Thread via GitHub
steveloughran commented on PR #5707: URL: https://github.com/apache/hadoop/pull/5707#issuecomment-1582343411 +1, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5643: HDFS-17003. Erasure Coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-08 Thread via GitHub
Hexiaoqiao commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1582282121 Committed to trunk. Thanks @hfutatzhanghb for your contirbutions, And @zhangshuyan0, @sodonnel for the reviews! -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] Hexiaoqiao merged pull request #5643: HDFS-17003. Erasure Coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-08 Thread via GitHub
Hexiaoqiao merged PR #5643: URL: https://github.com/apache/hadoop/pull/5643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-08 Thread via GitHub
ayushtkn commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1222765730 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java: ## @@ -81,6 +87,17 @@ public

[GitHub] [hadoop] hadoop-yetus commented on pull request #5715: HDFS-17037. Consider nonDfsUsed when running balancer.

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5715: URL: https://github.com/apache/hadoop/pull/5715#issuecomment-1582218750 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn merged pull request #5708: HDFS-17035. FsVolumeImpl#getActualNonDfsUsed may return negative value.

2023-06-08 Thread via GitHub
ayushtkn merged PR #5708: URL: https://github.com/apache/hadoop/pull/5708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #5519: MAPREDUCE-7435. Manifest Committer OOM on abfs

2023-06-08 Thread via GitHub
mehakmeet commented on code in PR #5519: URL: https://github.com/apache/hadoop/pull/5519#discussion_r1222648403 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5722: YARN-11504. [Federation] YARN Federation Supports Non-HA mode.

2023-06-08 Thread via GitHub
hadoop-yetus commented on PR #5722: URL: https://github.com/apache/hadoop/pull/5722#issuecomment-1582135821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18748) Configuration.get is slow

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730442#comment-17730442 ] ASF GitHub Bot commented on HADOOP-18748: - alkis commented on PR #5685: URL:

[GitHub] [hadoop] alkis commented on pull request #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

2023-06-08 Thread via GitHub
alkis commented on PR #5685: URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1582106658 > ok, style failures > > ``` > ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:754: Properties overlay = getOverlay();:16: