Re: [PR] YARN-11594. [Federation] Improve Yarn Federation documentation. [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6209: URL: https://github.com/apache/hadoop/pull/6209#issuecomment-1793355814 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782827#comment-17782827 ] ASF GitHub Bot commented on HADOOP-18487: - hadoop-yetus commented on PR #6185:

Re: [PR] HADOOP-18487. Protobuf 2.5 removal part 2: stop exporting protobuf-2.5" [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6185: URL: https://github.com/apache/hadoop/pull/6185#issuecomment-1793355401 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11548. [Federation] Router Supports Format FederationStateStore. [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6116: URL: https://github.com/apache/hadoop/pull/6116#issuecomment-1793352176 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11595. [BackPort] Fix hadoop-yarn-client#java.lang.NoClassDefFoundError. [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6253: URL: https://github.com/apache/hadoop/pull/6253#issuecomment-1793346230 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] Update plugin for SBOM generation to 2.7.10 [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6235: URL: https://github.com/apache/hadoop/pull/6235#issuecomment-1793332711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6198: URL: https://github.com/apache/hadoop/pull/6198#issuecomment-1793326233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17247. Improve AvailableSpaceRackFaultTolerantBlockPlacementPolicy logic [hadoop]

2023-11-03 Thread via GitHub
haiyang1987 commented on PR #6245: URL: https://github.com/apache/hadoop/pull/6245#issuecomment-1793323594 The implementation logic in both the AvailableSpaceBlockPlacementPolicy and AvailableSpaceRackFaultTolerantBlockPlacementPolicy is essentially identical. therefore, a public class c

Re: [PR] MAPREDUCE-7461: Fixed assertionComparision failure by resolving xml path for 'name' [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6252: URL: https://github.com/apache/hadoop/pull/6252#issuecomment-1793322663 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11483. [Federation] Router AdminCLI Supports Clean Finish Apps. [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6251: URL: https://github.com/apache/hadoop/pull/6251#issuecomment-1793315021 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782812#comment-17782812 ] ASF GitHub Bot commented on HADOOP-18359: - slfan1989 commented on PR #6248: URL

Re: [PR] HADOOP-18359. Update commons-cli from 1.2 to 1.5. (#5095). [hadoop]

2023-11-03 Thread via GitHub
slfan1989 commented on PR #6248: URL: https://github.com/apache/hadoop/pull/6248#issuecomment-1793308490 I've readed the error in 'patch-unit-root.txt', which we previously encountered in the trunk branch. I will backport YARN-11595 to resolve this issue. We can check the following l

[PR] YARN-11595. [BackPort] Fix hadoop-yarn-client#java.lang.NoClassDefFoundError. [hadoop]

2023-11-03 Thread via GitHub
slfan1989 opened a new pull request, #6253: URL: https://github.com/apache/hadoop/pull/6253 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOO

Re: [PR] HADOOP-18947. Fixed test flakiness during string comparision [hadoop]

2023-11-03 Thread via GitHub
ayushtkn merged PR #6215: URL: https://github.com/apache/hadoop/pull/6215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds. [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6132: URL: https://github.com/apache/hadoop/pull/6132#issuecomment-1793275656 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] MAPREDUCE-7461: Fixed assertionComparision failure by resolving xml path for 'name' [hadoop]

2023-11-03 Thread via GitHub
kavvya97 opened a new pull request, #6252: URL: https://github.com/apache/hadoop/pull/6252 **Setup:** Java version: openjdk 11.0.20.1 Maven version: Apache Maven 3.6.3 ### **Issue**: https://issues.apache.org/jira/browse/MAPREDUCE-7461 ### Description of PR The followin

[PR] YARN-11483. [Federation] Router AdminCLI Supports Clean Finish Apps. [hadoop]

2023-11-03 Thread via GitHub
slfan1989 opened a new pull request, #6251: URL: https://github.com/apache/hadoop/pull/6251 ### Description of PR JIRA:YARN-11483. [Federation] Router AdminCLI Supports Clean Finish Apps. ### How was this patch tested? ### For code changes: - [ ] Does t

[jira] [Updated] (HADOOP-18958) UserGroupInformation debug log improve

2023-11-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18958: -- Fix Version/s: (was: 3.3.4) > UserGroupInformation debug log improve > --

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782794#comment-17782794 ] ASF GitHub Bot commented on HADOOP-18958: - ayushtkn closed pull request #6234:

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782795#comment-17782795 ] ASF GitHub Bot commented on HADOOP-18958: - ayushtkn commented on PR #6234: URL:

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2023-11-03 Thread via GitHub
ayushtkn commented on PR #6234: URL: https://github.com/apache/hadoop/pull/6234#issuecomment-1793254799 The PR should be raised against trunk, 3.3.4 is already released, it can't be modified -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2023-11-03 Thread via GitHub
ayushtkn closed pull request #6234: HADOOP-18958. UserGroupInformation debug log improve. URL: https://github.com/apache/hadoop/pull/6234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (HADOOP-18963) Fix typos in .gitignore

2023-11-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18963. --- Fix Version/s: 3.4.0 (was: 3.3.6) Hadoop Flags: Reviewed

[jira] [Updated] (HADOOP-18963) Fix typos in .gitignore

2023-11-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18963: -- Summary: Fix typos in .gitignore (was: Fix typos in .gitignore #6243) > Fix typos in .gitign

[jira] [Assigned] (HADOOP-18963) Fix typos in .gitignore #6243

2023-11-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18963: - Assignee: 袁焊忠 > Fix typos in .gitignore #6243 > - > >

[jira] [Commented] (HADOOP-18963) Fix typos in .gitignore

2023-11-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782791#comment-17782791 ] Ayush Saxena commented on HADOOP-18963: --- Committed to trunk. Thanx [~yuanhanzhong

[jira] [Commented] (HADOOP-18963) Fix typos in .gitignore

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782790#comment-17782790 ] ASF GitHub Bot commented on HADOOP-18963: - ayushtkn merged PR #6243: URL: https

Re: [PR] HADOOP-18963. Fix typos in .gitignore [hadoop]

2023-11-03 Thread via GitHub
ayushtkn merged PR #6243: URL: https://github.com/apache/hadoop/pull/6243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] YARN-11608. Fix QueueCapacityVectorInfo NPE when accessible labels config is used. [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6250: URL: https://github.com/apache/hadoop/pull/6250#issuecomment-1793157663 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11548. [Federation] Router Supports Format FederationStateStore. [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6116: URL: https://github.com/apache/hadoop/pull/6116#issuecomment-1793064538 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-11-03 Thread via GitHub
mccormickt12 commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1382114831 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1940,7 +1940,8 @@ public Path getEnclosingRoot(Path pat

[PR] YARN-11608. Fix QueueCapacityVectorInfo NPE when accessible labels config is used. [hadoop]

2023-11-03 Thread via GitHub
brumi1024 opened a new pull request, #6250: URL: https://github.com/apache/hadoop/pull/6250 ### Description of PR Added a null check to avoid the NPE when accessible labels config is used. ### How was this patch tested? Unit test + brought up a cluster. ### For cod

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782700#comment-17782700 ] ASF GitHub Bot commented on HADOOP-18359: - hadoop-yetus commented on PR #6248:

Re: [PR] HADOOP-18359. Update commons-cli from 1.2 to 1.5. (#5095). [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6248: URL: https://github.com/apache/hadoop/pull/6248#issuecomment-1792948807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-11-03 Thread Agnes Tevesz (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782689#comment-17782689 ] Agnes Tevesz commented on HADOOP-17377: --- [~ste...@apache.org] [~brandonvin] Can y

Re: [PR] HDFS-17249. TestDFSUtil.testIsValidName() run failure [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6249: URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1792905854 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17249. TestDFSUtil.testIsValidName() run failure [hadoop]

2023-11-03 Thread via GitHub
LiuGuH commented on PR #6249: URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1792617907 @GauthamBanasandra I create a new JIRA for this. If the title is not matches, please give me a suggestion .Thanks. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] HADOOP-18954. Filter NaN values from JMX json interface [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6229: URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1792605958 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18954) Filter NaN values from JMX json interface

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782606#comment-17782606 ] ASF GitHub Bot commented on HADOOP-18954: - hadoop-yetus commented on PR #6229:

Re: [PR] HDFS-17248. Fix isValidName error [hadoop]

2023-11-03 Thread via GitHub
GauthamBanasandra commented on PR #6249: URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1792544583 > > @LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to `HDFS-17248`? > > Sure. I can. But what's the difference between them that

[jira] [Updated] (HADOOP-18797) Support Concurrent Writes With S3A Magic Committer

2023-11-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18797: Fix Version/s: 3.3.9 > Support Concurrent Writes With S3A Magic Committer > -

[jira] [Commented] (HADOOP-18797) Support Concurrent Writes With S3A Magic Committer

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782573#comment-17782573 ] ASF GitHub Bot commented on HADOOP-18797: - steveloughran merged PR #6122: URL:

Re: [PR] HADOOP-18797. Support Concurrent Writes With S3A Magic Committer [hadoop]

2023-11-03 Thread via GitHub
steveloughran merged PR #6122: URL: https://github.com/apache/hadoop/pull/6122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HDFS-17248. Fix isValidName error [hadoop]

2023-11-03 Thread via GitHub
LiuGuH commented on PR #6249: URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1792400786 > @LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to `HDFS-17248`? Sure. I can. But what's the difference between them that I

Re: [PR] HDFS-17248. Fix isValidName error [hadoop]

2023-11-03 Thread via GitHub
LiuGuH commented on code in PR #6249: URL: https://github.com/apache/hadoop/pull/6249#discussion_r1381639092 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java: ## @@ -661,9 +661,12 @@ public static boolean isValidName(String src) {

[jira] [Updated] (HADOOP-18963) Fix typos in .gitignore #6243

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18963: Labels: pull-request-available (was: ) > Fix typos in .gitignore #6243 > ---

[jira] [Commented] (HADOOP-18963) Fix typos in .gitignore #6243

2023-11-03 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782552#comment-17782552 ] 袁焊忠 commented on HADOOP-18963: -- [https://github.com/apache/hadoop/pull/6243] is created fo

[jira] [Commented] (HADOOP-18963) Fix typos in .gitignore #6243

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782551#comment-17782551 ] ASF GitHub Bot commented on HADOOP-18963: - YuanHanzhong commented on PR #6243:

Re: [PR] HADOOP-18963. Fix typos in .gitignore [hadoop]

2023-11-03 Thread via GitHub
YuanHanzhong commented on PR #6243: URL: https://github.com/apache/hadoop/pull/6243#issuecomment-1792366998 > I have approved your jira id request, can you create a HADOOP ticket & prefix that jira id on this PR I created HADOOP ticket https://issues.apache.org/jira/browse/HADOOP-1896

[jira] [Created] (HADOOP-18963) Fix typos in .gitignore #6243

2023-11-03 Thread Jira
袁焊忠 created HADOOP-18963: Summary: Fix typos in .gitignore #6243 Key: HADOOP-18963 URL: https://issues.apache.org/jira/browse/HADOOP-18963 Project: Hadoop Common Issue Type: Improvement Com

Re: [PR] HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 [hadoop-thirdparty]

2023-11-03 Thread via GitHub
steveloughran merged PR #23: URL: https://github.com/apache/hadoop-thirdparty/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsu

Re: [PR] HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 [hadoop-thirdparty]

2023-11-03 Thread via GitHub
steveloughran commented on PR #23: URL: https://github.com/apache/hadoop-thirdparty/pull/23#issuecomment-1792337815 done. mukund has been looking at doing a new 3.3.x release...we should get this out first -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Commented] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782544#comment-17782544 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #6185:

Re: [PR] HADOOP-18487. Protobuf 2.5 removal part 2: stop exporting protobuf-2.5" [hadoop]

2023-11-03 Thread via GitHub
steveloughran commented on PR #6185: URL: https://github.com/apache/hadoop/pull/6185#issuecomment-1792335963 oh, i get it. I'd updated the BUILDING.txt in the wrong branch, so even though it was pushed up it had gone to the branch on the earlier pr. lets see what yetus says and merge it -

[jira] [Commented] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782543#comment-17782543 ] ASF GitHub Bot commented on HADOOP-18487: - ayushtkn commented on PR #6185: URL:

Re: [PR] HADOOP-18487. Protobuf 2.5 removal part 2: stop exporting protobuf-2.5" [hadoop]

2023-11-03 Thread via GitHub
ayushtkn commented on PR #6185: URL: https://github.com/apache/hadoop/pull/6185#issuecomment-1792334819 ohh, cool, go ahead, feel free to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-18962) Upgrade kafka to 3.4.0

2023-11-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782539#comment-17782539 ] Steve Loughran commented on HADOOP-18962: - add ...component = build, set versio

[jira] [Commented] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782540#comment-17782540 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #6185:

Re: [PR] HADOOP-18487. Protobuf 2.5 removal part 2: stop exporting protobuf-2.5" [hadoop]

2023-11-03 Thread via GitHub
steveloughran commented on PR #6185: URL: https://github.com/apache/hadoop/pull/6185#issuecomment-1792331971 @ayushtkn i'd updated the doc already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-11-03 Thread via GitHub
steveloughran commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1381582965 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1940,7 +1940,8 @@ public Path getEnclosingRoot(Path pa

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-11-03 Thread via GitHub
steveloughran commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1381581642 ## hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md: ## @@ -601,7 +601,32 @@ on the filesystem. 1. The outcome of this operation M

Re: [PR] HDFS-16791 Add getEnclosingRoot API to filesystem interface and all implementations [hadoop]

2023-11-03 Thread via GitHub
steveloughran commented on code in PR #6198: URL: https://github.com/apache/hadoop/pull/6198#discussion_r1381580444 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1919,6 +1933,21 @@ public Collection getAllStoragePol

Re: [PR] HDFS-17015. Fix typos in .gitignore [hadoop]

2023-11-03 Thread via GitHub
YuanHanzhong commented on PR #6243: URL: https://github.com/apache/hadoop/pull/6243#issuecomment-1792294793 Thank you, I'll do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (HADOOP-18954) Filter NaN values from JMX json interface

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782522#comment-17782522 ] ASF GitHub Bot commented on HADOOP-18954: - K0K0V0K commented on code in PR #622

Re: [PR] HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout [hadoop]

2023-11-03 Thread via GitHub
ayushtkn commented on code in PR #5829: URL: https://github.com/apache/hadoop/pull/5829#discussion_r1381508823 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripeReader.java: ## @@ -233,41 +236,60 @@ private ByteBufferStrategy[] getReadStrategi

Re: [PR] HADOOP-18954. Filter NaN values from JMX json interface [hadoop]

2023-11-03 Thread via GitHub
K0K0V0K commented on code in PR #6229: URL: https://github.com/apache/hadoop/pull/6229#discussion_r1381509417 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java: ## @@ -62,10 +62,15 @@ public static void assertReFind(String re, Str

[jira] [Commented] (HADOOP-18954) Filter NaN values from JMX json interface

2023-11-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782521#comment-17782521 ] ASF GitHub Bot commented on HADOOP-18954: - K0K0V0K commented on code in PR #622

Re: [PR] HADOOP-18954. Filter NaN values from JMX json interface [hadoop]

2023-11-03 Thread via GitHub
K0K0V0K commented on code in PR #6229: URL: https://github.com/apache/hadoop/pull/6229#discussion_r1381509417 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java: ## @@ -62,10 +62,15 @@ public static void assertReFind(String re, Str

Re: [PR] YARN-11606. Upgrade fst to 2.57 [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6246: URL: https://github.com/apache/hadoop/pull/6246#issuecomment-1792239910 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17248. Fix isValidName error [hadoop]

2023-11-03 Thread via GitHub
GauthamBanasandra commented on code in PR #6249: URL: https://github.com/apache/hadoop/pull/6249#discussion_r1381474325 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java: ## @@ -661,9 +661,12 @@ public static boolean isValidName(St

Re: [PR] HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 [hadoop-thirdparty]

2023-11-03 Thread via GitHub
fredbalves86 commented on PR #23: URL: https://github.com/apache/hadoop-thirdparty/pull/23#issuecomment-1792219171 > ok, let's merge > > @fredbalves86 what name do you want to use for credit in the commit message? +what apache jira account is yours to assign the work to? You ca

Re: [PR] Update plugin for SBOM generation to 2.7.10 [hadoop]

2023-11-03 Thread via GitHub
ayushtkn commented on PR #6235: URL: https://github.com/apache/hadoop/pull/6235#issuecomment-1792219054 have triggered the build again. @VinodAnandan can you create a HADOOP ticket & prefix the jira id on this PR -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] HDFS-17015. Fix typos in .gitignore [hadoop]

2023-11-03 Thread via GitHub
ayushtkn commented on PR #6243: URL: https://github.com/apache/hadoop/pull/6243#issuecomment-1792216883 I have approved your jira id request, can you create a HADOOP ticket & prefix that jira id on this PR -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] YARN-11606. Upgrade fst to 2.57 [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6246: URL: https://github.com/apache/hadoop/pull/6246#issuecomment-1792190888 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2023-11-03 Thread wangzhihui (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782445#comment-17782445 ] wangzhihui commented on HADOOP-18958: - [~hexiaoqiao]  Can you help us make the deci

Re: [PR] HDFS-17248. Fix isValidName error [hadoop]

2023-11-03 Thread via GitHub
LiuGuH commented on PR #6249: URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1791981813 @GauthamBanasandra , hello sir,do you have time to review it,Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HDFS-17248. Fix isValidName error [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6249: URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1791979449 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11606. Upgrade fst to 2.57 [hadoop]

2023-11-03 Thread via GitHub
hadoop-yetus commented on PR #6246: URL: https://github.com/apache/hadoop/pull/6246#issuecomment-1791971145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe